From: Christoph Lameter <cl@linux.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kirill.shutemov@linux.intel.com, Andi Kleen <ak@linux.intel.com>,
akpm@linux-foundation.org, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/2] mm: slab/slub: use page->list consistently instead of page->lru
Date: Thu, 12 Dec 2013 17:39:59 +0000 [thread overview]
Message-ID: <00000142e7e4c89c-f8f8fab4-687c-4fe0-b0ac-c4b9ec25d739-000000@email.amazonses.com> (raw)
In-Reply-To: <20131211223631.51094A3D@viggo.jf.intel.com>
On Wed, 11 Dec 2013, Dave Hansen wrote:
> 'struct page' has two list_head fields: 'lru' and 'list'.
> Conveniently, they are unioned together. This means that code
> can use them interchangably, which gets horribly confusing like
> with this nugget from slab.c:
Acked-by: Christoph Lameter <cl@linux.com>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kirill.shutemov@linux.intel.com, Andi Kleen <ak@linux.intel.com>,
akpm@linux-foundation.org, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/2] mm: slab/slub: use page->list consistently instead of page->lru
Date: Thu, 12 Dec 2013 17:39:59 +0000 [thread overview]
Message-ID: <00000142e7e4c89c-f8f8fab4-687c-4fe0-b0ac-c4b9ec25d739-000000@email.amazonses.com> (raw)
In-Reply-To: <20131211223631.51094A3D@viggo.jf.intel.com>
On Wed, 11 Dec 2013, Dave Hansen wrote:
> 'struct page' has two list_head fields: 'lru' and 'list'.
> Conveniently, they are unioned together. This means that code
> can use them interchangably, which gets horribly confusing like
> with this nugget from slab.c:
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-12 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 22:36 [PATCH 1/2] mm: slab/slub: use page->list consistently instead of page->lru Dave Hansen
2013-12-11 22:36 ` Dave Hansen
2013-12-11 22:36 ` [PATCH 2/2] mm: blk-mq: uses page->list incorrectly Dave Hansen
2013-12-11 22:36 ` Dave Hansen
2013-12-11 22:47 ` David Rientjes
2013-12-11 22:47 ` David Rientjes
2013-12-12 13:16 ` Kirill A. Shutemov
2013-12-12 13:16 ` Kirill A. Shutemov
2013-12-11 22:45 ` [PATCH 1/2] mm: slab/slub: use page->list consistently instead of page->lru David Rientjes
2013-12-11 22:45 ` David Rientjes
2013-12-12 17:39 ` Christoph Lameter [this message]
2013-12-12 17:39 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000142e7e4c89c-f8f8fab4-687c-4fe0-b0ac-c4b9ec25d739-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.