* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 5:31 ` Olof Johansson
0 siblings, 0 replies; 50+ messages in thread
From: Olof Johansson @ 2013-05-29 5:31 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> The patches are at [1].
FWIW, a cgit/gitweb link is easier to follow when you're reading an
email. Anyway, found the patches.
> There are a total of 6 patches on top of
> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
> (e, f) are required to reset the hub during EHCI initialization.
Huh, I thought you said that (c) wasn't needed when I posted the
defconfig update. It'd be nice to see the code fixed to handle this
case instead of Linaro carrying a patch like this though. I.e. make it
able to deselect the uart, or make it tied to DEBUG_LL like on other
platforms instead of having a separate config for this.
> a. ARM: exynos: defconfig update
> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
> e. usb: ehci-s5p: add the HSIC port initialization
> f. ARM: dts: Add USB gpio entries for Arndale board
>
> I am not sure whether such kind of board-specific patches (e, f) are
> appreciated in the drivers. But that is all we need to get USB and
> Ethernet to work on v3.10-rc3 kernel.
I've come across a similar situation with wifi reset sequence on the
chromebook. On the product kernel we added some code to the board file
to deal with it, but if we keep doing that things will grow out of
hand.
I don't know if it'll be unpopular, but I think it's time to start a
drivers/platform/arm for these kind of things, and have those drivers
probe on the system compatible value, similar to how x86 does it (with
DMI tables). At least that's my plan for approaching the wifi
reset/power-on sequence on the Chromebook. I hope to have patches in
not all that long...
Likewise, the hub reset/enable code doesn't have to go with the USB
driver, right? I.e. if you cycle reset/enable on the hub after the
host and phy is configured, you'll still have a working setup?
-Olof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 5:31 ` Olof Johansson
0 siblings, 0 replies; 50+ messages in thread
From: Olof Johansson @ 2013-05-29 5:31 UTC (permalink / raw)
To: Tushar Behera, Arnd Bergmann
Cc: Kevin Hilman, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Kukjin Kim, Doug Anderson, Patch Tracking
On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> The patches are at [1].
FWIW, a cgit/gitweb link is easier to follow when you're reading an
email. Anyway, found the patches.
> There are a total of 6 patches on top of
> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
> (e, f) are required to reset the hub during EHCI initialization.
Huh, I thought you said that (c) wasn't needed when I posted the
defconfig update. It'd be nice to see the code fixed to handle this
case instead of Linaro carrying a patch like this though. I.e. make it
able to deselect the uart, or make it tied to DEBUG_LL like on other
platforms instead of having a separate config for this.
> a. ARM: exynos: defconfig update
> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
> e. usb: ehci-s5p: add the HSIC port initialization
> f. ARM: dts: Add USB gpio entries for Arndale board
>
> I am not sure whether such kind of board-specific patches (e, f) are
> appreciated in the drivers. But that is all we need to get USB and
> Ethernet to work on v3.10-rc3 kernel.
I've come across a similar situation with wifi reset sequence on the
chromebook. On the product kernel we added some code to the board file
to deal with it, but if we keep doing that things will grow out of
hand.
I don't know if it'll be unpopular, but I think it's time to start a
drivers/platform/arm for these kind of things, and have those drivers
probe on the system compatible value, similar to how x86 does it (with
DMI tables). At least that's my plan for approaching the wifi
reset/power-on sequence on the Chromebook. I hope to have patches in
not all that long...
Likewise, the hub reset/enable code doesn't have to go with the USB
driver, right? I.e. if you cycle reset/enable on the hub after the
host and phy is configured, you'll still have a working setup?
-Olof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 5:31 ` Olof Johansson
(?)
@ 2013-05-29 8:50 ` Tushar Behera
-1 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 8:50 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, Kevin Hilman, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
On 05/29/2013 11:01 AM, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
It would be good to free up the dependency on the correct UART port for
the board to boot. Without that, there would always be boards that don't
boot with default mainline defconfig file even though all other
components are in place.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
>>
>> I am not sure whether such kind of board-specific patches (e, f) are
>> appreciated in the drivers. But that is all we need to get USB and
>> Ethernet to work on v3.10-rc3 kernel.
>
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
>
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
>
> Likewise, the hub reset/enable code doesn't have to go with the USB
> driver, right? I.e. if you cycle reset/enable on the hub after the
> host and phy is configured, you'll still have a working setup?
>
Right, hub reset/enable code need not be tied up with USB driver. As per
your suggestion regarding drivers/platform/arm, I implemented an Arndale
specific driver [2] in drivers/platform/arm and verified USB and
ethernet to be working.
[2]
https://git.linaro.org/gitweb?p=landing-teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> -Olof
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 8:50 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 8:50 UTC (permalink / raw)
To: linux-arm-kernel
On 05/29/2013 11:01 AM, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
It would be good to free up the dependency on the correct UART port for
the board to boot. Without that, there would always be boards that don't
boot with default mainline defconfig file even though all other
components are in place.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
>>
>> I am not sure whether such kind of board-specific patches (e, f) are
>> appreciated in the drivers. But that is all we need to get USB and
>> Ethernet to work on v3.10-rc3 kernel.
>
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
>
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
>
> Likewise, the hub reset/enable code doesn't have to go with the USB
> driver, right? I.e. if you cycle reset/enable on the hub after the
> host and phy is configured, you'll still have a working setup?
>
Right, hub reset/enable code need not be tied up with USB driver. As per
your suggestion regarding drivers/platform/arm, I implemented an Arndale
specific driver [2] in drivers/platform/arm and verified USB and
ethernet to be working.
[2]
https://git.linaro.org/gitweb?p=landing-teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> -Olof
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 8:50 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 8:50 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, Kevin Hilman, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
On 05/29/2013 11:01 AM, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
It would be good to free up the dependency on the correct UART port for
the board to boot. Without that, there would always be boards that don't
boot with default mainline defconfig file even though all other
components are in place.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
>>
>> I am not sure whether such kind of board-specific patches (e, f) are
>> appreciated in the drivers. But that is all we need to get USB and
>> Ethernet to work on v3.10-rc3 kernel.
>
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
>
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
>
> Likewise, the hub reset/enable code doesn't have to go with the USB
> driver, right? I.e. if you cycle reset/enable on the hub after the
> host and phy is configured, you'll still have a working setup?
>
Right, hub reset/enable code need not be tied up with USB driver. As per
your suggestion regarding drivers/platform/arm, I implemented an Arndale
specific driver [2] in drivers/platform/arm and verified USB and
ethernet to be working.
[2]
https://git.linaro.org/gitweb?p=landing-teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> -Olof
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 8:50 ` Tushar Behera
@ 2013-05-29 9:33 ` Jingoo Han
-1 siblings, 0 replies; 50+ messages in thread
From: Jingoo Han @ 2013-05-29 9:33 UTC (permalink / raw)
To: 'Tushar Behera', 'Olof Johansson'
Cc: 'Arnd Bergmann', 'Kevin Hilman',
linux-kernel, linux-arm-kernel, linux-samsung-soc,
'Kukjin Kim', 'Doug Anderson',
'Patch Tracking', Jingoo Han, 'Thomas Abraham',
'Vivek Gautam'
On Wednesday, May 29, 2013 5:51 PM, Tushar Behera:
> On 05/29/2013 11:01 AM, Olof Johansson wrote:
> > On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> >
> >> The patches are at [1].
> >
> > FWIW, a cgit/gitweb link is easier to follow when you're reading an
> > email. Anyway, found the patches.
> >
> >> There are a total of 6 patches on top of
> >> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
> >> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
> >> (e, f) are required to reset the hub during EHCI initialization.
> >
> > Huh, I thought you said that (c) wasn't needed when I posted the
> > defconfig update. It'd be nice to see the code fixed to handle this
> > case instead of Linaro carrying a patch like this though. I.e. make it
> > able to deselect the uart, or make it tied to DEBUG_LL like on other
> > platforms instead of having a separate config for this.
> >
>
> It would be good to free up the dependency on the correct UART port for
> the board to boot. Without that, there would always be boards that don't
> boot with default mainline defconfig file even though all other
> components are in place.
>
> >> a. ARM: exynos: defconfig update
> >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
> >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
> >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
> >> e. usb: ehci-s5p: add the HSIC port initialization
> >> f. ARM: dts: Add USB gpio entries for Arndale board
> >>
> >> I am not sure whether such kind of board-specific patches (e, f) are
> >> appreciated in the drivers. But that is all we need to get USB and
> >> Ethernet to work on v3.10-rc3 kernel.
> >
> > I've come across a similar situation with wifi reset sequence on the
> > chromebook. On the product kernel we added some code to the board file
> > to deal with it, but if we keep doing that things will grow out of
> > hand.
> >
> > I don't know if it'll be unpopular, but I think it's time to start a
> > drivers/platform/arm for these kind of things, and have those drivers
> > probe on the system compatible value, similar to how x86 does it (with
> > DMI tables). At least that's my plan for approaching the wifi
> > reset/power-on sequence on the Chromebook. I hope to have patches in
> > not all that long...
> >
> > Likewise, the hub reset/enable code doesn't have to go with the USB
> > driver, right? I.e. if you cycle reset/enable on the hub after the
> > host and phy is configured, you'll still have a working setup?
> >
>
> Right, hub reset/enable code need not be tied up with USB driver. As per
> your suggestion regarding drivers/platform/arm, I implemented an Arndale
> specific driver [2] in drivers/platform/arm and verified USB and
> ethernet to be working.
CC'ed Thomas Abraham, Vivek Gautam
I think so.
I looked at Arndale board Schematics.
'Hub chip' on Arndale board needs hub reset/enable code.
'HUB_RESET' and 'HUB_CONNECT' pins are used to reset 'Hub chip'
on Arndale board, not Exynos EHCI controller. So, Exynos EHCI driver
does not need to consider this hub reset/enable code.
If there is a driver for this 'Hub chip', 'Hub chip' driver maybe
consider this.
However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
would be a good alternative.
>
> [2]
> https://git.linaro.org/gitweb?p=landing-
> teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
It looks good.
Best regards,
Jingoo Han
>
> >
> > -Olof
> >
>
>
> --
> Tushar Behera
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 9:33 ` Jingoo Han
0 siblings, 0 replies; 50+ messages in thread
From: Jingoo Han @ 2013-05-29 9:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, May 29, 2013 5:51 PM, Tushar Behera:
> On 05/29/2013 11:01 AM, Olof Johansson wrote:
> > On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> >
> >> The patches are at [1].
> >
> > FWIW, a cgit/gitweb link is easier to follow when you're reading an
> > email. Anyway, found the patches.
> >
> >> There are a total of 6 patches on top of
> >> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
> >> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
> >> (e, f) are required to reset the hub during EHCI initialization.
> >
> > Huh, I thought you said that (c) wasn't needed when I posted the
> > defconfig update. It'd be nice to see the code fixed to handle this
> > case instead of Linaro carrying a patch like this though. I.e. make it
> > able to deselect the uart, or make it tied to DEBUG_LL like on other
> > platforms instead of having a separate config for this.
> >
>
> It would be good to free up the dependency on the correct UART port for
> the board to boot. Without that, there would always be boards that don't
> boot with default mainline defconfig file even though all other
> components are in place.
>
> >> a. ARM: exynos: defconfig update
> >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
> >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
> >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
> >> e. usb: ehci-s5p: add the HSIC port initialization
> >> f. ARM: dts: Add USB gpio entries for Arndale board
> >>
> >> I am not sure whether such kind of board-specific patches (e, f) are
> >> appreciated in the drivers. But that is all we need to get USB and
> >> Ethernet to work on v3.10-rc3 kernel.
> >
> > I've come across a similar situation with wifi reset sequence on the
> > chromebook. On the product kernel we added some code to the board file
> > to deal with it, but if we keep doing that things will grow out of
> > hand.
> >
> > I don't know if it'll be unpopular, but I think it's time to start a
> > drivers/platform/arm for these kind of things, and have those drivers
> > probe on the system compatible value, similar to how x86 does it (with
> > DMI tables). At least that's my plan for approaching the wifi
> > reset/power-on sequence on the Chromebook. I hope to have patches in
> > not all that long...
> >
> > Likewise, the hub reset/enable code doesn't have to go with the USB
> > driver, right? I.e. if you cycle reset/enable on the hub after the
> > host and phy is configured, you'll still have a working setup?
> >
>
> Right, hub reset/enable code need not be tied up with USB driver. As per
> your suggestion regarding drivers/platform/arm, I implemented an Arndale
> specific driver [2] in drivers/platform/arm and verified USB and
> ethernet to be working.
CC'ed Thomas Abraham, Vivek Gautam
I think so.
I looked at Arndale board Schematics.
'Hub chip' on Arndale board needs hub reset/enable code.
'HUB_RESET' and 'HUB_CONNECT' pins are used to reset 'Hub chip'
on Arndale board, not Exynos EHCI controller. So, Exynos EHCI driver
does not need to consider this hub reset/enable code.
If there is a driver for this 'Hub chip', 'Hub chip' driver maybe
consider this.
However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
would be a good alternative.
>
> [2]
> https://git.linaro.org/gitweb?p=landing-
> teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
It looks good.
Best regards,
Jingoo Han
>
> >
> > -Olof
> >
>
>
> --
> Tushar Behera
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 9:33 ` Jingoo Han
(?)
@ 2013-05-29 18:46 ` Olof Johansson
-1 siblings, 0 replies; 50+ messages in thread
From: Olof Johansson @ 2013-05-29 18:46 UTC (permalink / raw)
To: Jingoo Han
Cc: Tushar Behera, Arnd Bergmann, Kevin Hilman, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Kukjin Kim, Doug Anderson,
Patch Tracking, Thomas Abraham, Vivek Gautam
On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
Whoa. I didn't quite realize what I proposed, or rather, how what I
proposed could be perceived. I take it back. :)
We must _not_ introduce something that will be abused as a new home
for board file junk. If we do introduce a platform glue directory it
would need to be very limited in scope. Compare to what's in
drivers/platform/x86 today.
-Olof
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 18:46 ` Olof Johansson
0 siblings, 0 replies; 50+ messages in thread
From: Olof Johansson @ 2013-05-29 18:46 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
Whoa. I didn't quite realize what I proposed, or rather, how what I
proposed could be perceived. I take it back. :)
We must _not_ introduce something that will be abused as a new home
for board file junk. If we do introduce a platform glue directory it
would need to be very limited in scope. Compare to what's in
drivers/platform/x86 today.
-Olof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 18:46 ` Olof Johansson
0 siblings, 0 replies; 50+ messages in thread
From: Olof Johansson @ 2013-05-29 18:46 UTC (permalink / raw)
To: Jingoo Han
Cc: Tushar Behera, Arnd Bergmann, Kevin Hilman, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Kukjin Kim, Doug Anderson,
Patch Tracking, Thomas Abraham, Vivek Gautam
On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
Whoa. I didn't quite realize what I proposed, or rather, how what I
proposed could be perceived. I take it back. :)
We must _not_ introduce something that will be abused as a new home
for board file junk. If we do introduce a platform glue directory it
would need to be very limited in scope. Compare to what's in
drivers/platform/x86 today.
-Olof
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 18:46 ` Olof Johansson
(?)
@ 2013-05-30 3:37 ` Tushar Behera
-1 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-30 3:37 UTC (permalink / raw)
To: Olof Johansson
Cc: Jingoo Han, Arnd Bergmann, Kevin Hilman, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Kukjin Kim, Doug Anderson,
Patch Tracking, Thomas Abraham, Vivek Gautam
On 05/30/2013 12:16 AM, Olof Johansson wrote:
> On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
>> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
>> would be a good alternative.
>
>
> Whoa. I didn't quite realize what I proposed, or rather, how what I
> proposed could be perceived. I take it back. :)
>
> We must _not_ introduce something that will be abused as a new home
> for board file junk. If we do introduce a platform glue directory it
> would need to be very limited in scope. Compare to what's in
> drivers/platform/x86 today.
>
>
> -Olof
>
This was my proof-of-concept for moving USB hub reset code out of USB
driver. Verified that it works.
I would wait for your patches for wifi-reset sequence and then will add
hub-reset code for Arndale.
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 3:37 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-30 3:37 UTC (permalink / raw)
To: linux-arm-kernel
On 05/30/2013 12:16 AM, Olof Johansson wrote:
> On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
>> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
>> would be a good alternative.
>
>
> Whoa. I didn't quite realize what I proposed, or rather, how what I
> proposed could be perceived. I take it back. :)
>
> We must _not_ introduce something that will be abused as a new home
> for board file junk. If we do introduce a platform glue directory it
> would need to be very limited in scope. Compare to what's in
> drivers/platform/x86 today.
>
>
> -Olof
>
This was my proof-of-concept for moving USB hub reset code out of USB
driver. Verified that it works.
I would wait for your patches for wifi-reset sequence and then will add
hub-reset code for Arndale.
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 3:37 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-30 3:37 UTC (permalink / raw)
To: Olof Johansson
Cc: Jingoo Han, Arnd Bergmann, Kevin Hilman, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Kukjin Kim, Doug Anderson,
Patch Tracking, Thomas Abraham, Vivek Gautam
On 05/30/2013 12:16 AM, Olof Johansson wrote:
> On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
>> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
>> would be a good alternative.
>
>
> Whoa. I didn't quite realize what I proposed, or rather, how what I
> proposed could be perceived. I take it back. :)
>
> We must _not_ introduce something that will be abused as a new home
> for board file junk. If we do introduce a platform glue directory it
> would need to be very limited in scope. Compare to what's in
> drivers/platform/x86 today.
>
>
> -Olof
>
This was my proof-of-concept for moving USB hub reset code out of USB
driver. Verified that it works.
I would wait for your patches for wifi-reset sequence and then will add
hub-reset code for Arndale.
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-30 3:37 ` Tushar Behera
@ 2013-05-30 7:05 ` Jingoo Han
-1 siblings, 0 replies; 50+ messages in thread
From: Jingoo Han @ 2013-05-30 7:05 UTC (permalink / raw)
To: 'Tushar Behera', 'Olof Johansson'
Cc: 'Arnd Bergmann', 'Kevin Hilman',
linux-kernel, linux-arm-kernel, linux-samsung-soc,
'Kukjin Kim', 'Doug Anderson',
'Patch Tracking', 'Thomas Abraham',
'Vivek Gautam',
Jingoo Han
On Thursday, May 30, 2013 12:38 PM, Tushar Behera wrote:
>On 05/30/2013 12:16 AM, Olof Johansson wrote:
>> On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>>
>>> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
>>> would be a good alternative.
>>
>>
>> Whoa. I didn't quite realize what I proposed, or rather, how what I
>> proposed could be perceived. I take it back. :)
My original message is as below.
"However, as Olof Johansson mentioned, 'drivers/platform/arm/'
would be a good alternative."
Also, 'board_arndale.c' should not be mentioned.
Sorry for making confusion. :)
>>
>> We must _not_ introduce something that will be abused as a new home
>> for board file junk. If we do introduce a platform glue directory it
>> would need to be very limited in scope. Compare to what's in
>> drivers/platform/x86 today.
>>
>>
>> -Olof
>>
>
>This was my proof-of-concept for moving USB hub reset code out of USB
>driver. Verified that it works.
Thank you for your additional comment.
>
>I would wait for your patches for wifi-reset sequence and then will add
>hub-reset code for Arndale.
Yes, this way looks good.
Best regards,
Jingoo Han
>
>
>--
>Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 7:05 ` Jingoo Han
0 siblings, 0 replies; 50+ messages in thread
From: Jingoo Han @ 2013-05-30 7:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, May 30, 2013 12:38 PM, Tushar Behera wrote:
>On 05/30/2013 12:16 AM, Olof Johansson wrote:
>> On Wed, May 29, 2013 at 2:33 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>>
>>> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
>>> would be a good alternative.
>>
>>
>> Whoa. I didn't quite realize what I proposed, or rather, how what I
>> proposed could be perceived. I take it back. :)
My original message is as below.
"However, as Olof Johansson mentioned, 'drivers/platform/arm/'
would be a good alternative."
Also, 'board_arndale.c' should not be mentioned.
Sorry for making confusion. :)
>>
>> We must _not_ introduce something that will be abused as a new home
>> for board file junk. If we do introduce a platform glue directory it
>> would need to be very limited in scope. Compare to what's in
>> drivers/platform/x86 today.
>>
>>
>> -Olof
>>
>
>This was my proof-of-concept for moving USB hub reset code out of USB
>driver. Verified that it works.
Thank you for your additional comment.
>
>I would wait for your patches for wifi-reset sequence and then will add
>hub-reset code for Arndale.
Yes, this way looks good.
Best regards,
Jingoo Han
>
>
>--
>Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 9:33 ` Jingoo Han
(?)
@ 2013-05-30 13:10 ` Vivek Gautam
-1 siblings, 0 replies; 50+ messages in thread
From: Vivek Gautam @ 2013-05-30 13:10 UTC (permalink / raw)
To: Jingoo Han, 'Tushar Behera', 'Olof Johansson'
Cc: 'Arnd Bergmann', 'Kevin Hilman',
linux-kernel, linux-arm-kernel, linux-samsung-soc,
'Kukjin Kim', 'Doug Anderson',
'Patch Tracking', Jingoo Han, 'Thomas Abraham',
Julius Werner, Vivek Gautam
Hi,
> On Wednesday, May 29, 2013 5:51 PM, Tushar Behera:
>> On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> > On Tue, May 28, 2013 at 8:59 PM, Tushar Behera
>> > <tushar.behera@linaro.org> wrote:
>> >
>> >> The patches are at [1].
>> >
>> > FWIW, a cgit/gitweb link is easier to follow when you're reading an
>> > email. Anyway, found the patches.
>> >
>> >> There are a total of 6 patches on top of
>> >> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another
>> >> patch
>> >> (c) is just a defconfig hack to get Arndale booting. Remaining 2
>> >> patches
>> >> (e, f) are required to reset the hub during EHCI initialization.
>> >
>> > Huh, I thought you said that (c) wasn't needed when I posted the
>> > defconfig update. It'd be nice to see the code fixed to handle this
>> > case instead of Linaro carrying a patch like this though. I.e. make it
>> > able to deselect the uart, or make it tied to DEBUG_LL like on other
>> > platforms instead of having a separate config for this.
>> >
>>
>> It would be good to free up the dependency on the correct UART port for
>> the board to boot. Without that, there would always be boards that don't
>> boot with default mainline defconfig file even though all other
>> components are in place.
>>
>> >> a. ARM: exynos: defconfig update
>> >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> >> e. usb: ehci-s5p: add the HSIC port initialization
>> >> f. ARM: dts: Add USB gpio entries for Arndale board
>> >>
>> >> I am not sure whether such kind of board-specific patches (e, f) are
>> >> appreciated in the drivers. But that is all we need to get USB and
>> >> Ethernet to work on v3.10-rc3 kernel.
>> >
>> > I've come across a similar situation with wifi reset sequence on the
>> > chromebook. On the product kernel we added some code to the board file
>> > to deal with it, but if we keep doing that things will grow out of
>> > hand.
>> >
>> > I don't know if it'll be unpopular, but I think it's time to start a
>> > drivers/platform/arm for these kind of things, and have those drivers
>> > probe on the system compatible value, similar to how x86 does it (with
>> > DMI tables). At least that's my plan for approaching the wifi
>> > reset/power-on sequence on the Chromebook. I hope to have patches in
>> > not all that long...
>> >
>> > Likewise, the hub reset/enable code doesn't have to go with the USB
>> > driver, right? I.e. if you cycle reset/enable on the hub after the
>> > host and phy is configured, you'll still have a working setup?
>> >
>>
>> Right, hub reset/enable code need not be tied up with USB driver. As per
>> your suggestion regarding drivers/platform/arm, I implemented an Arndale
>> specific driver [2] in drivers/platform/arm and verified USB and
>> ethernet to be working.
>
> CC'ed Thomas Abraham, Vivek Gautam
>
> I think so.
>
> I looked at Arndale board Schematics.
> 'Hub chip' on Arndale board needs hub reset/enable code.
> 'HUB_RESET' and 'HUB_CONNECT' pins are used to reset 'Hub chip'
> on Arndale board, not Exynos EHCI controller. So, Exynos EHCI driver
> does not need to consider this hub reset/enable code.
>
> If there is a driver for this 'Hub chip', 'Hub chip' driver maybe
> consider this.
>
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
We do have a driver for USB3503 in upstream now, which has enough
infrastructure for us to use.
We just want to handle states of HUB_CONNECT line or RESET_N line, which
should just be fine with this driver.
Am I missing something ?
>
>>
>> [2]
>> https://git.linaro.org/gitweb?p=landing-
>> teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> It looks good.
Regards
Vivek
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 13:10 ` Vivek Gautam
0 siblings, 0 replies; 50+ messages in thread
From: Vivek Gautam @ 2013-05-30 13:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
> On Wednesday, May 29, 2013 5:51 PM, Tushar Behera:
>> On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> > On Tue, May 28, 2013 at 8:59 PM, Tushar Behera
>> > <tushar.behera@linaro.org> wrote:
>> >
>> >> The patches are at [1].
>> >
>> > FWIW, a cgit/gitweb link is easier to follow when you're reading an
>> > email. Anyway, found the patches.
>> >
>> >> There are a total of 6 patches on top of
>> >> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another
>> >> patch
>> >> (c) is just a defconfig hack to get Arndale booting. Remaining 2
>> >> patches
>> >> (e, f) are required to reset the hub during EHCI initialization.
>> >
>> > Huh, I thought you said that (c) wasn't needed when I posted the
>> > defconfig update. It'd be nice to see the code fixed to handle this
>> > case instead of Linaro carrying a patch like this though. I.e. make it
>> > able to deselect the uart, or make it tied to DEBUG_LL like on other
>> > platforms instead of having a separate config for this.
>> >
>>
>> It would be good to free up the dependency on the correct UART port for
>> the board to boot. Without that, there would always be boards that don't
>> boot with default mainline defconfig file even though all other
>> components are in place.
>>
>> >> a. ARM: exynos: defconfig update
>> >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> >> e. usb: ehci-s5p: add the HSIC port initialization
>> >> f. ARM: dts: Add USB gpio entries for Arndale board
>> >>
>> >> I am not sure whether such kind of board-specific patches (e, f) are
>> >> appreciated in the drivers. But that is all we need to get USB and
>> >> Ethernet to work on v3.10-rc3 kernel.
>> >
>> > I've come across a similar situation with wifi reset sequence on the
>> > chromebook. On the product kernel we added some code to the board file
>> > to deal with it, but if we keep doing that things will grow out of
>> > hand.
>> >
>> > I don't know if it'll be unpopular, but I think it's time to start a
>> > drivers/platform/arm for these kind of things, and have those drivers
>> > probe on the system compatible value, similar to how x86 does it (with
>> > DMI tables). At least that's my plan for approaching the wifi
>> > reset/power-on sequence on the Chromebook. I hope to have patches in
>> > not all that long...
>> >
>> > Likewise, the hub reset/enable code doesn't have to go with the USB
>> > driver, right? I.e. if you cycle reset/enable on the hub after the
>> > host and phy is configured, you'll still have a working setup?
>> >
>>
>> Right, hub reset/enable code need not be tied up with USB driver. As per
>> your suggestion regarding drivers/platform/arm, I implemented an Arndale
>> specific driver [2] in drivers/platform/arm and verified USB and
>> ethernet to be working.
>
> CC'ed Thomas Abraham, Vivek Gautam
>
> I think so.
>
> I looked at Arndale board Schematics.
> 'Hub chip' on Arndale board needs hub reset/enable code.
> 'HUB_RESET' and 'HUB_CONNECT' pins are used to reset 'Hub chip'
> on Arndale board, not Exynos EHCI controller. So, Exynos EHCI driver
> does not need to consider this hub reset/enable code.
>
> If there is a driver for this 'Hub chip', 'Hub chip' driver maybe
> consider this.
>
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
We do have a driver for USB3503 in upstream now, which has enough
infrastructure for us to use.
We just want to handle states of HUB_CONNECT line or RESET_N line, which
should just be fine with this driver.
Am I missing something ?
>
>>
>> [2]
>> https://git.linaro.org/gitweb?p=landing-
>> teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> It looks good.
Regards
Vivek
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 13:10 ` Vivek Gautam
0 siblings, 0 replies; 50+ messages in thread
From: Vivek Gautam @ 2013-05-30 13:10 UTC (permalink / raw)
To: 'Tushar Behera', 'Olof Johansson'
Cc: 'Arnd Bergmann', 'Kevin Hilman',
linux-kernel, linux-arm-kernel, linux-samsung-soc,
'Kukjin Kim', 'Doug Anderson',
'Patch Tracking', Jingoo Han, 'Thomas Abraham',
Julius Werner, Vivek Gautam
Hi,
> On Wednesday, May 29, 2013 5:51 PM, Tushar Behera:
>> On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> > On Tue, May 28, 2013 at 8:59 PM, Tushar Behera
>> > <tushar.behera@linaro.org> wrote:
>> >
>> >> The patches are at [1].
>> >
>> > FWIW, a cgit/gitweb link is easier to follow when you're reading an
>> > email. Anyway, found the patches.
>> >
>> >> There are a total of 6 patches on top of
>> >> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another
>> >> patch
>> >> (c) is just a defconfig hack to get Arndale booting. Remaining 2
>> >> patches
>> >> (e, f) are required to reset the hub during EHCI initialization.
>> >
>> > Huh, I thought you said that (c) wasn't needed when I posted the
>> > defconfig update. It'd be nice to see the code fixed to handle this
>> > case instead of Linaro carrying a patch like this though. I.e. make it
>> > able to deselect the uart, or make it tied to DEBUG_LL like on other
>> > platforms instead of having a separate config for this.
>> >
>>
>> It would be good to free up the dependency on the correct UART port for
>> the board to boot. Without that, there would always be boards that don't
>> boot with default mainline defconfig file even though all other
>> components are in place.
>>
>> >> a. ARM: exynos: defconfig update
>> >> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> >> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> >> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> >> e. usb: ehci-s5p: add the HSIC port initialization
>> >> f. ARM: dts: Add USB gpio entries for Arndale board
>> >>
>> >> I am not sure whether such kind of board-specific patches (e, f) are
>> >> appreciated in the drivers. But that is all we need to get USB and
>> >> Ethernet to work on v3.10-rc3 kernel.
>> >
>> > I've come across a similar situation with wifi reset sequence on the
>> > chromebook. On the product kernel we added some code to the board file
>> > to deal with it, but if we keep doing that things will grow out of
>> > hand.
>> >
>> > I don't know if it'll be unpopular, but I think it's time to start a
>> > drivers/platform/arm for these kind of things, and have those drivers
>> > probe on the system compatible value, similar to how x86 does it (with
>> > DMI tables). At least that's my plan for approaching the wifi
>> > reset/power-on sequence on the Chromebook. I hope to have patches in
>> > not all that long...
>> >
>> > Likewise, the hub reset/enable code doesn't have to go with the USB
>> > driver, right? I.e. if you cycle reset/enable on the hub after the
>> > host and phy is configured, you'll still have a working setup?
>> >
>>
>> Right, hub reset/enable code need not be tied up with USB driver. As per
>> your suggestion regarding drivers/platform/arm, I implemented an Arndale
>> specific driver [2] in drivers/platform/arm and verified USB and
>> ethernet to be working.
>
> CC'ed Thomas Abraham, Vivek Gautam
>
> I think so.
>
> I looked at Arndale board Schematics.
> 'Hub chip' on Arndale board needs hub reset/enable code.
> 'HUB_RESET' and 'HUB_CONNECT' pins are used to reset 'Hub chip'
> on Arndale board, not Exynos EHCI controller. So, Exynos EHCI driver
> does not need to consider this hub reset/enable code.
>
> If there is a driver for this 'Hub chip', 'Hub chip' driver maybe
> consider this.
>
> However, Olof Johansson mentioned, 'drivers/platform/arm/board_arndale.c'
> would be a good alternative.
We do have a driver for USB3503 in upstream now, which has enough
infrastructure for us to use.
We just want to handle states of HUB_CONNECT line or RESET_N line, which
should just be fine with this driver.
Am I missing something ?
>
>>
>> [2]
>> https://git.linaro.org/gitweb?p=landing-
>> teams/working/samsung/kernel.git;a=shortlog;h=refs/heads/upstream/arndale-usb-2
>
> It looks good.
Regards
Vivek
^ permalink raw reply [flat|nested] 50+ messages in thread
[parent not found: <CAHbNUh0kWxqDMvLwE-_PKQVassDJvbgiCiDDNSHn9AW3md=A5A@mail.gmail.com>]
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
[not found] ` <CAHbNUh0kWxqDMvLwE-_PKQVassDJvbgiCiDDNSHn9AW3md=A5A@mail.gmail.com>
@ 2013-05-30 15:28 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-30 15:28 UTC (permalink / raw)
To: Vivek Gautam
Cc: Jingoo Han, Olof Johansson, Arnd Bergmann, Kevin Hilman, lkml,
linux-arm-kernel, linux-samsung-soc, Kukjin Kim, Doug Anderson,
Patch Tracking, Thomas Abraham, Julius Werner
Resending in plain-text mode.
On 30 May 2013 20:56, Tushar Behera <tushar.behera@linaro.org> wrote:
>>>
>> We do have a driver for USB3503 in upstream now, which has enough
>> infrastructure for us to use.
>> We just want to handle states of HUB_CONNECT line or RESET_N line, which
>> should just be fine with this driver.
>>
>> Am I missing something ?
>>
The USB3503 driver is an I2C client driver. In case of Arndale, the SDA and
SCL lines for SMSC3503 chip are sorted, hence there are no I2C channels that
the driver can register to. So effectively we can't use that driver for
Arndale.
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-30 15:28 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-30 15:28 UTC (permalink / raw)
To: linux-arm-kernel
Resending in plain-text mode.
On 30 May 2013 20:56, Tushar Behera <tushar.behera@linaro.org> wrote:
>>>
>> We do have a driver for USB3503 in upstream now, which has enough
>> infrastructure for us to use.
>> We just want to handle states of HUB_CONNECT line or RESET_N line, which
>> should just be fine with this driver.
>>
>> Am I missing something ?
>>
The USB3503 driver is an I2C client driver. In case of Arndale, the SDA and
SCL lines for SMSC3503 chip are sorted, hence there are no I2C channels that
the driver can register to. So effectively we can't use that driver for
Arndale.
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 5:31 ` Olof Johansson
(?)
@ 2013-05-29 12:03 ` Tushar Behera
-1 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 12:03 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, Kevin Hilman, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
I am working on this approach so that we can consolidate both the UART
port macros together and tie them to DEBUG_LL. I would post the patch
tomorrow.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 12:03 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 12:03 UTC (permalink / raw)
To: linux-arm-kernel
On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
I am working on this approach so that we can consolidate both the UART
port macros together and tie them to DEBUG_LL. I would post the patch
tomorrow.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 12:03 ` Tushar Behera
0 siblings, 0 replies; 50+ messages in thread
From: Tushar Behera @ 2013-05-29 12:03 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, Kevin Hilman, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
On 05/29/2013 11:01 AM, Olof Johansson wrote:
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
>
I am working on this approach so that we can consolidate both the UART
port macros together and tie them to DEBUG_LL. I would post the patch
tomorrow.
>> a. ARM: exynos: defconfig update
>> b. ARM: EXYNOS: Update defconfig for Arndale and Origen board
>> c. [TEMP] ARM: EXYNOS: Set low-level UART port to 2
>> d. ARM: dts: Enabling samsung-usb2phy driver for exynos5250
>> e. usb: ehci-s5p: add the HSIC port initialization
>> f. ARM: dts: Add USB gpio entries for Arndale board
--
Tushar Behera
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 5:31 ` Olof Johansson
(?)
@ 2013-05-29 18:23 ` Kevin Hilman
-1 siblings, 0 replies; 50+ messages in thread
From: Kevin Hilman @ 2013-05-29 18:23 UTC (permalink / raw)
To: Olof Johansson
Cc: Tushar Behera, Arnd Bergmann, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
Olof Johansson <olof@lixom.net> writes:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
I agree, that defconfig hack is awful to have to carry.
I also noticed that correct setting of CONFIG_S3C_LOWLEVEL_UART_PORT is
needed even without DEBUG_LL which seems broken.
Kevin
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 18:23 ` Kevin Hilman
0 siblings, 0 replies; 50+ messages in thread
From: Kevin Hilman @ 2013-05-29 18:23 UTC (permalink / raw)
To: linux-arm-kernel
Olof Johansson <olof@lixom.net> writes:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
I agree, that defconfig hack is awful to have to carry.
I also noticed that correct setting of CONFIG_S3C_LOWLEVEL_UART_PORT is
needed even without DEBUG_LL which seems broken.
Kevin
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-05-29 18:23 ` Kevin Hilman
0 siblings, 0 replies; 50+ messages in thread
From: Kevin Hilman @ 2013-05-29 18:23 UTC (permalink / raw)
To: Olof Johansson
Cc: Tushar Behera, Arnd Bergmann, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Kukjin Kim, Doug Anderson, Patch Tracking
Olof Johansson <olof@lixom.net> writes:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>
>> The patches are at [1].
>
> FWIW, a cgit/gitweb link is easier to follow when you're reading an
> email. Anyway, found the patches.
>
>> There are a total of 6 patches on top of
>> v3.10-rc3. 3 of them (a, b, d) are queued for 3.10-rc4 and another patch
>> (c) is just a defconfig hack to get Arndale booting. Remaining 2 patches
>> (e, f) are required to reset the hub during EHCI initialization.
>
> Huh, I thought you said that (c) wasn't needed when I posted the
> defconfig update. It'd be nice to see the code fixed to handle this
> case instead of Linaro carrying a patch like this though. I.e. make it
> able to deselect the uart, or make it tied to DEBUG_LL like on other
> platforms instead of having a separate config for this.
I agree, that defconfig hack is awful to have to carry.
I also noticed that correct setting of CONFIG_S3C_LOWLEVEL_UART_PORT is
needed even without DEBUG_LL which seems broken.
Kevin
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
2013-05-29 5:31 ` Olof Johansson
(?)
@ 2013-06-04 12:13 ` Mark Brown
-1 siblings, 0 replies; 50+ messages in thread
From: Mark Brown @ 2013-06-04 12:13 UTC (permalink / raw)
To: Olof Johansson
Cc: Tushar Behera, Arnd Bergmann, Kukjin Kim, grant.likely,
Kevin Hilman, Patch Tracking, linux-kernel, Doug Anderson,
linux-samsung-soc, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
On Tue, May 28, 2013 at 10:31:41PM -0700, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> > e. usb: ehci-s5p: add the HSIC port initialization
> > f. ARM: dts: Add USB gpio entries for Arndale board
> > I am not sure whether such kind of board-specific patches (e, f) are
> > appreciated in the drivers. But that is all we need to get USB and
> > Ethernet to work on v3.10-rc3 kernel.
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
This does seem to be a fairly general problem for embedded systems with
devices on enumerable buses - it's even worse for things like Slimbus
where the expectation is that many devices will spend almost all of
their time powered down. We probably need to come up with
infrastructure to enable the drivers for the individual devices to
handle this, or at least roll out such infrastructure more widely, IIRC
there's some DT stuff for PCI.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-06-04 12:13 ` Mark Brown
0 siblings, 0 replies; 50+ messages in thread
From: Mark Brown @ 2013-06-04 12:13 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 28, 2013 at 10:31:41PM -0700, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> > e. usb: ehci-s5p: add the HSIC port initialization
> > f. ARM: dts: Add USB gpio entries for Arndale board
> > I am not sure whether such kind of board-specific patches (e, f) are
> > appreciated in the drivers. But that is all we need to get USB and
> > Ethernet to work on v3.10-rc3 kernel.
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
This does seem to be a fairly general problem for embedded systems with
devices on enumerable buses - it's even worse for things like Slimbus
where the expectation is that many devices will spend almost all of
their time powered down. We probably need to come up with
infrastructure to enable the drivers for the individual devices to
handle this, or at least roll out such infrastructure more widely, IIRC
there's some DT stuff for PCI.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130604/fcb3868d/attachment.sig>
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Update defconfig for Arndale and Origen board
@ 2013-06-04 12:13 ` Mark Brown
0 siblings, 0 replies; 50+ messages in thread
From: Mark Brown @ 2013-06-04 12:13 UTC (permalink / raw)
To: Olof Johansson
Cc: Tushar Behera, Arnd Bergmann, Kukjin Kim, grant.likely,
Kevin Hilman, Patch Tracking, linux-kernel, Doug Anderson,
linux-samsung-soc, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
On Tue, May 28, 2013 at 10:31:41PM -0700, Olof Johansson wrote:
> On Tue, May 28, 2013 at 8:59 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> > e. usb: ehci-s5p: add the HSIC port initialization
> > f. ARM: dts: Add USB gpio entries for Arndale board
> > I am not sure whether such kind of board-specific patches (e, f) are
> > appreciated in the drivers. But that is all we need to get USB and
> > Ethernet to work on v3.10-rc3 kernel.
> I've come across a similar situation with wifi reset sequence on the
> chromebook. On the product kernel we added some code to the board file
> to deal with it, but if we keep doing that things will grow out of
> hand.
> I don't know if it'll be unpopular, but I think it's time to start a
> drivers/platform/arm for these kind of things, and have those drivers
> probe on the system compatible value, similar to how x86 does it (with
> DMI tables). At least that's my plan for approaching the wifi
> reset/power-on sequence on the Chromebook. I hope to have patches in
> not all that long...
This does seem to be a fairly general problem for embedded systems with
devices on enumerable buses - it's even worse for things like Slimbus
where the expectation is that many devices will spend almost all of
their time powered down. We probably need to come up with
infrastructure to enable the drivers for the individual devices to
handle this, or at least roll out such infrastructure more widely, IIRC
there's some DT stuff for PCI.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 50+ messages in thread