* Re: [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
@ 2015-05-27 14:18 Jingoo Han
2015-06-03 11:45 ` Pratyush Anand
0 siblings, 1 reply; 9+ messages in thread
From: Jingoo Han @ 2015-05-27 14:18 UTC (permalink / raw)
To: 'Yijing Wang', 'Bjorn Helgaas'
Cc: linux-pci, 'Daniel Axtens', 'Arnd Bergmann',
linux-arm-kernel, 'Mohit Kumar', 'Pratyush Anand',
'Lucas Stach'
On Tue, 28 Apr 2015 15:01:37 +0800, Yijing Wang wrote:
> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
> Now pci_scan_root_bus() == pci_create_root_bus() +
> pci_scan_child_bus() if busn resource is supplied.
> Designware added the busn resource to resources list
> in dw_pcie_setup(). So it should be safe to use
> pci_scan_root_bus() instead.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Mohit Kumar <mohit.kumar@st.com>
> CC: Jingoo Han <jg1.han@samsung.com>
+cc: Pratyush Anand, Lucas Stach
Acked-by: Jingoo Han <jingoohan1@gmail.com>
> ---
> drivers/pci/host/pcie-designware.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
2015-05-27 14:18 [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity Jingoo Han
@ 2015-06-03 11:45 ` Pratyush Anand
0 siblings, 0 replies; 9+ messages in thread
From: Pratyush Anand @ 2015-06-03 11:45 UTC (permalink / raw)
To: Jingoo Han
Cc: Yijing Wang, Bjorn Helgaas, linux-pci, Daniel Axtens,
Arnd Bergmann, linux-arm-kernel, Mohit Kumar, Lucas Stach
On Wed, May 27, 2015 at 7:48 PM, Jingoo Han <jingoohan1@gmail.com> wrote:
> On Tue, 28 Apr 2015 15:01:37 +0800, Yijing Wang wrote:
>
>> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
>> Now pci_scan_root_bus() == pci_create_root_bus() +
>> pci_scan_child_bus() if busn resource is supplied.
>> Designware added the busn resource to resources list
>> in dw_pcie_setup(). So it should be safe to use
>> pci_scan_root_bus() instead.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> CC: Mohit Kumar <mohit.kumar@st.com>
>> CC: Jingoo Han <jg1.han@samsung.com>
>
> +cc: Pratyush Anand, Lucas Stach
>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
Looks fine to me:
Acked-by: Pratyush Anand <pratyush.anand@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
@ 2015-06-03 11:45 ` Pratyush Anand
0 siblings, 0 replies; 9+ messages in thread
From: Pratyush Anand @ 2015-06-03 11:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 27, 2015 at 7:48 PM, Jingoo Han <jingoohan1@gmail.com> wrote:
> On Tue, 28 Apr 2015 15:01:37 +0800, Yijing Wang wrote:
>
>> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
>> Now pci_scan_root_bus() == pci_create_root_bus() +
>> pci_scan_child_bus() if busn resource is supplied.
>> Designware added the busn resource to resources list
>> in dw_pcie_setup(). So it should be safe to use
>> pci_scan_root_bus() instead.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> CC: Mohit Kumar <mohit.kumar@st.com>
>> CC: Jingoo Han <jg1.han@samsung.com>
>
> +cc: Pratyush Anand, Lucas Stach
>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
Looks fine to me:
Acked-by: Pratyush Anand <pratyush.anand@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
2015-04-28 7:01 ` Yijing Wang
@ 2015-05-27 0:12 ` Bjorn Helgaas
-1 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2015-05-27 0:12 UTC (permalink / raw)
To: Yijing Wang
Cc: linux-pci, dja, Arnd Bergmann, linux-arm-kernel, Mohit Kumar,
Jingoo Han, Pratyush Anand
[+cc Pratyush]
On Tue, Apr 28, 2015 at 03:01:37PM +0800, Yijing Wang wrote:
> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
> Now pci_scan_root_bus() == pci_create_root_bus() +
> pci_scan_child_bus() if busn resource is supplied.
> Designware added the busn resource to resources list
> in dw_pcie_setup(). So it should be safe to use
> pci_scan_root_bus() instead.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Mohit Kumar <mohit.kumar@st.com>
> CC: Jingoo Han <jg1.han@samsung.com>
Jingoo, Pratyush?
> ---
> drivers/pci/host/pcie-designware.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 2e9f84f..8c80f38 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> struct pcie_port *pp = sys_to_pcie(sys);
>
> pp->root_bus_nr = sys->busnr;
> - bus = pci_create_root_bus(pp->dev, sys->busnr,
> + bus = pci_scan_root_bus(pp->dev, sys->busnr,
> &dw_pcie_ops, sys, &sys->resources);
> if (!bus)
> return NULL;
>
> - pci_scan_child_bus(bus);
> -
> if (bus && pp->ops->scan_bus)
> pp->ops->scan_bus(pp);
>
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
@ 2015-05-27 0:12 ` Bjorn Helgaas
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2015-05-27 0:12 UTC (permalink / raw)
To: linux-arm-kernel
[+cc Pratyush]
On Tue, Apr 28, 2015 at 03:01:37PM +0800, Yijing Wang wrote:
> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
> Now pci_scan_root_bus() == pci_create_root_bus() +
> pci_scan_child_bus() if busn resource is supplied.
> Designware added the busn resource to resources list
> in dw_pcie_setup(). So it should be safe to use
> pci_scan_root_bus() instead.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Mohit Kumar <mohit.kumar@st.com>
> CC: Jingoo Han <jg1.han@samsung.com>
Jingoo, Pratyush?
> ---
> drivers/pci/host/pcie-designware.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 2e9f84f..8c80f38 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> struct pcie_port *pp = sys_to_pcie(sys);
>
> pp->root_bus_nr = sys->busnr;
> - bus = pci_create_root_bus(pp->dev, sys->busnr,
> + bus = pci_scan_root_bus(pp->dev, sys->busnr,
> &dw_pcie_ops, sys, &sys->resources);
> if (!bus)
> return NULL;
>
> - pci_scan_child_bus(bus);
> -
> if (bus && pp->ops->scan_bus)
> pp->ops->scan_bus(pp);
>
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
2015-04-28 7:01 ` Yijing Wang
@ 2015-04-28 8:15 ` Lucas Stach
-1 siblings, 0 replies; 9+ messages in thread
From: Lucas Stach @ 2015-04-28 8:15 UTC (permalink / raw)
To: Yijing Wang
Cc: Bjorn Helgaas, Arnd Bergmann, linux-pci, Jingoo Han, Mohit Kumar,
linux-arm-kernel, dja
Am Dienstag, den 28.04.2015, 15:01 +0800 schrieb Yijing Wang:
> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
> Now pci_scan_root_bus() == pci_create_root_bus() +
> pci_scan_child_bus() if busn resource is supplied.
> Designware added the busn resource to resources list
> in dw_pcie_setup(). So it should be safe to use
> pci_scan_root_bus() instead.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Mohit Kumar <mohit.kumar@st.com>
> CC: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/host/pcie-designware.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 2e9f84f..8c80f38 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> struct pcie_port *pp = sys_to_pcie(sys);
>
> pp->root_bus_nr = sys->busnr;
> - bus = pci_create_root_bus(pp->dev, sys->busnr,
> + bus = pci_scan_root_bus(pp->dev, sys->busnr,
> &dw_pcie_ops, sys, &sys->resources);
> if (!bus)
> return NULL;
>
> - pci_scan_child_bus(bus);
> -
> if (bus && pp->ops->scan_bus)
> pp->ops->scan_bus(pp);
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
@ 2015-04-28 8:15 ` Lucas Stach
0 siblings, 0 replies; 9+ messages in thread
From: Lucas Stach @ 2015-04-28 8:15 UTC (permalink / raw)
To: linux-arm-kernel
Am Dienstag, den 28.04.2015, 15:01 +0800 schrieb Yijing Wang:
> Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
> Now pci_scan_root_bus() == pci_create_root_bus() +
> pci_scan_child_bus() if busn resource is supplied.
> Designware added the busn resource to resources list
> in dw_pcie_setup(). So it should be safe to use
> pci_scan_root_bus() instead.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Mohit Kumar <mohit.kumar@st.com>
> CC: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/host/pcie-designware.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 2e9f84f..8c80f38 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> struct pcie_port *pp = sys_to_pcie(sys);
>
> pp->root_bus_nr = sys->busnr;
> - bus = pci_create_root_bus(pp->dev, sys->busnr,
> + bus = pci_scan_root_bus(pp->dev, sys->busnr,
> &dw_pcie_ops, sys, &sys->resources);
> if (!bus)
> return NULL;
>
> - pci_scan_child_bus(bus);
> -
> if (bus && pp->ops->scan_bus)
> pp->ops->scan_bus(pp);
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
2015-04-28 7:01 [PATCH Part1 v11 0/5] Some cleanup for pcie host drivers Yijing Wang
@ 2015-04-28 7:01 ` Yijing Wang
0 siblings, 0 replies; 9+ messages in thread
From: Yijing Wang @ 2015-04-28 7:01 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, dja, Arnd Bergmann, linux-arm-kernel, Yijing Wang,
Mohit Kumar, Jingoo Han
Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
Now pci_scan_root_bus() == pci_create_root_bus() +
pci_scan_child_bus() if busn resource is supplied.
Designware added the busn resource to resources list
in dw_pcie_setup(). So it should be safe to use
pci_scan_root_bus() instead.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
CC: Mohit Kumar <mohit.kumar@st.com>
CC: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pcie-designware.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 2e9f84f..8c80f38 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
struct pcie_port *pp = sys_to_pcie(sys);
pp->root_bus_nr = sys->busnr;
- bus = pci_create_root_bus(pp->dev, sys->busnr,
+ bus = pci_scan_root_bus(pp->dev, sys->busnr,
&dw_pcie_ops, sys, &sys->resources);
if (!bus)
return NULL;
- pci_scan_child_bus(bus);
-
if (bus && pp->ops->scan_bus)
pp->ops->scan_bus(pp);
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity
@ 2015-04-28 7:01 ` Yijing Wang
0 siblings, 0 replies; 9+ messages in thread
From: Yijing Wang @ 2015-04-28 7:01 UTC (permalink / raw)
To: linux-arm-kernel
Pci_bus_add_devices() was ripped out of pci_scan_root_bus().
Now pci_scan_root_bus() == pci_create_root_bus() +
pci_scan_child_bus() if busn resource is supplied.
Designware added the busn resource to resources list
in dw_pcie_setup(). So it should be safe to use
pci_scan_root_bus() instead.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
CC: Mohit Kumar <mohit.kumar@st.com>
CC: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pcie-designware.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 2e9f84f..8c80f38 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -728,13 +728,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys)
struct pcie_port *pp = sys_to_pcie(sys);
pp->root_bus_nr = sys->busnr;
- bus = pci_create_root_bus(pp->dev, sys->busnr,
+ bus = pci_scan_root_bus(pp->dev, sys->busnr,
&dw_pcie_ops, sys, &sys->resources);
if (!bus)
return NULL;
- pci_scan_child_bus(bus);
-
if (bus && pp->ops->scan_bus)
pp->ops->scan_bus(pp);
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-06-03 11:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-27 14:18 [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity Jingoo Han
2015-06-03 11:45 ` Pratyush Anand
2015-06-03 11:45 ` Pratyush Anand
-- strict thread matches above, loose matches on Subject: below --
2015-04-28 7:01 [PATCH Part1 v11 0/5] Some cleanup for pcie host drivers Yijing Wang
2015-04-28 7:01 ` [PATCH Part1 v11 3/5] PCI: designware: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-04-28 7:01 ` Yijing Wang
2015-04-28 8:15 ` Lucas Stach
2015-04-28 8:15 ` Lucas Stach
2015-05-27 0:12 ` Bjorn Helgaas
2015-05-27 0:12 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.