* [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag
@ 2009-12-15 17:56 Gustavo F. Padovan
2009-12-15 20:58 ` AW: " Marian Harbach
2009-12-17 20:06 ` Marcel Holtmann
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo F. Padovan @ 2009-12-15 17:56 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, gustavo
RemoteBusy flag need to be unset before l2cap_ertm_send(), otherwise
l2cap_ertm_send() will return without sending packets because it checks
that flag before start sending.
Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
---
net/bluetooth/l2cap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 8a2b3d3..2a2da9d 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -3469,8 +3469,8 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
&& (pi->unacked_frames > 0))
__mod_retrans_timer();
- l2cap_ertm_send(sk);
pi->conn_state &= ~L2CAP_CONN_REMOTE_BUSY;
+ l2cap_ertm_send(sk);
}
break;
--
1.6.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* AW: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag
2009-12-15 17:56 [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag Gustavo F. Padovan
@ 2009-12-15 20:58 ` Marian Harbach
2009-12-15 21:52 ` Gustavo F. Padovan
2009-12-17 20:06 ` Marcel Holtmann
1 sibling, 1 reply; 4+ messages in thread
From: Marian Harbach @ 2009-12-15 20:58 UTC (permalink / raw)
To: linux-bluetooth
Hi,
I have the same problem as described in this post:
http://www.spinics.net/lists/linux-bluetooth/msg03627.html
I found that depending on filesize, the original input is delayed by some
bytes (180-260 for 16kHz PCM input) and additionally the first few samples
are overwritten when doing sbcenc followed by sbcdec.
Is there a fix for this issue?
Cheers
Marian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag
2009-12-15 20:58 ` AW: " Marian Harbach
@ 2009-12-15 21:52 ` Gustavo F. Padovan
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo F. Padovan @ 2009-12-15 21:52 UTC (permalink / raw)
To: Marian Harbach; +Cc: linux-bluetooth
Hi Marian,
On Tue, Dec 15, 2009 at 6:58 PM, Marian Harbach
<harbach@mathematik.uni-marburg.de> wrote:
> Hi,
>
> I have the same problem as described in this post:
No, you don't have. This patch is about L2CAP Enhanced Retransmission
Mode and it's not related to the problem you had.
>
> http://www.spinics.net/lists/linux-bluetooth/msg03627.html
>
> I found that depending on filesize, the original input is delayed by some
> bytes (180-260 for 16kHz PCM input) and additionally the first few samples
> are overwritten when doing sbcenc followed by sbcdec.
>
> Is there a fix for this issue?
>
> Cheers
> Marian
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Gustavo F. Padovan
http://padovan.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag
2009-12-15 17:56 [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag Gustavo F. Padovan
2009-12-15 20:58 ` AW: " Marian Harbach
@ 2009-12-17 20:06 ` Marcel Holtmann
1 sibling, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2009-12-17 20:06 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: linux-bluetooth, gustavo
Hi Gustavo,
> RemoteBusy flag need to be unset before l2cap_ertm_send(), otherwise
> l2cap_ertm_send() will return without sending packets because it checks
> that flag before start sending.
patch has been applied. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-17 20:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-15 17:56 [PATCH 1/1] Bluetooth: fix unset of RemoteBusy flag Gustavo F. Padovan
2009-12-15 20:58 ` AW: " Marian Harbach
2009-12-15 21:52 ` Gustavo F. Padovan
2009-12-17 20:06 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.