All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: 'Joonyoung Shim' <jy0922.shim@samsung.com>
Cc: 'Leela Krishna Amudala' <l.krishna@samsung.com>,
	kgene.kim@samsung.com, devicetree-discuss@lists.ozlabs.org,
	joshi@samsung.com, grant.likely@secretlab.ca,
	linux-samsung-soc@vger.kernel.org, thomas.ab@samsung.com,
	olofj@google.com, linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH V2 6/7] ARM: EXYNOS5: Add the bus clock for FIMD
Date: Tue, 24 Jul 2012 08:48:40 +0900	[thread overview]
Message-ID: <000501cd692d$afa71560$0ef54020$%han@samsung.com> (raw)
In-Reply-To: <500DE22F.5010006@samsung.com>

On Tuesday, July 24, 2012 8:46 AM, Joonyoung Shim wrote:
> 
> On 07/24/2012 08:14 AM, Jingoo Han wrote:
> > On Monday, July 23, 2012 6:55 PM, Joonyoung Shim wrote:
> >> Hi, Jingoo.
> >>
> >> On 07/23/2012 05:34 PM, Joonyoung Shim wrote:
> >>> On 07/18/2012 02:57 PM, Leela Krishna Amudala wrote:
> >>>> This patch adds the bus clock for FIMD and changes
> >>>> the device name for lcd clock
> >>> Please refer below patch for exynos4.
> >>>
> >>> http://lists.linaro.org/pipermail/linaro-dev/2011-December/008872.html
> >>>
> >>>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >>>> ---
> >>>>    arch/arm/mach-exynos/clock-exynos5.c |    7 ++++++-
> >>>>    1 files changed, 6 insertions(+), 1 deletions(-)
> >>>>
> >>>> diff --git a/arch/arm/mach-exynos/clock-exynos5.c
> >>>> b/arch/arm/mach-exynos/clock-exynos5.c
> >>>> index 774533c..f001876 100644
> >>>> --- a/arch/arm/mach-exynos/clock-exynos5.c
> >>>> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> >>>> @@ -634,6 +634,11 @@ static struct clk exynos5_init_clocks_off[] = {
> >>>>            .enable        = exynos5_clk_ip_disp1_ctrl,
> >>>>            .ctrlbit    = (1 << 3),
> >>>>        }, {
> >>>> +        .name           = "fimd",
> >>>> +        .devname        = "exynos5-fb",
> >>>> +        .enable         = exynos5_clk_ip_disp1_ctrl,
> >>>> +        .ctrlbit        = (1 << 0),
> >>>> +    }, {
> >> With this patch, it causes below error at the DP driver because fimd
> >> clock is disabled.
> >>
> >> [    0.210000] exynos-dp exynos-dp: Timeout of video streamclk ok
> >> [    0.210000] exynos-dp exynos-dp: unable to config video
> >> [    0.210000] exynos-dp: probe of exynos-dp failed with error -110
> >>
> >> I wonder fimd clock has any dependency with DP
> > FIMD pixel clock is necessary to enable DP.
> 
> So then, i think DP driver also should control FIMD pixel clock.
> Do you have any patch or plan for it?

I have no plan.

Best regards,
Jingoo Han

> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jg1.han@samsung.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 6/7] ARM: EXYNOS5: Add the bus clock for FIMD
Date: Tue, 24 Jul 2012 08:48:40 +0900	[thread overview]
Message-ID: <000501cd692d$afa71560$0ef54020$%han@samsung.com> (raw)
In-Reply-To: <500DE22F.5010006@samsung.com>

On Tuesday, July 24, 2012 8:46 AM, Joonyoung Shim wrote:
> 
> On 07/24/2012 08:14 AM, Jingoo Han wrote:
> > On Monday, July 23, 2012 6:55 PM, Joonyoung Shim wrote:
> >> Hi, Jingoo.
> >>
> >> On 07/23/2012 05:34 PM, Joonyoung Shim wrote:
> >>> On 07/18/2012 02:57 PM, Leela Krishna Amudala wrote:
> >>>> This patch adds the bus clock for FIMD and changes
> >>>> the device name for lcd clock
> >>> Please refer below patch for exynos4.
> >>>
> >>> http://lists.linaro.org/pipermail/linaro-dev/2011-December/008872.html
> >>>
> >>>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >>>> ---
> >>>>    arch/arm/mach-exynos/clock-exynos5.c |    7 ++++++-
> >>>>    1 files changed, 6 insertions(+), 1 deletions(-)
> >>>>
> >>>> diff --git a/arch/arm/mach-exynos/clock-exynos5.c
> >>>> b/arch/arm/mach-exynos/clock-exynos5.c
> >>>> index 774533c..f001876 100644
> >>>> --- a/arch/arm/mach-exynos/clock-exynos5.c
> >>>> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> >>>> @@ -634,6 +634,11 @@ static struct clk exynos5_init_clocks_off[] = {
> >>>>            .enable        = exynos5_clk_ip_disp1_ctrl,
> >>>>            .ctrlbit    = (1 << 3),
> >>>>        }, {
> >>>> +        .name           = "fimd",
> >>>> +        .devname        = "exynos5-fb",
> >>>> +        .enable         = exynos5_clk_ip_disp1_ctrl,
> >>>> +        .ctrlbit        = (1 << 0),
> >>>> +    }, {
> >> With this patch, it causes below error at the DP driver because fimd
> >> clock is disabled.
> >>
> >> [    0.210000] exynos-dp exynos-dp: Timeout of video streamclk ok
> >> [    0.210000] exynos-dp exynos-dp: unable to config video
> >> [    0.210000] exynos-dp: probe of exynos-dp failed with error -110
> >>
> >> I wonder fimd clock has any dependency with DP
> > FIMD pixel clock is necessary to enable DP.
> 
> So then, i think DP driver also should control FIMD pixel clock.
> Do you have any patch or plan for it?

I have no plan.

Best regards,
Jingoo Han

> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-07-23 23:48 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18  5:57 [PATCH V2 0/7] Add device tree based discovery support for drm-fimd Leela Krishna Amudala
2012-07-18  5:57 ` Leela Krishna Amudala
2012-07-18  5:57 ` [PATCH V2 1/7] ARM: SAMSUNG: add additional registers and SFR definitions for writeback Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-18  6:51   ` Marek Szyprowski
2012-07-18  6:51     ` Marek Szyprowski
2012-07-18  7:09     ` Ajay kumar
2012-07-18  7:09       ` Ajay kumar
     [not found]       ` <CAEC9eQP01q+ddhA9Q4VQcm8wuvJXmR5KvAVZgX6MEdFLstST0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-20 10:09         ` Sylwester Nawrocki
2012-07-20 10:09           ` Sylwester Nawrocki
2012-07-19 12:43     ` Leela Krishna Amudala
2012-07-19 12:43       ` Leela Krishna Amudala
2012-07-20  6:45       ` Marek Szyprowski
2012-07-20  6:45         ` Marek Szyprowski
2012-07-18 11:05   ` Tomasz Figa
2012-07-18 11:05     ` Tomasz Figa
2012-07-19 13:00     ` Leela Krishna Amudala
2012-07-19 13:00       ` Leela Krishna Amudala
2012-07-19 13:35       ` Tomasz Figa
2012-07-19 13:35         ` Tomasz Figa
2012-07-20  2:21         ` Jingoo Han
2012-07-20  2:21           ` Jingoo Han
2012-07-20  2:59           ` Leela Krishna Amudala
2012-07-20  2:59             ` Leela Krishna Amudala
2012-07-20  9:49             ` Tomasz Figa
2012-07-20  9:49               ` Tomasz Figa
2012-07-20 10:00             ` Sylwester Nawrocki
2012-07-20 10:00               ` Sylwester Nawrocki
2012-07-20 11:07               ` Leela Krishna Amudala
2012-07-20 11:07                 ` Leela Krishna Amudala
2012-07-20 12:54                 ` Sylwester Nawrocki
2012-07-20 12:54                   ` Sylwester Nawrocki
2012-07-22 22:35               ` Jingoo Han
2012-07-22 22:35                 ` Jingoo Han
2012-07-18  5:57 ` [PATCH V2 2/7] ARM: EXYNOS5: add machine specific support for backlight Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-18  5:57 ` [PATCH V2 3/7] ARM: EXYNOS5: add machine specific support for LCD Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-18  6:45   ` Marek Szyprowski
2012-07-18  6:45     ` Marek Szyprowski
2012-07-19 13:21     ` Leela Krishna Amudala
2012-07-19 13:21       ` Leela Krishna Amudala
2012-07-20  6:31       ` Marek Szyprowski
2012-07-20  6:31         ` Marek Szyprowski
2012-07-24 16:02         ` Leela Krishna Amudala
2012-07-24 16:02           ` Leela Krishna Amudala
2012-07-20  7:17       ` Joonyoung Shim
2012-07-20  7:17         ` Joonyoung Shim
2012-07-18  5:57 ` [PATCH V2 4/7] ARM: EXYNOS: Adding DRM platform device Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-20  7:33   ` Joonyoung Shim
2012-07-20  7:33     ` Joonyoung Shim
2012-07-18  5:57 ` [PATCH V2 5/7] ARM: EXYNOS: add device tree based discovery support for FIMD Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-20  7:39   ` Joonyoung Shim
2012-07-20  7:39     ` Joonyoung Shim
2012-07-18  5:57 ` [PATCH V2 6/7] ARM: EXYNOS5: Add the bus clock " Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-23  8:34   ` Joonyoung Shim
2012-07-23  8:34     ` Joonyoung Shim
2012-07-23  9:54     ` Joonyoung Shim
2012-07-23  9:54       ` Joonyoung Shim
2012-07-23 23:14       ` Jingoo Han
2012-07-23 23:14         ` Jingoo Han
2012-07-23 23:45         ` Joonyoung Shim
2012-07-23 23:45           ` Joonyoung Shim
2012-07-23 23:48           ` Jingoo Han [this message]
2012-07-23 23:48             ` Jingoo Han
     [not found]           ` <500DE22F.5010006-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-07-23 23:55             ` Jingoo Han
2012-07-23 23:55               ` Jingoo Han
2012-07-24  1:55               ` Joonyoung Shim
2012-07-24  1:55                 ` Joonyoung Shim
     [not found]                 ` <500E00A3.8080203-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-07-24  2:15                   ` Jingoo Han
2012-07-24  2:15                     ` Jingoo Han
2012-07-24  3:06                     ` Joonyoung Shim
2012-07-24  3:06                       ` Joonyoung Shim
2012-07-24  4:02                       ` Jingoo Han
2012-07-24  4:02                         ` Jingoo Han
2012-07-24  9:13                         ` Sylwester Nawrocki
2012-07-24  9:13                           ` Sylwester Nawrocki
2012-07-18  5:57 ` [PATCH V2 7/7] ARM: EXYNOS5: Set parent clock to fimd Leela Krishna Amudala
2012-07-18  5:57   ` Leela Krishna Amudala
2012-07-23  8:41   ` Joonyoung Shim
2012-07-23  8:41     ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000501cd692d$afa71560$0ef54020$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=joshi@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=l.krishna@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olofj@google.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.