* [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
@ 2013-08-01 0:28 Jingoo Han
2013-08-01 14:52 ` Jaehoon Chung
2013-08-09 13:31 ` Seungwon Jeon
0 siblings, 2 replies; 7+ messages in thread
From: Jingoo Han @ 2013-08-01 0:28 UTC (permalink / raw)
To: Chris Ball
Cc: linux-mmc, Seungwon Jeon, Jaehoon Chung, 'Dinh Nguyen',
Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8a4c066..84102bc 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
config MMC_DW_SOCFPGA
tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
- depends on MMC_DW
+ depends on MMC_DW && MFD_SYSCON
select MMC_DW_PLTFM
help
This selects support for Altera SoCFPGA specific extensions to the
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-01 0:28 [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA Jingoo Han
@ 2013-08-01 14:52 ` Jaehoon Chung
2013-08-01 14:59 ` Dinh Nguyen
2013-08-09 13:31 ` Seungwon Jeon
1 sibling, 1 reply; 7+ messages in thread
From: Jaehoon Chung @ 2013-08-01 14:52 UTC (permalink / raw)
To: Jingoo Han
Cc: Chris Ball, linux-mmc, Seungwon Jeon, Jaehoon Chung,
'Dinh Nguyen'
When I used socfpga_defconfig, MFD_SYSCON is enabled.
Which config do you use?
Best Regards,
Jaehoon Chung
On 08/01/2013 09:28 AM, Jingoo Han wrote:
> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
> the following link error.
>
> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8a4c066..84102bc 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
>
> config MMC_DW_SOCFPGA
> tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
> - depends on MMC_DW
> + depends on MMC_DW && MFD_SYSCON
> select MMC_DW_PLTFM
> help
> This selects support for Altera SoCFPGA specific extensions to the
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-01 14:52 ` Jaehoon Chung
@ 2013-08-01 14:59 ` Dinh Nguyen
2013-08-01 23:22 ` Jingoo Han
0 siblings, 1 reply; 7+ messages in thread
From: Dinh Nguyen @ 2013-08-01 14:59 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: Jingoo Han, Chris Ball, linux-mmc, Seungwon Jeon
On Thu, 2013-08-01 at 23:52 +0900, Jaehoon Chung wrote:
> When I used socfpga_defconfig, MFD_SYSCON is enabled.
> Which config do you use?
>
Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have
fixed this error.
commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
Dinh
> Best Regards,
> Jaehoon Chung
>
> On 08/01/2013 09:28 AM, Jingoo Han wrote:
> > Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
> > the following link error.
> >
> > drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 8a4c066..84102bc 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
> >
> > config MMC_DW_SOCFPGA
> > tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
> > - depends on MMC_DW
> > + depends on MMC_DW && MFD_SYSCON
> > select MMC_DW_PLTFM
> > help
> > This selects support for Altera SoCFPGA specific extensions to the
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-01 14:59 ` Dinh Nguyen
@ 2013-08-01 23:22 ` Jingoo Han
2013-08-02 3:48 ` Jaehoon Chung
0 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2013-08-01 23:22 UTC (permalink / raw)
To: 'Dinh Nguyen', 'Jaehoon Chung'
Cc: 'Chris Ball', linux-mmc, 'Seungwon Jeon',
'Fengguang Wu',
Dan Carpenter, Arnd Bergmann, Jingoo Han
On Thursday, August 01, 2013 11:59 PM, Dinh Nguyen wrote:
> On Thu, 2013-08-01 at 23:52 +0900, Jaehoon Chung wrote:
> > When I used socfpga_defconfig, MFD_SYSCON is enabled.
> > Which config do you use?
> >
>
> Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have
> fixed this error.
>
> commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
+CC Fengguang Wu, Dan Carpenter, Arnd Bergmann
I used exynos_defconfig, and enabled socfpga mmc driver through menuconfig.
Also, 'drivers/mmc/host/dw_mmc-socfpga.c' is used by ARCH_SOCFPGA.
However, even though other configs are used, it should not make build error
or link error.
Please look at other drivers using MFD_SYSCON.
i.mx config also selects MFD_SYSCON; however, it added MFD_SYSCON
dependency in order to prevent link error.
(./arch/arm/mach-imx/Kconfig)
786: config SOC_IMX6Q
804: select MFD_SYSCON
813: config SOC_IMX6SL
825: select MFD_SYSCON
(./drivers/regulator/Kconfig)
90: config REGULATOR_ANATOP
91: tristate "Freescale i.MX on-chip ANATOP LDO regulators"
92: depends on MFD_SYSCON
Best regards,
Jingoo Han
>
> Dinh
> > Best Regards,
> > Jaehoon Chung
> >
> > On 08/01/2013 09:28 AM, Jingoo Han wrote:
> > > Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
> > > the following link error.
> > >
> > > drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > > ---
> > > drivers/mmc/host/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > > index 8a4c066..84102bc 100644
> > > --- a/drivers/mmc/host/Kconfig
> > > +++ b/drivers/mmc/host/Kconfig
> > > @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
> > >
> > > config MMC_DW_SOCFPGA
> > > tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
> > > - depends on MMC_DW
> > > + depends on MMC_DW && MFD_SYSCON
> > > select MMC_DW_PLTFM
> > > help
> > > This selects support for Altera SoCFPGA specific extensions to the
> > >
> >
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-01 23:22 ` Jingoo Han
@ 2013-08-02 3:48 ` Jaehoon Chung
0 siblings, 0 replies; 7+ messages in thread
From: Jaehoon Chung @ 2013-08-02 3:48 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Dinh Nguyen', 'Jaehoon Chung',
'Chris Ball', linux-mmc, 'Seungwon Jeon',
'Fengguang Wu',
Dan Carpenter, Arnd Bergmann
Hi Jingoo,
I checked exynos_defconfig as your comment.
I also found the compiler error. thanks for your effort.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
On 08/02/2013 08:22 AM, Jingoo Han wrote:
> On Thursday, August 01, 2013 11:59 PM, Dinh Nguyen wrote:
>> On Thu, 2013-08-01 at 23:52 +0900, Jaehoon Chung wrote:
>>> When I used socfpga_defconfig, MFD_SYSCON is enabled.
>>> Which config do you use?
>>>
>>
>> Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have
>> fixed this error.
>>
>> commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
>
> +CC Fengguang Wu, Dan Carpenter, Arnd Bergmann
>
> I used exynos_defconfig, and enabled socfpga mmc driver through menuconfig.
> Also, 'drivers/mmc/host/dw_mmc-socfpga.c' is used by ARCH_SOCFPGA.
> However, even though other configs are used, it should not make build error
> or link error.
>
> Please look at other drivers using MFD_SYSCON.
> i.mx config also selects MFD_SYSCON; however, it added MFD_SYSCON
> dependency in order to prevent link error.
>
> (./arch/arm/mach-imx/Kconfig)
> 786: config SOC_IMX6Q
> 804: select MFD_SYSCON
>
> 813: config SOC_IMX6SL
> 825: select MFD_SYSCON
>
> (./drivers/regulator/Kconfig)
> 90: config REGULATOR_ANATOP
> 91: tristate "Freescale i.MX on-chip ANATOP LDO regulators"
> 92: depends on MFD_SYSCON
>
>
> Best regards,
> Jingoo Han
>
>>
>> Dinh
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>> On 08/01/2013 09:28 AM, Jingoo Han wrote:
>>>> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
>>>> the following link error.
>>>>
>>>> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
>>>>
>>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>>> ---
>>>> drivers/mmc/host/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>>> index 8a4c066..84102bc 100644
>>>> --- a/drivers/mmc/host/Kconfig
>>>> +++ b/drivers/mmc/host/Kconfig
>>>> @@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
>>>>
>>>> config MMC_DW_SOCFPGA
>>>> tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
>>>> - depends on MMC_DW
>>>> + depends on MMC_DW && MFD_SYSCON
>>>> select MMC_DW_PLTFM
>>>> help
>>>> This selects support for Altera SoCFPGA specific extensions to the
>>>>
>>>
>>>
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-01 0:28 [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA Jingoo Han
2013-08-01 14:52 ` Jaehoon Chung
@ 2013-08-09 13:31 ` Seungwon Jeon
2013-08-25 3:33 ` Chris Ball
1 sibling, 1 reply; 7+ messages in thread
From: Seungwon Jeon @ 2013-08-09 13:31 UTC (permalink / raw)
To: 'Jingoo Han', 'Chris Ball'
Cc: linux-mmc, 'Jaehoon Chung', 'Dinh Nguyen'
On Thu, August 01, 2013, Jingoo Han wrote:
> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
> the following link error.
>
> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA
2013-08-09 13:31 ` Seungwon Jeon
@ 2013-08-25 3:33 ` Chris Ball
0 siblings, 0 replies; 7+ messages in thread
From: Chris Ball @ 2013-08-25 3:33 UTC (permalink / raw)
To: Seungwon Jeon
Cc: 'Jingoo Han', linux-mmc, 'Jaehoon Chung',
'Dinh Nguyen'
Hi,
On Fri, Aug 09 2013, Seungwon Jeon wrote:
> On Thu, August 01, 2013, Jingoo Han wrote:
>> Added missing MFD_SYSCON dependency for SOCFPGA in order to fix
>> the following link error.
>>
>> drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to
>> syscon_regmap_lookup_by_compatible'
>>
>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-25 3:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-01 0:28 [PATCH] mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA Jingoo Han
2013-08-01 14:52 ` Jaehoon Chung
2013-08-01 14:59 ` Dinh Nguyen
2013-08-01 23:22 ` Jingoo Han
2013-08-02 3:48 ` Jaehoon Chung
2013-08-09 13:31 ` Seungwon Jeon
2013-08-25 3:33 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.