All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pwm: tiecap: add CONFIG_PM_SLEEP to ecap_pwm_{save,restore}_context()
@ 2013-08-02  6:11 Jingoo Han
  2013-08-14  9:46 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-02  6:11 UTC (permalink / raw)
  To: 'Thierry Reding'; +Cc: linux-pwm, Philip Avinash, 'Jingoo Han'

ecap_pwm_save_context() and ecap_pwm_restore_context() are only used
when CONFIG_PM_SLEEP is selected.

drivers/pwm/pwm-tiecap.c:293:13: warning: 'ecap_pwm_save_context' defined but not used [-Wunused-function]
drivers/pwm/pwm-tiecap.c:302:13: warning: 'ecap_pwm_restore_context' defined but not used [-Wunused-function]

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-tiecap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 72ca42d..c2e2e58 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -290,6 +290,7 @@ static int ecap_pwm_remove(struct platform_device *pdev)
 	return pwmchip_remove(&pc->chip);
 }
 
+#ifdef CONFIG_PM_SLEEP
 static void ecap_pwm_save_context(struct ecap_pwm_chip *pc)
 {
 	pm_runtime_get_sync(pc->chip.dev);
@@ -306,7 +307,6 @@ static void ecap_pwm_restore_context(struct ecap_pwm_chip *pc)
 	writew(pc->ctx.ecctl2, pc->mmio_base + ECCTL2);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int ecap_pwm_suspend(struct device *dev)
 {
 	struct ecap_pwm_chip *pc = dev_get_drvdata(dev);
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pwm: tiecap: add CONFIG_PM_SLEEP to ecap_pwm_{save,restore}_context()
  2013-08-02  6:11 [PATCH] pwm: tiecap: add CONFIG_PM_SLEEP to ecap_pwm_{save,restore}_context() Jingoo Han
@ 2013-08-14  9:46 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2013-08-14  9:46 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Thierry Reding', linux-pwm, Philip Avinash

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Fri, Aug 02, 2013 at 03:11:18PM +0900, Jingoo Han wrote:
> ecap_pwm_save_context() and ecap_pwm_restore_context() are only used
> when CONFIG_PM_SLEEP is selected.
> 
> drivers/pwm/pwm-tiecap.c:293:13: warning: 'ecap_pwm_save_context' defined but not used [-Wunused-function]
> drivers/pwm/pwm-tiecap.c:302:13: warning: 'ecap_pwm_restore_context' defined but not used [-Wunused-function]
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/pwm/pwm-tiecap.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-14  9:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-02  6:11 [PATCH] pwm: tiecap: add CONFIG_PM_SLEEP to ecap_pwm_{save,restore}_context() Jingoo Han
2013-08-14  9:46 ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.