All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: berlin: Use devm_ioremap_resource()
@ 2014-05-27  6:29 Jingoo Han
  2014-05-27  7:43 ` Antoine Ténart
  2014-05-27 14:03 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2014-05-27  6:29 UTC (permalink / raw)
  To: 'Linus Walleij'
  Cc: linux-kernel, 'Antoine Tenart',
	'Sebastian Hesselbarth', 'Jingoo Han'

Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pinctrl/berlin/berlin-bg2.c   |    6 +++---
 drivers/pinctrl/berlin/berlin-bg2cd.c |    6 +++---
 drivers/pinctrl/berlin/berlin-bg2q.c  |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/pinctrl/berlin/berlin-bg2.c b/drivers/pinctrl/berlin/berlin-bg2.c
index 0d8fd50..dcd4f6a 100644
--- a/drivers/pinctrl/berlin/berlin-bg2.c
+++ b/drivers/pinctrl/berlin/berlin-bg2.c
@@ -243,9 +243,9 @@ static int berlin2_pinctrl_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!base)
-		return -EADDRNOTAVAIL;
+	base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(base))
+		return PTR_ERR(base);
 
 	rmconfig->reg_bits = 32,
 	rmconfig->val_bits = 32,
diff --git a/drivers/pinctrl/berlin/berlin-bg2cd.c b/drivers/pinctrl/berlin/berlin-bg2cd.c
index e095a5d..89d585e 100644
--- a/drivers/pinctrl/berlin/berlin-bg2cd.c
+++ b/drivers/pinctrl/berlin/berlin-bg2cd.c
@@ -186,9 +186,9 @@ static int berlin2cd_pinctrl_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!base)
-		return -EADDRNOTAVAIL;
+	base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(base))
+		return PTR_ERR(base);
 
 	rmconfig->reg_bits = 32,
 	rmconfig->val_bits = 32,
diff --git a/drivers/pinctrl/berlin/berlin-bg2q.c b/drivers/pinctrl/berlin/berlin-bg2q.c
index ab33a3b..9fcf983 100644
--- a/drivers/pinctrl/berlin/berlin-bg2q.c
+++ b/drivers/pinctrl/berlin/berlin-bg2q.c
@@ -405,9 +405,9 @@ static int berlin2q_pinctrl_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!base)
-		return -EADDRNOTAVAIL;
+	base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(base))
+		return PTR_ERR(base);
 
 	rmconfig->reg_bits = 32,
 	rmconfig->val_bits = 32,
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: berlin: Use devm_ioremap_resource()
  2014-05-27  6:29 [PATCH] pinctrl: berlin: Use devm_ioremap_resource() Jingoo Han
@ 2014-05-27  7:43 ` Antoine Ténart
  2014-05-27 14:03 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Antoine Ténart @ 2014-05-27  7:43 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Linus Walleij', linux-kernel, 'Antoine Tenart',
	'Sebastian Hesselbarth'

On Tue, May 27, 2014 at 03:29:17PM +0900, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Antoine Ténart <antoine.tenart@free-electrons.com>


Thanks!

Antoine

> ---
>  drivers/pinctrl/berlin/berlin-bg2.c   |    6 +++---
>  drivers/pinctrl/berlin/berlin-bg2cd.c |    6 +++---
>  drivers/pinctrl/berlin/berlin-bg2q.c  |    6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pinctrl/berlin/berlin-bg2.c b/drivers/pinctrl/berlin/berlin-bg2.c
> index 0d8fd50..dcd4f6a 100644
> --- a/drivers/pinctrl/berlin/berlin-bg2.c
> +++ b/drivers/pinctrl/berlin/berlin-bg2.c
> @@ -243,9 +243,9 @@ static int berlin2_pinctrl_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base)
> -		return -EADDRNOTAVAIL;
> +	base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base))
> +		return PTR_ERR(base);
>  
>  	rmconfig->reg_bits = 32,
>  	rmconfig->val_bits = 32,
> diff --git a/drivers/pinctrl/berlin/berlin-bg2cd.c b/drivers/pinctrl/berlin/berlin-bg2cd.c
> index e095a5d..89d585e 100644
> --- a/drivers/pinctrl/berlin/berlin-bg2cd.c
> +++ b/drivers/pinctrl/berlin/berlin-bg2cd.c
> @@ -186,9 +186,9 @@ static int berlin2cd_pinctrl_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base)
> -		return -EADDRNOTAVAIL;
> +	base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base))
> +		return PTR_ERR(base);
>  
>  	rmconfig->reg_bits = 32,
>  	rmconfig->val_bits = 32,
> diff --git a/drivers/pinctrl/berlin/berlin-bg2q.c b/drivers/pinctrl/berlin/berlin-bg2q.c
> index ab33a3b..9fcf983 100644
> --- a/drivers/pinctrl/berlin/berlin-bg2q.c
> +++ b/drivers/pinctrl/berlin/berlin-bg2q.c
> @@ -405,9 +405,9 @@ static int berlin2q_pinctrl_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base)
> -		return -EADDRNOTAVAIL;
> +	base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base))
> +		return PTR_ERR(base);
>  
>  	rmconfig->reg_bits = 32,
>  	rmconfig->val_bits = 32,
> -- 
> 1.7.10.4
> 
> 

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: berlin: Use devm_ioremap_resource()
  2014-05-27  6:29 [PATCH] pinctrl: berlin: Use devm_ioremap_resource() Jingoo Han
  2014-05-27  7:43 ` Antoine Ténart
@ 2014-05-27 14:03 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-05-27 14:03 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-kernel, Antoine Tenart, Sebastian Hesselbarth

On Tue, May 27, 2014 at 8:29 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Patch applied with Antoine's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 14:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27  6:29 [PATCH] pinctrl: berlin: Use devm_ioremap_resource() Jingoo Han
2014-05-27  7:43 ` Antoine Ténart
2014-05-27 14:03 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.