All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH ] android/socket: Add PBAP supported features bits
@ 2014-12-09 12:51 Gowtham Anandha Babu
  2014-12-09 12:51 ` [PATCH ] android/socket: Add MAP " Gowtham Anandha Babu
  2014-12-09 13:24 ` [PATCH ] android/socket: Add PBAP " Szymon Janc
  0 siblings, 2 replies; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-09 12:51 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: d.kasatkin, bharat.panda, cpgs, Gowtham Anandha Babu

Add PBAP supported features in sdp record.
---
 android/socket.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/android/socket.c b/android/socket.c
index 2b836e9..f2cfd07 100644
--- a/android/socket.c
+++ b/android/socket.c
@@ -58,6 +58,8 @@
 /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
 #define DEFAULT_MAS_INSTANCE	0x00
 
+#define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
+
 #define MAP_MSG_TYPE_SMS_GSM	0x02
 #define MAP_MSG_TYPE_SMS_CDMA	0x04
 #define DEFAULT_MAS_MSG_TYPE	(MAP_MSG_TYPE_SMS_GSM | MAP_MSG_TYPE_SMS_CDMA)
@@ -287,6 +289,7 @@ static sdp_record_t *create_pbap_record(uint8_t chan, const char *svc_name)
 	sdp_list_t *seq;
 	sdp_profile_desc_t profile[1];
 	uint8_t formats = 0x01;
+	uint8_t supft = DEFAULT_PBAP_SUPPORTED_FEATURES;
 	sdp_record_t *record;
 	uuid_t uuid;
 
@@ -304,6 +307,9 @@ static sdp_record_t *create_pbap_record(uint8_t chan, const char *svc_name)
 	sdp_attr_add_new(record, SDP_ATTR_SUPPORTED_REPOSITORIES, SDP_UINT8,
 								&formats);
 
+	sdp_attr_add_new(record, SDP_ATTR_PBAP_SUPPORTED_FEATURES, SDP_UINT32,
+								&supft);
+
 	sdp_list_free(seq, NULL);
 
 	return record;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH ] android/socket: Add MAP supported features bits
  2014-12-09 12:51 [PATCH ] android/socket: Add PBAP supported features bits Gowtham Anandha Babu
@ 2014-12-09 12:51 ` Gowtham Anandha Babu
  2014-12-10  7:27   ` Luiz Augusto von Dentz
  2014-12-09 13:24 ` [PATCH ] android/socket: Add PBAP " Szymon Janc
  1 sibling, 1 reply; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-09 12:51 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: d.kasatkin, bharat.panda, cpgs, Gowtham Anandha Babu

Add MAP supported features in sdp record.
---
 android/socket.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/android/socket.c b/android/socket.c
index f2cfd07..d89c8c2 100644
--- a/android/socket.c
+++ b/android/socket.c
@@ -58,6 +58,7 @@
 /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
 #define DEFAULT_MAS_INSTANCE	0x00
 
+#define DEFAULT_MAP_SUPPORTED_FEATURES 0x0000001f
 #define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
 
 #define MAP_MSG_TYPE_SMS_GSM	0x02
@@ -321,6 +322,7 @@ static sdp_record_t *create_mas_record(uint8_t chan, const char *svc_name)
 	sdp_profile_desc_t profile[1];
 	uint8_t minst = DEFAULT_MAS_INSTANCE;
 	uint8_t mtype = DEFAULT_MAS_MSG_TYPE;
+	uint8_t supft = DEFAULT_MAP_SUPPORTED_FEATURES;
 	sdp_record_t *record;
 	uuid_t uuid;
 
@@ -339,6 +341,9 @@ static sdp_record_t *create_mas_record(uint8_t chan, const char *svc_name)
 	sdp_attr_add_new(record, SDP_ATTR_SUPPORTED_MESSAGE_TYPES, SDP_UINT8,
 									&mtype);
 
+	sdp_attr_add_new(record, SDP_ATTR_MAP_SUPPORTED_FEATURES, SDP_UINT32,
+									&supft);
+
 	sdp_list_free(seq, NULL);
 
 	return record;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH ] android/socket: Add PBAP supported features bits
  2014-12-09 12:51 [PATCH ] android/socket: Add PBAP supported features bits Gowtham Anandha Babu
  2014-12-09 12:51 ` [PATCH ] android/socket: Add MAP " Gowtham Anandha Babu
@ 2014-12-09 13:24 ` Szymon Janc
  2014-12-09 13:46   ` Gowtham Anandha Babu
  1 sibling, 1 reply; 10+ messages in thread
From: Szymon Janc @ 2014-12-09 13:24 UTC (permalink / raw)
  To: Gowtham Anandha Babu; +Cc: linux-bluetooth, d.kasatkin, bharat.panda, cpgs

Hi Gowtham,

On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu wrote:
> Add PBAP supported features in sdp record.

Isn't that a 1.2 feature? (AOSP supports only 1.1).

Same goes with MAP.

> ---
>  android/socket.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/android/socket.c b/android/socket.c
> index 2b836e9..f2cfd07 100644
> --- a/android/socket.c
> +++ b/android/socket.c
> @@ -58,6 +58,8 @@
>  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
>  #define DEFAULT_MAS_INSTANCE	0x00
> 
> +#define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
> +
>  #define MAP_MSG_TYPE_SMS_GSM	0x02
>  #define MAP_MSG_TYPE_SMS_CDMA	0x04
>  #define DEFAULT_MAS_MSG_TYPE	(MAP_MSG_TYPE_SMS_GSM | MAP_MSG_TYPE_SMS_CDMA)
> @@ -287,6 +289,7 @@ static sdp_record_t *create_pbap_record(uint8_t chan,
> const char *svc_name) sdp_list_t *seq;
>  	sdp_profile_desc_t profile[1];
>  	uint8_t formats = 0x01;
> +	uint8_t supft = DEFAULT_PBAP_SUPPORTED_FEATURES;
>  	sdp_record_t *record;
>  	uuid_t uuid;
> 
> @@ -304,6 +307,9 @@ static sdp_record_t *create_pbap_record(uint8_t chan,
> const char *svc_name) sdp_attr_add_new(record,
> SDP_ATTR_SUPPORTED_REPOSITORIES, SDP_UINT8, &formats);
> 
> +	sdp_attr_add_new(record, SDP_ATTR_PBAP_SUPPORTED_FEATURES, SDP_UINT32,
> +								&supft);
> +
>  	sdp_list_free(seq, NULL);
> 
>  	return record;

-- 
BR
Szymon Janc

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH ] android/socket: Add PBAP supported features bits
  2014-12-09 13:24 ` [PATCH ] android/socket: Add PBAP " Szymon Janc
@ 2014-12-09 13:46   ` Gowtham Anandha Babu
  2014-12-10  8:44     ` Szymon Janc
  0 siblings, 1 reply; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-09 13:46 UTC (permalink / raw)
  To: 'Szymon Janc'; +Cc: linux-bluetooth, d.kasatkin, bharat.panda, cpgs

Hi Szymon,

> -----Original Message-----
> From: Szymon Janc [mailto:szymon.janc@tieto.com]
> Sent: Tuesday, December 09, 2014 6:54 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; d.kasatkin@samsung.com;
> bharat.panda@samsung.com; cpgs@samsung.com
> Subject: Re: [PATCH ] android/socket: Add PBAP supported features bits
> 
> Hi Gowtham,
> 
> On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu wrote:
> > Add PBAP supported features in sdp record.
> 
> Isn't that a 1.2 feature? (AOSP supports only 1.1).

Yes, this one is 1.2 feature. Then, I have to wait till 1.2 release.
Btw, Right now in android, 
Server (PBAP-PSE and MAP-MAS) records are getting added.
What happened to client(PBAP-PCE and MAP-MNS) records?
Will it be added only after implementing them?
Am I right?

> 
> Same goes with MAP.
> 
> > ---
> >  android/socket.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/android/socket.c b/android/socket.c index
> > 2b836e9..f2cfd07 100644
> > --- a/android/socket.c
> > +++ b/android/socket.c
> > @@ -58,6 +58,8 @@
> >  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
> >  #define DEFAULT_MAS_INSTANCE	0x00
> >
> > +#define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
> > +
> >  #define MAP_MSG_TYPE_SMS_GSM	0x02
> >  #define MAP_MSG_TYPE_SMS_CDMA	0x04
> >  #define DEFAULT_MAS_MSG_TYPE	(MAP_MSG_TYPE_SMS_GSM |
> MAP_MSG_TYPE_SMS_CDMA)
> > @@ -287,6 +289,7 @@ static sdp_record_t *create_pbap_record(uint8_t
> > chan, const char *svc_name) sdp_list_t *seq;
> >  	sdp_profile_desc_t profile[1];
> >  	uint8_t formats = 0x01;
> > +	uint8_t supft = DEFAULT_PBAP_SUPPORTED_FEATURES;
> >  	sdp_record_t *record;
> >  	uuid_t uuid;
> >
> > @@ -304,6 +307,9 @@ static sdp_record_t *create_pbap_record(uint8_t
> > chan, const char *svc_name) sdp_attr_add_new(record,
> > SDP_ATTR_SUPPORTED_REPOSITORIES, SDP_UINT8, &formats);
> >
> > +	sdp_attr_add_new(record,
> SDP_ATTR_PBAP_SUPPORTED_FEATURES, SDP_UINT32,
> > +								&supft);
> > +
> >  	sdp_list_free(seq, NULL);
> >
> >  	return record;
> 
> --
> BR
> Szymon Janc


Regards,
Gowtham Anandha Babu


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH ] android/socket: Add MAP supported features bits
  2014-12-09 12:51 ` [PATCH ] android/socket: Add MAP " Gowtham Anandha Babu
@ 2014-12-10  7:27   ` Luiz Augusto von Dentz
  2014-12-10  8:36     ` Gowtham Anandha Babu
  0 siblings, 1 reply; 10+ messages in thread
From: Luiz Augusto von Dentz @ 2014-12-10  7:27 UTC (permalink / raw)
  To: Gowtham Anandha Babu; +Cc: linux-bluetooth, Dmitry Kasatkin, Bharat Panda, cpgs

Hi Gowtham,

On Tue, Dec 9, 2014 at 2:51 PM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Add MAP supported features in sdp record.
> ---
>  android/socket.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/android/socket.c b/android/socket.c
> index f2cfd07..d89c8c2 100644
> --- a/android/socket.c
> +++ b/android/socket.c
> @@ -58,6 +58,7 @@
>  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
>  #define DEFAULT_MAS_INSTANCE   0x00
>
> +#define DEFAULT_MAP_SUPPORTED_FEATURES 0x0000001f
>  #define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
>
>  #define MAP_MSG_TYPE_SMS_GSM   0x02
> @@ -321,6 +322,7 @@ static sdp_record_t *create_mas_record(uint8_t chan, const char *svc_name)
>         sdp_profile_desc_t profile[1];
>         uint8_t minst = DEFAULT_MAS_INSTANCE;
>         uint8_t mtype = DEFAULT_MAS_MSG_TYPE;
> +       uint8_t supft = DEFAULT_MAP_SUPPORTED_FEATURES;
>         sdp_record_t *record;
>         uuid_t uuid;
>
> @@ -339,6 +341,9 @@ static sdp_record_t *create_mas_record(uint8_t chan, const char *svc_name)
>         sdp_attr_add_new(record, SDP_ATTR_SUPPORTED_MESSAGE_TYPES, SDP_UINT8,
>                                                                         &mtype);
>
> +       sdp_attr_add_new(record, SDP_ATTR_MAP_SUPPORTED_FEATURES, SDP_UINT32,
> +                                                                       &supft);
> +
>         sdp_list_free(seq, NULL);
>
>         return record;
> --
> 1.9.1

I recall supported features being introduced in 1.2, in that case it
is probably not required to add it to the record since Android only
support 1.1.


-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH ] android/socket: Add MAP supported features bits
  2014-12-10  7:27   ` Luiz Augusto von Dentz
@ 2014-12-10  8:36     ` Gowtham Anandha Babu
  2014-12-10  8:42       ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-10  8:36 UTC (permalink / raw)
  To: 'Luiz Augusto von Dentz'
  Cc: linux-bluetooth, 'Dmitry Kasatkin', 'Bharat Panda', cpgs

Hi Luiz,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> Sent: Wednesday, December 10, 2014 12:58 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> cpgs@samsung.com
> Subject: Re: [PATCH ] android/socket: Add MAP supported features bits
> 
> Hi Gowtham,
> 
> On Tue, Dec 9, 2014 at 2:51 PM, Gowtham Anandha Babu
> <gowtham.ab@samsung.com> wrote:
> > Add MAP supported features in sdp record.
> > ---
> >  android/socket.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/android/socket.c b/android/socket.c index
> > f2cfd07..d89c8c2 100644
> > --- a/android/socket.c
> > +++ b/android/socket.c
> > @@ -58,6 +58,7 @@
> >  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
> >  #define DEFAULT_MAS_INSTANCE   0x00
> >
> > +#define DEFAULT_MAP_SUPPORTED_FEATURES 0x0000001f
> >  #define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
> >
> >  #define MAP_MSG_TYPE_SMS_GSM   0x02
> > @@ -321,6 +322,7 @@ static sdp_record_t *create_mas_record(uint8_t
> chan, const char *svc_name)
> >         sdp_profile_desc_t profile[1];
> >         uint8_t minst = DEFAULT_MAS_INSTANCE;
> >         uint8_t mtype = DEFAULT_MAS_MSG_TYPE;
> > +       uint8_t supft = DEFAULT_MAP_SUPPORTED_FEATURES;
> >         sdp_record_t *record;
> >         uuid_t uuid;
> >
> > @@ -339,6 +341,9 @@ static sdp_record_t *create_mas_record(uint8_t
> chan, const char *svc_name)
> >         sdp_attr_add_new(record, SDP_ATTR_SUPPORTED_MESSAGE_TYPES,
> SDP_UINT8,
> >
> > &mtype);
> >
> > +       sdp_attr_add_new(record, SDP_ATTR_MAP_SUPPORTED_FEATURES,
> SDP_UINT32,
> > +
> > + &supft);
> > +
> >         sdp_list_free(seq, NULL);
> >
> >         return record;
> > --
> > 1.9.1
> 
> I recall supported features being introduced in 1.2, in that case it is probably
> not required to add it to the record since Android only support 1.1.
> 

Yes, this one is 1.2 feature. Then, I have to wait till 1.2 implementation.
Btw, Right now in android,
Server (PBAP-PSE and MAP-MAS) records are added to SDP.
What happened to client(PBAP-PCE and MAP-MNS) records?
Will it be added only after implementing them?

> 
> --
> Luiz Augusto von Dentz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html


Regards,
Gowtham Anandha Babu


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH ] android/socket: Add MAP supported features bits
  2014-12-10  8:36     ` Gowtham Anandha Babu
@ 2014-12-10  8:42       ` Luiz Augusto von Dentz
  2014-12-10  8:47         ` Gowtham Anandha Babu
  0 siblings, 1 reply; 10+ messages in thread
From: Luiz Augusto von Dentz @ 2014-12-10  8:42 UTC (permalink / raw)
  To: Gowtham Anandha Babu; +Cc: linux-bluetooth, Dmitry Kasatkin, Bharat Panda, cpgs

Hi Gowtham,

On Wed, Dec 10, 2014 at 10:36 AM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Hi Luiz,
>
>> -----Original Message-----
>> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
>> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
>> Sent: Wednesday, December 10, 2014 12:58 PM
>> To: Gowtham Anandha Babu
>> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
>> cpgs@samsung.com
>> Subject: Re: [PATCH ] android/socket: Add MAP supported features bits
>>
>> Hi Gowtham,
>>
>> On Tue, Dec 9, 2014 at 2:51 PM, Gowtham Anandha Babu
>> <gowtham.ab@samsung.com> wrote:
>> > Add MAP supported features in sdp record.
>> > ---
>> >  android/socket.c | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/android/socket.c b/android/socket.c index
>> > f2cfd07..d89c8c2 100644
>> > --- a/android/socket.c
>> > +++ b/android/socket.c
>> > @@ -58,6 +58,7 @@
>> >  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
>> >  #define DEFAULT_MAS_INSTANCE   0x00
>> >
>> > +#define DEFAULT_MAP_SUPPORTED_FEATURES 0x0000001f
>> >  #define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
>> >
>> >  #define MAP_MSG_TYPE_SMS_GSM   0x02
>> > @@ -321,6 +322,7 @@ static sdp_record_t *create_mas_record(uint8_t
>> chan, const char *svc_name)
>> >         sdp_profile_desc_t profile[1];
>> >         uint8_t minst = DEFAULT_MAS_INSTANCE;
>> >         uint8_t mtype = DEFAULT_MAS_MSG_TYPE;
>> > +       uint8_t supft = DEFAULT_MAP_SUPPORTED_FEATURES;
>> >         sdp_record_t *record;
>> >         uuid_t uuid;
>> >
>> > @@ -339,6 +341,9 @@ static sdp_record_t *create_mas_record(uint8_t
>> chan, const char *svc_name)
>> >         sdp_attr_add_new(record, SDP_ATTR_SUPPORTED_MESSAGE_TYPES,
>> SDP_UINT8,
>> >
>> > &mtype);
>> >
>> > +       sdp_attr_add_new(record, SDP_ATTR_MAP_SUPPORTED_FEATURES,
>> SDP_UINT32,
>> > +
>> > + &supft);
>> > +
>> >         sdp_list_free(seq, NULL);
>> >
>> >         return record;
>> > --
>> > 1.9.1
>>
>> I recall supported features being introduced in 1.2, in that case it is probably
>> not required to add it to the record since Android only support 1.1.
>>
>
> Yes, this one is 1.2 feature. Then, I have to wait till 1.2 implementation.
> Btw, Right now in android,
> Server (PBAP-PSE and MAP-MAS) records are added to SDP.
> What happened to client(PBAP-PCE and MAP-MNS) records?
> Will it be added only after implementing them?

They don't seem to be supported by Android HAL, so we have to wait
Google enable them in the upper layer.


-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH ] android/socket: Add PBAP supported features bits
  2014-12-09 13:46   ` Gowtham Anandha Babu
@ 2014-12-10  8:44     ` Szymon Janc
  2014-12-10  8:51       ` Gowtham Anandha Babu
  0 siblings, 1 reply; 10+ messages in thread
From: Szymon Janc @ 2014-12-10  8:44 UTC (permalink / raw)
  To: Gowtham Anandha Babu; +Cc: linux-bluetooth, d.kasatkin, bharat.panda, cpgs

Hi Gowtham,

On Tuesday 09 of December 2014 19:16:58 Gowtham Anandha Babu wrote:
> Hi Szymon,
> 
> > -----Original Message-----
> > From: Szymon Janc [mailto:szymon.janc@tieto.com]
> > Sent: Tuesday, December 09, 2014 6:54 PM
> > To: Gowtham Anandha Babu
> > Cc: linux-bluetooth@vger.kernel.org; d.kasatkin@samsung.com;
> > bharat.panda@samsung.com; cpgs@samsung.com
> > Subject: Re: [PATCH ] android/socket: Add PBAP supported features bits
> > 
> > Hi Gowtham,
> > 
> > On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu wrote:
> > > Add PBAP supported features in sdp record.
> > 
> > Isn't that a 1.2 feature? (AOSP supports only 1.1).
> 
> Yes, this one is 1.2 feature. Then, I have to wait till 1.2 release.
> Btw, Right now in android,
> Server (PBAP-PSE and MAP-MAS) records are getting added.
> What happened to client(PBAP-PCE and MAP-MNS) records?
> Will it be added only after implementing them?
> Am I right?

I'm not sure if we really need PBAP client SDP record. Since there is no 
listening socket we wouldn't know when/if we should add it.

For MAP-MNS, that depends on what application implementing MAP client would 
support. Since AOSP doesn't provide such application and HAL and java API 
indicates no support for it I'd leave it until this gets clarified.

-- 
BR
Szymon Janc

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH ] android/socket: Add MAP supported features bits
  2014-12-10  8:42       ` Luiz Augusto von Dentz
@ 2014-12-10  8:47         ` Gowtham Anandha Babu
  0 siblings, 0 replies; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-10  8:47 UTC (permalink / raw)
  To: 'Luiz Augusto von Dentz'
  Cc: linux-bluetooth, 'Dmitry Kasatkin', 'Bharat Panda', cpgs

Hi Luiz,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> Sent: Wednesday, December 10, 2014 2:13 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> cpgs@samsung.com
> Subject: Re: [PATCH ] android/socket: Add MAP supported features bits
> 
> Hi Gowtham,
> 
> On Wed, Dec 10, 2014 at 10:36 AM, Gowtham Anandha Babu
> <gowtham.ab@samsung.com> wrote:
> > Hi Luiz,
> >
> >> -----Original Message-----
> >> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> >> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> >> Sent: Wednesday, December 10, 2014 12:58 PM
> >> To: Gowtham Anandha Babu
> >> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> >> cpgs@samsung.com
> >> Subject: Re: [PATCH ] android/socket: Add MAP supported features bits
> >>
> >> Hi Gowtham,
> >>
> >> On Tue, Dec 9, 2014 at 2:51 PM, Gowtham Anandha Babu
> >> <gowtham.ab@samsung.com> wrote:
> >> > Add MAP supported features in sdp record.
> >> > ---
> >> >  android/socket.c | 5 +++++
> >> >  1 file changed, 5 insertions(+)
> >> >
> >> > diff --git a/android/socket.c b/android/socket.c index
> >> > f2cfd07..d89c8c2 100644
> >> > --- a/android/socket.c
> >> > +++ b/android/socket.c
> >> > @@ -58,6 +58,7 @@
> >> >  /* Hardcoded MAP stuff needed for MAS SMS Instance.*/
> >> >  #define DEFAULT_MAS_INSTANCE   0x00
> >> >
> >> > +#define DEFAULT_MAP_SUPPORTED_FEATURES 0x0000001f
> >> >  #define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003
> >> >
> >> >  #define MAP_MSG_TYPE_SMS_GSM   0x02
> >> > @@ -321,6 +322,7 @@ static sdp_record_t *create_mas_record(uint8_t
> >> chan, const char *svc_name)
> >> >         sdp_profile_desc_t profile[1];
> >> >         uint8_t minst = DEFAULT_MAS_INSTANCE;
> >> >         uint8_t mtype = DEFAULT_MAS_MSG_TYPE;
> >> > +       uint8_t supft = DEFAULT_MAP_SUPPORTED_FEATURES;
> >> >         sdp_record_t *record;
> >> >         uuid_t uuid;
> >> >
> >> > @@ -339,6 +341,9 @@ static sdp_record_t *create_mas_record(uint8_t
> >> chan, const char *svc_name)
> >> >         sdp_attr_add_new(record,
> SDP_ATTR_SUPPORTED_MESSAGE_TYPES,
> >> SDP_UINT8,
> >> >
> >> > &mtype);
> >> >
> >> > +       sdp_attr_add_new(record,
> SDP_ATTR_MAP_SUPPORTED_FEATURES,
> >> SDP_UINT32,
> >> > +
> >> > + &supft);
> >> > +
> >> >         sdp_list_free(seq, NULL);
> >> >
> >> >         return record;
> >> > --
> >> > 1.9.1
> >>
> >> I recall supported features being introduced in 1.2, in that case it
> >> is probably not required to add it to the record since Android only support
> 1.1.
> >>
> >
> > Yes, this one is 1.2 feature. Then, I have to wait till 1.2 implementation.
> > Btw, Right now in android,
> > Server (PBAP-PSE and MAP-MAS) records are added to SDP.
> > What happened to client(PBAP-PCE and MAP-MNS) records?
> > Will it be added only after implementing them?
> 
> They don't seem to be supported by Android HAL, so we have to wait Google
> enable them in the upper layer.
> 
> 

Okay. Thanks for you information. 

> --
> Luiz Augusto von Dentz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html


Regards,
Gowtham Anandha Babu


^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH ] android/socket: Add PBAP supported features bits
  2014-12-10  8:44     ` Szymon Janc
@ 2014-12-10  8:51       ` Gowtham Anandha Babu
  0 siblings, 0 replies; 10+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-10  8:51 UTC (permalink / raw)
  To: 'Szymon Janc'; +Cc: linux-bluetooth, d.kasatkin, bharat.panda, cpgs

Hi Szymon,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Szymon Janc
> Sent: Wednesday, December 10, 2014 2:15 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; d.kasatkin@samsung.com;
> bharat.panda@samsung.com; cpgs@samsung.com
> Subject: Re: [PATCH ] android/socket: Add PBAP supported features bits
> 
> Hi Gowtham,
> 
> On Tuesday 09 of December 2014 19:16:58 Gowtham Anandha Babu wrote:
> > Hi Szymon,
> >
> > > -----Original Message-----
> > > From: Szymon Janc [mailto:szymon.janc@tieto.com]
> > > Sent: Tuesday, December 09, 2014 6:54 PM
> > > To: Gowtham Anandha Babu
> > > Cc: linux-bluetooth@vger.kernel.org; d.kasatkin@samsung.com;
> > > bharat.panda@samsung.com; cpgs@samsung.com
> > > Subject: Re: [PATCH ] android/socket: Add PBAP supported features
> > > bits
> > >
> > > Hi Gowtham,
> > >
> > > On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu
> wrote:
> > > > Add PBAP supported features in sdp record.
> > >
> > > Isn't that a 1.2 feature? (AOSP supports only 1.1).
> >
> > Yes, this one is 1.2 feature. Then, I have to wait till 1.2 release.
> > Btw, Right now in android,
> > Server (PBAP-PSE and MAP-MAS) records are getting added.
> > What happened to client(PBAP-PCE and MAP-MNS) records?
> > Will it be added only after implementing them?
> > Am I right?
> 
> I'm not sure if we really need PBAP client SDP record. Since there is no
> listening socket we wouldn't know when/if we should add it.
> 
> For MAP-MNS, that depends on what application implementing MAP client
> would support. Since AOSP doesn't provide such application and HAL and
> java API indicates no support for it I'd leave it until this gets
clarified.
> 

I am new to Android and exploring it, anyway thanks for your information.

> --
> BR
> Szymon Janc
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html


Regards,
Gowtham Anandha Babu


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-12-10  8:51 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-09 12:51 [PATCH ] android/socket: Add PBAP supported features bits Gowtham Anandha Babu
2014-12-09 12:51 ` [PATCH ] android/socket: Add MAP " Gowtham Anandha Babu
2014-12-10  7:27   ` Luiz Augusto von Dentz
2014-12-10  8:36     ` Gowtham Anandha Babu
2014-12-10  8:42       ` Luiz Augusto von Dentz
2014-12-10  8:47         ` Gowtham Anandha Babu
2014-12-09 13:24 ` [PATCH ] android/socket: Add PBAP " Szymon Janc
2014-12-09 13:46   ` Gowtham Anandha Babu
2014-12-10  8:44     ` Szymon Janc
2014-12-10  8:51       ` Gowtham Anandha Babu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.