[smfrench-smb3-kernel:cifsd-for-next 4/72] fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type bool

[smfrench-smb3-kernel:cifsd-for-next 4/72] fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type bool

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

tree:   git://github.com/smfrench/smb3-kernel.git cifsd-for-next
head:   bcd62a368314deeea8bd0823399b649a236b7d5b
commit: a848c4f15ab6d5d405dbee7de5da71839b2bf35e [4/72] cifsd: add Kconfig and Makefile
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type bool
--
>> fs/cifsd/smb2pdu.c:1744:27-41: duplicated argument to & or |

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65630 bytes --]

[PATCH] cifsd: fix boolreturn.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

From: kernel test robot <lkp@intel.com>

fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: a848c4f15ab6 ("cifsd: add Kconfig and Makefile")
CC: Namjae Jeon <namjae.jeon@samsung.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://github.com/smfrench/smb3-kernel.git cifsd-for-next
head:   bcd62a368314deeea8bd0823399b649a236b7d5b
commit: a848c4f15ab6d5d405dbee7de5da71839b2bf35e [4/72] cifsd: add Kconfig and Makefile
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago

 smb2pdu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/cifsd/smb2pdu.c
+++ b/fs/cifsd/smb2pdu.c
@@ -8095,7 +8095,7 @@ bool smb2_is_sign_req(struct ksmbd_work
 			command != SMB2_OPLOCK_BREAK_HE)
 		return true;
 
-	return 0;
+	return false;
 }
 
 /**

Re: [PATCH] cifsd: fix boolreturn.cocci warnings

[Namjae Jeon]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

> From: kernel test robot <lkp@intel.com>
I will apply, Thanks for your patch!

> 
> fs/cifsd/smb2pdu.c:8098:8-9: WARNING: return of 0/1 in function 'smb2_is_sign_req' with return type
> bool
> 
>  Return statements in functions returning bool should use  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: a848c4f15ab6 ("cifsd: add Kconfig and Makefile")
> CC: Namjae Jeon <namjae.jeon@samsung.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   git://github.com/smfrench/smb3-kernel.git cifsd-for-next
> head:   bcd62a368314deeea8bd0823399b649a236b7d5b
> commit: a848c4f15ab6d5d405dbee7de5da71839b2bf35e [4/72] cifsd: add Kconfig and Makefile
> :::::: branch date: 13 hours ago
> :::::: commit date: 13 hours ago
> 
>  smb2pdu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/cifsd/smb2pdu.c
> +++ b/fs/cifsd/smb2pdu.c
> @@ -8095,7 +8095,7 @@ bool smb2_is_sign_req(struct ksmbd_work
>  			command != SMB2_OPLOCK_BREAK_HE)
>  		return true;
> 
> -	return 0;
> +	return false;
>  }
> 
>  /**