* [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
@ 2016-11-02 7:44 zhanghailiang
2016-11-02 14:04 ` Eric Blake
0 siblings, 1 reply; 12+ messages in thread
From: zhanghailiang @ 2016-11-02 7:44 UTC (permalink / raw)
To: eblake, armbru; +Cc: qemu-devel, qemu-trivial, zhanghailiang
VM can not get into colo state unless users enable 'x-colo'
capability for migration, Here it is necessary to clarify
this.
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
v2:
- Clarify colo state for RunState too as Eric suggested.
---
qapi-schema.json | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 5dc96af..04f5aab 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -176,8 +176,9 @@
#
# @guest-panicked: guest has been panicked as a result of guest OS panic
#
-# @colo: guest is paused to save/restore VM state under colo checkpoint (since
-# 2.8)
+# @colo: guest is paused to save/restore VM state under colo checkpoint,
+# VM can not get into this state unless colo capability is enabled
+# for migration. (since 2.8)
##
{ 'enum': 'RunState',
'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
@@ -462,7 +463,8 @@
#
# @failed: some error occurred during migration process.
#
-# @colo: VM is in the process of fault tolerance. (since 2.8)
+# @colo: VM is in the process of fault tolerance, VM can not get into this
+# state unless colo capability is enabled for migration. (since 2.8)
#
# Since: 2.3
#
--
1.8.3.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-02 7:44 [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
@ 2016-11-02 14:04 ` Eric Blake
2016-11-14 2:36 ` Hailiang Zhang
0 siblings, 1 reply; 12+ messages in thread
From: Eric Blake @ 2016-11-02 14:04 UTC (permalink / raw)
To: zhanghailiang, armbru; +Cc: qemu-devel, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On 11/02/2016 02:44 AM, zhanghailiang wrote:
> VM can not get into colo state unless users enable 'x-colo'
> capability for migration, Here it is necessary to clarify
> this.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> v2:
> - Clarify colo state for RunState too as Eric suggested.
> ---
> qapi-schema.json | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-02 14:04 ` Eric Blake
@ 2016-11-14 2:36 ` Hailiang Zhang
2016-11-14 13:54 ` Stefan Hajnoczi
0 siblings, 1 reply; 12+ messages in thread
From: Hailiang Zhang @ 2016-11-14 2:36 UTC (permalink / raw)
To: Eric Blake, armbru; +Cc: qemu-devel, qemu-trivial
ping ?
Anyone pick this up?
On 2016/11/2 22:04, Eric Blake wrote:
> On 11/02/2016 02:44 AM, zhanghailiang wrote:
>> VM can not get into colo state unless users enable 'x-colo'
>> capability for migration, Here it is necessary to clarify
>> this.
>>
>> Suggested-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> ---
>> v2:
>> - Clarify colo state for RunState too as Eric suggested.
>> ---
>> qapi-schema.json | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-14 2:36 ` Hailiang Zhang
@ 2016-11-14 13:54 ` Stefan Hajnoczi
2016-11-15 6:12 ` Hailiang Zhang
2016-11-15 8:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 2 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-11-14 13:54 UTC (permalink / raw)
To: Hailiang Zhang
Cc: Eric Blake, armbru, qemu-trivial, qemu-devel, Amit Shah, dgilbert
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
> ping ?
>
> Anyone pick this up?
The original patch that added these lines went through Amit Shah and
David Gilbert. I have CCed them.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-14 13:54 ` Stefan Hajnoczi
@ 2016-11-15 6:12 ` Hailiang Zhang
2016-11-15 8:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 12+ messages in thread
From: Hailiang Zhang @ 2016-11-15 6:12 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Eric Blake, armbru, qemu-trivial, qemu-devel, Amit Shah, dgilbert
On 2016/11/14 21:54, Stefan Hajnoczi wrote:
> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>> ping ?
>>
>> Anyone pick this up?
>
> The original patch that added these lines went through Amit Shah and
> David Gilbert. I have CCed them.
>
Great, thanks :)
> Stefan
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-14 13:54 ` Stefan Hajnoczi
2016-11-15 6:12 ` Hailiang Zhang
@ 2016-11-15 8:44 ` Laurent Vivier
2016-11-15 8:58 ` Zhang Chen
2016-11-17 7:08 ` Hailiang Zhang
1 sibling, 2 replies; 12+ messages in thread
From: Laurent Vivier @ 2016-11-15 8:44 UTC (permalink / raw)
To: Stefan Hajnoczi, Hailiang Zhang
Cc: qemu-devel, qemu-trivial, armbru, dgilbert, Amit Shah, Eric Blake
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>> ping ?
>>
>> Anyone pick this up?
>
> The original patch that added these lines went through Amit Shah and
> David Gilbert. I have CCed them.
If it is needed, I can also send a pull request through my
trivial-patches branch.
Laurent
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-15 8:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2016-11-15 8:58 ` Zhang Chen
2016-11-15 9:03 ` Hailiang Zhang
2016-11-17 7:08 ` Hailiang Zhang
1 sibling, 1 reply; 12+ messages in thread
From: Zhang Chen @ 2016-11-15 8:58 UTC (permalink / raw)
To: Laurent Vivier, Stefan Hajnoczi, Hailiang Zhang
Cc: qemu-trivial, armbru, qemu-devel, dgilbert, Amit Shah
On 11/15/2016 04:44 PM, Laurent Vivier wrote:
> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>> ping ?
>>>
>>> Anyone pick this up?
>> The original patch that added these lines went through Amit Shah and
>> David Gilbert. I have CCed them.
> If it is needed, I can also send a pull request through my
> trivial-patches branch.
>
> Laurent
The pull request for this patch has been sent by Jason.
Thanks for your attention, and thank Stefan.
Zhang Chen
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-15 8:58 ` Zhang Chen
@ 2016-11-15 9:03 ` Hailiang Zhang
2016-11-15 9:10 ` Zhang Chen
0 siblings, 1 reply; 12+ messages in thread
From: Hailiang Zhang @ 2016-11-15 9:03 UTC (permalink / raw)
To: Zhang Chen, Laurent Vivier, Stefan Hajnoczi
Cc: qemu-trivial, armbru, qemu-devel, dgilbert, Amit Shah
On 2016/11/15 16:58, Zhang Chen wrote:
>
>
> On 11/15/2016 04:44 PM, Laurent Vivier wrote:
>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>> ping ?
>>>>
>>>> Anyone pick this up?
>>> The original patch that added these lines went through Amit Shah and
>>> David Gilbert. I have CCed them.
>> If it is needed, I can also send a pull request through my
>> trivial-patches branch.
>>
>> Laurent
>
> The pull request for this patch has been sent by Jason.
> Thanks for your attention, and thank Stefan.
>
Er, It seems that you made a mistake, Jason's pull request doesn't
contain this patch. no ?
Thanks,
Hailiang
> Zhang Chen
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-15 9:03 ` Hailiang Zhang
@ 2016-11-15 9:10 ` Zhang Chen
0 siblings, 0 replies; 12+ messages in thread
From: Zhang Chen @ 2016-11-15 9:10 UTC (permalink / raw)
To: Hailiang Zhang, Laurent Vivier, Stefan Hajnoczi
Cc: qemu-trivial, armbru, qemu-devel, dgilbert, Amit Shah
On 11/15/2016 05:03 PM, Hailiang Zhang wrote:
> On 2016/11/15 16:58, Zhang Chen wrote:
>>
>>
>> On 11/15/2016 04:44 PM, Laurent Vivier wrote:
>>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>>> ping ?
>>>>>
>>>>> Anyone pick this up?
>>>> The original patch that added these lines went through Amit Shah and
>>>> David Gilbert. I have CCed them.
>>> If it is needed, I can also send a pull request through my
>>> trivial-patches branch.
>>>
>>> Laurent
>>
>> The pull request for this patch has been sent by Jason.
>> Thanks for your attention, and thank Stefan.
>>
>
> Er, It seems that you made a mistake, Jason's pull request doesn't
> contain this patch. no ?
>
> Thanks,
> Hailiang
>
Oh...Sorry....I was wrong.
Please ignore this....
Thanks
Zhang Chen
>> Zhang Chen
>>
>>
>
>
>
> .
>
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-15 8:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2016-11-15 8:58 ` Zhang Chen
@ 2016-11-17 7:08 ` Hailiang Zhang
2016-11-17 7:52 ` Laurent Vivier
1 sibling, 1 reply; 12+ messages in thread
From: Hailiang Zhang @ 2016-11-17 7:08 UTC (permalink / raw)
To: Laurent Vivier, Stefan Hajnoczi
Cc: qemu-devel, qemu-trivial, armbru, dgilbert, Amit Shah, Eric Blake
Hi Laurent,
On 2016/11/15 16:44, Laurent Vivier wrote:
> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>> ping ?
>>>
>>> Anyone pick this up?
>>
>> The original patch that added these lines went through Amit Shah and
>> David Gilbert. I have CCed them.
>
> If it is needed, I can also send a pull request through my
> trivial-patches branch.
>
I think this patch can go through your trivial branch if Amit or Dave
didn't pick it up.
Thanks,
Hailiang
> Laurent
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-17 7:08 ` Hailiang Zhang
@ 2016-11-17 7:52 ` Laurent Vivier
2016-11-17 10:07 ` Stefan Hajnoczi
0 siblings, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2016-11-17 7:52 UTC (permalink / raw)
To: Hailiang Zhang, Stefan Hajnoczi
Cc: qemu-devel, qemu-trivial, armbru, dgilbert, Amit Shah, Eric Blake
Le 17/11/2016 à 08:08, Hailiang Zhang a écrit :
> Hi Laurent,
>
> On 2016/11/15 16:44, Laurent Vivier wrote:
>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
>>>> ping ?
>>>>
>>>> Anyone pick this up?
>>>
>>> The original patch that added these lines went through Amit Shah and
>>> David Gilbert. I have CCed them.
>>
>> If it is needed, I can also send a pull request through my
>> trivial-patches branch.
>>
>
> I think this patch can go through your trivial branch if Amit or Dave
> didn't pick it up.
Stefan,
can I send a pull request for this while we are in hard freeze phase or
should we wait the end of the release?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus
2016-11-17 7:52 ` Laurent Vivier
@ 2016-11-17 10:07 ` Stefan Hajnoczi
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-11-17 10:07 UTC (permalink / raw)
To: Laurent Vivier
Cc: Hailiang Zhang, qemu-devel, qemu-trivial, armbru, dgilbert,
Amit Shah, Eric Blake
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Thu, Nov 17, 2016 at 08:52:12AM +0100, Laurent Vivier wrote:
> Le 17/11/2016 à 08:08, Hailiang Zhang a écrit :
> > Hi Laurent,
> >
> > On 2016/11/15 16:44, Laurent Vivier wrote:
> >> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
> >>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
> >>>> ping ?
> >>>>
> >>>> Anyone pick this up?
> >>>
> >>> The original patch that added these lines went through Amit Shah and
> >>> David Gilbert. I have CCed them.
> >>
> >> If it is needed, I can also send a pull request through my
> >> trivial-patches branch.
> >>
> >
> > I think this patch can go through your trivial branch if Amit or Dave
> > didn't pick it up.
>
> Stefan,
>
> can I send a pull request for this while we are in hard freeze phase or
> should we wait the end of the release?
Yes, it's a fix for incomplete documentation.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-11-17 10:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02 7:44 [Qemu-devel] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
2016-11-02 14:04 ` Eric Blake
2016-11-14 2:36 ` Hailiang Zhang
2016-11-14 13:54 ` Stefan Hajnoczi
2016-11-15 6:12 ` Hailiang Zhang
2016-11-15 8:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2016-11-15 8:58 ` Zhang Chen
2016-11-15 9:03 ` Hailiang Zhang
2016-11-15 9:10 ` Zhang Chen
2016-11-17 7:08 ` Hailiang Zhang
2016-11-17 7:52 ` Laurent Vivier
2016-11-17 10:07 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.