* [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
@ 2023-01-20 5:54 Doug Smythies
2023-01-20 9:17 ` Huang Rui
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Doug Smythies @ 2023-01-20 5:54 UTC (permalink / raw)
To: 'Rafael J. Wysocki', 'Huang Rui', sedat.dilek, li.meng
Cc: Doug Smythies, linux-kernel, linux-pm
Revert the portion of a recent Makefile change that incorrectly
deletes source files when doing "make clean".
Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
tools/testing/selftests/amd-pstate/Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
index 5f195ee756d6..5fd1424db37d 100644
--- a/tools/testing/selftests/amd-pstate/Makefile
+++ b/tools/testing/selftests/amd-pstate/Makefile
@@ -7,11 +7,6 @@ all:
uname_M := $(shell uname -m 2>/dev/null || echo not)
ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
-ifeq (x86,$(ARCH))
-TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
-TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
-endif
-
TEST_PROGS := run.sh
TEST_FILES := basic.sh tbench.sh gitsource.sh
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
@ 2023-01-20 9:17 ` Huang Rui
2023-01-20 16:11 ` Sedat Dilek
2023-01-20 16:06 ` Sedat Dilek
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2 siblings, 1 reply; 13+ messages in thread
From: Huang Rui @ 2023-01-20 9:17 UTC (permalink / raw)
To: Doug Smythies, Shuah Khan
Cc: 'Rafael J. Wysocki', sedat.dilek, Meng, Li (Jassmine),
linux-kernel, linux-pm, linux-kselftest
On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
(+ Shuah and linux-kselftest mailing list)
Thanks for fix!
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
> TEST_PROGS := run.sh
> TEST_FILES := basic.sh tbench.sh gitsource.sh
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
2023-01-20 9:17 ` Huang Rui
@ 2023-01-20 16:06 ` Sedat Dilek
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2 siblings, 0 replies; 13+ messages in thread
From: Sedat Dilek @ 2023-01-20 16:06 UTC (permalink / raw)
To: Doug Smythies
Cc: Rafael J. Wysocki, Huang Rui, li.meng, linux-kernel, linux-pm
On Fri, Jan 20, 2023 at 6:54 AM Doug Smythies <dsmythies@telus.net> wrote:
>
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
Hi Doug,
Thanks for the patch!
Small nit, I saw this with:
$ make -C tools/ clean
Otherwise:
Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
BR,
-Sedat-
> ---
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
> TEST_PROGS := run.sh
> TEST_FILES := basic.sh tbench.sh gitsource.sh
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 9:17 ` Huang Rui
@ 2023-01-20 16:11 ` Sedat Dilek
2023-01-20 16:15 ` Shuah Khan
0 siblings, 1 reply; 13+ messages in thread
From: Sedat Dilek @ 2023-01-20 16:11 UTC (permalink / raw)
To: Huang Rui
Cc: Doug Smythies, Shuah Khan, Rafael J. Wysocki, Meng, Li (Jassmine),
linux-kernel, linux-pm, linux-kselftest
On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
>
> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
> > Revert the portion of a recent Makefile change that incorrectly
> > deletes source files when doing "make clean".
> >
> > Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> > Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> > Signed-off-by: Doug Smythies <dsmythies@telus.net>
>
> (+ Shuah and linux-kselftest mailing list)
>
> Thanks for fix!
>
> Acked-by: Huang Rui <ray.huang@amd.com>
>
[ I already replied - but with these important CCs ]
Hi Doug,
Thanks for the patch!
Small nit, I saw this with:
$ make -C tools/ clean
Otherwise:
Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
BR,
-Sedat-
> > ---
> > tools/testing/selftests/amd-pstate/Makefile | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> > index 5f195ee756d6..5fd1424db37d 100644
> > --- a/tools/testing/selftests/amd-pstate/Makefile
> > +++ b/tools/testing/selftests/amd-pstate/Makefile
> > @@ -7,11 +7,6 @@ all:
> > uname_M := $(shell uname -m 2>/dev/null || echo not)
> > ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> >
> > -ifeq (x86,$(ARCH))
> > -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> > -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > -endif
> > -
> > TEST_PROGS := run.sh
> > TEST_FILES := basic.sh tbench.sh gitsource.sh
> >
> > --
> > 2.25.1
> >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 16:11 ` Sedat Dilek
@ 2023-01-20 16:15 ` Shuah Khan
2023-01-20 16:20 ` Sedat Dilek
0 siblings, 1 reply; 13+ messages in thread
From: Shuah Khan @ 2023-01-20 16:15 UTC (permalink / raw)
To: sedat.dilek, Huang Rui
Cc: Doug Smythies, Rafael J. Wysocki, Meng, Li (Jassmine),
linux-kernel, linux-pm, linux-kselftest, Shuah Khan
On 1/20/23 09:11, Sedat Dilek wrote:
> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
>>
>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
>>> Revert the portion of a recent Makefile change that incorrectly
>>> deletes source files when doing "make clean".
Ooo. That is bad.
>>>
>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>>
>> (+ Shuah and linux-kselftest mailing list)
>>
>> Thanks for fix!
>>
>> Acked-by: Huang Rui <ray.huang@amd.com>
>>
>
> [ I already replied - but with these important CCs ]
>
> Hi Doug,
>
> Thanks for the patch!
>
> Small nit, I saw this with:
What did you see and should that be fixed as well.
>
> $ make -C tools/ clean
>
> Otherwise:
>
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>
Send me the revised patch with all the right CCs and I will pull
this right away.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 16:15 ` Shuah Khan
@ 2023-01-20 16:20 ` Sedat Dilek
2023-01-20 16:23 ` Shuah Khan
0 siblings, 1 reply; 13+ messages in thread
From: Sedat Dilek @ 2023-01-20 16:20 UTC (permalink / raw)
To: Shuah Khan
Cc: Huang Rui, Doug Smythies, Rafael J. Wysocki, Meng, Li (Jassmine),
linux-kernel, linux-pm, linux-kselftest
On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 1/20/23 09:11, Sedat Dilek wrote:
> > On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
> >>
> >> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
> >>> Revert the portion of a recent Makefile change that incorrectly
> >>> deletes source files when doing "make clean".
>
> Ooo. That is bad.
>
> >>>
> >>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> >>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> >>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> >>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> >>
> >> (+ Shuah and linux-kselftest mailing list)
> >>
> >> Thanks for fix!
> >>
> >> Acked-by: Huang Rui <ray.huang@amd.com>
> >>
> >
> > [ I already replied - but with these important CCs ]
> >
> > Hi Doug,
> >
> > Thanks for the patch!
> >
> > Small nit, I saw this with:
>
> What did you see and should that be fixed as well.
>
> >
> > $ make -C tools/ clean
> >
> > Otherwise:
> >
> > Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> >
>
> Send me the revised patch with all the right CCs and I will pull
> this right away.
>
Hi Shuah,
that was my original posting...
Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean
https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@mail.gmail.com/
...and should contain all CCs I got with scripts/get_maintainer.pl.
Is that OK?
BR,
-Sedat-
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 16:20 ` Sedat Dilek
@ 2023-01-20 16:23 ` Shuah Khan
0 siblings, 0 replies; 13+ messages in thread
From: Shuah Khan @ 2023-01-20 16:23 UTC (permalink / raw)
To: sedat.dilek
Cc: Huang Rui, Doug Smythies, Rafael J. Wysocki, Meng, Li (Jassmine),
linux-kernel, linux-pm, linux-kselftest, Shuah Khan
On 1/20/23 09:20, Sedat Dilek wrote:
> On Fri, Jan 20, 2023 at 5:15 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> On 1/20/23 09:11, Sedat Dilek wrote:
>>> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
>>>>
>>>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
>>>>> Revert the portion of a recent Makefile change that incorrectly
>>>>> deletes source files when doing "make clean".
>>
>> Ooo. That is bad.
>>
>>>>>
>>>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>>>>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>>>>
>>>> (+ Shuah and linux-kselftest mailing list)
>>>>
>>>> Thanks for fix!
>>>>
>>>> Acked-by: Huang Rui <ray.huang@amd.com>
>>>>
>>>
>>> [ I already replied - but with these important CCs ]
>>>
>>> Hi Doug,
>>>
>>> Thanks for the patch!
>>>
>>> Small nit, I saw this with:
>>
>> What did you see and should that be fixed as well.
>>
>>>
>>> $ make -C tools/ clean
>>>
>>> Otherwise:
>>>
>>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>>>
>>
>> Send me the revised patch with all the right CCs and I will pull
>> this right away.
>>
>
> Hi Shuah,
>
> that was my original posting...
>
> Subject: [6.2-rc4] tools: {amd,intel}_pstate_tracer: make -C tools/ clean
> https://lore.kernel.org/all/CA+icZUUOckm1kwOEZhSw8zsaL5z7r8uczwiKeKGEVioZ=GeFNg@mail.gmail.com/
>
> ...and should contain all CCs I got with scripts/get_maintainer.pl.
>
> Is that OK?
>
Yes - the current list looks complete to me.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
2023-01-20 9:17 ` Huang Rui
2023-01-20 16:06 ` Sedat Dilek
@ 2023-01-21 16:41 ` Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
` (2 more replies)
2 siblings, 3 replies; 13+ messages in thread
From: Doug Smythies @ 2023-01-21 16:41 UTC (permalink / raw)
To: 'Huang Rui', sedat.dilek, li.meng, skhan
Cc: linux-kernel, linux-pm, 'Rafael J. Wysocki',
linux-kselftest, Doug Smythies
Revert the portion of a recent Makefile change that incorrectly
deletes source files when doing "make clean".
Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
v2: fix address list.
---
tools/testing/selftests/amd-pstate/Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
index 5f195ee756d6..5fd1424db37d 100644
--- a/tools/testing/selftests/amd-pstate/Makefile
+++ b/tools/testing/selftests/amd-pstate/Makefile
@@ -7,11 +7,6 @@ all:
uname_M := $(shell uname -m 2>/dev/null || echo not)
ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
-ifeq (x86,$(ARCH))
-TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
-TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
-endif
-
TEST_PROGS := run.sh
TEST_FILES := basic.sh tbench.sh gitsource.sh
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
@ 2023-01-21 16:58 ` Sedat Dilek
2023-01-25 17:03 ` Shuah Khan
2023-02-03 15:15 ` Guillaume Tucker
2 siblings, 0 replies; 13+ messages in thread
From: Sedat Dilek @ 2023-01-21 16:58 UTC (permalink / raw)
To: Doug Smythies
Cc: Huang Rui, li.meng, skhan, linux-kernel, linux-pm,
Rafael J. Wysocki, linux-kselftest
On Sat, Jan 21, 2023 at 5:41 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> Acked-by: Huang Rui <ray.huang@amd.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
> v2: fix address list.
> ---
Hi Doug,
thanks for the update.
You happen to know through which Git tree this will go?
linux-pm?
linux-kselftest?
https://lore.kernel.org/lkml/?q=Doug+Smythies
Hmm, I cannot download the patch with b4:
link="https://lore.kernel.org/lkml/000601d92db7$39e9d0b0$adbd7210$@telus.net/"
$ b4 -d am $link
Running git --no-pager config -z --get-regexp b4\..*
Running git --no-pager config -z --get-regexp get-lore-mbox\..*
Running git --no-pager config -z --get-regexp gpg\..*
t_mbx_url=https://lore.kernel.org/all/https%3A%2F%2Flore.kernel.org%2Flkml%2F000601d92db79e9d0b0telus.net%2F/t.mbox.gz
Grabbing thread from
lore.kernel.org/all/https%3A%2F%2Flore.kernel.org%2Flkml%2F000601d92db79e9d0b0telus.net%2F/t.mbox.gz
That message-id is not known.
Maybe be patient.
BR,
-Sedat-
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
> TEST_PROGS := run.sh
> TEST_FILES := basic.sh tbench.sh gitsource.sh
>
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
@ 2023-01-25 17:03 ` Shuah Khan
2023-01-26 22:43 ` Doug Smythies
2023-02-03 15:15 ` Guillaume Tucker
2 siblings, 1 reply; 13+ messages in thread
From: Shuah Khan @ 2023-01-25 17:03 UTC (permalink / raw)
To: Doug Smythies, 'Huang Rui', sedat.dilek, li.meng
Cc: linux-kernel, linux-pm, 'Rafael J. Wysocki',
linux-kselftest, Shuah Khan
On 1/21/23 09:41, Doug Smythies wrote:
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> Acked-by: Huang Rui <ray.huang@amd.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
> v2: fix address list.
> ---
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
This looks good - Do you need these files to run this test and if so
do these need to installed when the test is run on a test system?
Now applied to linux-kselftest fixes. I will send this up for the next
rc.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-25 17:03 ` Shuah Khan
@ 2023-01-26 22:43 ` Doug Smythies
0 siblings, 0 replies; 13+ messages in thread
From: Doug Smythies @ 2023-01-26 22:43 UTC (permalink / raw)
To: 'Shuah Khan', 'Huang Rui', li.meng
Cc: linux-kernel, linux-pm, 'Rafael J. Wysocki',
linux-kselftest, Doug Smythies, sedat.dilek
On 2023.01.25 09:03 Shuah Khan wrote:
> On 1/21/23 09:41, Doug Smythies wrote:
>> Revert the portion of a recent Makefile change that incorrectly
>> deletes source files when doing "make clean".
>>
>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Acked-by: Huang Rui <ray.huang@amd.com>
>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>> ---
>> v2: fix address list.
>> ---
>> tools/testing/selftests/amd-pstate/Makefile | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
>> index 5f195ee756d6..5fd1424db37d 100644
>> --- a/tools/testing/selftests/amd-pstate/Makefile
>> +++ b/tools/testing/selftests/amd-pstate/Makefile
>> @@ -7,11 +7,6 @@ all:
>> uname_M := $(shell uname -m 2>/dev/null || echo not)
>> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>>
>> -ifeq (x86,$(ARCH))
>> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
>> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
>> -endif
>> -
>
> This looks good - Do you need these files to run this test and if so
> do these need to installed when the test is run on a test system?
I do not know.
It is a question for the AMD people.
> Now applied to linux-kselftest fixes. I will send this up for the next
> rc.
Thank you
... Doug
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
2023-01-25 17:03 ` Shuah Khan
@ 2023-02-03 15:15 ` Guillaume Tucker
2023-02-03 16:26 ` Shuah Khan
2 siblings, 1 reply; 13+ messages in thread
From: Guillaume Tucker @ 2023-02-03 15:15 UTC (permalink / raw)
To: Doug Smythies, 'Huang Rui', sedat.dilek, li.meng, skhan
Cc: linux-kernel, linux-pm, 'Rafael J. Wysocki',
linux-kselftest, Collabora Kernel ML
On 21/01/2023 17:41, Doug Smythies wrote:
> Revert the portion of a recent Makefile change that incorrectly
> deletes source files when doing "make clean".
>
> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> Acked-by: Huang Rui <ray.huang@amd.com>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
> v2: fix address list.
> ---
> tools/testing/selftests/amd-pstate/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
> index 5f195ee756d6..5fd1424db37d 100644
> --- a/tools/testing/selftests/amd-pstate/Makefile
> +++ b/tools/testing/selftests/amd-pstate/Makefile
> @@ -7,11 +7,6 @@ all:
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>
> -ifeq (x86,$(ARCH))
> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> -endif
> -
The two lines above should also be removed as they're only used
in the condition to include the Python files.
I've also hit this issue and independently came up with an
alternative solution, let me know if you want me to submit it as
a patch on top of the previous fix; see below.
The Python scripts appear to be used in gitsource.sh and
tbench.sh so I guess they are needed for these kselftests
although I haven't tried to run them or do anything with them.
This is just to fix make clean.
Author: Guillaume Tucker <guillaume.tucker@collabora.com>
Date: Fri Feb 3 11:23:50 2023 +0100
selftests: amd-pstate: fix TEST_FILES
Replace TEST_GEN_FILES with TEST_FILES to avoid having them deleted
when doing a clean. Also fix the way the architecture is being
determined as they should also be installed when ARCH=x86_64 is
provided explicitly. Then also append extra files to TEST_FILES and
TEST_PROGS with += so they don't get discarded.
Fixes: a2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
index 5f195ee756d6..c382f579fe94 100644
--- a/tools/testing/selftests/amd-pstate/Makefile
+++ b/tools/testing/selftests/amd-pstate/Makefile
@@ -4,15 +4,15 @@
# No binaries, but make sure arg-less "make" doesn't trigger "run_tests"
all:
-uname_M := $(shell uname -m 2>/dev/null || echo not)
-ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
+ARCH ?= $(shell uname -m 2>/dev/null || echo not)
+ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq (x86,$(ARCH))
-TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
-TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+TEST_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
+TEST_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
endif
-TEST_PROGS := run.sh
-TEST_FILES := basic.sh tbench.sh gitsource.sh
+TEST_PROGS += run.sh
+TEST_FILES += basic.sh tbench.sh gitsource.sh
include ../lib.mk
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] selftests: amd-pstate: Don't delete source files via Makefile
2023-02-03 15:15 ` Guillaume Tucker
@ 2023-02-03 16:26 ` Shuah Khan
0 siblings, 0 replies; 13+ messages in thread
From: Shuah Khan @ 2023-02-03 16:26 UTC (permalink / raw)
To: Guillaume Tucker, Doug Smythies, 'Huang Rui',
sedat.dilek, li.meng
Cc: linux-kernel, linux-pm, 'Rafael J. Wysocki',
linux-kselftest, Collabora Kernel ML, Shuah Khan
On 2/3/23 08:15, Guillaume Tucker wrote:
> On 21/01/2023 17:41, Doug Smythies wrote:
>> Revert the portion of a recent Makefile change that incorrectly
>> deletes source files when doing "make clean".
>>
>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
>> Acked-by: Huang Rui <ray.huang@amd.com>
>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>> ---
>> v2: fix address list.
>> ---
>> tools/testing/selftests/amd-pstate/Makefile | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile
>> index 5f195ee756d6..5fd1424db37d 100644
>> --- a/tools/testing/selftests/amd-pstate/Makefile
>> +++ b/tools/testing/selftests/amd-pstate/Makefile
>> @@ -7,11 +7,6 @@ all:
>> uname_M := $(shell uname -m 2>/dev/null || echo not)
>> ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>>
>> -ifeq (x86,$(ARCH))
>> -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py
>> -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py
>> -endif
>> -
>
>
> The two lines above should also be removed as they're only used
> in the condition to include the Python files.
>
> I've also hit this issue and independently came up with an
> alternative solution, let me know if you want me to submit it as
> a patch on top of the previous fix; see below.
>
> The Python scripts appear to be used in gitsource.sh and
> tbench.sh so I guess they are needed for these kselftests
> although I haven't tried to run them or do anything with them.
> This is just to fix make clean.
>
>
Please send me the patch.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-02-03 16:26 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 5:54 [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Doug Smythies
2023-01-20 9:17 ` Huang Rui
2023-01-20 16:11 ` Sedat Dilek
2023-01-20 16:15 ` Shuah Khan
2023-01-20 16:20 ` Sedat Dilek
2023-01-20 16:23 ` Shuah Khan
2023-01-20 16:06 ` Sedat Dilek
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58 ` Sedat Dilek
2023-01-25 17:03 ` Shuah Khan
2023-01-26 22:43 ` Doug Smythies
2023-02-03 15:15 ` Guillaume Tucker
2023-02-03 16:26 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.