All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Sam Protsenko'" <semen.protsenko@linaro.org>,
	"'Jaewon Kim'" <jaewon02.kim@samsung.com>
Cc: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Wolfram Sang'" <wsa@kernel.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	<linux-samsung-soc@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v3 2/2] i2c: exynos5: add support for ExynosAutov9 SoC
Date: Tue, 16 Nov 2021 10:12:04 +0900	[thread overview]
Message-ID: <001401d7da86$f7ebd660$e7c38320$@samsung.com> (raw)
In-Reply-To: <CAPLW+4==X+irRBKHiDfgJeAb0oDKkzbcWERFs7Y3=PSOg0+qAw@mail.gmail.com>

> With this patch the Exynos850 HSI2C becomes functional. The only nit-pick
> from my side (just a food for thought): do we want to configure USI
> related config inside of particular drivers (SPI, I2C, UART)? Or it would
> be better design to implement some platform driver for that, so we can
> choose USI configuration (SPI/I2C/UART) in device tree? I think this
> series is good to be merged as is, but we should probably consider all
> upsides and downsides of each option, for the future work.

I'm also considering how to support this USI configuration gracefully.
Current version of USI is v2 which means there is a v1 version as well. It might be a non-upstream SoC so we don't need to consider it so far.
But, there is a possibility that the USI hw version can be bumped for future SoCs.

As you probably know, earlier version of the product kernel has a USI SoC driver[1] and it was designed to be configured the USI settings by device tree.

Option1) Make a USI driver under soc/samsung/ like [1].
Option2) Use more generic driver such as "reset driver"? This might be required to extend the reset core driver.
Option3) Each USI driver(uart/i2c/spi) has its own USI configurations respectively and expose some configurations which can be variable as device tree.

[1]: https://github.com/ianmacd/d2s/blob/master/drivers/soc/samsung/usi_v2.c

Best Regards,
Chanho Park


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Sam Protsenko'" <semen.protsenko@linaro.org>,
	"'Jaewon Kim'" <jaewon02.kim@samsung.com>
Cc: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Wolfram Sang'" <wsa@kernel.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	<linux-samsung-soc@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v3 2/2] i2c: exynos5: add support for ExynosAutov9 SoC
Date: Tue, 16 Nov 2021 10:12:04 +0900	[thread overview]
Message-ID: <001401d7da86$f7ebd660$e7c38320$@samsung.com> (raw)
In-Reply-To: <CAPLW+4==X+irRBKHiDfgJeAb0oDKkzbcWERFs7Y3=PSOg0+qAw@mail.gmail.com>

> With this patch the Exynos850 HSI2C becomes functional. The only nit-pick
> from my side (just a food for thought): do we want to configure USI
> related config inside of particular drivers (SPI, I2C, UART)? Or it would
> be better design to implement some platform driver for that, so we can
> choose USI configuration (SPI/I2C/UART) in device tree? I think this
> series is good to be merged as is, but we should probably consider all
> upsides and downsides of each option, for the future work.

I'm also considering how to support this USI configuration gracefully.
Current version of USI is v2 which means there is a v1 version as well. It might be a non-upstream SoC so we don't need to consider it so far.
But, there is a possibility that the USI hw version can be bumped for future SoCs.

As you probably know, earlier version of the product kernel has a USI SoC driver[1] and it was designed to be configured the USI settings by device tree.

Option1) Make a USI driver under soc/samsung/ like [1].
Option2) Use more generic driver such as "reset driver"? This might be required to extend the reset core driver.
Option3) Each USI driver(uart/i2c/spi) has its own USI configurations respectively and expose some configurations which can be variable as device tree.

[1]: https://github.com/ianmacd/d2s/blob/master/drivers/soc/samsung/usi_v2.c

Best Regards,
Chanho Park


  reply	other threads:[~2021-11-16  1:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211112010603epcas2p331fe717eabfd9fc0280792921b25c535@epcas2p3.samsung.com>
2021-11-12  1:01 ` [PATCH v3 0/2] i2c: exynos5: add support for ExynosAutov9 SoC Jaewon Kim
2021-11-12  1:01   ` Jaewon Kim
     [not found]   ` <CGME20211112010603epcas2p26c076e65e0cb286cb53f06053165ef60@epcas2p2.samsung.com>
2021-11-12  1:01     ` [PATCH v3 1/2] dt-bindings: i2c: exynos5: add exynosautov9-hsi2c compatible Jaewon Kim
2021-11-12  1:01       ` Jaewon Kim
2021-11-15 18:56       ` Sam Protsenko
2021-11-15 18:56         ` Sam Protsenko
2021-11-19  8:57       ` Krzysztof Kozlowski
2021-11-19  8:57         ` Krzysztof Kozlowski
     [not found]   ` <CGME20211112010603epcas2p339d1a6ef3df7cdbe61c87c8afa541fd0@epcas2p3.samsung.com>
2021-11-12  1:01     ` [PATCH v3 2/2] i2c: exynos5: add support for ExynosAutov9 SoC Jaewon Kim
2021-11-12  1:01       ` Jaewon Kim
2021-11-12  8:09       ` Krzysztof Kozlowski
2021-11-12  8:09         ` Krzysztof Kozlowski
2021-11-15 18:55       ` Sam Protsenko
2021-11-15 18:55         ` Sam Protsenko
2021-11-16  1:12         ` Chanho Park [this message]
2021-11-16  1:12           ` Chanho Park
2021-11-16  9:31           ` Krzysztof Kozlowski
2021-11-16  9:31             ` Krzysztof Kozlowski
2021-11-16 15:31             ` Sam Protsenko
2021-11-16 15:31               ` Sam Protsenko
2021-11-19  8:51               ` Krzysztof Kozlowski
2021-11-19  8:51                 ` Krzysztof Kozlowski
2021-11-18 19:59             ` Sam Protsenko
2021-11-18 19:59               ` Sam Protsenko
2021-11-19  8:54               ` Krzysztof Kozlowski
2021-11-19  8:54                 ` Krzysztof Kozlowski
2021-11-19 14:12                 ` Sam Protsenko
2021-11-19 14:12                   ` Sam Protsenko
2021-11-22  2:51                   ` Jaewon Kim
2021-11-22  2:51                     ` Jaewon Kim
2021-11-17 22:17           ` David Virag
2021-11-17 22:17             ` David Virag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001401d7da86$f7ebd660$e7c38320$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jaewon02.kim@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.