[PATCH 0/8] watchdog: Remove unnecessary OOM messages

[PATCH 0/8] watchdog: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().

Jingoo Han (8):
      watchdog: at32ap700x: Remove unnecessary OOM messages
      watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
      watchdog: bcm2835: Remove unnecessary OOM messages
      watchdog: da9052: Remove unnecessary OOM messages
      watchdog: da9055: Remove unnecessary OOM messages
      watchdog: pcwd_usb: Remove unnecessary OOM messages
      watchdog: sp805_wdt: Remove unnecessary OOM messages
      watchdog: ts72xx_wdt: Remove unnecessary OOM messages
      watchdog: wm831x: Remove unnecessary OOM messages

---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 drivers/watchdog/bcm2835_wdt.c    |    4 +---
 drivers/watchdog/da9052_wdt.c     |    1 -
 drivers/watchdog/da9055_wdt.c     |    4 +---
 drivers/watchdog/pcwd_usb.c       |    4 +---
 drivers/watchdog/sp805_wdt.c      |    1 -
 drivers/watchdog/ts72xx_wdt.c     |    6 ++----
 drivers/watchdog/wm831x_wdt.c     |    1 -
 8 files changed, 6 insertions(+), 19 deletions(-)

[PATCH 1/8] watchdog: at32ap700x: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/at32ap700x_wdt.c b/drivers/watchdog/at32ap700x_wdt.c
index afe7d17..25b5c67 100644
--- a/drivers/watchdog/at32ap700x_wdt.c
+++ b/drivers/watchdog/at32ap700x_wdt.c
@@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev)
 
 	wdt = devm_kzalloc(&pdev->dev, sizeof(struct wdt_at32ap700x),
 			GFP_KERNEL);
-	if (!wdt) {
-		dev_dbg(&pdev->dev, "no memory for wdt structure\n");
+	if (!wdt)
 		return -ENOMEM;
-	}
 
 	wdt->regs = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
 	if (!wdt->regs) {
-- 
1.7.10.4

[PATCH 2/8] watchdog: bcm2835: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/bcm2835_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
index cafa973..8df450c 100644
--- a/drivers/watchdog/bcm2835_wdt.c
+++ b/drivers/watchdog/bcm2835_wdt.c
@@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
 	int err;
 
 	wdt = devm_kzalloc(dev, sizeof(struct bcm2835_wdt), GFP_KERNEL);
-	if (!wdt) {
-		dev_err(dev, "Failed to allocate memory for watchdog device");
+	if (!wdt)
 		return -ENOMEM;
-	}
 	platform_set_drvdata(pdev, wdt);
 
 	spin_lock_init(&wdt->lock);
-- 
1.7.10.4

[PATCH 3/8] watchdog: da9052: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/da9052_wdt.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
index f09c54e..2e95896 100644
--- a/drivers/watchdog/da9052_wdt.c
+++ b/drivers/watchdog/da9052_wdt.c
@@ -185,7 +185,6 @@ static int da9052_wdt_probe(struct platform_device *pdev)
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
 	if (!driver_data) {
-		dev_err(da9052->dev, "Unable to alloacate watchdog device\n");
 		ret = -ENOMEM;
 		goto err;
 	}
-- 
1.7.10.4

[PATCH 4/8] watchdog: da9055: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/da9055_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/da9055_wdt.c b/drivers/watchdog/da9055_wdt.c
index 575f37a..495089d 100644
--- a/drivers/watchdog/da9055_wdt.c
+++ b/drivers/watchdog/da9055_wdt.c
@@ -151,10 +151,8 @@ static int da9055_wdt_probe(struct platform_device *pdev)
 
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
-	if (!driver_data) {
-		dev_err(da9055->dev, "Failed to allocate watchdog device\n");
+	if (!driver_data)
 		return -ENOMEM;
-	}
 
 	driver_data->da9055 = da9055;
 
-- 
1.7.10.4

[PATCH 5/8] watchdog: pcwd_usb: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/pcwd_usb.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c
index e562e04..1a11aed 100644
--- a/drivers/watchdog/pcwd_usb.c
+++ b/drivers/watchdog/pcwd_usb.c
@@ -645,10 +645,8 @@ static int usb_pcwd_probe(struct usb_interface *interface,
 
 	/* allocate memory for our device and initialize it */
 	usb_pcwd = kzalloc(sizeof(struct usb_pcwd_private), GFP_KERNEL);
-	if (usb_pcwd == NULL) {
-		pr_err("Out of memory\n");
+	if (usb_pcwd == NULL)
 		goto error;
-	}
 
 	usb_pcwd_device = usb_pcwd;
 
-- 
1.7.10.4

[PATCH 6/8] watchdog: sp805_wdt: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/sp805_wdt.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
index 3f786ce..d7da73e 100644
--- a/drivers/watchdog/sp805_wdt.c
+++ b/drivers/watchdog/sp805_wdt.c
@@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
 
 	wdt = devm_kzalloc(&adev->dev, sizeof(*wdt), GFP_KERNEL);
 	if (!wdt) {
-		dev_warn(&adev->dev, "Kzalloc failed\n");
 		ret = -ENOMEM;
 		goto err;
 	}
-- 
1.7.10.4

[PATCH 7/8] watchdog: ts72xx_wdt: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/ts72xx_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c
index 09d4831..6959fa0 100644
--- a/drivers/watchdog/ts72xx_wdt.c
+++ b/drivers/watchdog/ts72xx_wdt.c
@@ -394,10 +394,8 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
 	int error = 0;
 
 	wdt = devm_kzalloc(&pdev->dev, sizeof(struct ts72xx_wdt), GFP_KERNEL);
-	if (!wdt) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!wdt)
 		return -ENOMEM;
-	}
 
 	r1 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	wdt->control_reg = devm_ioremap_resource(&pdev->dev, r1);
-- 
1.7.10.4

[PATCH 8/8] watchdog: wm831x: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/watchdog/wm831x_wdt.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/wm831x_wdt.c b/drivers/watchdog/wm831x_wdt.c
index e243bd0..2fa17e7 100644
--- a/drivers/watchdog/wm831x_wdt.c
+++ b/drivers/watchdog/wm831x_wdt.c
@@ -204,7 +204,6 @@ static int wm831x_wdt_probe(struct platform_device *pdev)
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
 	if (!driver_data) {
-		dev_err(wm831x->dev, "Unable to alloacate watchdog device\n");
 		ret = -ENOMEM;
 		goto err;
 	}
-- 
1.7.10.4

Re: [PATCH 0/8] watchdog: Remove unnecessary OOM messages

[Jingoo Han]

On Tuesday, February 11, 2014 3:47 PM, Jingoo Han wrote:
> 
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
> 
> Jingoo Han (8):
>       watchdog: at32ap700x: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static

There is a mistake. The followings are right.

Jingoo Han (8):
      watchdog: at32ap700x: Remove unnecessary OOM messages
      watchdog: bcm2835: Remove unnecessary OOM messages
      watchdog: da9052: Remove unnecessary OOM messages
      watchdog: da9055: Remove unnecessary OOM messages
      watchdog: pcwd_usb: Remove unnecessary OOM messages
      watchdog: sp805_wdt: Remove unnecessary OOM messages
      watchdog: ts72xx_wdt: Remove unnecessary OOM messages
      watchdog: wm831x: Remove unnecessary OOM messages

Best regards,
Jingoo Han

>       watchdog: bcm2835: Remove unnecessary OOM messages
>       watchdog: da9052: Remove unnecessary OOM messages
>       watchdog: da9055: Remove unnecessary OOM messages
>       watchdog: pcwd_usb: Remove unnecessary OOM messages
>       watchdog: sp805_wdt: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: Remove unnecessary OOM messages
>       watchdog: wm831x: Remove unnecessary OOM messages
> 
> ---
>  drivers/watchdog/at32ap700x_wdt.c |    4 +---
>  drivers/watchdog/bcm2835_wdt.c    |    4 +---
>  drivers/watchdog/da9052_wdt.c     |    1 -
>  drivers/watchdog/da9055_wdt.c     |    4 +---
>  drivers/watchdog/pcwd_usb.c       |    4 +---
>  drivers/watchdog/sp805_wdt.c      |    1 -
>  drivers/watchdog/ts72xx_wdt.c     |    6 ++----
>  drivers/watchdog/wm831x_wdt.c     |    1 -
>  8 files changed, 6 insertions(+), 19 deletions(-)

Re: [PATCH 6/8] watchdog: sp805_wdt: Remove unnecessary OOM messages

[Viresh Kumar]

On 11 February 2014 12:23, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/watchdog/sp805_wdt.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index 3f786ce..d7da73e 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
>
>         wdt = devm_kzalloc(&adev->dev, sizeof(*wdt), GFP_KERNEL);
>         if (!wdt) {
> -               dev_warn(&adev->dev, "Kzalloc failed\n");
>                 ret = -ENOMEM;
>                 goto err;
>         }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH 1/8] watchdog: at32ap700x: Remove unnecessary OOM messages

[Jean Delvare]

Le Tuesday 11 February 2014 à 15:48 +0900, Jingoo Han a écrit :
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/watchdog/at32ap700x_wdt.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/at32ap700x_wdt.c b/drivers/watchdog/at32ap700x_wdt.c
> index afe7d17..25b5c67 100644
> --- a/drivers/watchdog/at32ap700x_wdt.c
> +++ b/drivers/watchdog/at32ap700x_wdt.c
> @@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev)
>  
>  	wdt = devm_kzalloc(&pdev->dev, sizeof(struct wdt_at32ap700x),
>  			GFP_KERNEL);
> -	if (!wdt) {
> -		dev_dbg(&pdev->dev, "no memory for wdt structure\n");
> +	if (!wdt)
>  		return -ENOMEM;
> -	}
>  
>  	wdt->regs = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
>  	if (!wdt->regs) {

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
Suse L3 Support

Re: [PATCH 7/8] watchdog: ts72xx_wdt: Remove unnecessary OOM messages

['Mika Westerberg']

On Tue, Feb 11, 2014 at 03:54:56PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH 2/8] watchdog: bcm2835: Remove unnecessary OOM messages

[Lubomir Rintel]

On Tue, 2014-02-11 at 15:50 +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

> ---
>  drivers/watchdog/bcm2835_wdt.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index cafa973..8df450c 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
>  	int err;
>  
>  	wdt = devm_kzalloc(dev, sizeof(struct bcm2835_wdt), GFP_KERNEL);
> -	if (!wdt) {
> -		dev_err(dev, "Failed to allocate memory for watchdog device");
> +	if (!wdt)
>  		return -ENOMEM;
> -	}
>  	platform_set_drvdata(pdev, wdt);
>  
>  	spin_lock_init(&wdt->lock);

Re: [PATCH 0/8] watchdog: Remove unnecessary OOM messages

[Guenter Roeck]

On Tue, Feb 11, 2014 at 03:46:43PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
> 
> Jingoo Han (8):
>       watchdog: at32ap700x: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
>       watchdog: bcm2835: Remove unnecessary OOM messages
>       watchdog: da9052: Remove unnecessary OOM messages
>       watchdog: da9055: Remove unnecessary OOM messages
>       watchdog: pcwd_usb: Remove unnecessary OOM messages
>       watchdog: sp805_wdt: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: Remove unnecessary OOM messages
>       watchdog: wm831x: Remove unnecessary OOM messages
> 
For the series:

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH 0/8] watchdog: Remove unnecessary OOM messages

[Wim Van Sebroeck]

Hi Jingoo,

> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
> 
> Jingoo Han (8):
>       watchdog: at32ap700x: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
>       watchdog: bcm2835: Remove unnecessary OOM messages
>       watchdog: da9052: Remove unnecessary OOM messages
>       watchdog: da9055: Remove unnecessary OOM messages
>       watchdog: pcwd_usb: Remove unnecessary OOM messages
>       watchdog: sp805_wdt: Remove unnecessary OOM messages
>       watchdog: ts72xx_wdt: Remove unnecessary OOM messages
>       watchdog: wm831x: Remove unnecessary OOM messages
> 
> ---
>  drivers/watchdog/at32ap700x_wdt.c |    4 +---
>  drivers/watchdog/bcm2835_wdt.c    |    4 +---
>  drivers/watchdog/da9052_wdt.c     |    1 -
>  drivers/watchdog/da9055_wdt.c     |    4 +---
>  drivers/watchdog/pcwd_usb.c       |    4 +---
>  drivers/watchdog/sp805_wdt.c      |    1 -
>  drivers/watchdog/ts72xx_wdt.c     |    6 ++----
>  drivers/watchdog/wm831x_wdt.c     |    1 -
>  8 files changed, 6 insertions(+), 19 deletions(-)
> 

This has been added as a single patch to linux-watchdog-next.

Kind regards,
Wim.