From: Jingoo Han <jg1.han@samsung.com>
To: 'Thadeu Lima de Souza Cascardo' <cascardo@linux.vnet.ibm.com>
Cc: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH 3/5] serial: jsm: use DEFINE_PCI_DEVICE_TABLE macro
Date: Fri, 29 Nov 2013 09:53:36 +0900 [thread overview]
Message-ID: <001c01ceec9d$6fa72a50$4ef57ef0$%han@samsung.com> (raw)
In-Reply-To: <20131128113542.GC24646@oc0268524204.ibm.com>
On Thursday, November 28, 2013 8:36 PM, Thadeu Lima de Souza Cascardo wrote:
> On Thu, Nov 28, 2013 at 10:58:39AM +0900, Jingoo Han wrote:
> > This macro is used to create a struct pci_device_id array.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/tty/serial/jsm/jsm_driver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
[.....]
>
> Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Thank you for your review! :-)
However, these patches should NOT be merged.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.
Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches."
So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
Sorry for annoying you. :-)
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-11-29 0:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 1:55 [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 1:57 ` [PATCH 2/5] serial: icom: " Jingoo Han
2013-11-28 1:58 ` [PATCH 3/5] serial: jsm: " Jingoo Han
2013-11-28 11:35 ` Thadeu Lima de Souza Cascardo
2013-11-29 0:53 ` Jingoo Han [this message]
2013-11-28 1:59 ` [PATCH 4/5] serial: mfd: " Jingoo Han
2013-11-28 2:00 ` [PATCH 5/5] serial: txx9: " Jingoo Han
2013-11-28 4:07 ` [PATCH 1/5] serial: 8250_pci: " 'Greg Kroah-Hartman'
2013-11-28 4:32 ` Jingoo Han
2013-11-28 5:29 ` Jingoo Han
2013-11-28 5:40 ` Joe Perches
2013-11-28 5:53 ` 'Greg Kroah-Hartman'
2013-11-28 6:24 ` Joe Perches
2013-11-29 1:33 ` Jingoo Han
2013-12-02 0:07 ` Jingoo Han
2013-12-02 0:07 ` Jingoo Han
2013-12-02 3:45 ` Guenter Roeck
2013-12-02 3:50 ` Jingoo Han
2013-12-02 3:55 ` Guenter Roeck
2013-12-02 4:03 ` Jingoo Han
2013-12-02 5:48 ` Joe Perches
2013-12-02 10:44 ` Jonas Bonn
2013-12-02 17:43 ` [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE Joe Perches
2013-12-02 18:01 ` Guenter Roeck
2013-12-02 18:07 ` Joe Perches
2013-12-03 1:52 ` Jingoo Han
2013-12-13 18:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001c01ceec9d$6fa72a50$4ef57ef0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.