From: Joe Perches <joe@perches.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jonas Bonn <jonas@southpole.se>, Jingoo Han <jg1.han@samsung.com>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"'Andrew Morton'" <akpm@linux-foundation.org>,
"'Andy Whitcroft'" <apw@canonical.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE
Date: Mon, 02 Dec 2013 10:07:37 -0800 [thread overview]
Message-ID: <1386007657.2680.15.camel@joe-AO722> (raw)
In-Reply-To: <20131202180147.GB31606@roeck-us.net>
On Mon, 2013-12-02 at 10:01 -0800, Guenter Roeck wrote:
> On Mon, Dec 02, 2013 at 09:43:37AM -0800, Joe Perches wrote:
> > Prefer use of the direct definition of struct pci_device_id
[]
> > +all-zero entry. Definitions with static const are generally preferred.
see here:
> Add 'const' ?
Also see $fix.
Not all can be const as some codes actually modify
the tables for various quirks.
next prev parent reply other threads:[~2013-12-02 18:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 1:55 [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 1:57 ` [PATCH 2/5] serial: icom: " Jingoo Han
2013-11-28 1:58 ` [PATCH 3/5] serial: jsm: " Jingoo Han
2013-11-28 11:35 ` Thadeu Lima de Souza Cascardo
2013-11-29 0:53 ` Jingoo Han
2013-11-28 1:59 ` [PATCH 4/5] serial: mfd: " Jingoo Han
2013-11-28 2:00 ` [PATCH 5/5] serial: txx9: " Jingoo Han
2013-11-28 4:07 ` [PATCH 1/5] serial: 8250_pci: " 'Greg Kroah-Hartman'
2013-11-28 4:32 ` Jingoo Han
2013-11-28 5:29 ` Jingoo Han
2013-11-28 5:40 ` Joe Perches
2013-11-28 5:53 ` 'Greg Kroah-Hartman'
2013-11-28 6:24 ` Joe Perches
2013-11-29 1:33 ` Jingoo Han
2013-12-02 0:07 ` Jingoo Han
2013-12-02 0:07 ` Jingoo Han
2013-12-02 3:45 ` Guenter Roeck
2013-12-02 3:50 ` Jingoo Han
2013-12-02 3:55 ` Guenter Roeck
2013-12-02 4:03 ` Jingoo Han
2013-12-02 5:48 ` Joe Perches
2013-12-02 10:44 ` Jonas Bonn
2013-12-02 17:43 ` [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE Joe Perches
2013-12-02 18:01 ` Guenter Roeck
2013-12-02 18:07 ` Joe Perches [this message]
2013-12-03 1:52 ` Jingoo Han
2013-12-13 18:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386007657.2680.15.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.