[PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Add nodes for fimd and dp controller for exynos5250 based snow
and exynos5420 based peach-pit board.

This series is based on Kukjin Kims, for-next branch.

It is dependent on
1) Andrew Bresticker's patch for hpd gpio addition, avilable at
http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
2) Arun's patch for adding peach-pit board dts file at
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg28846.html.

Rahul Sharma (5):
  ARM: dts: move dp hpd line to the board file for exynos5420
  ARM: dts: enable fimd for exynos5250 based snow board
  ARM: dts: enable dp-controller for exynos5250 based snow board
  ARM: dts: enable fimd for exynos5420 based peach-pit board
  ARM: dts: enable dp-controller for exynos5420 based peach-pit board

 arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
 arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
 4 files changed, 78 insertions(+), 7 deletions(-)

-- 
1.7.9.5

[PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Add nodes for fimd and dp controller for exynos5250 based snow
and exynos5420 based peach-pit board.

This series is based on Kukjin Kims, for-next branch.

It is dependent on
1) Andrew Bresticker's patch for hpd gpio addition, avilable at
http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
2) Arun's patch for adding peach-pit board dts file at
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg28846.html.

Rahul Sharma (5):
  ARM: dts: move dp hpd line to the board file for exynos5420
  ARM: dts: enable fimd for exynos5250 based snow board
  ARM: dts: enable dp-controller for exynos5250 based snow board
  ARM: dts: enable fimd for exynos5420 based peach-pit board
  ARM: dts: enable dp-controller for exynos5420 based peach-pit board

 arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
 arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
 4 files changed, 78 insertions(+), 7 deletions(-)

-- 
1.7.9.5

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Display controller HPD Gpio line is board specific. This patch
is moving the pinctrl for hpd gpio line to the respective board
file.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index e62c8eb..5848c42 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,13 +59,6 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
-
-		dp_hpd: dp_hpd {
-			samsung,pins = "gpx0-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
 	};
 
 	pinctrl@13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..62d38c8 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -138,6 +138,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx0-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	hdmi@14530000 {
-- 
1.7.9.5

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Display controller HPD Gpio line is board specific. This patch
is moving the pinctrl for hpd gpio line to the respective board
file.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index e62c8eb..5848c42 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -59,13 +59,6 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
-
-		dp_hpd: dp_hpd {
-			samsung,pins = "gpx0-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
-		};
 	};
 
 	pinctrl at 13410000 {
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..62d38c8 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -138,6 +138,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx0-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	hdmi at 14530000 {
-- 
1.7.9.5

[PATCH 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd node for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 586cd38..09f363d 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -344,6 +344,11 @@
 		};
 	};
 
+	fimd@14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
+
 	hdmi {
 		hdmi-en-supply = <&tps65090_fet7>;
 		vdd-supply = <&ldo8_reg>;
-- 
1.7.9.5

[PATCH 2/5] ARM: dts: enable fimd for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd node for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 586cd38..09f363d 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -344,6 +344,11 @@
 		};
 	};
 
+	fimd at 14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
+
 	hdmi {
 		hdmi-en-supply = <&tps65090_fet7>;
 		vdd-supply = <&ldo8_reg>;
-- 
1.7.9.5

[PATCH 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Ennable dp-controller for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 09f363d..60cc2a8 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -344,6 +344,33 @@
 		};
 	};
 
+	dp-controller@145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x0a>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx0 7 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing@1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd@14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

[PATCH 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Ennable dp-controller for snow board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 09f363d..60cc2a8 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -344,6 +344,33 @@
 		};
 	};
 
+	dp-controller at 145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x0a>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx0 7 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing at 1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd at 14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

[PATCH 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 5b70522..d6eaa1f 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -248,4 +248,9 @@
 		ddc = <&i2c_2>;
 		status = "okay";
 	};
+
+	fimd@14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
 };
-- 
1.7.9.5

[PATCH 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable fimd for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 5b70522..d6eaa1f 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -248,4 +248,9 @@
 		ddc = <&i2c_2>;
 		status = "okay";
 	};
+
+	fimd at 14400000 {
+		status = "okay";
+		samsung,invert-vclk;
+	};
 };
-- 
1.7.9.5

[PATCH 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index d6eaa1f..e6199e1 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -61,6 +61,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx2-6";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl@14010000 {
@@ -249,6 +256,33 @@
 		status = "okay";
 	};
 
+	dp-controller@145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x06>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx2 6 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing@1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd@14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

[PATCH 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Enable dp-controller for peach-pit board.

Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index d6eaa1f..e6199e1 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -61,6 +61,13 @@
 			samsung,pin-pud = <1>;
 			samsung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx2-6";
+			samsung,pin-function = <0>;
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl at 14010000 {
@@ -249,6 +256,33 @@
 		status = "okay";
 	};
 
+	dp-controller at 145B0000 {
+		status = "okay";
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
+		samsung,color-space = <0>;
+		samsung,dynamic-range = <0>;
+		samsung,ycbcr-coeff = <0>;
+		samsung,color-depth = <1>;
+		samsung,link-rate = <0x06>;
+		samsung,lane-count = <2>;
+		samsung,hpd-gpio = <&gpx2 6 0>;
+		display-timings {
+			native-mode = <&timing1>;
+			timing1: timing at 1 {
+				clock-frequency = <70589280>;
+				hactive = <1366>;
+				vactive = <768>;
+				hfront-porch = <40>;
+				hback-porch = <40>;
+				hsync-len = <32>;
+				vback-porch = <10>;
+				vfront-porch = <12>;
+				vsync-len = <6>;
+			};
+		};
+	};
+
 	fimd at 14400000 {
 		status = "okay";
 		samsung,invert-vclk;
-- 
1.7.9.5

Re: [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Arun Kumar K]

Hi,
Tested this whole series on peach-pit board.

Tested-by : Arun Kumar K <arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On Sun, Apr 20, 2014 at 5:18 PM, Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> From: Rahul Sharma <Rahul.Sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Add nodes for fimd and dp controller for exynos5250 based snow
> and exynos5420 based peach-pit board.
>
> This series is based on Kukjin Kims, for-next branch.
>
> It is dependent on
> 1) Andrew Bresticker's patch for hpd gpio addition, avilable at
> http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
> 2) Arun's patch for adding peach-pit board dts file at
> http://www.mail-archive.com/linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg28846.html.
>
> Rahul Sharma (5):
>   ARM: dts: move dp hpd line to the board file for exynos5420
>   ARM: dts: enable fimd for exynos5250 based snow board
>   ARM: dts: enable dp-controller for exynos5250 based snow board
>   ARM: dts: enable fimd for exynos5420 based peach-pit board
>   ARM: dts: enable dp-controller for exynos5420 based peach-pit board
>
>  arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
>  arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
>  4 files changed, 78 insertions(+), 7 deletions(-)
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Arun Kumar K]

Hi,
Tested this whole series on peach-pit board.

Tested-by : Arun Kumar K <arun.kk@samsung.com>

On Sun, Apr 20, 2014 at 5:18 PM, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Add nodes for fimd and dp controller for exynos5250 based snow
> and exynos5420 based peach-pit board.
>
> This series is based on Kukjin Kims, for-next branch.
>
> It is dependent on
> 1) Andrew Bresticker's patch for hpd gpio addition, avilable at
> http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
> 2) Arun's patch for adding peach-pit board dts file at
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg28846.html.
>
> Rahul Sharma (5):
>   ARM: dts: move dp hpd line to the board file for exynos5420
>   ARM: dts: enable fimd for exynos5250 based snow board
>   ARM: dts: enable dp-controller for exynos5250 based snow board
>   ARM: dts: enable fimd for exynos5420 based peach-pit board
>   ARM: dts: enable dp-controller for exynos5420 based peach-pit board
>
>  arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
>  arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
>  4 files changed, 78 insertions(+), 7 deletions(-)
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

Hi Kukjin,

The only dependency for this patch is new property "samsung,hpd-gpio" which
is acked by Jingoo Han, Maintainer, exynos DP at
http://oascentral.opensubscriber.com/message/dri-devel@lists.freedesktop.org/17150750.html.

All remaining properties are as per existing DT bindings.

@Jingoo, I want to request you to review the dp-controller nodes for
exynos5420 and 5250.

Please consider it for merge.

Regards,
Rahul Sharma.

On 20 April 2014 17:18, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Ennable dp-controller for snow board.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 09f363d..60cc2a8 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -344,6 +344,33 @@
>                 };
>         };
>
> +       dp-controller@145B0000 {
> +               status = "okay";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&dp_hpd>;
> +               samsung,color-space = <0>;
> +               samsung,dynamic-range = <0>;
> +               samsung,ycbcr-coeff = <0>;
> +               samsung,color-depth = <1>;
> +               samsung,link-rate = <0x0a>;
> +               samsung,lane-count = <2>;
> +               samsung,hpd-gpio = <&gpx0 7 0>;
> +               display-timings {
> +                       native-mode = <&timing1>;
> +                       timing1: timing@1 {
> +                               clock-frequency = <70589280>;
> +                               hactive = <1366>;
> +                               vactive = <768>;
> +                               hfront-porch = <40>;
> +                               hback-porch = <40>;
> +                               hsync-len = <32>;
> +                               vback-porch = <10>;
> +                               vfront-porch = <12>;
> +                               vsync-len = <6>;
> +                       };
> +               };
> +       };
> +
>         fimd@14400000 {
>                 status = "okay";
>                 samsung,invert-vclk;
> --
> 1.7.9.5
>

[PATCH 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

[Rahul Sharma]

Hi Kukjin,

The only dependency for this patch is new property "samsung,hpd-gpio" which
is acked by Jingoo Han, Maintainer, exynos DP at
http://oascentral.opensubscriber.com/message/dri-devel at lists.freedesktop.org/17150750.html.

All remaining properties are as per existing DT bindings.

@Jingoo, I want to request you to review the dp-controller nodes for
exynos5420 and 5250.

Please consider it for merge.

Regards,
Rahul Sharma.

On 20 April 2014 17:18, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Ennable dp-controller for snow board.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-snow.dts |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 09f363d..60cc2a8 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -344,6 +344,33 @@
>                 };
>         };
>
> +       dp-controller at 145B0000 {
> +               status = "okay";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&dp_hpd>;
> +               samsung,color-space = <0>;
> +               samsung,dynamic-range = <0>;
> +               samsung,ycbcr-coeff = <0>;
> +               samsung,color-depth = <1>;
> +               samsung,link-rate = <0x0a>;
> +               samsung,lane-count = <2>;
> +               samsung,hpd-gpio = <&gpx0 7 0>;
> +               display-timings {
> +                       native-mode = <&timing1>;
> +                       timing1: timing at 1 {
> +                               clock-frequency = <70589280>;
> +                               hactive = <1366>;
> +                               vactive = <768>;
> +                               hfront-porch = <40>;
> +                               hback-porch = <40>;
> +                               hsync-len = <32>;
> +                               vback-porch = <10>;
> +                               vfront-porch = <12>;
> +                               vsync-len = <6>;
> +                       };
> +               };
> +       };
> +
>         fimd at 14400000 {
>                 status = "okay";
>                 samsung,invert-vclk;
> --
> 1.7.9.5
>

Re: [PATCH 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

Hi Kukjin,

I have same update for this patch. The new DT property is Acked at
http://oascentral.opensubscriber.com/message/dri-devel@lists.freedesktop.org/17150750.html

Please consider it for merge.

Regards,
Rahul Sharma.

On 20 April 2014 17:18, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Enable dp-controller for peach-pit board.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index d6eaa1f..e6199e1 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -61,6 +61,13 @@
>                         samsung,pin-pud = <1>;
>                         samsung,pin-drv = <0>;
>                 };
> +
> +               dp_hpd: dp_hpd {
> +                       samsung,pins = "gpx2-6";
> +                       samsung,pin-function = <0>;
> +                       samsung,pin-pud = <3>;
> +                       samsung,pin-drv = <0>;
> +               };
>         };
>
>         pinctrl@14010000 {
> @@ -249,6 +256,33 @@
>                 status = "okay";
>         };
>
> +       dp-controller@145B0000 {
> +               status = "okay";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&dp_hpd>;
> +               samsung,color-space = <0>;
> +               samsung,dynamic-range = <0>;
> +               samsung,ycbcr-coeff = <0>;
> +               samsung,color-depth = <1>;
> +               samsung,link-rate = <0x06>;
> +               samsung,lane-count = <2>;
> +               samsung,hpd-gpio = <&gpx2 6 0>;
> +               display-timings {
> +                       native-mode = <&timing1>;
> +                       timing1: timing@1 {
> +                               clock-frequency = <70589280>;
> +                               hactive = <1366>;
> +                               vactive = <768>;
> +                               hfront-porch = <40>;
> +                               hback-porch = <40>;
> +                               hsync-len = <32>;
> +                               vback-porch = <10>;
> +                               vfront-porch = <12>;
> +                               vsync-len = <6>;
> +                       };
> +               };
> +       };
> +
>         fimd@14400000 {
>                 status = "okay";
>                 samsung,invert-vclk;
> --
> 1.7.9.5
>

[PATCH 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

[Rahul Sharma]

Hi Kukjin,

I have same update for this patch. The new DT property is Acked at
http://oascentral.opensubscriber.com/message/dri-devel at lists.freedesktop.org/17150750.html

Please consider it for merge.

Regards,
Rahul Sharma.

On 20 April 2014 17:18, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Enable dp-controller for peach-pit board.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index d6eaa1f..e6199e1 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -61,6 +61,13 @@
>                         samsung,pin-pud = <1>;
>                         samsung,pin-drv = <0>;
>                 };
> +
> +               dp_hpd: dp_hpd {
> +                       samsung,pins = "gpx2-6";
> +                       samsung,pin-function = <0>;
> +                       samsung,pin-pud = <3>;
> +                       samsung,pin-drv = <0>;
> +               };
>         };
>
>         pinctrl at 14010000 {
> @@ -249,6 +256,33 @@
>                 status = "okay";
>         };
>
> +       dp-controller at 145B0000 {
> +               status = "okay";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&dp_hpd>;
> +               samsung,color-space = <0>;
> +               samsung,dynamic-range = <0>;
> +               samsung,ycbcr-coeff = <0>;
> +               samsung,color-depth = <1>;
> +               samsung,link-rate = <0x06>;
> +               samsung,lane-count = <2>;
> +               samsung,hpd-gpio = <&gpx2 6 0>;
> +               display-timings {
> +                       native-mode = <&timing1>;
> +                       timing1: timing at 1 {
> +                               clock-frequency = <70589280>;
> +                               hactive = <1366>;
> +                               vactive = <768>;
> +                               hfront-porch = <40>;
> +                               hback-porch = <40>;
> +                               hsync-len = <32>;
> +                               vback-porch = <10>;
> +                               vfront-porch = <12>;
> +                               vsync-len = <6>;
> +                       };
> +               };
> +       };
> +
>         fimd at 14400000 {
>                 status = "okay";
>                 samsung,invert-vclk;
> --
> 1.7.9.5
>

Re: [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Jingoo Han]

On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Add nodes for fimd and dp controller for exynos5250 based snow
> and exynos5420 based peach-pit board.
> 
> This series is based on Kukjin Kims, for-next branch.
> 
> It is dependent on
> 1) Andrew Bresticker's patch for hpd gpio addition, avilable at
> http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
> 2) Arun's patch for adding peach-pit board dts file at
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg28846.html.

One more thing. These patches were based against the following patches.

3) Rahul Sharma's patch for hdmi support for exynos5 based dt files.
([PATCH 0/7] ARM: dts: enable hdmi for exynos5 based peach and snow boards)
http://www.spinics.net/lists/linux-samsung-soc/msg29011.html

Please check the dependency.
Anyone does not want to waste the time, due to patch breakage.

Best regards,
Jingoo Han

> 
> Rahul Sharma (5):
>   ARM: dts: move dp hpd line to the board file for exynos5420
>   ARM: dts: enable fimd for exynos5250 based snow board
>   ARM: dts: enable dp-controller for exynos5250 based snow board
>   ARM: dts: enable fimd for exynos5420 based peach-pit board
>   ARM: dts: enable dp-controller for exynos5420 based peach-pit board
> 
>  arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
>  arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
>  4 files changed, 78 insertions(+), 7 deletions(-)
> 
> --
> 1.7.9.5

[PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

[Jingoo Han]

On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Add nodes for fimd and dp controller for exynos5250 based snow
> and exynos5420 based peach-pit board.
> 
> This series is based on Kukjin Kims, for-next branch.
> 
> It is dependent on
> 1) Andrew Bresticker's patch for hpd gpio addition, avilable at
> http://www.spinics.net/lists/linux-samsung-soc/msg28827.html
> 2) Arun's patch for adding peach-pit board dts file at
> http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg28846.html.

One more thing. These patches were based against the following patches.

3) Rahul Sharma's patch for hdmi support for exynos5 based dt files.
([PATCH 0/7] ARM: dts: enable hdmi for exynos5 based peach and snow boards)
http://www.spinics.net/lists/linux-samsung-soc/msg29011.html

Please check the dependency.
Anyone does not want to waste the time, due to patch breakage.

Best regards,
Jingoo Han

> 
> Rahul Sharma (5):
>   ARM: dts: move dp hpd line to the board file for exynos5420
>   ARM: dts: enable fimd for exynos5250 based snow board
>   ARM: dts: enable dp-controller for exynos5250 based snow board
>   ARM: dts: enable fimd for exynos5420 based peach-pit board
>   ARM: dts: enable dp-controller for exynos5420 based peach-pit board
> 
>  arch/arm/boot/dts/exynos5250-snow.dts      |   32 +++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   39 ++++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi  |    7 -----
>  arch/arm/boot/dts/exynos5420-smdk5420.dts  |    7 +++++
>  4 files changed, 78 insertions(+), 7 deletions(-)
> 
> --
> 1.7.9.5

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Jingoo Han]

On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Display controller HPD Gpio line is board specific. This patch
> is moving the pinctrl for hpd gpio line to the respective board
> file.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> index e62c8eb..5848c42 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -59,13 +59,6 @@
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> -
> -		dp_hpd: dp_hpd {
> -			samsung,pins = "gpx0-7";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
>  	};

(+cc Doug Anderson, Tomasz Figa)

'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
So, there should be "gpx0-7" part on chip specific dts file such as
'exynos5420-pinctrl.dtsi'.

However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
This is board specific. In my opinion, the following would look
better. In this way, this patch is not necessary.

1. case: Standard HPD pin is used. (smdk5420)
arch/arm/boot/dts/exynos5420-pinctrl.dts
	pinctrl@13400000 {
		dp_hpd: dp_hpd {
			samsung,pins = "gpx0-7";
			samsung,pin-function = <3>;
			samsung,pin-pud = <0>;
			samsung,pin-drv = <0>;
		};
arch/arm/boot/dts/exynos5420-smdk5420.dts
	dp-controller@145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd>;
		...


2. case: non-standard HPD pin such as GPIO is used. (peach pit)
arch/arm/boot/dts/exynos5420-peach-pit.dts
	pinctrl@13400000 {
		dp_hpd: dp_hpd {
			samsung,pins = "gpx2-6";
			samsung,pin-function = <0>;
			samsung,pin-pud = <3>;
			samsung,pin-drv = <0>;
		};
	dp-controller@145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd>;
		...
		samsung,hpd-gpio = <&gpx2 6 0>;

Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
respectively.

A year ago, Doug Anderson and me agreed that standard HPD pin
part should be included to 'exynos5250-pinctrl.dtsi'.
(https://lkml.org/lkml/2013/5/11/134)

Best regards,
Jingoo Han

> 
>  	pinctrl@13410000 {
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 6910485..62d38c8 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -138,6 +138,13 @@
>  			samsung,pin-pud = <1>;
>  			samsung,pin-drv = <0>;
>  		};
> +
> +		dp_hpd: dp_hpd {
> +			samsung,pins = "gpx0-7";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
>  	};
> 
>  	hdmi@14530000 {
> --
> 1.7.9.5

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Jingoo Han]

On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> 
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> 
> Display controller HPD Gpio line is board specific. This patch
> is moving the pinctrl for hpd gpio line to the respective board
> file.
> 
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> index e62c8eb..5848c42 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -59,13 +59,6 @@
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> -
> -		dp_hpd: dp_hpd {
> -			samsung,pins = "gpx0-7";
> -			samsung,pin-function = <3>;
> -			samsung,pin-pud = <0>;
> -			samsung,pin-drv = <0>;
> -		};
>  	};

(+cc Doug Anderson, Tomasz Figa)

'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
So, there should be "gpx0-7" part on chip specific dts file such as
'exynos5420-pinctrl.dtsi'.

However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
This is board specific. In my opinion, the following would look
better. In this way, this patch is not necessary.

1. case: Standard HPD pin is used. (smdk5420)
arch/arm/boot/dts/exynos5420-pinctrl.dts
	pinctrl at 13400000 {
		dp_hpd: dp_hpd {
			samsung,pins = "gpx0-7";
			samsung,pin-function = <3>;
			samsung,pin-pud = <0>;
			samsung,pin-drv = <0>;
		};
arch/arm/boot/dts/exynos5420-smdk5420.dts
	dp-controller at 145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd>;
		...


2. case: non-standard HPD pin such as GPIO is used. (peach pit)
arch/arm/boot/dts/exynos5420-peach-pit.dts
	pinctrl at 13400000 {
		dp_hpd: dp_hpd {
			samsung,pins = "gpx2-6";
			samsung,pin-function = <0>;
			samsung,pin-pud = <3>;
			samsung,pin-drv = <0>;
		};
	dp-controller at 145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd>;
		...
		samsung,hpd-gpio = <&gpx2 6 0>;

Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
respectively.

A year ago, Doug Anderson and me agreed that standard HPD pin
part should be included to 'exynos5250-pinctrl.dtsi'.
(https://lkml.org/lkml/2013/5/11/134)

Best regards,
Jingoo Han

> 
>  	pinctrl at 13410000 {
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 6910485..62d38c8 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -138,6 +138,13 @@
>  			samsung,pin-pud = <1>;
>  			samsung,pin-drv = <0>;
>  		};
> +
> +		dp_hpd: dp_hpd {
> +			samsung,pins = "gpx0-7";
> +			samsung,pin-function = <3>;
> +			samsung,pin-pud = <0>;
> +			samsung,pin-drv = <0>;
> +		};
>  	};
> 
>  	hdmi at 14530000 {
> --
> 1.7.9.5

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

Thanks Jingoo,

On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
> On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Display controller HPD Gpio line is board specific. This patch
>> is moving the pinctrl for hpd gpio line to the respective board
>> file.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> index e62c8eb..5848c42 100644
>> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> @@ -59,13 +59,6 @@
>>                       interrupt-controller;
>>                       #interrupt-cells = <2>;
>>               };
>> -
>> -             dp_hpd: dp_hpd {
>> -                     samsung,pins = "gpx0-7";
>> -                     samsung,pin-function = <3>;
>> -                     samsung,pin-pud = <0>;
>> -                     samsung,pin-drv = <0>;
>> -             };
>>       };
>
> (+cc Doug Anderson, Tomasz Figa)
>
> 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
> So, there should be "gpx0-7" part on chip specific dts file such as
> 'exynos5420-pinctrl.dtsi'.
>
> However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
> This is board specific. In my opinion, the following would look
> better. In this way, this patch is not necessary.
>
> 1. case: Standard HPD pin is used. (smdk5420)
> arch/arm/boot/dts/exynos5420-pinctrl.dts
>         pinctrl@13400000 {
>                 dp_hpd: dp_hpd {
>                         samsung,pins = "gpx0-7";
>                         samsung,pin-function = <3>;
>                         samsung,pin-pud = <0>;
>                         samsung,pin-drv = <0>;
>                 };
> arch/arm/boot/dts/exynos5420-smdk5420.dts
>         dp-controller@145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd>;
>                 ...
>
>
> 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
> arch/arm/boot/dts/exynos5420-peach-pit.dts
>         pinctrl@13400000 {
>                 dp_hpd: dp_hpd {
>                         samsung,pins = "gpx2-6";
>                         samsung,pin-function = <0>;
>                         samsung,pin-pud = <3>;
>                         samsung,pin-drv = <0>;
>                 };
>         dp-controller@145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd>;
>                 ...
>                 samsung,hpd-gpio = <&gpx2 6 0>;
>
> Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
> 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
> respectively.
>
> A year ago, Doug Anderson and me agreed that standard HPD pin
> part should be included to 'exynos5250-pinctrl.dtsi'.
> (https://lkml.org/lkml/2013/5/11/134)
>

I wasn't aware of this discussion. It make sense. I will drop this patch.
I need to choose some other name for this pin, say "peach_dp_hpd".
Let me know if any concern.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>>
>>       pinctrl@13410000 {
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 6910485..62d38c8 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -138,6 +138,13 @@
>>                       samsung,pin-pud = <1>;
>>                       samsung,pin-drv = <0>;
>>               };
>> +
>> +             dp_hpd: dp_hpd {
>> +                     samsung,pins = "gpx0-7";
>> +                     samsung,pin-function = <3>;
>> +                     samsung,pin-pud = <0>;
>> +                     samsung,pin-drv = <0>;
>> +             };
>>       };
>>
>>       hdmi@14530000 {
>> --
>> 1.7.9.5
>

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

Thanks Jingoo,

On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
> On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Display controller HPD Gpio line is board specific. This patch
>> is moving the pinctrl for hpd gpio line to the respective board
>> file.
>>
>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> index e62c8eb..5848c42 100644
>> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> @@ -59,13 +59,6 @@
>>                       interrupt-controller;
>>                       #interrupt-cells = <2>;
>>               };
>> -
>> -             dp_hpd: dp_hpd {
>> -                     samsung,pins = "gpx0-7";
>> -                     samsung,pin-function = <3>;
>> -                     samsung,pin-pud = <0>;
>> -                     samsung,pin-drv = <0>;
>> -             };
>>       };
>
> (+cc Doug Anderson, Tomasz Figa)
>
> 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
> So, there should be "gpx0-7" part on chip specific dts file such as
> 'exynos5420-pinctrl.dtsi'.
>
> However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
> This is board specific. In my opinion, the following would look
> better. In this way, this patch is not necessary.
>
> 1. case: Standard HPD pin is used. (smdk5420)
> arch/arm/boot/dts/exynos5420-pinctrl.dts
>         pinctrl at 13400000 {
>                 dp_hpd: dp_hpd {
>                         samsung,pins = "gpx0-7";
>                         samsung,pin-function = <3>;
>                         samsung,pin-pud = <0>;
>                         samsung,pin-drv = <0>;
>                 };
> arch/arm/boot/dts/exynos5420-smdk5420.dts
>         dp-controller at 145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd>;
>                 ...
>
>
> 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
> arch/arm/boot/dts/exynos5420-peach-pit.dts
>         pinctrl at 13400000 {
>                 dp_hpd: dp_hpd {
>                         samsung,pins = "gpx2-6";
>                         samsung,pin-function = <0>;
>                         samsung,pin-pud = <3>;
>                         samsung,pin-drv = <0>;
>                 };
>         dp-controller at 145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd>;
>                 ...
>                 samsung,hpd-gpio = <&gpx2 6 0>;
>
> Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
> 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
> respectively.
>
> A year ago, Doug Anderson and me agreed that standard HPD pin
> part should be included to 'exynos5250-pinctrl.dtsi'.
> (https://lkml.org/lkml/2013/5/11/134)
>

I wasn't aware of this discussion. It make sense. I will drop this patch.
I need to choose some other name for this pin, say "peach_dp_hpd".
Let me know if any concern.

Regards,
Rahul Sharma.

> Best regards,
> Jingoo Han
>
>>
>>       pinctrl at 13410000 {
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 6910485..62d38c8 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -138,6 +138,13 @@
>>                       samsung,pin-pud = <1>;
>>                       samsung,pin-drv = <0>;
>>               };
>> +
>> +             dp_hpd: dp_hpd {
>> +                     samsung,pins = "gpx0-7";
>> +                     samsung,pin-function = <3>;
>> +                     samsung,pin-pud = <0>;
>> +                     samsung,pin-drv = <0>;
>> +             };
>>       };
>>
>>       hdmi at 14530000 {
>> --
>> 1.7.9.5
>

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Jingoo Han]

On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote:
> On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> >>
> >> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> >>
> >> Display controller HPD Gpio line is board specific. This patch
> >> is moving the pinctrl for hpd gpio line to the respective board
> >> file.
> >>
> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
> >>  2 files changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> index e62c8eb..5848c42 100644
> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> @@ -59,13 +59,6 @@
> >>                       interrupt-controller;
> >>                       #interrupt-cells = <2>;
> >>               };
> >> -
> >> -             dp_hpd: dp_hpd {
> >> -                     samsung,pins = "gpx0-7";
> >> -                     samsung,pin-function = <3>;
> >> -                     samsung,pin-pud = <0>;
> >> -                     samsung,pin-drv = <0>;
> >> -             };
> >>       };
> >
> > (+cc Doug Anderson, Tomasz Figa)
> >
> > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
> > So, there should be "gpx0-7" part on chip specific dts file such as
> > 'exynos5420-pinctrl.dtsi'.
> >
> > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
> > This is board specific. In my opinion, the following would look
> > better. In this way, this patch is not necessary.
> >
> > 1. case: Standard HPD pin is used. (smdk5420)
> > arch/arm/boot/dts/exynos5420-pinctrl.dts
> >         pinctrl@13400000 {
> >                 dp_hpd: dp_hpd {
> >                         samsung,pins = "gpx0-7";
> >                         samsung,pin-function = <3>;
> >                         samsung,pin-pud = <0>;
> >                         samsung,pin-drv = <0>;
> >                 };
> > arch/arm/boot/dts/exynos5420-smdk5420.dts
> >         dp-controller@145B0000 {
> >                 pinctrl-names = "default";
> >                 pinctrl-0 = <&dp_hpd>;
> >                 ...
> >
> >
> > 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
> > arch/arm/boot/dts/exynos5420-peach-pit.dts
> >         pinctrl@13400000 {
> >                 dp_hpd: dp_hpd {
> >                         samsung,pins = "gpx2-6";
> >                         samsung,pin-function = <0>;
> >                         samsung,pin-pud = <3>;
> >                         samsung,pin-drv = <0>;
> >                 };
> >         dp-controller@145B0000 {
> >                 pinctrl-names = "default";
> >                 pinctrl-0 = <&dp_hpd>;
> >                 ...
> >                 samsung,hpd-gpio = <&gpx2 6 0>;
> >
> > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
> > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
> > respectively.
> >
> > A year ago, Doug Anderson and me agreed that standard HPD pin
> > part should be included to 'exynos5250-pinctrl.dtsi'.
> > (https://lkml.org/lkml/2013/5/11/134)
> >
> 
> I wasn't aware of this discussion. It make sense. I will drop this patch.
> I need to choose some other name for this pin, say "peach_dp_hpd".
> Let me know if any concern.

In my opinion, "dp_hpd_gpio" looks better as below.

arch/arm/boot/dts/exynos5420-peach-pit.dts
	pinctrl@13400000 {
		dp_hpd_gpio: dp_hpd_gpio {
			samsung,pins = "gpx2-6";
			samsung,pin-function = <0>;
			samsung,pin-pud = <3>;
			samsung,pin-drv = <0>;
		};
	dp-controller@145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd_gpio>;
		...
		samsung,hpd-gpio = <&gpx2 6 0>;

Best regards,
Jingoo Han

> 
> Regards,
> Rahul Sharma.
> 
> > Best regards,
> > Jingoo Han
> >
> >>
> >>       pinctrl@13410000 {
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> index 6910485..62d38c8 100644
> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -138,6 +138,13 @@
> >>                       samsung,pin-pud = <1>;
> >>                       samsung,pin-drv = <0>;
> >>               };
> >> +
> >> +             dp_hpd: dp_hpd {
> >> +                     samsung,pins = "gpx0-7";
> >> +                     samsung,pin-function = <3>;
> >> +                     samsung,pin-pud = <0>;
> >> +                     samsung,pin-drv = <0>;
> >> +             };
> >>       };
> >>
> >>       hdmi@14530000 {
> >> --
> >> 1.7.9.5
> >

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Jingoo Han]

On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote:
> On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
> >>
> >> From: Rahul Sharma <Rahul.Sharma@samsung.com>
> >>
> >> Display controller HPD Gpio line is board specific. This patch
> >> is moving the pinctrl for hpd gpio line to the respective board
> >> file.
> >>
> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
> >>  2 files changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> index e62c8eb..5848c42 100644
> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> @@ -59,13 +59,6 @@
> >>                       interrupt-controller;
> >>                       #interrupt-cells = <2>;
> >>               };
> >> -
> >> -             dp_hpd: dp_hpd {
> >> -                     samsung,pins = "gpx0-7";
> >> -                     samsung,pin-function = <3>;
> >> -                     samsung,pin-pud = <0>;
> >> -                     samsung,pin-drv = <0>;
> >> -             };
> >>       };
> >
> > (+cc Doug Anderson, Tomasz Figa)
> >
> > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
> > So, there should be "gpx0-7" part on chip specific dts file such as
> > 'exynos5420-pinctrl.dtsi'.
> >
> > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
> > This is board specific. In my opinion, the following would look
> > better. In this way, this patch is not necessary.
> >
> > 1. case: Standard HPD pin is used. (smdk5420)
> > arch/arm/boot/dts/exynos5420-pinctrl.dts
> >         pinctrl at 13400000 {
> >                 dp_hpd: dp_hpd {
> >                         samsung,pins = "gpx0-7";
> >                         samsung,pin-function = <3>;
> >                         samsung,pin-pud = <0>;
> >                         samsung,pin-drv = <0>;
> >                 };
> > arch/arm/boot/dts/exynos5420-smdk5420.dts
> >         dp-controller at 145B0000 {
> >                 pinctrl-names = "default";
> >                 pinctrl-0 = <&dp_hpd>;
> >                 ...
> >
> >
> > 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
> > arch/arm/boot/dts/exynos5420-peach-pit.dts
> >         pinctrl at 13400000 {
> >                 dp_hpd: dp_hpd {
> >                         samsung,pins = "gpx2-6";
> >                         samsung,pin-function = <0>;
> >                         samsung,pin-pud = <3>;
> >                         samsung,pin-drv = <0>;
> >                 };
> >         dp-controller at 145B0000 {
> >                 pinctrl-names = "default";
> >                 pinctrl-0 = <&dp_hpd>;
> >                 ...
> >                 samsung,hpd-gpio = <&gpx2 6 0>;
> >
> > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
> > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
> > respectively.
> >
> > A year ago, Doug Anderson and me agreed that standard HPD pin
> > part should be included to 'exynos5250-pinctrl.dtsi'.
> > (https://lkml.org/lkml/2013/5/11/134)
> >
> 
> I wasn't aware of this discussion. It make sense. I will drop this patch.
> I need to choose some other name for this pin, say "peach_dp_hpd".
> Let me know if any concern.

In my opinion, "dp_hpd_gpio" looks better as below.

arch/arm/boot/dts/exynos5420-peach-pit.dts
	pinctrl at 13400000 {
		dp_hpd_gpio: dp_hpd_gpio {
			samsung,pins = "gpx2-6";
			samsung,pin-function = <0>;
			samsung,pin-pud = <3>;
			samsung,pin-drv = <0>;
		};
	dp-controller at 145B0000 {
		pinctrl-names = "default";
		pinctrl-0 = <&dp_hpd_gpio>;
		...
		samsung,hpd-gpio = <&gpx2 6 0>;

Best regards,
Jingoo Han

> 
> Regards,
> Rahul Sharma.
> 
> > Best regards,
> > Jingoo Han
> >
> >>
> >>       pinctrl at 13410000 {
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> index 6910485..62d38c8 100644
> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -138,6 +138,13 @@
> >>                       samsung,pin-pud = <1>;
> >>                       samsung,pin-drv = <0>;
> >>               };
> >> +
> >> +             dp_hpd: dp_hpd {
> >> +                     samsung,pins = "gpx0-7";
> >> +                     samsung,pin-function = <3>;
> >> +                     samsung,pin-pud = <0>;
> >> +                     samsung,pin-drv = <0>;
> >> +             };
> >>       };
> >>
> >>       hdmi at 14530000 {
> >> --
> >> 1.7.9.5
> >

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

On 9 May 2014 06:15, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote:
>> On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
>> > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
>> >>
>> >> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>> >>
>> >> Display controller HPD Gpio line is board specific. This patch
>> >> is moving the pinctrl for hpd gpio line to the respective board
>> >> file.
>> >>
>> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> >> ---
>> >>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>> >>  2 files changed, 7 insertions(+), 7 deletions(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> index e62c8eb..5848c42 100644
>> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> @@ -59,13 +59,6 @@
>> >>                       interrupt-controller;
>> >>                       #interrupt-cells = <2>;
>> >>               };
>> >> -
>> >> -             dp_hpd: dp_hpd {
>> >> -                     samsung,pins = "gpx0-7";
>> >> -                     samsung,pin-function = <3>;
>> >> -                     samsung,pin-pud = <0>;
>> >> -                     samsung,pin-drv = <0>;
>> >> -             };
>> >>       };
>> >
>> > (+cc Doug Anderson, Tomasz Figa)
>> >
>> > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
>> > So, there should be "gpx0-7" part on chip specific dts file such as
>> > 'exynos5420-pinctrl.dtsi'.
>> >
>> > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
>> > This is board specific. In my opinion, the following would look
>> > better. In this way, this patch is not necessary.
>> >
>> > 1. case: Standard HPD pin is used. (smdk5420)
>> > arch/arm/boot/dts/exynos5420-pinctrl.dts
>> >         pinctrl@13400000 {
>> >                 dp_hpd: dp_hpd {
>> >                         samsung,pins = "gpx0-7";
>> >                         samsung,pin-function = <3>;
>> >                         samsung,pin-pud = <0>;
>> >                         samsung,pin-drv = <0>;
>> >                 };
>> > arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >         dp-controller@145B0000 {
>> >                 pinctrl-names = "default";
>> >                 pinctrl-0 = <&dp_hpd>;
>> >                 ...
>> >
>> >
>> > 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
>> > arch/arm/boot/dts/exynos5420-peach-pit.dts
>> >         pinctrl@13400000 {
>> >                 dp_hpd: dp_hpd {
>> >                         samsung,pins = "gpx2-6";
>> >                         samsung,pin-function = <0>;
>> >                         samsung,pin-pud = <3>;
>> >                         samsung,pin-drv = <0>;
>> >                 };
>> >         dp-controller@145B0000 {
>> >                 pinctrl-names = "default";
>> >                 pinctrl-0 = <&dp_hpd>;
>> >                 ...
>> >                 samsung,hpd-gpio = <&gpx2 6 0>;
>> >
>> > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
>> > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
>> > respectively.
>> >
>> > A year ago, Doug Anderson and me agreed that standard HPD pin
>> > part should be included to 'exynos5250-pinctrl.dtsi'.
>> > (https://lkml.org/lkml/2013/5/11/134)
>> >
>>
>> I wasn't aware of this discussion. It make sense. I will drop this patch.
>> I need to choose some other name for this pin, say "peach_dp_hpd".
>> Let me know if any concern.
>
> In my opinion, "dp_hpd_gpio" looks better as below.
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts
>         pinctrl@13400000 {
>                 dp_hpd_gpio: dp_hpd_gpio {
>                         samsung,pins = "gpx2-6";
>                         samsung,pin-function = <0>;
>                         samsung,pin-pud = <3>;
>                         samsung,pin-drv = <0>;
>                 };
>         dp-controller@145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd_gpio>;
>                 ...
>                 samsung,hpd-gpio = <&gpx2 6 0>;

Ok.

>
> Best regards,
> Jingoo Han
>
>>
>> Regards,
>> Rahul Sharma.
>>
>> > Best regards,
>> > Jingoo Han
>> >
>> >>
>> >>       pinctrl@13410000 {
>> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> index 6910485..62d38c8 100644
>> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> @@ -138,6 +138,13 @@
>> >>                       samsung,pin-pud = <1>;
>> >>                       samsung,pin-drv = <0>;
>> >>               };
>> >> +
>> >> +             dp_hpd: dp_hpd {
>> >> +                     samsung,pins = "gpx0-7";
>> >> +                     samsung,pin-function = <3>;
>> >> +                     samsung,pin-pud = <0>;
>> >> +                     samsung,pin-drv = <0>;
>> >> +             };
>> >>       };
>> >>
>> >>       hdmi@14530000 {
>> >> --
>> >> 1.7.9.5
>> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

[Rahul Sharma]

On 9 May 2014 06:15, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote:
>> On 8 May 2014 12:02, Jingoo Han <jg1.han@samsung.com> wrote:
>> > On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote:
>> >>
>> >> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>> >>
>> >> Display controller HPD Gpio line is board specific. This patch
>> >> is moving the pinctrl for hpd gpio line to the respective board
>> >> file.
>> >>
>> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
>> >> ---
>> >>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi |    7 -------
>> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    7 +++++++
>> >>  2 files changed, 7 insertions(+), 7 deletions(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> index e62c8eb..5848c42 100644
>> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> >> @@ -59,13 +59,6 @@
>> >>                       interrupt-controller;
>> >>                       #interrupt-cells = <2>;
>> >>               };
>> >> -
>> >> -             dp_hpd: dp_hpd {
>> >> -                     samsung,pins = "gpx0-7";
>> >> -                     samsung,pin-function = <3>;
>> >> -                     samsung,pin-pud = <0>;
>> >> -                     samsung,pin-drv = <0>;
>> >> -             };
>> >>       };
>> >
>> > (+cc Doug Anderson, Tomasz Figa)
>> >
>> > 'gpx0-7' pin is assigned for standard HPD pin. This is chip specific.
>> > So, there should be "gpx0-7" part on chip specific dts file such as
>> > 'exynos5420-pinctrl.dtsi'.
>> >
>> > However, some boards use GPIO as HPD pin, instead of 'gpx0-7' pin.
>> > This is board specific. In my opinion, the following would look
>> > better. In this way, this patch is not necessary.
>> >
>> > 1. case: Standard HPD pin is used. (smdk5420)
>> > arch/arm/boot/dts/exynos5420-pinctrl.dts
>> >         pinctrl at 13400000 {
>> >                 dp_hpd: dp_hpd {
>> >                         samsung,pins = "gpx0-7";
>> >                         samsung,pin-function = <3>;
>> >                         samsung,pin-pud = <0>;
>> >                         samsung,pin-drv = <0>;
>> >                 };
>> > arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >         dp-controller at 145B0000 {
>> >                 pinctrl-names = "default";
>> >                 pinctrl-0 = <&dp_hpd>;
>> >                 ...
>> >
>> >
>> > 2. case: non-standard HPD pin such as GPIO is used. (peach pit)
>> > arch/arm/boot/dts/exynos5420-peach-pit.dts
>> >         pinctrl at 13400000 {
>> >                 dp_hpd: dp_hpd {
>> >                         samsung,pins = "gpx2-6";
>> >                         samsung,pin-function = <0>;
>> >                         samsung,pin-pud = <3>;
>> >                         samsung,pin-drv = <0>;
>> >                 };
>> >         dp-controller at 145B0000 {
>> >                 pinctrl-names = "default";
>> >                 pinctrl-0 = <&dp_hpd>;
>> >                 ...
>> >                 samsung,hpd-gpio = <&gpx2 6 0>;
>> >
>> > Even though, there is 'dp_hpd' in exynos5420-pinctrl.dts,
>> > 'smdk5420' and 'peach pit' can use "gpx0-7" and "gpx2-6",
>> > respectively.
>> >
>> > A year ago, Doug Anderson and me agreed that standard HPD pin
>> > part should be included to 'exynos5250-pinctrl.dtsi'.
>> > (https://lkml.org/lkml/2013/5/11/134)
>> >
>>
>> I wasn't aware of this discussion. It make sense. I will drop this patch.
>> I need to choose some other name for this pin, say "peach_dp_hpd".
>> Let me know if any concern.
>
> In my opinion, "dp_hpd_gpio" looks better as below.
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts
>         pinctrl at 13400000 {
>                 dp_hpd_gpio: dp_hpd_gpio {
>                         samsung,pins = "gpx2-6";
>                         samsung,pin-function = <0>;
>                         samsung,pin-pud = <3>;
>                         samsung,pin-drv = <0>;
>                 };
>         dp-controller at 145B0000 {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&dp_hpd_gpio>;
>                 ...
>                 samsung,hpd-gpio = <&gpx2 6 0>;

Ok.

>
> Best regards,
> Jingoo Han
>
>>
>> Regards,
>> Rahul Sharma.
>>
>> > Best regards,
>> > Jingoo Han
>> >
>> >>
>> >>       pinctrl at 13410000 {
>> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> index 6910485..62d38c8 100644
>> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> >> @@ -138,6 +138,13 @@
>> >>                       samsung,pin-pud = <1>;
>> >>                       samsung,pin-drv = <0>;
>> >>               };
>> >> +
>> >> +             dp_hpd: dp_hpd {
>> >> +                     samsung,pins = "gpx0-7";
>> >> +                     samsung,pin-function = <3>;
>> >> +                     samsung,pin-pud = <0>;
>> >> +                     samsung,pin-drv = <0>;
>> >> +             };
>> >>       };
>> >>
>> >>       hdmi at 14530000 {
>> >> --
>> >> 1.7.9.5
>> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel