All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback
@ 2018-07-27  8:27 Chris Wilson
  2018-07-27  8:27 ` [igt-dev] [PATCH i-g-t 2/2] intel-ci: Move uABI hang testing to shards Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2018-07-27  8:27 UTC (permalink / raw)
  To: igt-dev; +Cc: Tomi Sarvela, Martin Peres

Basic gem_exec_flush coherency checking is performed by
drv_selftests/live_coherency, so we do not need to duplicate coverage
with BAT. However, we do want to keep the uABI checking for the shards.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 2e1abf239..b6557ef3f 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -49,21 +49,6 @@ igt@gem_exec_fence@basic-wait-default
 igt@gem_exec_fence@basic-await-default
 igt@gem_exec_fence@await-hang-default
 igt@gem_exec_fence@nb-await-default
-igt@gem_exec_flush@basic-batch-kernel-default-cmd
-igt@gem_exec_flush@basic-batch-kernel-default-uc
-igt@gem_exec_flush@basic-batch-kernel-default-wb
-igt@gem_exec_flush@basic-uc-pro-default
-igt@gem_exec_flush@basic-uc-prw-default
-igt@gem_exec_flush@basic-uc-ro-default
-igt@gem_exec_flush@basic-uc-rw-default
-igt@gem_exec_flush@basic-uc-set-default
-igt@gem_exec_flush@basic-wb-pro-default
-igt@gem_exec_flush@basic-wb-prw-default
-igt@gem_exec_flush@basic-wb-ro-before-default
-igt@gem_exec_flush@basic-wb-ro-default
-igt@gem_exec_flush@basic-wb-rw-before-default
-igt@gem_exec_flush@basic-wb-rw-default
-igt@gem_exec_flush@basic-wb-set-default
 igt@gem_exec_gttfill@basic
 igt@gem_exec_nop@basic-parallel
 igt@gem_exec_nop@basic-series
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [igt-dev] [PATCH i-g-t 2/2] intel-ci: Move uABI hang testing to shards
  2018-07-27  8:27 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback Chris Wilson
@ 2018-07-27  8:27 ` Chris Wilson
  2018-07-27 10:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Remove gem_exec_flush from fast-feedback Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-07-27  8:27 UTC (permalink / raw)
  To: igt-dev; +Cc: Tomi Sarvela, Martin Peres

The foundational property of the driver to reset and recover hung
hardware is covered by drv_selftests/live_hangcheck; that is all we need
inside BAT. Beyond that checking the uABI behaves under hangs, and even
wedging, remains covered by post-ff testing in the shards.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
---
 tests/intel-ci/blacklist.txt          | 2 +-
 tests/intel-ci/fast-feedback.testlist | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index d65d8ff35..1d1652964 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -4,7 +4,7 @@ igt@meta_test(@.*)?
 ###############################################
 igt@drv_selftest(@.*)?
 igt@drm_mm(@.*)?
-igt@gem_busy@.*hang.*
+igt@gem_busy@(?!.*basic).*hang.*
 igt@gem_close_race@(?!.*basic).*
 igt@gem_concurrent_blit(@.*)?
 igt@gem_cs_prefetch(@.*)?
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index b6557ef3f..510024c15 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -10,7 +10,6 @@ igt@gem_basic@bad-close
 igt@gem_basic@create-close
 igt@gem_basic@create-fd-close
 igt@gem_busy@basic-busy-default
-igt@gem_busy@basic-hang-default
 igt@gem_close_race@basic-process
 igt@gem_close_race@basic-threads
 igt@gem_cpu_reloc@basic
@@ -47,7 +46,6 @@ igt@gem_exec_create@basic
 igt@gem_exec_fence@basic-busy-default
 igt@gem_exec_fence@basic-wait-default
 igt@gem_exec_fence@basic-await-default
-igt@gem_exec_fence@await-hang-default
 igt@gem_exec_fence@nb-await-default
 igt@gem_exec_gttfill@basic
 igt@gem_exec_nop@basic-parallel
@@ -130,7 +128,6 @@ igt@gem_ringfill@basic-default
 igt@gem_ringfill@basic-default-interruptible
 igt@gem_ringfill@basic-default-forked
 igt@gem_ringfill@basic-default-fd
-igt@gem_ringfill@basic-default-hang
 igt@gem_sync@basic-all
 igt@gem_sync@basic-each
 igt@gem_sync@basic-many-each
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Remove gem_exec_flush from fast-feedback
  2018-07-27  8:27 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback Chris Wilson
  2018-07-27  8:27 ` [igt-dev] [PATCH i-g-t 2/2] intel-ci: Move uABI hang testing to shards Chris Wilson
@ 2018-07-27 10:46 ` Patchwork
  2018-07-31  6:13 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
  2018-07-31  9:26 ` Tomi Sarvela
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-07-27 10:46 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] intel-ci: Remove gem_exec_flush from fast-feedback
URL   : https://patchwork.freedesktop.org/series/47327/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4547 -> IGTPW_1658 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1658 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1658, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47327/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1658:

  === IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      {fi-icl-u}:         NOTRUN -> DMESG-WARN

    igt@drv_module_reload@basic-reload-inject:
      fi-pnv-d510:        NOTRUN -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_1658 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-no-display:
      fi-cnl-psr:         NOTRUN -> DMESG-WARN (fdo#105395) +2

    igt@gem_exec_suspend@basic-s3:
      {fi-skl-caroline}:  NOTRUN -> INCOMPLETE (fdo#104108)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       PASS -> DMESG-WARN (fdo#105128, fdo#107139)

    igt@gem_workarounds@basic-read:
      {fi-icl-u}:         NOTRUN -> FAIL (fdo#107338)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      {fi-icl-u}:         NOTRUN -> DMESG-WARN (fdo#107382) +4

    {igt@kms_psr@cursor_plane_move}:
      fi-cnl-psr:         NOTRUN -> DMESG-FAIL (fdo#107372) +1

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         NOTRUN -> DMESG-WARN (fdo#107372)

    {igt@kms_psr@primary_page_flip}:
      {fi-icl-u}:         NOTRUN -> FAIL (fdo#107383) +3

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload:
      fi-glk-j4005:       DMESG-WARN (fdo#106725, fdo#106248) -> PASS

    igt@gem_exec_create@basic:
      fi-glk-j4005:       DMESG-WARN (fdo#106745) -> PASS

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       FAIL (fdo#100368) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
  fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
  fdo#106745 https://bugs.freedesktop.org/show_bug.cgi?id=106745
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107338 https://bugs.freedesktop.org/show_bug.cgi?id=107338
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
  fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383


== Participating hosts (48 -> 47) ==

  Additional (5): fi-byt-j1900 fi-skl-caroline fi-icl-u fi-cnl-psr fi-pnv-d510 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper 


== Build changes ==

    * IGT: IGT_4575 -> IGTPW_1658

  CI_DRM_4547: 0a7ab192a697e951b2404f3c1ce42c5fa74f9ed1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1658: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1658/
  IGT_4575: fe908a01012c9daafafb3410b9407725ca9d4f21 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1658/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback
  2018-07-27  8:27 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback Chris Wilson
  2018-07-27  8:27 ` [igt-dev] [PATCH i-g-t 2/2] intel-ci: Move uABI hang testing to shards Chris Wilson
  2018-07-27 10:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Remove gem_exec_flush from fast-feedback Patchwork
@ 2018-07-31  6:13 ` Petri Latvala
  2018-07-31  9:26 ` Tomi Sarvela
  3 siblings, 0 replies; 5+ messages in thread
From: Petri Latvala @ 2018-07-31  6:13 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, Tomi Sarvela, Martin Peres

On Fri, Jul 27, 2018 at 09:27:33AM +0100, Chris Wilson wrote:
> Basic gem_exec_flush coherency checking is performed by
> drv_selftests/live_coherency, so we do not need to duplicate coverage
> with BAT. However, we do want to keep the uABI checking for the shards.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 15 ---------------
>  1 file changed, 15 deletions(-)


Both patches

Acked-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback
  2018-07-27  8:27 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback Chris Wilson
                   ` (2 preceding siblings ...)
  2018-07-31  6:13 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
@ 2018-07-31  9:26 ` Tomi Sarvela
  3 siblings, 0 replies; 5+ messages in thread
From: Tomi Sarvela @ 2018-07-31  9:26 UTC (permalink / raw)
  To: Chris Wilson, igt-dev; +Cc: Martin Peres

On 07/27/2018 11:27 AM, Chris Wilson wrote:
> Basic gem_exec_flush coherency checking is performed by
> drv_selftests/live_coherency, so we do not need to duplicate coverage
> with BAT. However, we do want to keep the uABI checking for the shards.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> ---
>   tests/intel-ci/fast-feedback.testlist | 15 ---------------
>   1 file changed, 15 deletions(-)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 2e1abf239..b6557ef3f 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -49,21 +49,6 @@ igt@gem_exec_fence@basic-wait-default
>   igt@gem_exec_fence@basic-await-default
>   igt@gem_exec_fence@await-hang-default
>   igt@gem_exec_fence@nb-await-default
> -igt@gem_exec_flush@basic-batch-kernel-default-cmd
> -igt@gem_exec_flush@basic-batch-kernel-default-uc
> -igt@gem_exec_flush@basic-batch-kernel-default-wb
> -igt@gem_exec_flush@basic-uc-pro-default
> -igt@gem_exec_flush@basic-uc-prw-default
> -igt@gem_exec_flush@basic-uc-ro-default
> -igt@gem_exec_flush@basic-uc-rw-default
> -igt@gem_exec_flush@basic-uc-set-default
> -igt@gem_exec_flush@basic-wb-pro-default
> -igt@gem_exec_flush@basic-wb-prw-default
> -igt@gem_exec_flush@basic-wb-ro-before-default
> -igt@gem_exec_flush@basic-wb-ro-default
> -igt@gem_exec_flush@basic-wb-rw-before-default
> -igt@gem_exec_flush@basic-wb-rw-default
> -igt@gem_exec_flush@basic-wb-set-default
>   igt@gem_exec_gttfill@basic
>   igt@gem_exec_nop@basic-parallel
>   igt@gem_exec_nop@basic-series
> 

Each test takes 5 seconds to pass, so this shaves over a minute off from 
fast-feedback.

Acked-by: Tomi Sarvela <tomi.p.sarvela@intel.com>

Tomi
-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-07-31  9:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27  8:27 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Remove gem_exec_flush from fast-feedback Chris Wilson
2018-07-27  8:27 ` [igt-dev] [PATCH i-g-t 2/2] intel-ci: Move uABI hang testing to shards Chris Wilson
2018-07-27 10:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Remove gem_exec_flush from fast-feedback Patchwork
2018-07-31  6:13 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
2018-07-31  9:26 ` Tomi Sarvela

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.