* [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:15 Jingoo Han
0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-05-07 6:15 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, 'Viresh Kumar', 'David Woodhouse'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/devices/spear_smi.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 8a82b8b..e290ef8 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
if (ret) {
dev_err(&dev->pdev->dev, "bank setup failed\n");
- goto err_bank_setup;
+ goto err_irq;
}
}
return 0;
-err_bank_setup:
- platform_set_drvdata(pdev, NULL);
err_irq:
clk_disable_unprepare(dev->clk);
err:
@@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
}
clk_disable_unprepare(dev->clk);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
2013-05-07 6:17 Jingoo Han
@ 2013-07-01 7:27 ` Artem Bityutskiy
0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2013-07-01 7:27 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-mtd, 'David Woodhouse', Viresh Kumar
On Tue, 2013-05-07 at 15:17 +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Pushed the series to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
2013-05-07 6:25 Jingoo Han
2013-05-13 4:15 ` Viresh Kumar
@ 2013-06-25 1:19 ` Jingoo Han
1 sibling, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-06-25 1:19 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: 'Roland Stigge', 'Marc Kleine-Budde',
'Mike Dunn', 'Artem Bityutskiy',
'Viresh Kumar', Jingoo Han, 'Josh Wu',
linux-mtd, 'Gupta, Pekon', 'Shawn Guo',
'David Woodhouse'
On Tuesday, May 07, 2013 3:26 PM, Jingoo Han wrote:
>
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Hi Artem Bityutskiy,
I will squash everything down into one patch with the ACKs,
and send it again.
Best regards,
Jingoo Han
> ---
> drivers/mtd/devices/spear_smi.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
> index 8a82b8b..e290ef8 100644
> --- a/drivers/mtd/devices/spear_smi.c
> +++ b/drivers/mtd/devices/spear_smi.c
> @@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
> ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
> if (ret) {
> dev_err(&dev->pdev->dev, "bank setup failed\n");
> - goto err_bank_setup;
> + goto err_irq;
> }
> }
>
> return 0;
>
> -err_bank_setup:
> - platform_set_drvdata(pdev, NULL);
> err_irq:
> clk_disable_unprepare(dev->clk);
> err:
> @@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
> }
>
> clk_disable_unprepare(dev->clk);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
2013-05-07 6:25 Jingoo Han
@ 2013-05-13 4:15 ` Viresh Kumar
2013-06-25 1:19 ` Jingoo Han
1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2013-05-13 4:15 UTC (permalink / raw)
To: Jingoo Han; +Cc: Artem Bityutskiy, David Woodhouse, linux-mtd
On 7 May 2013 11:55, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mtd/devices/spear_smi.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
> index 8a82b8b..e290ef8 100644
> --- a/drivers/mtd/devices/spear_smi.c
> +++ b/drivers/mtd/devices/spear_smi.c
> @@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
> ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
> if (ret) {
> dev_err(&dev->pdev->dev, "bank setup failed\n");
> - goto err_bank_setup;
> + goto err_irq;
> }
> }
>
> return 0;
>
> -err_bank_setup:
> - platform_set_drvdata(pdev, NULL);
> err_irq:
> clk_disable_unprepare(dev->clk);
> err:
> @@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
> }
>
> clk_disable_unprepare(dev->clk);
> - platform_set_drvdata(pdev, NULL);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:25 Jingoo Han
2013-05-13 4:15 ` Viresh Kumar
2013-06-25 1:19 ` Jingoo Han
0 siblings, 2 replies; 6+ messages in thread
From: Jingoo Han @ 2013-05-07 6:25 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse', Viresh Kumar
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/devices/spear_smi.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 8a82b8b..e290ef8 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
if (ret) {
dev_err(&dev->pdev->dev, "bank setup failed\n");
- goto err_bank_setup;
+ goto err_irq;
}
}
return 0;
-err_bank_setup:
- platform_set_drvdata(pdev, NULL);
err_irq:
clk_disable_unprepare(dev->clk);
err:
@@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
}
clk_disable_unprepare(dev->clk);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:17 Jingoo Han
2013-07-01 7:27 ` Artem Bityutskiy
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-05-07 6:17 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse', Viresh Kumar
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/devices/spear_smi.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 8a82b8b..e290ef8 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
if (ret) {
dev_err(&dev->pdev->dev, "bank setup failed\n");
- goto err_bank_setup;
+ goto err_irq;
}
}
return 0;
-err_bank_setup:
- platform_set_drvdata(pdev, NULL);
err_irq:
clk_disable_unprepare(dev->clk);
err:
@@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
}
clk_disable_unprepare(dev->clk);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-01 7:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 6:15 [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 6:17 Jingoo Han
2013-07-01 7:27 ` Artem Bityutskiy
2013-05-07 6:25 Jingoo Han
2013-05-13 4:15 ` Viresh Kumar
2013-06-25 1:19 ` Jingoo Han
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.