[Fuego] eval considered harmful

[Fuego] eval considered harmful

[Bird, Timothy]

Daniel,

I noticed an issue with the 'local' transport.  It uses "eval" in ov_transport_cmd().
However, if the command is to change directory (cd), then this changes the
directory in the current shell.  This can wreak havoc on the Fuego script system,
which expects that stuff that happens on the target board does not affect
the shell environment.

I changed this to using a shell invocation: /bin/sh -c "$@".

This is in my 'next' branch.  Let me know if you have any questions.
 -- Tim

Re: [Fuego] eval considered harmful

[Daniel Sangorrin]

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> Sent: Saturday, April 01, 2017 9:38 AM
> I noticed an issue with the 'local' transport.  It uses "eval" in ov_transport_cmd().
> However, if the command is to change directory (cd), then this changes the
> directory in the current shell.  This can wreak havoc on the Fuego script system,
> which expects that stuff that happens on the target board does not affect
> the shell environment.
> 
> I changed this to using a shell invocation: /bin/sh -c "$@".
> 
> This is in my 'next' branch.  Let me know if you have any questions.

Thanks for the change.
There was a another eval when extracting DISTRIB. Did you fix it as well?

Thanks,
Daniel

Re: [Fuego] eval considered harmful

[Bird, Timothy]

> -----Original Message-----
> From: Daniel Sangorrin on Sunday, April 02, 2017 5:08 PM
> 
> > -----Original Message-----
> > From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> > Sent: Saturday, April 01, 2017 9:38 AM
> > I noticed an issue with the 'local' transport.  It uses "eval" in
> ov_transport_cmd().
> > However, if the command is to change directory (cd), then this changes the
> > directory in the current shell.  This can wreak havoc on the Fuego script
> system,
> > which expects that stuff that happens on the target board does not affect
> > the shell environment.
> >
> > I changed this to using a shell invocation: /bin/sh -c "$@".
> >
> > This is in my 'next' branch.  Let me know if you have any questions.
> 
> Thanks for the change.
> There was a another eval when extracting DISTRIB. Did you fix it as well?

Yes.
 -- Tim