Gerrit owners plugin coming

Gerrit owners plugin coming

[Ed Tanous]

Over the last few weeks, we've been slowly getting the gerrit owners
plugin deployed and tested, and got the OWNERS files merged into their
respective meta layers.

This has been leading up to a process change that has been on the
roadmap for some time now.  Once the plugin is enabled (and some other
housekeeping is done) meta-layer changes will be able to be submitted
to the normal openbmc/openbmc repository, simplifying one portion of
our review/merge process.  Submitting to openbmc/openbmc is something
most newcomers to the project expect, and we've had numerous gerrit
reviews submitted to the wrong repo in error.  Hopefully, this change
makes meta-layer changes much more normalized.

Once this goes in, this means that functionally:
1. We no longer have a bottleneck on creating new meta-layers,
renaming meta layers, or moving files between meta layers.  New meta
layers can be submitted through gerrit similar to any other patchset,
and will be reviewed with the same process we already have for any
other type of code, and don't require requesting a new repo in
advance.
2. Changes that require mods to all meta layers (yocto compat fields
for example) can be done in a single commit, across all systems at
once, reducing the possibility of breaking builds for meta-layer
combinations that aren't covered by CI.
3. No more waiting for your meta-X changes to get merged into
mainline, which should reduce the amount of time between recipe bumps
and the main build reflecting the changes.

Ownership of the various meta-layer folders is still enforced by
gerrit through the owners plugin using the OWNERS files.  Today, they
contain the same mapping as the content in the MAINTAINERS files, so
no files in the repo actually change ownership.

The final review to add the OWNERS file to the root of the repo is here:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
And has already had some discussion and looks to be good to go.
Assuming there's no other objections, I'd like to get this change made
on this coming Sunday.

Overall, I hope that this will be a great improvement in the overall
structure and usability of openbmc, and remove at least one stumbling
block people new to the project tend to hit.

-Ed

Re: Gerrit owners plugin coming

[Andrew Jeffery]

On Thu, 21 Jan 2021, at 05:53, Ed Tanous wrote:
> Over the last few weeks, we've been slowly getting the gerrit owners
> plugin deployed and tested, and got the OWNERS files merged into their
> respective meta layers.
> 
> This has been leading up to a process change that has been on the
> roadmap for some time now.  Once the plugin is enabled (and some other
> housekeeping is done) meta-layer changes will be able to be submitted
> to the normal openbmc/openbmc repository, simplifying one portion of
> our review/merge process.  Submitting to openbmc/openbmc is something
> most newcomers to the project expect, and we've had numerous gerrit
> reviews submitted to the wrong repo in error.  Hopefully, this change
> makes meta-layer changes much more normalized.
> 
> Once this goes in, this means that functionally:
> 1. We no longer have a bottleneck on creating new meta-layers,
> renaming meta layers, or moving files between meta layers.  New meta
> layers can be submitted through gerrit similar to any other patchset,
> and will be reviewed with the same process we already have for any
> other type of code, and don't require requesting a new repo in
> advance.
> 2. Changes that require mods to all meta layers (yocto compat fields
> for example) can be done in a single commit, across all systems at
> once, reducing the possibility of breaking builds for meta-layer
> combinations that aren't covered by CI.
> 3. No more waiting for your meta-X changes to get merged into
> mainline, which should reduce the amount of time between recipe bumps
> and the main build reflecting the changes.
> 
> Ownership of the various meta-layer folders is still enforced by
> gerrit through the owners plugin using the OWNERS files.  Today, they
> contain the same mapping as the content in the MAINTAINERS files, so
> no files in the repo actually change ownership.
> 
> The final review to add the OWNERS file to the root of the repo is here:
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
> And has already had some discussion and looks to be good to go.
> Assuming there's no other objections, I'd like to get this change made
> on this coming Sunday.
> 
> Overall, I hope that this will be a great improvement in the overall
> structure and usability of openbmc, and remove at least one stumbling
> block people new to the project tend to hit.

This is great! Thanks for pushing it.

Andrew

Re: Gerrit owners plugin coming

[Andrew Geissler]

> On Jan 20, 2021, at 1:23 PM, Ed Tanous <ed@tanous.net> wrote:
> 
> 
> Overall, I hope that this will be a great improvement in the overall
> structure and usability of openbmc, and remove at least one stumbling
> block people new to the project tend to hit.

Thanks Ed, this is going to be great!

Brad, we run this autobump[1] script in a cron job right now. It scans the meta-* layer
recipes and creates bumps into the meta-* layers as needed. I assume all we
need to do is tweak this to just look at openbmc/openbmc meta-* layers now and
do the same bumps against openbmc/openbmc?

I’ll continue to utilize openbmc-config[2] for non-openbmc meta layers 
(i.e. meta-openembedded,…) but no need to run against our openbmc
meta-* layers after this change.

Once we change over, I’ll also be disabling the meta-* layers CI job
(https://jenkins.openbmc.org/job/ci-meta/)

Andrew

[1]: https://github.com/openbmc/openbmc-tools/blob/master/openbmc-autobump/openbmc-autobump.py
[2]: https://github.com/bradbishop/openbmc-config

> 
> -Ed

Re: Gerrit owners plugin coming

[Brad Bishop]

On Thu, Jan 21, 2021 at 10:07:21AM -0600, Andrew Geissler wrote:
>
>
>> On Jan 20, 2021, at 1:23 PM, Ed Tanous <ed@tanous.net> wrote:
>>
>>
>> Overall, I hope that this will be a great improvement in the overall
>> structure and usability of openbmc, and remove at least one stumbling
>> block people new to the project tend to hit.
>
>Thanks Ed, this is going to be great!
>
>Brad, we run this autobump[1] script in a cron job right now. It scans the meta-* layer
>recipes and creates bumps into the meta-* layers as needed. I assume all we
>need to do is tweak this to just look at openbmc/openbmc meta-* layers now and
>do the same bumps against openbmc/openbmc?

That's right.  I'll do that this morning.

-brad

Re: Gerrit owners plugin coming

[Brad Bishop]

On Wed, Jan 20, 2021 at 11:23:25AM -0800, Ed Tanous wrote:
>Over the last few weeks, we've been slowly getting the gerrit owners
>plugin deployed and tested, and got the OWNERS files merged into their
>respective meta layers.

[snip]

>Overall, I hope that this will be a great improvement in the overall
>structure and usability of openbmc, and remove at least one stumbling
>block people new to the project tend to hit.

This is a great piece of work Ed, thank you for getting it done.

-brad

Re: Gerrit owners plugin coming

[Klaus Heinrich Kiwi]

On 1/20/2021 4:23 PM, Ed Tanous wrote:
> The final review to add the OWNERS file to the root of the repo is here:
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
> And has already had some discussion and looks to be good to go.
> Assuming there's no other objections, I'd like to get this change made
> on this coming Sunday.

Thanks for this!

Is this process live now? I have a few patches that I already moved from
openbmc to meta-*, need to know if I need to revert them back ;-)

Thanks,

  -Klaus


-- 
Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>

Re: Gerrit owners plugin coming

[Ed Tanous]

On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
>
> Over the last few weeks, we've been slowly getting the gerrit owners
> plugin deployed and tested, and got the OWNERS files merged into their
> respective meta layers.

These changes are live.  Any commits to the individual meta layers can
now be submitted directly to openbmc/openbmc now.  If there's anything
broken about the new workflow, or anything unexpected happens in your
workflow, please let me know on discord and we'll try to get it
resolved.

I forgot to mention one important improvement:  Listed owners will now
get added to code reviews automatically if any files are changed in
their owned directories, without having to take any action, via the
gerrit-owners-autoassign plugin that we added.  This is also a very
nice quality of life improvement when opening reviews, and something
that tends to trip up developers new to the project when they are
looking for code reviewers.


>
> This has been leading up to a process change that has been on the
> roadmap for some time now.  Once the plugin is enabled (and some other
> housekeeping is done) meta-layer changes will be able to be submitted
> to the normal openbmc/openbmc repository, simplifying one portion of
> our review/merge process.  Submitting to openbmc/openbmc is something
> most newcomers to the project expect, and we've had numerous gerrit
> reviews submitted to the wrong repo in error.  Hopefully, this change
> makes meta-layer changes much more normalized.
>
> Once this goes in, this means that functionally:
> 1. We no longer have a bottleneck on creating new meta-layers,
> renaming meta layers, or moving files between meta layers.  New meta
> layers can be submitted through gerrit similar to any other patchset,
> and will be reviewed with the same process we already have for any
> other type of code, and don't require requesting a new repo in
> advance.
> 2. Changes that require mods to all meta layers (yocto compat fields
> for example) can be done in a single commit, across all systems at
> once, reducing the possibility of breaking builds for meta-layer
> combinations that aren't covered by CI.
> 3. No more waiting for your meta-X changes to get merged into
> mainline, which should reduce the amount of time between recipe bumps
> and the main build reflecting the changes.


>
> Ownership of the various meta-layer folders is still enforced by
> gerrit through the owners plugin using the OWNERS files.  Today, they
> contain the same mapping as the content in the MAINTAINERS files, so
> no files in the repo actually change ownership.
>
> The final review to add the OWNERS file to the root of the repo is here:
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
> And has already had some discussion and looks to be good to go.
> Assuming there's no other objections, I'd like to get this change made
> on this coming Sunday.
>
> Overall, I hope that this will be a great improvement in the overall
> structure and usability of openbmc, and remove at least one stumbling
> block people new to the project tend to hit.
>
> -Ed

Re: Gerrit owners plugin coming

[Ed Tanous]

On Mon, Jan 25, 2021 at 10:04 AM Klaus Heinrich Kiwi
<klaus@linux.vnet.ibm.com> wrote:
>
>
>
> On 1/20/2021 4:23 PM, Ed Tanous wrote:
> > The final review to add the OWNERS file to the root of the repo is here:
> > https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
> > And has already had some discussion and looks to be good to go.
> > Assuming there's no other objections, I'd like to get this change made
> > on this coming Sunday.
>
> Thanks for this!
>
> Is this process live now? I have a few patches that I already moved from
> openbmc to meta-*, need to know if I need to revert them back ;-)
>

At the time you sent your message, no, the changes were not live.
With that said, they are live now, so your changes destined for
openbmc/openbmc should be ok where they're at.

> Thanks,
>
>   -Klaus
>
>
> --
> Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>

Re: Gerrit owners plugin coming

[Alexander Amelkin]

26.01.2021 00:26, Ed Tanous пишет:
> On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
>> Over the last few weeks, we've been slowly getting the gerrit owners
>> plugin deployed and tested, and got the OWNERS files merged into their
>> respective meta layers.
> These changes are live.  Any commits to the individual meta layers can
> now be submitted directly to openbmc/openbmc now.  If there's anything
> broken about the new workflow, or anything unexpected happens in your
> workflow, please let me know on discord and we'll try to get it
> resolved.

Does this mean that meta-<vendor> directories are not subtrees anymore 
and respective repositories are now obsolete and can (will?) be dropped?

Thanks.

Alexander.

Re: Gerrit owners plugin coming

[Ed Tanous]

On Wed, Jan 27, 2021 at 4:02 AM Alexander Amelkin <a.amelkin@yadro.com> wrote:
>
> 26.01.2021 00:26, Ed Tanous пишет:
> > On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
> >> Over the last few weeks, we've been slowly getting the gerrit owners
> >> plugin deployed and tested, and got the OWNERS files merged into their
> >> respective meta layers.
> > These changes are live.  Any commits to the individual meta layers can
> > now be submitted directly to openbmc/openbmc now.  If there's anything
> > broken about the new workflow, or anything unexpected happens in your
> > workflow, please let me know on discord and we'll try to get it
> > resolved.
>
> Does this mean that meta-<vendor> directories are not subtrees anymore
> and respective repositories are now obsolete and can (will?) be dropped?
>

The intent was to make them read-only in case someone was relying on
them directly.

> Thanks.
>
> Alexander.
>

Re: Gerrit owners plugin coming

[Brad Bishop]

On Wed, Jan 27, 2021 at 09:09:56AM -0800, Ed Tanous wrote:
>On Wed, Jan 27, 2021 at 4:02 AM Alexander Amelkin <a.amelkin@yadro.com> wrote:

>> Does this mean that meta-<vendor> directories are not subtrees anymore
>> and respective repositories are now obsolete and can (will?) be dropped?
>>
>
>The intent was to make them read-only in case someone was relying on
>them directly.

I removed all the ACLs from all the meta repositories in Github and 
Gerrit today.  There were a couple patches that snuck in so I also ran 
the subtree script one last time for our own subtrees (Andrew will still 
use it for pulling upstream - e.g. poky, meta-openembedded, etc).

-brad

Re: Gerrit owners plugin coming

[Thang Q. Nguyen]

On 1/28/21 00:09, Ed Tanous wrote:
> On Wed, Jan 27, 2021 at 4:02 AM Alexander Amelkin <a.amelkin@yadro.com> wrote:
>> 26.01.2021 00:26, Ed Tanous пишет:
>>> On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
>>>> Over the last few weeks, we've been slowly getting the gerrit owners
>>>> plugin deployed and tested, and got the OWNERS files merged into their
>>>> respective meta layers.
>>> These changes are live.  Any commits to the individual meta layers can
>>> now be submitted directly to openbmc/openbmc now.  If there's anything
>>> broken about the new workflow, or anything unexpected happens in your
>>> workflow, please let me know on discord and we'll try to get it
>>> resolved.
>> Does this mean that meta-<vendor> directories are not subtrees anymore
>> and respective repositories are now obsolete and can (will?) be dropped?
>>
> The intent was to make them read-only in case someone was relying on
> them directly.

Hi Ed,

Any problem with meta-* repos which have not been integrated into the 
main openbmc repo? For example, meta-ampere, meta-fii.

And with the change, the new change will be submitted into 
openbmc/openbmc repos in gerrit instead of openbmc/meta-*?

>> Thanks.
>>
>> Alexander.
>>

Re: Gerrit owners plugin coming

[Ed Tanous]

On Wed, Jan 27, 2021 at 6:08 PM Thang Q. Nguyen
<thang@os.amperecomputing.com> wrote:
>
> On 1/28/21 00:09, Ed Tanous wrote:
> > On Wed, Jan 27, 2021 at 4:02 AM Alexander Amelkin <a.amelkin@yadro.com> wrote:
> >> 26.01.2021 00:26, Ed Tanous пишет:
> >>> On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
> >>>> Over the last few weeks, we've been slowly getting the gerrit owners
> >>>> plugin deployed and tested, and got the OWNERS files merged into their
> >>>> respective meta layers.
> >>> These changes are live.  Any commits to the individual meta layers can
> >>> now be submitted directly to openbmc/openbmc now.  If there's anything
> >>> broken about the new workflow, or anything unexpected happens in your
> >>> workflow, please let me know on discord and we'll try to get it
> >>> resolved.
> >> Does this mean that meta-<vendor> directories are not subtrees anymore
> >> and respective repositories are now obsolete and can (will?) be dropped?
> >>
> > The intent was to make them read-only in case someone was relying on
> > them directly.
>
> Hi Ed,
>
> Any problem with meta-* repos which have not been integrated into the
> main openbmc repo? For example, meta-ampere, meta-fii.

They'll need a review pushed to openbmc/openbmc by someone with an
interest in them.  Make sure to include an OWNERS file in them.

>
> And with the change, the new change will be submitted into
> openbmc/openbmc repos in gerrit instead of openbmc/meta-*?

correct.

>
> >> Thanks.
> >>
> >> Alexander.
> >>

Re: Gerrit owners plugin coming

[Thang Q. Nguyen]

On 1/29/21 00:23, Ed Tanous wrote:
> On Wed, Jan 27, 2021 at 6:08 PM Thang Q. Nguyen
> <thang@os.amperecomputing.com> wrote:
>> On 1/28/21 00:09, Ed Tanous wrote:
>>> On Wed, Jan 27, 2021 at 4:02 AM Alexander Amelkin <a.amelkin@yadro.com> wrote:
>>>> 26.01.2021 00:26, Ed Tanous пишет:
>>>>> On Wed, Jan 20, 2021 at 11:23 AM Ed Tanous <ed@tanous.net> wrote:
>>>>>> Over the last few weeks, we've been slowly getting the gerrit owners
>>>>>> plugin deployed and tested, and got the OWNERS files merged into their
>>>>>> respective meta layers.
>>>>> These changes are live.  Any commits to the individual meta layers can
>>>>> now be submitted directly to openbmc/openbmc now.  If there's anything
>>>>> broken about the new workflow, or anything unexpected happens in your
>>>>> workflow, please let me know on discord and we'll try to get it
>>>>> resolved.
>>>> Does this mean that meta-<vendor> directories are not subtrees anymore
>>>> and respective repositories are now obsolete and can (will?) be dropped?
>>>>
>>> The intent was to make them read-only in case someone was relying on
>>> them directly.
>> Hi Ed,
>>
>> Any problem with meta-* repos which have not been integrated into the
>> main openbmc repo? For example, meta-ampere, meta-fii.
> They'll need a review pushed to openbmc/openbmc by someone with an
> interest in them.  Make sure to include an OWNERS file in them.
I requested the meta-ampere for Ampere Computing's Mt.Jade platform 
support and I requested to integrate meta-ampere to openbmc/openbmc 
before. There is OWNERS file added to the repository.
>> And with the change, the new change will be submitted into
>> openbmc/openbmc repos in gerrit instead of openbmc/meta-*?
> correct.
>
>>>> Thanks.
>>>>
>>>> Alexander.
>>>>