All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: xen-devel@lists.xenproject.org
Subject: Re: Registering interrupt handler for performance counter overflow
Date: Mon, 20 May 2019 11:52:14 +0100	[thread overview]
Message-ID: <00520ca1-3a22-5956-e6f9-5fac4e8c3d9a@citrix.com> (raw)
In-Reply-To: <CAMctL7UVJm-5fhkX8oHvkUXUK5LsF0BPY44Y3HmuMx6MJXqVMA@mail.gmail.com>

On 19/05/2019 19:46, Eitan Kaplan wrote:
> Hi all,
>
> I am a computer engineering student at Columbia University. This is my
> first time writing to this list (please let me know if this isn't the
> place for this type of question!).

This is indeed the correct place for this kind of question.

>
> I am working with a professor on a project to mitigate Spectre and
> Meltdown (and other similar cache timing side-channel attacks).  We
> are using Xen and modifying its source as a way of modeling the affect
> certain potential hardware changes. As part of that project, we need
> to use the performance counters to generate interrupts at certain
> microarchitectural events.  I have successfully added into
> xen/arch/x86/setup.c a few lines to setup the (Intel Sandy Bridge)
> performance counter control MSRs and set the counter itself to a few
> below overflow.  All that's missing is a simple interrupt handler that
> will reset the counter to a few below overflow (and perhaps do some
> logging).
>
> I am having trouble figuring out how to register my handler in Xen.  I
> assume that I have to call request_irq(), but I am not sure how to set
> all the arguments for that call.  Would anyone be able to give me any
> pointers?  Suggestions or pointers to resources/examples for
> registering interrupt handlers in Xen would be really helpful!
>
> Alternatively, is there an existing interrupt handler that is already
> setup for PMC overflow interrupts that I might be able to tweak?

In the Xen code, there are two uses performance counters.

One is the watchdog (cmdline "watchdog", xen/arch/x86/nmi.c) which uses
the unhalted cycles counter to generated an NMI on a periodic basis. 
See setup_apic_nmi_watchdog() for the setup details.

The second is the vpmu infrastructure (cmdline "vpmu"
xen/arch/x86/cpu/vpmu*) which is for virtualising the performance
counters for guest use, and is probably closer to what you're wanting. 
In particular, see how PMU_APIC_VECTOR is configured, which includes the
interrupt registration and LAPIC programming.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] Registering interrupt handler for performance counter overflow
Date: Mon, 20 May 2019 11:52:14 +0100	[thread overview]
Message-ID: <00520ca1-3a22-5956-e6f9-5fac4e8c3d9a@citrix.com> (raw)
Message-ID: <20190520105214.SZdzGja8Ob49CMj6JW5LCTvx0oTHTfz-rlwWfJdUENE@z> (raw)
In-Reply-To: <CAMctL7UVJm-5fhkX8oHvkUXUK5LsF0BPY44Y3HmuMx6MJXqVMA@mail.gmail.com>

On 19/05/2019 19:46, Eitan Kaplan wrote:
> Hi all,
>
> I am a computer engineering student at Columbia University. This is my
> first time writing to this list (please let me know if this isn't the
> place for this type of question!).

This is indeed the correct place for this kind of question.

>
> I am working with a professor on a project to mitigate Spectre and
> Meltdown (and other similar cache timing side-channel attacks).  We
> are using Xen and modifying its source as a way of modeling the affect
> certain potential hardware changes. As part of that project, we need
> to use the performance counters to generate interrupts at certain
> microarchitectural events.  I have successfully added into
> xen/arch/x86/setup.c a few lines to setup the (Intel Sandy Bridge)
> performance counter control MSRs and set the counter itself to a few
> below overflow.  All that's missing is a simple interrupt handler that
> will reset the counter to a few below overflow (and perhaps do some
> logging).
>
> I am having trouble figuring out how to register my handler in Xen.  I
> assume that I have to call request_irq(), but I am not sure how to set
> all the arguments for that call.  Would anyone be able to give me any
> pointers?  Suggestions or pointers to resources/examples for
> registering interrupt handlers in Xen would be really helpful!
>
> Alternatively, is there an existing interrupt handler that is already
> setup for PMC overflow interrupts that I might be able to tweak?

In the Xen code, there are two uses performance counters.

One is the watchdog (cmdline "watchdog", xen/arch/x86/nmi.c) which uses
the unhalted cycles counter to generated an NMI on a periodic basis. 
See setup_apic_nmi_watchdog() for the setup details.

The second is the vpmu infrastructure (cmdline "vpmu"
xen/arch/x86/cpu/vpmu*) which is for virtualising the performance
counters for guest use, and is probably closer to what you're wanting. 
In particular, see how PMU_APIC_VECTOR is configured, which includes the
interrupt registration and LAPIC programming.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-20 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 18:46 Registering interrupt handler for performance counter overflow Eitan Kaplan
2019-05-19 18:46 ` [Xen-devel] " Eitan Kaplan
2019-05-20 10:52 ` Andrew Cooper [this message]
2019-05-20 10:52   ` Andrew Cooper
2019-05-20 10:55 ` Andrew Cooper
2019-05-20 10:55   ` [Xen-devel] " Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00520ca1-3a22-5956-e6f9-5fac4e8c3d9a@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.