* [PATCH 17/26] mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:39 Jingoo Han
2013-05-07 16:23 ` Roland Stigge
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:39 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: Roland Stigge, linux-mtd, Jingoo Han, 'David Woodhouse'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/lpc32xx_mlc.c | 2 --
drivers/mtd/nand/lpc32xx_slc.c | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index a94facb..5a5cfbc 100644
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -833,7 +833,6 @@ err_exit3:
err_exit2:
clk_disable(host->clk);
clk_put(host->clk);
- platform_set_drvdata(pdev, NULL);
err_exit1:
lpc32xx_wp_enable(host);
gpio_free(host->ncfg->wp_gpio);
@@ -856,7 +855,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
clk_disable(host->clk);
clk_put(host->clk);
- platform_set_drvdata(pdev, NULL);
lpc32xx_wp_enable(host);
gpio_free(host->ncfg->wp_gpio);
diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index be94ed5..a66f33f 100644
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
@@ -936,7 +936,6 @@ err_exit3:
err_exit2:
clk_disable(host->clk);
clk_put(host->clk);
- platform_set_drvdata(pdev, NULL);
err_exit1:
lpc32xx_wp_enable(host);
gpio_free(host->ncfg->wp_gpio);
@@ -963,7 +962,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
clk_disable(host->clk);
clk_put(host->clk);
- platform_set_drvdata(pdev, NULL);
lpc32xx_wp_enable(host);
gpio_free(host->ncfg->wp_gpio);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 17/26] mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata()
2013-05-07 6:39 [PATCH 17/26] mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 16:23 ` Roland Stigge
0 siblings, 0 replies; 2+ messages in thread
From: Roland Stigge @ 2013-05-07 16:23 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Artem Bityutskiy', 'David Woodhouse', linux-mtd
On 05/07/2013 08:39 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/mtd/nand/lpc32xx_mlc.c | 2 --
> drivers/mtd/nand/lpc32xx_slc.c | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
> index a94facb..5a5cfbc 100644
> --- a/drivers/mtd/nand/lpc32xx_mlc.c
> +++ b/drivers/mtd/nand/lpc32xx_mlc.c
> @@ -833,7 +833,6 @@ err_exit3:
> err_exit2:
> clk_disable(host->clk);
> clk_put(host->clk);
> - platform_set_drvdata(pdev, NULL);
> err_exit1:
> lpc32xx_wp_enable(host);
> gpio_free(host->ncfg->wp_gpio);
> @@ -856,7 +855,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
>
> clk_disable(host->clk);
> clk_put(host->clk);
> - platform_set_drvdata(pdev, NULL);
>
> lpc32xx_wp_enable(host);
> gpio_free(host->ncfg->wp_gpio);
> diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
> index be94ed5..a66f33f 100644
> --- a/drivers/mtd/nand/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/lpc32xx_slc.c
> @@ -936,7 +936,6 @@ err_exit3:
> err_exit2:
> clk_disable(host->clk);
> clk_put(host->clk);
> - platform_set_drvdata(pdev, NULL);
> err_exit1:
> lpc32xx_wp_enable(host);
> gpio_free(host->ncfg->wp_gpio);
> @@ -963,7 +962,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
>
> clk_disable(host->clk);
> clk_put(host->clk);
> - platform_set_drvdata(pdev, NULL);
> lpc32xx_wp_enable(host);
> gpio_free(host->ncfg->wp_gpio);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 6:39 [PATCH 17/26] mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 16:23 ` Roland Stigge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.