* [PATCH 20/26] mtd: nand: omap2: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:41 Jingoo Han
2013-06-05 7:01 ` Gupta, Pekon
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:41 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse', Daniel Mack
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/omap2.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 81b80af..daa3dfc 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -2087,7 +2087,6 @@ static int omap_nand_remove(struct platform_device *pdev)
mtd);
omap3_free_bch(&info->mtd);
- platform_set_drvdata(pdev, NULL);
if (info->dma)
dma_release_channel(info->dma);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 20/26] mtd: nand: omap2: remove unnecessary platform_set_drvdata()
2013-05-07 6:41 [PATCH 20/26] mtd: nand: omap2: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-06-05 7:01 ` Gupta, Pekon
0 siblings, 0 replies; 2+ messages in thread
From: Gupta, Pekon @ 2013-06-05 7:01 UTC (permalink / raw)
To: Jingoo Han, 'Artem Bityutskiy'
Cc: 'David Woodhouse', linux-mtd, Daniel Mack
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit
> 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Pekon Gupta <pekon@ti.com>
Thanks for this ..
With regards, pekon
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 81b80af..daa3dfc 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -2087,7 +2087,6 @@ static int omap_nand_remove(struct
> platform_device *pdev)
> mtd);
> omap3_free_bch(&info->mtd);
>
> - platform_set_drvdata(pdev, NULL);
> if (info->dma)
> dma_release_channel(info->dma);
>
> --
> 1.7.2.5
>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-05 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 6:41 [PATCH 20/26] mtd: nand: omap2: remove unnecessary platform_set_drvdata() Jingoo Han
2013-06-05 7:01 ` Gupta, Pekon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.