[Fuego] Add Functional.kernel_build test

[Fuego] Add Functional.kernel_build test

[Daniel Sangorrin]

Hi,

I have created a kernel build test that can be used for
testing that a kernel builds correctly on different
architectures and configurations very easily.

fuego-core patches:
[PATCH 1/2] functional: only call test_run when it exists
[PATCH 2/2] tests: add Functional.kernel_build test

fuego patches:
[PATCH 1/4] Dockerfile: add u-boot-tools for mkimage in the kernel
[PATCH 2/4] Dockerfile: inject proxy variables into /etc/environment
[PATCH 3/4] crosstool: allow installing different architectures
[PATCH 4/4] arm64: add toolchain script for arm64

Next steps:
  - add deployment methods (e.g.: deploy to a TFTP server or LAVA)
  - trigger other tests to test the resulting kernel (e.g.: boot test, etc)
  - add a simple script to bisect the patch that caused the build error

You can find them on my next branch.

Cheers,
Daniel

[Fuego] [PATCH 1/4] Dockerfile: add u-boot-tools for mkimage in the kernel build test

[Daniel Sangorrin]

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Dockerfile b/Dockerfile
index fd1aa00..9dc7d8c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -28,7 +28,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get -yV install \
 	libtool xmlstarlet autoconf automake rsync openjdk-7-jre openjdk-7-jdk iperf \
 	netperf netpipe-tcp sshpass wget git diffstat sudo net-tools vim curl \
 	inotify-tools g++ bzip2 bc libaio-dev gettext pkg-config libglib2.0-dev \
-	time python-pip python-xmltodict at minicom lzop bsdmainutils
+	time python-pip python-xmltodict at minicom lzop bsdmainutils u-boot-tools
 RUN pip install python-jenkins==0.4.14
 RUN /bin/bash -c 'echo "dash dash/sh boolean false" | debconf-set-selections ; DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash'
 RUN if [ -n "$HTTP_PROXY" ]; then echo "use_proxy = on" >> /etc/wgetrc; fi
-- 
2.7.4

Re: [Fuego] [PATCH 1/4] Dockerfile: add u-boot-tools for mkimage in the kernel build test

[Bird, Timothy]

OK.
 -- Tim


> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Tuesday, April 18, 2017 1:42 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 1/4] Dockerfile: add u-boot-tools for mkimage in
> the kernel build test
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  Dockerfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Dockerfile b/Dockerfile
> index fd1aa00..9dc7d8c 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -28,7 +28,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get
> update && apt-get -yV install \
>  	libtool xmlstarlet autoconf automake rsync openjdk-7-jre openjdk-7-
> jdk iperf \
>  	netperf netpipe-tcp sshpass wget git diffstat sudo net-tools vim curl \
>  	inotify-tools g++ bzip2 bc libaio-dev gettext pkg-config libglib2.0-dev
> \
> -	time python-pip python-xmltodict at minicom lzop bsdmainutils
> +	time python-pip python-xmltodict at minicom lzop bsdmainutils u-
> boot-tools
>  RUN pip install python-jenkins==0.4.14
>  RUN /bin/bash -c 'echo "dash dash/sh boolean false" | debconf-set-
> selections ; DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash'
>  RUN if [ -n "$HTTP_PROXY" ]; then echo "use_proxy = on" >> /etc/wgetrc; fi
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego

[Fuego] [PATCH 1/2] functional: only call test_run when it exists

[Daniel Sangorrin]

Build tests do not need to be "run".

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 engine/scripts/functional.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/scripts/functional.sh b/engine/scripts/functional.sh
index af60429..9574cdd 100644
--- a/engine/scripts/functional.sh
+++ b/engine/scripts/functional.sh
@@ -44,7 +44,7 @@ echo "##### doing fuego phase: deploy ########"
 deploy
 
 echo "##### doing fuego phase: run ########"
-test_run
+call_if_present test_run
 
 echo "##### doing fuego phase: get_testlog ########"
 get_testlog $TESTDIR
-- 
2.7.4

[Fuego] [PATCH 2/4] Dockerfile: inject proxy variables into /etc/environment

[Daniel Sangorrin]

This is necessary for git clone if you are behind a proxy

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Dockerfile b/Dockerfile
index 9dc7d8c..1746467 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -32,6 +32,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get -yV install \
 RUN pip install python-jenkins==0.4.14
 RUN /bin/bash -c 'echo "dash dash/sh boolean false" | debconf-set-selections ; DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash'
 RUN if [ -n "$HTTP_PROXY" ]; then echo "use_proxy = on" >> /etc/wgetrc; fi
+RUN if [ -n "$HTTP_PROXY" ]; then echo "http_proxy=$HTTP_PROXY; https_proxy=$HTTP_PROXY" >> /etc/environment; fi
 
 # ==============================================================================
 # Install Jenkins with the same UID/GID as the host user
-- 
2.7.4

Re: [Fuego] [PATCH 2/4] Dockerfile: inject proxy variables into /etc/environment

[Bird, Timothy]

Accepted.
 -- Tim

> -----Original Message-----
> From:  Daniel Sangorrin on Tuesday, April 18, 2017 1:42 AM
> This is necessary for git clone if you are behind a proxy
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  Dockerfile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Dockerfile b/Dockerfile
> index 9dc7d8c..1746467 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -32,6 +32,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get
> update && apt-get -yV install \
>  RUN pip install python-jenkins==0.4.14
>  RUN /bin/bash -c 'echo "dash dash/sh boolean false" | debconf-set-
> selections ; DEBIAN_FRONTEND=noninteractive dpkg-reconfigure dash'
>  RUN if [ -n "$HTTP_PROXY" ]; then echo "use_proxy = on" >> /etc/wgetrc; fi
> +RUN if [ -n "$HTTP_PROXY" ]; then echo "http_proxy=$HTTP_PROXY;
> https_proxy=$HTTP_PROXY" >> /etc/environment; fi
> 
>  #
> ==========================================================
> ====================
>  # Install Jenkins with the same UID/GID as the host user
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego

[Fuego] [PATCH 2/2] tests: add Functional.kernel_build test

[Daniel Sangorrin]

Easy to automatize kernel builds for different architectures.
There are a few TODOs for corner cases but it works.

Next I want to add a deploy option so that we can put the
resulting kernel on a tftp folder or give it to lava.

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 .../Functional.kernel_build.spec                   | 18 +++++
 .../tests/Functional.kernel_build/kernel_build.sh  | 80 ++++++++++++++++++++++
 2 files changed, 98 insertions(+)
 create mode 100644 engine/tests/Functional.kernel_build/Functional.kernel_build.spec
 create mode 100755 engine/tests/Functional.kernel_build/kernel_build.sh

diff --git a/engine/tests/Functional.kernel_build/Functional.kernel_build.spec b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
new file mode 100644
index 0000000..39914a8
--- /dev/null
+++ b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
@@ -0,0 +1,18 @@
+{
+    "testName": "Functional.kernel_build",
+    "specs":
+    [
+        {
+            "name": "cip-x86",
+            "repo": "https://github.com/cip-project/linux-cip.git"
+        },
+        {
+            "name": "cip-arm64",
+            "repo": "https://github.com/cip-project/linux-cip.git",
+            "platform": "aarch64",
+            "arch": "arm64",
+            "params": "-j8 Image dtbs modules",
+            "regex_p": "^  OBJCOPY arch/arm64/boot/Image"
+        }
+    ]
+}
diff --git a/engine/tests/Functional.kernel_build/kernel_build.sh b/engine/tests/Functional.kernel_build/kernel_build.sh
new file mode 100755
index 0000000..285d5ba
--- /dev/null
+++ b/engine/tests/Functional.kernel_build/kernel_build.sh
@@ -0,0 +1,80 @@
+function test_pre_check {
+    echo "Doing a pre_check"
+    # FIXTHIS: if making uImage, check for mkimage
+}
+
+function test_build {
+    FOLDER="$(basename "$FUNCTIONAL_KERNEL_BUILD_REPO" .git)"
+
+    # Clone if no tarball was defined
+    if [ -z ${tarball+x} ]; then
+        assert_define FUNCTIONAL_KERNEL_BUILD_REPO
+
+        # Set branch or tag (default: "master" branch)
+        if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
+            if [ -z ${FUNCTIONAL_KERNEL_BUILD_BRANCH+x} ]; then
+                FUNCTIONAL_KERNEL_BUILD_BRANCH="master"
+            fi
+        else
+            FUNCTIONAL_KERNEL_BUILD_BRANCH=$FUNCTIONAL_KERNEL_BUILD_TAG
+        fi
+
+        # FIXTHIS: the folder gets removed with the rebuild flag set to true
+        if [ ! -d "$FOLDER" ]; then
+            echo "Cloning $FUNCTIONAL_KERNEL_BUILD_REPO:$FUNCTIONAL_KERNEL_BUILD_BRANCH"
+            git clone --depth 1 "$FUNCTIONAL_KERNEL_BUILD_REPO" \
+                      --branch $FUNCTIONAL_KERNEL_BUILD_BRANCH
+            cd "$FOLDER"
+        else
+            cd "$FOLDER"
+            if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
+                make mrproper
+                git pull
+            fi
+        fi
+    fi
+
+    # Configuration
+    if [ -z ${FUNCTIONAL_KERNEL_BUILD_ARCH+x} ]; then
+        FUNCTIONAL_KERNEL_BUILD_ARCH="x86_64"
+    fi
+
+    if [ -z ${FUNCTIONAL_KERNEL_BUILD_CONFIG+x} ]; then
+        FUNCTIONAL_KERNEL_BUILD_CONFIG="defconfig"
+    fi
+    echo "Configuring kernel with $FUNCTIONAL_KERNEL_BUILD_CONFIG"
+    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH $FUNCTIONAL_KERNEL_BUILD_CONFIG
+
+    # Building
+    echo "Building Kernel"
+    if [ -z ${FUNCTIONAL_KERNEL_BUILD_PARAMS+x} ]; then
+        $FUNCTIONAL_KERNEL_BUILD_PARAMS="-j4 bzImage modules"
+    fi
+
+    if [ ! -z ${FUNCTIONAL_KERNEL_BUILD_PLATFORM+x} ]; then
+          OLD_PLATFORM=$PLATFORM
+          PLATFORM=$FUNCTIONAL_KERNEL_BUILD_PLATFORM
+          source $FUEGO_RO/toolchains/tools.sh
+          PLATFORM=$OLD_PLATFORM
+    fi
+
+    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH $FUNCTIONAL_KERNEL_BUILD_PARAMS > build.log 2>&1 || true
+
+    report "cat build.log"
+}
+
+function test_deploy {
+    echo "Deploying kernel"
+    # FIXTHIS: copy to tftp folder for lava etc..
+}
+
+function test_processing {
+    echo "Processing kernel build log"
+    if [ -z ${FUNCTIONAL_KERNEL_BUILD_REGEX_P+x} ]; then
+        log_compare "$TESTDIR" "1" "^Kernel: arch/.* is ready" "p"
+    else
+        log_compare "$TESTDIR" "1" "$FUNCTIONAL_KERNEL_BUILD_REGEX_P" "p"
+    fi
+}
+
+. $FUEGO_CORE/engine/scripts/functional.sh
-- 
2.7.4

Re: [Fuego] [PATCH 2/2] tests: add Functional.kernel_build test

[Bird, Timothy]

See comments inline below.

> -----Original Message-----
> From: Daniel Sangorrin on Tuesday, April 18, 2017 1:42 AM
> 
> Easy to automatize kernel builds for different architectures.
> There are a few TODOs for corner cases but it works.
> 
> Next I want to add a deploy option so that we can put the
> resulting kernel on a tftp folder or give it to lava.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  .../Functional.kernel_build.spec                   | 18 +++++
>  .../tests/Functional.kernel_build/kernel_build.sh  | 80
> ++++++++++++++++++++++
>  2 files changed, 98 insertions(+)
>  create mode 100644
> engine/tests/Functional.kernel_build/Functional.kernel_build.spec
>  create mode 100755 engine/tests/Functional.kernel_build/kernel_build.sh

This is a pretty generically-named test, for something that looks a bit specific
to CIP.  I plan to accept it, but I think it needs more work to be a truly generic
kernel build test.  Two paths forward are possible:
1) rename it to be a kernel CIP build test
2) generalize it for other use cases.

We can decide which path to take as other use cases or requirements
become apparent.

Since this is the first test of this type, it gets to hold the position of 'kernel build test'
even though it's not generalized yet. 

> 
> diff --git
> a/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> new file mode 100644
> index 0000000..39914a8
> --- /dev/null
> +++ b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> @@ -0,0 +1,18 @@
> +{
> +    "testName": "Functional.kernel_build",
> +    "specs":
> +    [
> +        {
> +            "name": "cip-x86",
> +            "repo": "https://github.com/cip-project/linux-cip.git"
> +        },
> +        {
> +            "name": "cip-arm64",
> +            "repo": "https://github.com/cip-project/linux-cip.git",
> +            "platform": "aarch64",
This seems to be duplicating information that should be coming from
the board file, not the spec file.

> +            "arch": "arm64",
Same here.

> +            "params": "-j8 Image dtbs modules",
> +            "regex_p": "^  OBJCOPY arch/arm64/boot/Image"
> +        }
> +    ]
> +}
> diff --git a/engine/tests/Functional.kernel_build/kernel_build.sh
> b/engine/tests/Functional.kernel_build/kernel_build.sh
> new file mode 100755
> index 0000000..285d5ba
> --- /dev/null
> +++ b/engine/tests/Functional.kernel_build/kernel_build.sh
> @@ -0,0 +1,80 @@
> +function test_pre_check {
> +    echo "Doing a pre_check"
> +    # FIXTHIS: if making uImage, check for mkimage
> +}
> +
> +function test_build {
> +    FOLDER="$(basename "$FUNCTIONAL_KERNEL_BUILD_REPO" .git)"
> +
> +    # Clone if no tarball was defined
> +    if [ -z ${tarball+x} ]; then
> +        assert_define FUNCTIONAL_KERNEL_BUILD_REPO
> +
> +        # Set branch or tag (default: "master" branch)
> +        if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
> +            if [ -z ${FUNCTIONAL_KERNEL_BUILD_BRANCH+x} ]; then
> +                FUNCTIONAL_KERNEL_BUILD_BRANCH="master"
> +            fi
> +        else
> +
> FUNCTIONAL_KERNEL_BUILD_BRANCH=$FUNCTIONAL_KERNEL_BUILD_TAG
> +        fi
> +
> +        # FIXTHIS: the folder gets removed with the rebuild flag set to true
> +        if [ ! -d "$FOLDER" ]; then
> +            echo "Cloning
> $FUNCTIONAL_KERNEL_BUILD_REPO:$FUNCTIONAL_KERNEL_BUILD_BRANC
> H"
> +            git clone --depth 1 "$FUNCTIONAL_KERNEL_BUILD_REPO" \
> +                      --branch $FUNCTIONAL_KERNEL_BUILD_BRANCH
This could (and probably should) be used more generally for all packages,
as a download step if a git repository is specified rather than a tarball.

Have you looked at moving this into: functions.sh: unpack()?

> +            cd "$FOLDER"
> +        else
> +            cd "$FOLDER"
> +            if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
> +                make mrproper
> +                git pull
> +            fi
> +        fi
> +    fi
> +
> +    # Configuration
> +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_ARCH+x} ]; then
> +        FUNCTIONAL_KERNEL_BUILD_ARCH="x86_64"
> +    fi
> +
> +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_CONFIG+x} ]; then
> +        FUNCTIONAL_KERNEL_BUILD_CONFIG="defconfig"
> +    fi
> +    echo "Configuring kernel with $FUNCTIONAL_KERNEL_BUILD_CONFIG"
> +    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH
> $FUNCTIONAL_KERNEL_BUILD_CONFIG
> +
> +    # Building
> +    echo "Building Kernel"
> +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_PARAMS+x} ]; then
> +        $FUNCTIONAL_KERNEL_BUILD_PARAMS="-j4 bzImage modules"
> +    fi
> +
> +    if [ ! -z ${FUNCTIONAL_KERNEL_BUILD_PLATFORM+x} ]; then
> +          OLD_PLATFORM=$PLATFORM
> +          PLATFORM=$FUNCTIONAL_KERNEL_BUILD_PLATFORM
> +          source $FUEGO_RO/toolchains/tools.sh
> +          PLATFORM=$OLD_PLATFORM
> +    fi
> +
> +    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH
> $FUNCTIONAL_KERNEL_BUILD_PARAMS > build.log 2>&1 || true
> +
> +    report "cat build.log"
> +}
> +
> +function test_deploy {
> +    echo "Deploying kernel"
> +    # FIXTHIS: copy to tftp folder for lava etc..
> +}
> +
> +function test_processing {
> +    echo "Processing kernel build log"
> +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_REGEX_P+x} ]; then
> +        log_compare "$TESTDIR" "1" "^Kernel: arch/.* is ready" "p"
> +    else
> +        log_compare "$TESTDIR" "1"
> "$FUNCTIONAL_KERNEL_BUILD_REGEX_P" "p"
> +    fi
> +}
> +
> +. $FUEGO_CORE/engine/scripts/functional.sh
> --
> 2.7.4


The rest of this looks OK.  Thanks.
 -- Tim

Re: [Fuego] [PATCH 2/2] tests: add Functional.kernel_build test

[Daniel Sangorrin]

Hi Tim,

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> Sent: Wednesday, April 26, 2017 9:23 AM
> To: Daniel Sangorrin; fuego@lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH 2/2] tests: add Functional.kernel_build test
> 
> See comments inline below.
> 
> > -----Original Message-----
> > From: Daniel Sangorrin on Tuesday, April 18, 2017 1:42 AM
> >
> > Easy to automatize kernel builds for different architectures.
> > There are a few TODOs for corner cases but it works.
> >
> > Next I want to add a deploy option so that we can put the
> > resulting kernel on a tftp folder or give it to lava.
> >
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> > ---
> >  .../Functional.kernel_build.spec                   | 18 +++++
> >  .../tests/Functional.kernel_build/kernel_build.sh  | 80
> > ++++++++++++++++++++++
> >  2 files changed, 98 insertions(+)
> >  create mode 100644
> > engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> >  create mode 100755 engine/tests/Functional.kernel_build/kernel_build.sh
> 
> This is a pretty generically-named test, for something that looks a bit specific
> to CIP.  I plan to accept it, but I think it needs more work to be a truly generic
> kernel build test.  Two paths forward are possible:
> 1) rename it to be a kernel CIP build test
> 2) generalize it for other use cases.

The spec just contains kernel CIP as an example. As a matter of fact, the latest
version of the spec (see below) includes linux mainstream. I will add more specs
in the future.

https://bitbucket.org/nirrognas/fuego-core/src/c1304fb7d5286a47e93262ccc9074a9774eae655/engine/tests/Functional.kernel_build/Functional.kernel_build.spec?at=next&fileviewer=file-view-default


> 
> We can decide which path to take as other use cases or requirements
> become apparent.
> 
> Since this is the first test of this type, it gets to hold the position of 'kernel build test'
> even though it's not generalized yet.
> 
> >
> > diff --git
> > a/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> > b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> > new file mode 100644
> > index 0000000..39914a8
> > --- /dev/null
> > +++ b/engine/tests/Functional.kernel_build/Functional.kernel_build.spec
> > @@ -0,0 +1,18 @@
> > +{
> > +    "testName": "Functional.kernel_build",
> > +    "specs":
> > +    [
> > +        {
> > +            "name": "cip-x86",
> > +            "repo": "https://github.com/cip-project/linux-cip.git"
> > +        },
> > +        {
> > +            "name": "cip-arm64",
> > +            "repo": "https://github.com/cip-project/linux-cip.git",
> > +            "platform": "aarch64",
> This seems to be duplicating information that should be coming from
> the board file, not the spec file.
> 
> > +            "arch": "arm64",
> Same here.

Actually it's not because the board file is "docker", since we are building it there.
So the idea is that you have to add the test as ftc add-jobs -b docker -t Functional.kernel_build -s xxx


> 
> > +            "params": "-j8 Image dtbs modules",
> > +            "regex_p": "^  OBJCOPY arch/arm64/boot/Image"
> > +        }
> > +    ]
> > +}
> > diff --git a/engine/tests/Functional.kernel_build/kernel_build.sh
> > b/engine/tests/Functional.kernel_build/kernel_build.sh
> > new file mode 100755
> > index 0000000..285d5ba
> > --- /dev/null
> > +++ b/engine/tests/Functional.kernel_build/kernel_build.sh
> > @@ -0,0 +1,80 @@
> > +function test_pre_check {
> > +    echo "Doing a pre_check"
> > +    # FIXTHIS: if making uImage, check for mkimage
> > +}
> > +
> > +function test_build {
> > +    FOLDER="$(basename "$FUNCTIONAL_KERNEL_BUILD_REPO" .git)"
> > +
> > +    # Clone if no tarball was defined
> > +    if [ -z ${tarball+x} ]; then
> > +        assert_define FUNCTIONAL_KERNEL_BUILD_REPO
> > +
> > +        # Set branch or tag (default: "master" branch)
> > +        if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
> > +            if [ -z ${FUNCTIONAL_KERNEL_BUILD_BRANCH+x} ]; then
> > +                FUNCTIONAL_KERNEL_BUILD_BRANCH="master"
> > +            fi
> > +        else
> > +
> > FUNCTIONAL_KERNEL_BUILD_BRANCH=$FUNCTIONAL_KERNEL_BUILD_TAG
> > +        fi
> > +
> > +        # FIXTHIS: the folder gets removed with the rebuild flag set to true
> > +        if [ ! -d "$FOLDER" ]; then
> > +            echo "Cloning
> > $FUNCTIONAL_KERNEL_BUILD_REPO:$FUNCTIONAL_KERNEL_BUILD_BRANC
> > H"
> > +            git clone --depth 1 "$FUNCTIONAL_KERNEL_BUILD_REPO" \
> > +                      --branch $FUNCTIONAL_KERNEL_BUILD_BRANCH
> This could (and probably should) be used more generally for all packages,
> as a download step if a git repository is specified rather than a tarball.
> 
> Have you looked at moving this into: functions.sh: unpack()?

Good point!

Thanks,
Daniel

> 
> > +            cd "$FOLDER"
> > +        else
> > +            cd "$FOLDER"
> > +            if [ -z ${FUNCTIONAL_KERNEL_BUILD_TAG+x} ]; then
> > +                make mrproper
> > +                git pull
> > +            fi
> > +        fi
> > +    fi
> > +
> > +    # Configuration
> > +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_ARCH+x} ]; then
> > +        FUNCTIONAL_KERNEL_BUILD_ARCH="x86_64"
> > +    fi
> > +
> > +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_CONFIG+x} ]; then
> > +        FUNCTIONAL_KERNEL_BUILD_CONFIG="defconfig"
> > +    fi
> > +    echo "Configuring kernel with $FUNCTIONAL_KERNEL_BUILD_CONFIG"
> > +    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH
> > $FUNCTIONAL_KERNEL_BUILD_CONFIG
> > +
> > +    # Building
> > +    echo "Building Kernel"
> > +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_PARAMS+x} ]; then
> > +        $FUNCTIONAL_KERNEL_BUILD_PARAMS="-j4 bzImage modules"
> > +    fi
> > +
> > +    if [ ! -z ${FUNCTIONAL_KERNEL_BUILD_PLATFORM+x} ]; then
> > +          OLD_PLATFORM=$PLATFORM
> > +          PLATFORM=$FUNCTIONAL_KERNEL_BUILD_PLATFORM
> > +          source $FUEGO_RO/toolchains/tools.sh
> > +          PLATFORM=$OLD_PLATFORM
> > +    fi
> > +
> > +    make ARCH=$FUNCTIONAL_KERNEL_BUILD_ARCH
> > $FUNCTIONAL_KERNEL_BUILD_PARAMS > build.log 2>&1 || true
> > +
> > +    report "cat build.log"
> > +}
> > +
> > +function test_deploy {
> > +    echo "Deploying kernel"
> > +    # FIXTHIS: copy to tftp folder for lava etc..
> > +}
> > +
> > +function test_processing {
> > +    echo "Processing kernel build log"
> > +    if [ -z ${FUNCTIONAL_KERNEL_BUILD_REGEX_P+x} ]; then
> > +        log_compare "$TESTDIR" "1" "^Kernel: arch/.* is ready" "p"
> > +    else
> > +        log_compare "$TESTDIR" "1"
> > "$FUNCTIONAL_KERNEL_BUILD_REGEX_P" "p"
> > +    fi
> > +}
> > +
> > +. $FUEGO_CORE/engine/scripts/functional.sh
> > --
> > 2.7.4
> 
> 
> The rest of this looks OK.  Thanks.
>  -- Tim

[Fuego] [PATCH 3/4] crosstool: allow installing different architectures

[Daniel Sangorrin]

Before only armhf was available, now we can install
arm64 armel armhf mips mipsel powerpc ppc64el toolchains

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 fuego-ro/toolchains/install_armhf_toolchain.sh |  6 ------
 fuego-ro/toolchains/install_cross_toolchain.sh | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 6 deletions(-)
 delete mode 100644 fuego-ro/toolchains/install_armhf_toolchain.sh
 create mode 100755 fuego-ro/toolchains/install_cross_toolchain.sh

diff --git a/fuego-ro/toolchains/install_armhf_toolchain.sh b/fuego-ro/toolchains/install_armhf_toolchain.sh
deleted file mode 100644
index d650384..0000000
--- a/fuego-ro/toolchains/install_armhf_toolchain.sh
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/bash
-echo deb http://emdebian.org/tools/debian/ jessie main > /etc/apt/sources.list.d/crosstools.list
-dpkg --add-architecture armhf
-curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key | sudo apt-key add -
-DEBIAN_FRONTEND=noninteractive apt-get update
-DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-armhf
diff --git a/fuego-ro/toolchains/install_cross_toolchain.sh b/fuego-ro/toolchains/install_cross_toolchain.sh
new file mode 100755
index 0000000..eb74f31
--- /dev/null
+++ b/fuego-ro/toolchains/install_cross_toolchain.sh
@@ -0,0 +1,14 @@
+#!/bin/bash
+# $1: architecture (e.g.: arm64 armel armhf mips mipsel powerpc ppc64el)
+
+if [ -z ${1+x} ]; then
+    ARCH=armhf
+else
+    ARCH=$1
+fi
+
+echo deb http://emdebian.org/tools/debian/ jessie main > /etc/apt/sources.list.d/crosstools.list
+dpkg --add-architecture $ARCH
+curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key | sudo apt-key add -
+DEBIAN_FRONTEND=noninteractive apt-get update
+DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-$ARCH
-- 
2.7.4

Re: [Fuego] [PATCH 3/4] crosstool: allow installing different architectures

[Bird, Timothy]

This is nice.  I added some documentation about this at:
http://bird.org/fuego/Adding_a_toolchain

Should we have some more files in /fuego-ro/toolchains to match the available options?
(or install_cross_toolchain.sh could generate the correct file during installation).

ex: /fuego-ro/toolchains/mipsel-tools.sh?

Accepted into my 'next' branch.
 -- Tim

> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Tuesday, April 18, 2017 1:42 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 3/4] crosstool: allow installing different
> architectures
> 
> Before only armhf was available, now we can install
> arm64 armel armhf mips mipsel powerpc ppc64el toolchains
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  fuego-ro/toolchains/install_armhf_toolchain.sh |  6 ------
>  fuego-ro/toolchains/install_cross_toolchain.sh | 14 ++++++++++++++
>  2 files changed, 14 insertions(+), 6 deletions(-)
>  delete mode 100644 fuego-ro/toolchains/install_armhf_toolchain.sh
>  create mode 100755 fuego-ro/toolchains/install_cross_toolchain.sh
> 
> diff --git a/fuego-ro/toolchains/install_armhf_toolchain.sh b/fuego-
> ro/toolchains/install_armhf_toolchain.sh
> deleted file mode 100644
> index d650384..0000000
> --- a/fuego-ro/toolchains/install_armhf_toolchain.sh
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#!/bin/bash
> -echo deb http://emdebian.org/tools/debian/ jessie main >
> /etc/apt/sources.list.d/crosstools.list
> -dpkg --add-architecture armhf
> -curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> sudo apt-key add -
> -DEBIAN_FRONTEND=noninteractive apt-get update
> -DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-
> armhf
> diff --git a/fuego-ro/toolchains/install_cross_toolchain.sh b/fuego-
> ro/toolchains/install_cross_toolchain.sh
> new file mode 100755
> index 0000000..eb74f31
> --- /dev/null
> +++ b/fuego-ro/toolchains/install_cross_toolchain.sh
> @@ -0,0 +1,14 @@
> +#!/bin/bash
> +# $1: architecture (e.g.: arm64 armel armhf mips mipsel powerpc ppc64el)
> +
> +if [ -z ${1+x} ]; then
> +    ARCH=armhf
> +else
> +    ARCH=$1
> +fi
> +
> +echo deb http://emdebian.org/tools/debian/ jessie main >
> /etc/apt/sources.list.d/crosstools.list
> +dpkg --add-architecture $ARCH
> +curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> sudo apt-key add -
> +DEBIAN_FRONTEND=noninteractive apt-get update
> +DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-
> $ARCH
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego

Re: [Fuego] [PATCH 3/4] crosstool: allow installing different architectures

[Daniel Sangorrin]

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> Sent: Wednesday, April 26, 2017 8:45 AM
> To: Daniel Sangorrin; fuego@lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH 3/4] crosstool: allow installing different architectures
> 
> This is nice.  I added some documentation about this at:
> http://bird.org/fuego/Adding_a_toolchain
> 
> Should we have some more files in /fuego-ro/toolchains to match the available options?
> (or install_cross_toolchain.sh could generate the correct file during installation).
> 
> ex: /fuego-ro/toolchains/mipsel-tools.sh?

Yeah, that's a good idea.

> 
> Accepted into my 'next' branch.
>  -- Tim
> 
> > -----Original Message-----
> > From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> > bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> > Sent: Tuesday, April 18, 2017 1:42 AM
> > To: fuego@lists.linuxfoundation.org
> > Subject: [Fuego] [PATCH 3/4] crosstool: allow installing different
> > architectures
> >
> > Before only armhf was available, now we can install
> > arm64 armel armhf mips mipsel powerpc ppc64el toolchains
> >
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> > ---
> >  fuego-ro/toolchains/install_armhf_toolchain.sh |  6 ------
> >  fuego-ro/toolchains/install_cross_toolchain.sh | 14 ++++++++++++++
> >  2 files changed, 14 insertions(+), 6 deletions(-)
> >  delete mode 100644 fuego-ro/toolchains/install_armhf_toolchain.sh
> >  create mode 100755 fuego-ro/toolchains/install_cross_toolchain.sh
> >
> > diff --git a/fuego-ro/toolchains/install_armhf_toolchain.sh b/fuego-
> > ro/toolchains/install_armhf_toolchain.sh
> > deleted file mode 100644
> > index d650384..0000000
> > --- a/fuego-ro/toolchains/install_armhf_toolchain.sh
> > +++ /dev/null
> > @@ -1,6 +0,0 @@
> > -#!/bin/bash
> > -echo deb http://emdebian.org/tools/debian/ jessie main >
> > /etc/apt/sources.list.d/crosstools.list
> > -dpkg --add-architecture armhf
> > -curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> > sudo apt-key add -
> > -DEBIAN_FRONTEND=noninteractive apt-get update
> > -DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-
> > armhf
> > diff --git a/fuego-ro/toolchains/install_cross_toolchain.sh b/fuego-
> > ro/toolchains/install_cross_toolchain.sh
> > new file mode 100755
> > index 0000000..eb74f31
> > --- /dev/null
> > +++ b/fuego-ro/toolchains/install_cross_toolchain.sh
> > @@ -0,0 +1,14 @@
> > +#!/bin/bash
> > +# $1: architecture (e.g.: arm64 armel armhf mips mipsel powerpc ppc64el)
> > +
> > +if [ -z ${1+x} ]; then
> > +    ARCH=armhf
> > +else
> > +    ARCH=$1
> > +fi
> > +
> > +echo deb http://emdebian.org/tools/debian/ jessie main >
> > /etc/apt/sources.list.d/crosstools.list
> > +dpkg --add-architecture $ARCH
> > +curl http://emdebian.org/tools/debian/emdebian-toolchain-archive.key |
> > sudo apt-key add -
> > +DEBIAN_FRONTEND=noninteractive apt-get update
> > +DEBIAN_FRONTEND=noninteractive apt-get -yV install crossbuild-essential-
> > $ARCH
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego@lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego

[Fuego] [PATCH 4/4] arm64: add toolchain script for arm64

[Daniel Sangorrin]

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 fuego-ro/toolchains/aarch64-tools.sh | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 fuego-ro/toolchains/aarch64-tools.sh

diff --git a/fuego-ro/toolchains/aarch64-tools.sh b/fuego-ro/toolchains/aarch64-tools.sh
new file mode 100644
index 0000000..d1f6a0a
--- /dev/null
+++ b/fuego-ro/toolchains/aarch64-tools.sh
@@ -0,0 +1,21 @@
+# fuego toolchain script
+# this sets up the environment needed for fuego to use a toolchain
+# this includes the following variables:
+# CC, CXX, CPP, CXXCPP, CONFIGURE_FLAGS, AS, LD, ARCH
+# CROSS_COMPILE, PREFIX, HOST, SDKROOT
+# CFLAGS and LDFLAGS are optional
+#
+# this script should be sourced by ${FUEGO_RO}/toolchains/tools.sh
+
+SDKROOT=/
+
+# the Yocto project environment setup script changes PATH so that python uses
+# libs from sysroot, which is not what we want, so save the original path
+# and use it later
+ORIG_PATH=$PATH
+
+PREFIX=aarch64-linux-gnu
+export_tools
+
+# avoid could not find -lm errors
+LDFLAGS=
-- 
2.7.4

Re: [Fuego] Add Functional.kernel_build test

[Bird, Timothy]

Sounds good.  I'll post comments on the individual patches.

> -----Original Message-----
> From: Daniel Sangorrin on Tuesday, April 18, 2017 1:42 AM
> Hi,
> 
> I have created a kernel build test that can be used for
> testing that a kernel builds correctly on different
> architectures and configurations very easily.
> 
> fuego-core patches:
> [PATCH 1/2] functional: only call test_run when it exists
> [PATCH 2/2] tests: add Functional.kernel_build test
> 
> fuego patches:
> [PATCH 1/4] Dockerfile: add u-boot-tools for mkimage in the kernel
> [PATCH 2/4] Dockerfile: inject proxy variables into /etc/environment
> [PATCH 3/4] crosstool: allow installing different architectures
> [PATCH 4/4] arm64: add toolchain script for arm64
> 
> Next steps:
>   - add deployment methods (e.g.: deploy to a TFTP server or LAVA)
>   - trigger other tests to test the resulting kernel (e.g.: boot test, etc)
>   - add a simple script to bisect the patch that caused the build error
> 
> You can find them on my next branch.
> 
> Cheers,
> Daniel
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego