All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Peter Xu <peterx@redhat.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:VFIO DRIVER" <kvm@vger.kernel.org>
Subject: Re: [PATCH V3 5/6] PCI: Rename pci_try_reset_bus() to pci_reset_bus()
Date: Thu, 28 Jun 2018 15:17:45 -0400	[thread overview]
Message-ID: <006d7041-6d5c-af10-6252-005978bdc203@codeaurora.org> (raw)
In-Reply-To: <1530210507-9287-5-git-send-email-okaya@codeaurora.org>

On 6/28/2018 2:28 PM, Sinan Kaya wrote:
> --- a/drivers/infiniband/hw/hfi1/pcie.c
> +++ b/drivers/infiniband/hw/hfi1/pcie.c
> @@ -905,7 +905,7 @@ static int trigger_sbr(struct hfi1_devdata *dd)
>  	 * delay after a reset is required.  Per spec requirements,
>  	 * the link is either working or not after that point.
>  	 */
> -	return pci_try_reset_bus(dev->bus);
> +	return pci_reset_bus(dev->bus);
>  }
>  

This should have been 

return pci_reset_bus(dev);

I'll wait until I hear more feedback.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>,
	"open list:VFIO DRIVER" <kvm@vger.kernel.org>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	linux-arm-msm@vger.kernel.org,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Doug Ledford <dledford@redhat.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org,
	"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH V3 5/6] PCI: Rename pci_try_reset_bus() to pci_reset_bus()
Date: Thu, 28 Jun 2018 15:17:45 -0400	[thread overview]
Message-ID: <006d7041-6d5c-af10-6252-005978bdc203@codeaurora.org> (raw)
In-Reply-To: <1530210507-9287-5-git-send-email-okaya@codeaurora.org>

On 6/28/2018 2:28 PM, Sinan Kaya wrote:
> --- a/drivers/infiniband/hw/hfi1/pcie.c
> +++ b/drivers/infiniband/hw/hfi1/pcie.c
> @@ -905,7 +905,7 @@ static int trigger_sbr(struct hfi1_devdata *dd)
>  	 * delay after a reset is required.  Per spec requirements,
>  	 * the link is either working or not after that point.
>  	 */
> -	return pci_try_reset_bus(dev->bus);
> +	return pci_reset_bus(dev->bus);
>  }
>  

This should have been 

return pci_reset_bus(dev);

I'll wait until I hear more feedback.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 5/6] PCI: Rename pci_try_reset_bus() to pci_reset_bus()
Date: Thu, 28 Jun 2018 15:17:45 -0400	[thread overview]
Message-ID: <006d7041-6d5c-af10-6252-005978bdc203@codeaurora.org> (raw)
In-Reply-To: <1530210507-9287-5-git-send-email-okaya@codeaurora.org>

On 6/28/2018 2:28 PM, Sinan Kaya wrote:
> --- a/drivers/infiniband/hw/hfi1/pcie.c
> +++ b/drivers/infiniband/hw/hfi1/pcie.c
> @@ -905,7 +905,7 @@ static int trigger_sbr(struct hfi1_devdata *dd)
>  	 * delay after a reset is required.  Per spec requirements,
>  	 * the link is either working or not after that point.
>  	 */
> -	return pci_try_reset_bus(dev->bus);
> +	return pci_reset_bus(dev->bus);
>  }
>  

This should have been 

return pci_reset_bus(dev);

I'll wait until I hear more feedback.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2018-06-28 19:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 18:28 [PATCH V3 1/6] IB/hfi1: Use pci_try_reset_bus() for initiating pci secondary bus reset Sinan Kaya
2018-06-28 18:28 ` Sinan Kaya
2018-06-28 18:28 ` Sinan Kaya
2018-06-28 18:28 ` Sinan Kaya
2018-06-28 18:28 ` [PATCH V3 2/6] PCI: Hide pci_reset_bridge_secondary_bus() from drivers Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28 ` [PATCH V3 3/6] PCI: Unify try slot and bus reset API Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28 ` [PATCH V3 4/6] PCI: Deprecate pci_reset_bus() and pci_reset_slot() functions Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28 ` [PATCH V3 5/6] PCI: Rename pci_try_reset_bus() to pci_reset_bus() Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 19:17   ` Sinan Kaya [this message]
2018-06-28 19:17     ` Sinan Kaya
2018-06-28 19:17     ` Sinan Kaya
2018-06-28 18:28 ` [PATCH V3 6/6] PCI: Handle link reset via hotplug if supported Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya
2018-06-28 18:28   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=006d7041-6d5c-af10-6252-005978bdc203@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=peterx@redhat.com \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.