All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sameer Goel <sameer.goel@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Manish Jaggi <mjaggi@caviumnetworks.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	shankerd@codeaurora.org, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver
Date: Wed, 30 May 2018 13:30:36 -0600	[thread overview]
Message-ID: <006db3b8-0bc0-3ec2-6de2-4b6d42eee0db@linaro.org> (raw)
In-Reply-To: <5B07B6ED02000078001C5D51@prv1-mh.provo.novell.com>



On 5/25/2018 1:10 AM, Jan Beulich wrote:
>>>> On 24.05.18 at 22:26, <sameer.goel@linaro.org> wrote:
>> On 05/24/2018 01:57 AM, Jan Beulich wrote:
>>>>>> On 24.05.18 at 02:46, <sameer.goel@linaro.org> wrote:
>>>> --- /dev/null
>>>> +++ b/xen/include/xen/linux_compat.h
>>> I continue to dislike the idea of having a header with these contents in 
>> this location.
>> As explained previously this header can be used for the any driver that 
>> we want to port from Linux. This is not arm specific. This seemed like 
>> the best location for the file.
This code was added to every source file that was being ported. I found this explicitly in smmu-v2.c. Eventually this might be needed for the iort code that Manish might pull in.

The function signatures in the header file are consistent and should not change.

So, if we plan on porting a lot of Linux code, I would argue that this file is a necessity so that we do not define these functions in every ported source file.  (If we want to port Linux code with minimal changes.) The only example I found in the code base is arm smmu driver and the iort code that is being pulled in. So, we can move it to an arm specific location if needed, but this header is needed.

Thanks,
Sameer
> Please take into consideration that with lots of code originally having come
> from Linux, in all the years we've never had a need to have such a header.
> With that history, it needs good reasoning to introduce one now in such a
> global fashion.
>
>> Which other common location should I pick?
> None - that's the whole point of my comment: I don't see this as something
> that should go in a common location.
>
> Jan
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-05-30 19:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24  0:46 [v2 0/6] SMMUv3 driver Sameer Goel
2018-05-24  0:46 ` [v2 1/6] Port WARN_ON_ONCE() from Linux Sameer Goel
2018-05-24  7:53   ` Jan Beulich
2018-05-24 20:23     ` Sameer Goel
2018-05-25  7:07       ` Jan Beulich
2018-06-07  1:21         ` Sameer Goel
2018-05-24  0:46 ` [v2 2/6] passthrough/arm: Modify SMMU driver to use generic device definition Sameer Goel
2018-05-24  0:46 ` [v2 3/6] Add verbatim copy of arm-smmu-v3.c from Linux Sameer Goel
2018-05-24  0:46 ` [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver Sameer Goel
2018-05-24  4:48   ` Manish Jaggi
2018-05-24 20:18     ` Sameer Goel
2018-05-24 20:29     ` Sameer Goel
2018-05-25  4:41       ` Manish Jaggi
2018-05-25  8:45         ` Julien Grall
2018-05-30 19:46         ` Sameer Goel
2018-05-31  4:10           ` Manish Jaggi
2018-05-31 16:06             ` Goel, Sameer
2018-05-30 23:01         ` Sameer Goel
2018-05-31  4:13           ` Manish Jaggi
2018-05-31 15:57             ` Sameer Goel
2018-06-01  5:16               ` Manish Jaggi
2018-06-01 18:58                 ` Sameer Goel
2018-06-02 21:26                   ` Manish Jaggi
2018-05-24  7:57   ` Jan Beulich
2018-05-24 20:26     ` Sameer Goel
2018-05-25  7:10       ` Jan Beulich
2018-05-30 19:30         ` Sameer Goel [this message]
2018-05-24  0:46 ` [v2 5/6] drivers/passthrough/arm: Refactor code for arm smmu drivers Sameer Goel
2018-05-24  7:58   ` Jan Beulich
2018-05-24 20:30     ` Sameer Goel
2018-05-24  0:46 ` [v2 6/6] xen/smmu: Add a new config define for legacy SMMU Sameer Goel
2018-05-24  7:59   ` Jan Beulich
2018-05-24  8:52     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=006db3b8-0bc0-3ec2-6de2-4b6d42eee0db@linaro.org \
    --to=sameer.goel@linaro.org \
    --cc=JBeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=mjaggi@caviumnetworks.com \
    --cc=roger.pau@citrix.com \
    --cc=shankerd@codeaurora.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.