From: Sameer Goel <sameer.goel@linaro.org>
To: Jan Beulich <JBeulich@suse.com>, Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Manish Jaggi <mjaggi@caviumnetworks.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Ian.Jackson@citrix.com, nd@arm.com, shankerd@codeaurora.org,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [v2 1/6] Port WARN_ON_ONCE() from Linux
Date: Thu, 24 May 2018 14:23:56 -0600 [thread overview]
Message-ID: <aee35e24-cf78-5f33-c13d-f10715e899f4@linaro.org> (raw)
In-Reply-To: <5B066F7302000078001C56BB@prv1-mh.provo.novell.com>
On 05/24/2018 01:53 AM, Jan Beulich wrote:
>>>> On 24.05.18 at 02:46, <sameer.goel@linaro.org> wrote:
>> Port WARN_ON_ONCE macro from Linux.
> In such a case you should justify adjustments you've made:
I can add more details, but have mostly just changed variable names. The
macro is self explanatory.
Should I just change this to: "Define WARN_ON_ONCE macro to mirror LInux
functionality"
>
>> --- a/xen/include/xen/lib.h
>> +++ b/xen/include/xen/lib.h
>> @@ -11,6 +11,19 @@
>> #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0)
>> #define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
>>
>> +#define WARN_ON_ONCE(p) \
>> +({ \
>> + static bool __section(".data.unlikely") warned; \
> Linux uses .data.once. That or .data.cold would seem better to me than
> .data.unlikely.
I guess there is not reason to keep this in a specific section. I'll
just go ahead and remove the section here?
>
> Jan
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-24 20:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 0:46 [v2 0/6] SMMUv3 driver Sameer Goel
2018-05-24 0:46 ` [v2 1/6] Port WARN_ON_ONCE() from Linux Sameer Goel
2018-05-24 7:53 ` Jan Beulich
2018-05-24 20:23 ` Sameer Goel [this message]
2018-05-25 7:07 ` Jan Beulich
2018-06-07 1:21 ` Sameer Goel
2018-05-24 0:46 ` [v2 2/6] passthrough/arm: Modify SMMU driver to use generic device definition Sameer Goel
2018-05-24 0:46 ` [v2 3/6] Add verbatim copy of arm-smmu-v3.c from Linux Sameer Goel
2018-05-24 0:46 ` [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver Sameer Goel
2018-05-24 4:48 ` Manish Jaggi
2018-05-24 20:18 ` Sameer Goel
2018-05-24 20:29 ` Sameer Goel
2018-05-25 4:41 ` Manish Jaggi
2018-05-25 8:45 ` Julien Grall
2018-05-30 19:46 ` Sameer Goel
2018-05-31 4:10 ` Manish Jaggi
2018-05-31 16:06 ` Goel, Sameer
2018-05-30 23:01 ` Sameer Goel
2018-05-31 4:13 ` Manish Jaggi
2018-05-31 15:57 ` Sameer Goel
2018-06-01 5:16 ` Manish Jaggi
2018-06-01 18:58 ` Sameer Goel
2018-06-02 21:26 ` Manish Jaggi
2018-05-24 7:57 ` Jan Beulich
2018-05-24 20:26 ` Sameer Goel
2018-05-25 7:10 ` Jan Beulich
2018-05-30 19:30 ` Sameer Goel
2018-05-24 0:46 ` [v2 5/6] drivers/passthrough/arm: Refactor code for arm smmu drivers Sameer Goel
2018-05-24 7:58 ` Jan Beulich
2018-05-24 20:30 ` Sameer Goel
2018-05-24 0:46 ` [v2 6/6] xen/smmu: Add a new config define for legacy SMMU Sameer Goel
2018-05-24 7:59 ` Jan Beulich
2018-05-24 8:52 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee35e24-cf78-5f33-c13d-f10715e899f4@linaro.org \
--to=sameer.goel@linaro.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=nd@arm.com \
--cc=roger.pau@citrix.com \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.