* [PATCH] ARM: imx: Use correct SRC base address
@ 2020-11-20 17:51 Robert Karszniewicz
2020-11-20 17:56 ` Robert Karszniewicz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-11-20 17:51 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, linux-arm-kernel
Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
forgot to rename a variable, which caused the wrong address to be used
and, in our case, the ULL getting falsely identified as ULZ.
Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
arch/arm/mach-imx/anatop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/anatop.c b/arch/arm/mach-imx/anatop.c
index d841bed8664d..7bb47eb3fc07 100644
--- a/arch/arm/mach-imx/anatop.c
+++ b/arch/arm/mach-imx/anatop.c
@@ -136,7 +136,7 @@ void __init imx_init_revision_from_anatop(void)
src_np = of_find_compatible_node(NULL, NULL,
"fsl,imx6ul-src");
- src_base = of_iomap(np, 0);
+ src_base = of_iomap(src_np, 0);
of_node_put(src_np);
WARN_ON(!src_base);
sbmr2 = readl_relaxed(src_base + SRC_SBMR2);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: imx: Use correct SRC base address
2020-11-20 17:51 [PATCH] ARM: imx: Use correct SRC base address Robert Karszniewicz
@ 2020-11-20 17:56 ` Robert Karszniewicz
2020-11-20 18:09 ` Fabio Estevam
2020-12-01 0:09 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-11-20 17:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team, Anson Huang
On 11/20/20 6:51 PM, Robert Karszniewicz wrote:
> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
> forgot to rename a variable, which caused the wrong address to be used
> and, in our case, the ULL getting falsely identified as ULZ.
>
> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---
Sorry, I failed to Cc: with send-email.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: imx: Use correct SRC base address
2020-11-20 17:51 [PATCH] ARM: imx: Use correct SRC base address Robert Karszniewicz
2020-11-20 17:56 ` Robert Karszniewicz
@ 2020-11-20 18:09 ` Fabio Estevam
2020-11-20 18:13 ` Robert Karszniewicz
2020-12-01 0:09 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2020-11-20 18:09 UTC (permalink / raw)
To: Robert Karszniewicz
Cc: Sascha Hauer, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Robert,
On Fri, Nov 20, 2020 at 2:52 PM Robert Karszniewicz
<r.karszniewicz@phytec.de> wrote:
>
> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
> forgot to rename a variable, which caused the wrong address to be used
> and, in our case, the ULL getting falsely identified as ULZ.
>
> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Just a small suggestion: next time, please do not put a blank line
between Fixes and Signed-off-by tag.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: imx: Use correct SRC base address
2020-11-20 18:09 ` Fabio Estevam
@ 2020-11-20 18:13 ` Robert Karszniewicz
0 siblings, 0 replies; 5+ messages in thread
From: Robert Karszniewicz @ 2020-11-20 18:13 UTC (permalink / raw)
To: Fabio Estevam
Cc: Sascha Hauer, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On 11/20/20 7:09 PM, Fabio Estevam wrote:
> Hi Robert,
>
> On Fri, Nov 20, 2020 at 2:52 PM Robert Karszniewicz
> <r.karszniewicz@phytec.de> wrote:
>>
>> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
>> forgot to rename a variable, which caused the wrong address to be used
>> and, in our case, the ULL getting falsely identified as ULZ.
>>
>> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>>
>> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Just a small suggestion: next time, please do not put a blank line
> between Fixes and Signed-off-by tag.
Understood, thank you!
>
> Thanks
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: imx: Use correct SRC base address
2020-11-20 17:51 [PATCH] ARM: imx: Use correct SRC base address Robert Karszniewicz
2020-11-20 17:56 ` Robert Karszniewicz
2020-11-20 18:09 ` Fabio Estevam
@ 2020-12-01 0:09 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-12-01 0:09 UTC (permalink / raw)
To: Robert Karszniewicz; +Cc: Sascha Hauer, linux-arm-kernel
On Fri, Nov 20, 2020 at 06:51:24PM +0100, Robert Karszniewicz wrote:
> Commit 4a4fb66119eb ("ARM: imx: Add missing of_node_put()") accidentally
> forgot to rename a variable, which caused the wrong address to be used
> and, in our case, the ULL getting falsely identified as ULZ.
>
> Fixes: 4a4fb66119eb ("ARM: imx: Add missing of_node_put()")
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-01 0:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 17:51 [PATCH] ARM: imx: Use correct SRC base address Robert Karszniewicz
2020-11-20 17:56 ` Robert Karszniewicz
2020-11-20 18:09 ` Fabio Estevam
2020-11-20 18:13 ` Robert Karszniewicz
2020-12-01 0:09 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.