From: Jingoo Han <jg1.han@samsung.com> To: "'Levente Kurusa'" <levex@linux.com>, "'Andrew Morton'" <akpm@linux-foundation.org> Cc: "'LKML'" <linux-kernel@vger.kernel.org>, "'Jean-Christophe Plagniol-Villard'" <plagnioj@jcrosoft.com>, "'Tomi Valkeinen'" <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, "'Jingoo Han'" <jg1.han@samsung.com> Subject: Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails Date: Mon, 16 Dec 2013 13:52:16 +0900 [thread overview] Message-ID: <006f01cefa1a$97ea4710$c7bed530$%han@samsung.com> (raw) In-Reply-To: <1386959996-7958-4-git-send-email-levex@linux.com> On Saturday, December 14, 2013 3:40 AM, Levente Kurusa wrote: > > Currently we kfree the container of the device which failed to register. > This is wrong as the last reference is not given up with a put_device > call. Also, now that we have put_device() callen, we no longer need > the kfree as the new_ld->dev.release function will take care of kfreeing > the associated memory. > > Signed-off-by: Levente Kurusa <levex@linux.com> (+cc Andrew Morton) Acked-by: Jingoo Han <jg1.han@samsung.com> It looks good. According to the comment of device_register, put_device() should be used, instead of directly freeing. ./drivers/base/core.c * NOTE: _Never_ directly free @dev after calling this function, even * if it returned an error! Always use put_device() to give up the * reference initialized in this function instead. */ int device_register(struct device *dev) { device_initialize(dev); return device_add(dev); } EXPORT_SYMBOL_GPL(device_register); Levente Kurusa, By the way, don't send the same mails three times, without any reason. It is the waste of traffic. :-( Best regards, Jingoo Han > --- > drivers/video/backlight/lcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c > index 93cf15e..7de847d 100644 > --- a/drivers/video/backlight/lcd.c > +++ b/drivers/video/backlight/lcd.c > @@ -228,7 +228,7 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent, > > rc = device_register(&new_ld->dev); > if (rc) { > - kfree(new_ld); > + put_device(&new_ld->dev); > return ERR_PTR(rc); > } > > -- > 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Jingoo Han <jg1.han@samsung.com> To: 'Levente Kurusa' <levex@linux.com>, 'Andrew Morton' <akpm@linux-foundation.org> Cc: 'LKML' <linux-kernel@vger.kernel.org>, 'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>, 'Tomi Valkeinen' <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com> Subject: Re: [PATCH 3/4] backlight: lcd: call put_device if device_register fails Date: Mon, 16 Dec 2013 04:52:16 +0000 [thread overview] Message-ID: <006f01cefa1a$97ea4710$c7bed530$%han@samsung.com> (raw) In-Reply-To: <1386959996-7958-4-git-send-email-levex@linux.com> On Saturday, December 14, 2013 3:40 AM, Levente Kurusa wrote: > > Currently we kfree the container of the device which failed to register. > This is wrong as the last reference is not given up with a put_device > call. Also, now that we have put_device() callen, we no longer need > the kfree as the new_ld->dev.release function will take care of kfreeing > the associated memory. > > Signed-off-by: Levente Kurusa <levex@linux.com> (+cc Andrew Morton) Acked-by: Jingoo Han <jg1.han@samsung.com> It looks good. According to the comment of device_register, put_device() should be used, instead of directly freeing. ./drivers/base/core.c * NOTE: _Never_ directly free @dev after calling this function, even * if it returned an error! Always use put_device() to give up the * reference initialized in this function instead. */ int device_register(struct device *dev) { device_initialize(dev); return device_add(dev); } EXPORT_SYMBOL_GPL(device_register); Levente Kurusa, By the way, don't send the same mails three times, without any reason. It is the waste of traffic. :-( Best regards, Jingoo Han > --- > drivers/video/backlight/lcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c > index 93cf15e..7de847d 100644 > --- a/drivers/video/backlight/lcd.c > +++ b/drivers/video/backlight/lcd.c > @@ -228,7 +228,7 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent, > > rc = device_register(&new_ld->dev); > if (rc) { > - kfree(new_ld); > + put_device(&new_ld->dev); > return ERR_PTR(rc); > } > > -- > 1.8.3.1
next prev parent reply other threads:[~2013-12-16 4:52 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1386959996-7958-1-git-send-email-levex@linux.com> [not found] ` <1386959996-7958-3-git-send-email-levex@linux.com> 2013-12-13 19:04 ` [PATCH 2/4] eisa: call put_device if device_register fails Bjorn Helgaas 2013-12-13 19:08 ` Levente Kurusa [not found] ` <1386959996-7958-2-git-send-email-levex@linux.com> 2013-12-14 17:25 ` [PATCH 1/4] net: phy: call put_device on device_register() failure Greg Kroah-Hartman [not found] ` <1386959996-7958-4-git-send-email-levex@linux.com> 2013-12-16 4:52 ` Jingoo Han [this message] 2013-12-16 4:52 ` [PATCH 3/4] backlight: lcd: call put_device if device_register fails Jingoo Han 2013-12-16 17:16 ` Levente Kurusa 2013-12-16 17:16 ` Levente Kurusa 2014-01-07 1:42 ` Jingoo Han 2014-01-07 1:42 ` Jingoo Han 2013-12-13 19:22 [PATCH 0/4] treewide: add missing put_device calls Levente Kurusa 2013-12-13 19:22 ` [PATCH 3/4] backlight: lcd: call put_device if device_register fails Levente Kurusa 2013-12-13 19:22 ` Levente Kurusa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='006f01cefa1a$97ea4710$c7bed530$%han@samsung.com' \ --to=jg1.han@samsung.com \ --cc=akpm@linux-foundation.org \ --cc=levex@linux.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=plagnioj@jcrosoft.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.