* [PATCH 01/15] serial: altera: remove unnecessary platform_set_drvdata()
@ 2013-05-07 7:15 Jingoo Han
2013-05-14 7:13 ` Tobias Klauser
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 7:15 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Jiri Slaby', linux-serial, 'Jingoo Han',
'Tobias Klauser'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/altera_uart.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/altera_uart.c b/drivers/tty/serial/altera_uart.c
index 13471dd..1d46966 100644
--- a/drivers/tty/serial/altera_uart.c
+++ b/drivers/tty/serial/altera_uart.c
@@ -604,7 +604,6 @@ static int altera_uart_remove(struct platform_device *pdev)
if (port) {
uart_remove_one_port(&altera_uart_driver, port);
- platform_set_drvdata(pdev, NULL);
port->mapbase = 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 01/15] serial: altera: remove unnecessary platform_set_drvdata()
2013-05-07 7:15 [PATCH 01/15] serial: altera: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-14 7:13 ` Tobias Klauser
0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2013-05-14 7:13 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Greg Kroah-Hartman', 'Jiri Slaby', linux-serial
On 2013-05-07 at 09:15:28 +0200, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Tobias Klauser <tklauser@distanz.ch>
Thanks a lot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 7:15 [PATCH 01/15] serial: altera: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-14 7:13 ` Tobias Klauser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.