From: "M Tamseel Shams" <m.shams@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: <kgene@kernel.org>, <gregkh@linuxfoundation.org>,
<jslaby@suse.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alim.akhtar@samsung.com>
Subject: RE: [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC
Date: Mon, 13 Jul 2020 19:33:42 +0530 [thread overview]
Message-ID: <007301d6591e$74a4b2d0$5dee1870$@samsung.com> (raw)
In-Reply-To: <20200706081307.GA13025@kozik-lap>
> > In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP
> > is having 2 interrupt lines.
> > However, in other SoCs like s3c6400, s5pv210, exynos5433, and
> > exynos4210 UART is having only 1 interrupt line. Due to this,
> > "platform_get_irq(platdev, 1)"
> > call in the driver gives the following warning:
> > "IRQ index 1 not found" on recent platforms.
> >
> > This patch re-factors the IRQ resources handling for each platform and
> > hence fixing the above warnings seen on some platforms.
> >
> > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> > ---
> > Removed the logic of irq_cnt and directly using
> > s3c24xx_serial_has_interrupt_mask() to check for number of interrupt
> > lines.
> >
> > drivers/tty/serial/samsung_tty.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 6ef614d8648c..8a955f3d8975 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -1908,10 +1908,13 @@ static int s3c24xx_serial_init_port(struct
> s3c24xx_uart_port *ourport,
> > else {
> > port->irq = ret;
> > ourport->rx_irq = ret;
> > - ourport->tx_irq = ret + 1;
> > + if (s3c24xx_serial_has_interrupt_mask(port))
> > + ourport->tx_irq = ret;
>
> Hi,
>
> I don't understand: Why do you assign here the same interrupt as RX?
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I was assigning the same interrupt to Tx and Rx for UART, which have one interrupt line,
but ourport->tx_irq is never used for those UART's. So, leaving it as it was.
The change now is using platform_get_irq_optional () instead of platform_get_irq ()
to avoid false-positive error.
Thanks & Regards,
Tamseel
WARNING: multiple messages have this Message-ID (diff)
From: "M Tamseel Shams" <m.shams@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
kgene@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC
Date: Mon, 13 Jul 2020 19:33:42 +0530 [thread overview]
Message-ID: <007301d6591e$74a4b2d0$5dee1870$@samsung.com> (raw)
In-Reply-To: <20200706081307.GA13025@kozik-lap>
> > In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP
> > is having 2 interrupt lines.
> > However, in other SoCs like s3c6400, s5pv210, exynos5433, and
> > exynos4210 UART is having only 1 interrupt line. Due to this,
> > "platform_get_irq(platdev, 1)"
> > call in the driver gives the following warning:
> > "IRQ index 1 not found" on recent platforms.
> >
> > This patch re-factors the IRQ resources handling for each platform and
> > hence fixing the above warnings seen on some platforms.
> >
> > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> > ---
> > Removed the logic of irq_cnt and directly using
> > s3c24xx_serial_has_interrupt_mask() to check for number of interrupt
> > lines.
> >
> > drivers/tty/serial/samsung_tty.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 6ef614d8648c..8a955f3d8975 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -1908,10 +1908,13 @@ static int s3c24xx_serial_init_port(struct
> s3c24xx_uart_port *ourport,
> > else {
> > port->irq = ret;
> > ourport->rx_irq = ret;
> > - ourport->tx_irq = ret + 1;
> > + if (s3c24xx_serial_has_interrupt_mask(port))
> > + ourport->tx_irq = ret;
>
> Hi,
>
> I don't understand: Why do you assign here the same interrupt as RX?
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I was assigning the same interrupt to Tx and Rx for UART, which have one interrupt line,
but ourport->tx_irq is never used for those UART's. So, leaving it as it was.
The change now is using platform_get_irq_optional () instead of platform_get_irq ()
to avoid false-positive error.
Thanks & Regards,
Tamseel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-14 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200704142658epcas5p254ae909fedb07dda58cece5d6d5252b4@epcas5p2.samsung.com>
2020-07-04 14:06 ` [PATCH v3] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC Tamseel Shams
2020-07-04 14:06 ` Tamseel Shams
2020-07-06 8:13 ` Krzysztof Kozlowski
2020-07-06 8:13 ` Krzysztof Kozlowski
2020-07-13 14:03 ` M Tamseel Shams [this message]
2020-07-13 14:03 ` M Tamseel Shams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007301d6591e$74a4b2d0$5dee1870$@samsung.com' \
--to=m.shams@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.