* [PATCH 1/1] dosfstools: really compile supporting large files [ Fix: 409915 ]
@ 2013-03-25 20:49 Joe Slater
2013-03-25 21:15 ` Chris Larson
0 siblings, 1 reply; 3+ messages in thread
From: Joe Slater @ 2013-03-25 20:49 UTC (permalink / raw)
To: openembedded-core
CQID: 409915
Makefile in the package tries to set _FILE_OFFSET_BITS=64,
but we clobber that with our CFLAGS, so we add it in
the recipe.
Signed-off-by: Joe Slater <jslater@windriver.com>
---
.../recipes-devtools/dosfstools/dosfstools_2.11.bb | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
index eca54f1..b7b85f0 100644
--- a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
+++ b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
@@ -7,7 +7,7 @@ DESCRIPTION = "DOS FAT Filesystem Utilities"
SECTION = "base"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://mkdosfs/COPYING;md5=cbe67f08d6883bff587f615f0cc81aa8"
-PR = "r4"
+PR = "r5"
SRC_URI = "ftp://ftp.uni-erlangen.de/pub/Linux/LOCAL/dosfstools/dosfstools-${PV}.src.tar.gz \
file://mkdosfs-bootcode.patch \
@@ -22,6 +22,11 @@ SRC_URI = "ftp://ftp.uni-erlangen.de/pub/Linux/LOCAL/dosfstools/dosfstools-${PV}
SRC_URI[md5sum] = "407d405ade410f7597d364ab5dc8c9f6"
SRC_URI[sha256sum] = "0eac6d12388b3d9ed78684529c1b0d9346fa2abbe406c4d4a3eb5a023c98a484"
+# Makefile sets this, but we clobber its CFLAGS, so
+# add this in here to for sure allow for big files.
+#
+CFLAGS_append = " -D_FILE_OFFSET_BITS=64"
+
do_install () {
oe_runmake "PREFIX=${D}" "SBINDIR=${D}${sbindir}" \
"MANDIR=${D}${mandir}/man8" install
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dosfstools: really compile supporting large files [ Fix: 409915 ]
2013-03-25 20:49 [PATCH 1/1] dosfstools: really compile supporting large files [ Fix: 409915 ] Joe Slater
@ 2013-03-25 21:15 ` Chris Larson
2013-03-26 17:37 ` Slater, Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Chris Larson @ 2013-03-25 21:15 UTC (permalink / raw)
To: Joe Slater; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Mon, Mar 25, 2013 at 1:49 PM, Joe Slater <jslater@windriver.com> wrote:
> CQID: 409915
>
> Makefile in the package tries to set _FILE_OFFSET_BITS=64,
> but we clobber that with our CFLAGS, so we add it in
> the recipe.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
>
Afaik there is a largefile distro feature, should this use that, through
packageconfig?
--
Christopher Larson
[-- Attachment #2: Type: text/html, Size: 786 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dosfstools: really compile supporting large files [ Fix: 409915 ]
2013-03-25 21:15 ` Chris Larson
@ 2013-03-26 17:37 ` Slater, Joseph
0 siblings, 0 replies; 3+ messages in thread
From: Slater, Joseph @ 2013-03-26 17:37 UTC (permalink / raw)
To: Chris Larson; +Cc: Patches and discussions about the oe-core layer
> -----Original Message-----
> From: kergoth@gmail.com [mailto:kergoth@gmail.com] On Behalf Of Chris Larson
> Sent: Monday, March 25, 2013 2:16 PM
> To: Slater, Joseph
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 1/1] dosfstools: really compile supporting large files [
> Fix: 409915 ]
>
>
> On Mon, Mar 25, 2013 at 1:49 PM, Joe Slater <jslater@windriver.com> wrote:
>
>
> CQID: 409915
>
> Makefile in the package tries to set _FILE_OFFSET_BITS=64,
> but we clobber that with our CFLAGS, so we add it in
> the recipe.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
>
>
> Afaik there is a largefile distro feature, should this use that, through packageconfig?
This is really aimed at dosfstools-native, but I noticed, just by chance, that bzip2
unconditionally sets this, apparently without ill effect.
Joe
> --
> Christopher Larson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-26 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-25 20:49 [PATCH 1/1] dosfstools: really compile supporting large files [ Fix: 409915 ] Joe Slater
2013-03-25 21:15 ` Chris Larson
2013-03-26 17:37 ` Slater, Joseph
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.