[PATCH 1/1] libwebp: do not assume armv7a has neon intrinsics

[PATCH 1/1] libwebp: do not assume armv7a has neon intrinsics

[Joe Slater]

configure incorrectly thinks -mfpu=neon is in CC for armv7a,
so defeat automatic neon detection.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 meta/recipes-multimedia/webp/libwebp_0.5.1.bb |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb b/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
index 222bd56..2d86b4a 100644
--- a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
+++ b/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
@@ -26,6 +26,9 @@ EXTRA_OECONF = " \
     --enable-libwebpdemux \
     --enable-threading \
 "
+# configure incorrectly believes that armv7a has -mfpu=neon
+#
+EXTRA_OECONF_append_armv7a = " --disable-neon"
 
 inherit autotools lib_package
 
-- 
1.7.9.5

Re: [PATCH 1/1] libwebp: do not assume armv7a has neon intrinsics

[Andre McCurdy]

On Tue, Sep 6, 2016 at 1:25 PM, Joe Slater <jslater@windriver.com> wrote:
> configure incorrectly thinks -mfpu=neon is in CC for armv7a,
> so defeat automatic neon detection.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  meta/recipes-multimedia/webp/libwebp_0.5.1.bb |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb b/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
> index 222bd56..2d86b4a 100644
> --- a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
> +++ b/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
> @@ -26,6 +26,9 @@ EXTRA_OECONF = " \
>      --enable-libwebpdemux \
>      --enable-threading \
>  "
> +# configure incorrectly believes that armv7a has -mfpu=neon
> +#
> +EXTRA_OECONF_append_armv7a = " --disable-neon"

Unless you want to disable neon for all armv7a builds, perhaps
something like this would be better:

  EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "neon", "",
"--disable-neon" ,d)}"

>  inherit autotools lib_package
>
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/1] libwebp: do not assume armv7a has neon intrinsics

[Slater, Joseph]

> -----Original Message-----
> From: Andre McCurdy [mailto:armccurdy@gmail.com]
> Sent: Tuesday, September 06, 2016 1:52 PM
> To: Slater, Joseph
> Cc: OE Core mailing list
> Subject: Re: [OE-core] [oe-core][PATCH 1/1] libwebp: do not assume armv7a has neon
> intrinsics
> 
> On Tue, Sep 6, 2016 at 1:25 PM, Joe Slater <jslater@windriver.com> wrote:
> > configure incorrectly thinks -mfpu=neon is in CC for armv7a,
> > so defeat automatic neon detection.
> >
> > Signed-off-by: Joe Slater <jslater@windriver.com>
> > ---
> >  meta/recipes-multimedia/webp/libwebp_0.5.1.bb |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb b/meta/recipes-
> multimedia/webp/libwebp_0.5.1.bb
> > index 222bd56..2d86b4a 100644
> > --- a/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
> > +++ b/meta/recipes-multimedia/webp/libwebp_0.5.1.bb
> > @@ -26,6 +26,9 @@ EXTRA_OECONF = " \
> >      --enable-libwebpdemux \
> >      --enable-threading \
> >  "
> > +# configure incorrectly believes that armv7a has -mfpu=neon
> > +#
> > +EXTRA_OECONF_append_armv7a = " --disable-neon"
> 
> Unless you want to disable neon for all armv7a builds, perhaps
> something like this would be better:
> 
>   EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "neon", "",
> "--disable-neon" ,d)}"

That's a good idea, but I'd only do the check for arm.  Also, if we do have
neon, shouldn't the core be armv7a-neon, or something like that?  Can't we
rely on the overrides?

Joe


> 
> >  inherit autotools lib_package
> >
> > --
> > 1.7.9.5
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core