[v2][PATCH 1/1] build-compare: add date to PV

[v2][PATCH 1/1] build-compare: add date to PV

[Joe Slater]

We want PV values to be easily ordered, so
use the latest entry in build-compare.changes which
will also match the date of SRCREV.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 .../build-compare/build-compare_git.bb             |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-devtools/build-compare/build-compare_git.bb
index eb12e40..bdbad03 100644
--- a/meta/recipes-devtools/build-compare/build-compare_git.bb
+++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
@@ -17,8 +17,10 @@ SRC_URI = "git://github.com/openSUSE/build-compare.git \
            file://functions.sh-improve-deb-and-ipk-checking.patch \
            "
 
+# Date matches entry in build-compare.changes and date of SRCREV.
+#
 SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
-PV = "git+${SRCPV}"
+PV = "2015.02.10+git${SRCPV}"
 
 S = "${WORKDIR}/git"
 
-- 
1.7.9.5

Re: [v2][PATCH 1/1] build-compare: add date to PV

[Slater, Joseph]

Given that PV for *_git recipes should now be specified and
start with a version, it would be nice to shorten (or eliminate)
SRCPV.  At least get rid of the AUTOINC.  Perhaps shorten the
amount of SRCREV included.  The point is that as currently
computed, PV will be far longer than the useful information
it provides.

Also, should PE be defined given that the form of PV has changed?
I know it hasn't been for any of the recipes modified so far.

Joe


> -----Original Message-----
> From: Joe Slater [mailto:jslater@windriver.com]
> Sent: Thursday, March 16, 2017 10:19 AM
> To: openembedded-core@lists.openembedded.org
> Cc: Slater, Joseph
> Subject: [oe-core][v2][PATCH 1/1] build-compare: add date to PV
> 
> We want PV values to be easily ordered, so
> use the latest entry in build-compare.changes which
> will also match the date of SRCREV.
> 
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  .../build-compare/build-compare_git.bb             |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-
> devtools/build-compare/build-compare_git.bb
> index eb12e40..bdbad03 100644
> --- a/meta/recipes-devtools/build-compare/build-compare_git.bb
> +++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
> @@ -17,8 +17,10 @@ SRC_URI = "git://github.com/openSUSE/build-compare.git \
>             file://functions.sh-improve-deb-and-ipk-checking.patch \
>             "
> 
> +# Date matches entry in build-compare.changes and date of SRCREV.
> +#
>  SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
> -PV = "git+${SRCPV}"
> +PV = "2015.02.10+git${SRCPV}"
> 
>  S = "${WORKDIR}/git"
> 
> --
> 1.7.9.5

Re: [v2][PATCH 1/1] build-compare: add date to PV

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

On 16 March 2017 at 17:28, Slater, Joseph <joe.slater@windriver.com> wrote:

> Also, should PE be defined given that the form of PV has changed?
> I know it hasn't been for any of the recipes modified so far.
>

Depends on how it changed.  Numbers sort before letters, so yes this needs
a PE bump.

Ross

[-- Attachment #2: Type: text/html, Size: 731 bytes --]

Re: [v2][PATCH 1/1] build-compare: add date to PV

[Richard Purdie]

On Thu, 2017-03-16 at 17:28 +0000, Slater, Joseph wrote:
> Given that PV for *_git recipes should now be specified and
> start with a version, it would be nice to shorten (or eliminate)
> SRCPV.  At least get rid of the AUTOINC.  Perhaps shorten the
> amount of SRCREV included.  The point is that as currently
> computed, PV will be far longer than the useful information
> it provides.

I thought we already did?

e.g. for the kernel you see packages like:

kernel-module-xt-u32-4.10.0-yocto-standard_4.10+git0+805ea440c7_b259a5d744-r0.30_qemux86_64.ipk

which has several shortened hashes in it.

Cheers,

Richard

Re: [v2][PATCH 1/1] build-compare: add date to PV

[Slater, Joseph]

> -----Original Message-----
> From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
> Sent: Thursday, March 16, 2017 3:14 PM
> To: Slater, Joseph; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [oe-core][v2][PATCH 1/1] build-compare: add date to PV
> 
> On Thu, 2017-03-16 at 17:28 +0000, Slater, Joseph wrote:
> > Given that PV for *_git recipes should now be specified and
> > start with a version, it would be nice to shorten (or eliminate)
> > SRCPV.  At least get rid of the AUTOINC.  Perhaps shorten the
> > amount of SRCREV included.  The point is that as currently
> > computed, PV will be far longer than the useful information
> > it provides.
> 
> I thought we already did?
> 
> e.g. for the kernel you see packages like:
> 
> kernel-module-xt-u32-4.10.0-yocto-standard_4.10+git0+805ea440c7_b259a5d744-
> r0.30_qemux86_64.ipk
> 
> which has several shortened hashes in it.

I guess it matters where you look.  For things like rpm's you see "...+git0+...".  For things
like items generated by the archiver you see "...+gitAUTOINC+...".  In either case, the
characters appended to "git" do not seem to be useful.  And, since the 805... and b25...
hashes are just anecdotal because the <version>-yocto determines version sequence, they could
be much shorter.

Joe

> 
> Cheers,
> 
> Richard