[dm-devel] [PATCH v3] multipathd: fix path checkint not changed when path state changed from delay to failed

[dm-devel] [PATCH v3] multipathd: fix path checkint not changed when path state changed from delay to failed

[wucy11]

[-- Attachment #1: Type: text/html, Size: 3992 bytes --]

[-- Attachment #2: Type: text/plain, Size: 93 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3] multipathd: fix path checkint not changed when path state changed from delay to failed

[Benjamin Marzinski]

On Mon, Dec 21, 2020 at 11:13:38AM +0800, wucy11 wrote:
> Hi all,
> The new patch shown as below acocording to ben's suggestion,  please ignore v2,
> thanks.
> 
> From 31ec4e9c270ff854b8edc526c5bcc9b24608d751 Mon Sep 17 00:00:00 2001
> From: Chongyun Wu <wucy11@chinatelecom.cn>
> Date: Wed, 16 Dec 2020 13:59:16 +0800
> Subject: [PATCH] multipathd: fix path checkint not changed when path state
>  form delay to failed
> 
> Check_path: when path state change back to failed from delay state, should
> change
> this path's check interval time to the shortest delay to faster path state
> check.
> 
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Chongyun Wu <wucy11@chinatelecom.cn>
> ---
>  multipathd/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index a4abbb27..9fd34e97 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2166,6 +2166,11 @@ check_path (struct vectors * vecs, struct path * pp,
> unsigned int ticks)
>   (pp->state == PATH_DELAYED)) {
>   /* If path state become failed again cancel path delay state */
>   pp->state = newstate;
> + /*
> + * path state bad again should change the check interval time
> + * to the shortest delay
> + */
> + pp->checkint = checkint;
>   return 1;
>   }
>   if (!pp->mpp) {
> -- 
> 2.29.2.windows.3
> 
> Best Regard,
> Chongyun Wu

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3] multipathd: fix path checkint not changed when path state changed from delay to failed

[Martin Wilck]

Hello Chongyun,

On Mon, 2020-12-21 at 11:13 +0800, wucy11 wrote:
> Hi all,
> The new patch shown as below acocording to ben's suggestion,  please
> ignore v2, thanks.
> 
> From 31ec4e9c270ff854b8edc526c5bcc9b24608d751 Mon Sep 17 00:00:00
> 2001
> From: Chongyun Wu <wucy11@chinatelecom.cn>
> Date: Wed, 16 Dec 2020 13:59:16 +0800
> Subject: [PATCH] multipathd: fix path checkint not changed when path
> state
>  form delay to failed
> 
> Check_path: when path state change back to failed from delay state,
> should change
> this path's check interval time to the shortest delay to faster path
> state check.
> 
> Signed-off-by: Chongyun Wu <wucy11@chinatelecom.cn>
> ---
>  multipathd/main.c | 5 +++++
>  1 file changed, 5 insertions(+)

Thank you. Please resubmit in text format.

Martin



--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel