All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Use long endian options for ppc64
@ 2022-01-31  9:17 Miroslav Rezanina
  2022-02-01  0:00 ` Philippe Mathieu-Daudé via
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Miroslav Rezanina @ 2022-01-31  9:17 UTC (permalink / raw)
  To: qemu-devel; +Cc: pbonzini, Miroslav Rezanina, richard.henderson, f4bug

GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
equivalent on ppc64 architecture. However, Clang supports only long
version of the options.

Use longer form in configure to properly support both GCC and Clang
compiler. In addition, fix this issue in tcg test configure.

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

---
This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.

v2:
 - handle both -mlittle and -mbig usage
 - fix tests/tcg/configure.sh
---
 configure              | 4 ++--
 tests/tcg/configure.sh | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index e6cfc0e4be..066fa29b70 100755
--- a/configure
+++ b/configure
@@ -655,10 +655,10 @@ case "$cpu" in
   ppc)
     CPU_CFLAGS="-m32" ;;
   ppc64)
-    CPU_CFLAGS="-m64 -mbig" ;;
+    CPU_CFLAGS="-m64 -mbig-endian" ;;
   ppc64le)
     cpu="ppc64"
-    CPU_CFLAGS="-m64 -mlittle" ;;
+    CPU_CFLAGS="-m64 -mlittle-endian" ;;
 
   s390)
     CPU_CFLAGS="-m31" ;;
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index 309335a2bd..21959e1fde 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -64,9 +64,9 @@ fi
 : ${cross_cc_ppc="powerpc-linux-gnu-gcc"}
 : ${cross_cc_cflags_ppc="-m32"}
 : ${cross_cc_ppc64="powerpc64-linux-gnu-gcc"}
-: ${cross_cc_cflags_ppc64="-m64 -mbig"}
+: ${cross_cc_cflags_ppc64="-m64 -mbig-endian"}
 : ${cross_cc_ppc64le="$cross_cc_ppc64"}
-: ${cross_cc_cflags_ppc64le="-m64 -mlittle"}
+: ${cross_cc_cflags_ppc64le="-m64 -mlittle-endian"}
 : ${cross_cc_riscv64="riscv64-linux-gnu-gcc"}
 : ${cross_cc_s390x="s390x-linux-gnu-gcc"}
 : ${cross_cc_sh4="sh4-linux-gnu-gcc"}
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] Use long endian options for ppc64
  2022-01-31  9:17 [PATCH v2] Use long endian options for ppc64 Miroslav Rezanina
@ 2022-02-01  0:00 ` Philippe Mathieu-Daudé via
  2022-02-08 13:47 ` Greg Kurz
  2022-02-08 20:57 ` Matheus K. Ferst
  2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-02-01  0:00 UTC (permalink / raw)
  To: Miroslav Rezanina, qemu-devel; +Cc: pbonzini, richard.henderson

On 31/1/22 10:17, Miroslav Rezanina wrote:
> GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
> equivalent on ppc64 architecture. However, Clang supports only long
> version of the options.
> 
> Use longer form in configure to properly support both GCC and Clang
> compiler. In addition, fix this issue in tcg test configure.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> 
> ---
> This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
> 
> v2:
>   - handle both -mlittle and -mbig usage
>   - fix tests/tcg/configure.sh
> ---
>   configure              | 4 ++--
>   tests/tcg/configure.sh | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] Use long endian options for ppc64
  2022-01-31  9:17 [PATCH v2] Use long endian options for ppc64 Miroslav Rezanina
  2022-02-01  0:00 ` Philippe Mathieu-Daudé via
@ 2022-02-08 13:47 ` Greg Kurz
  2022-02-09  9:24   ` Greg Kurz
  2022-02-08 20:57 ` Matheus K. Ferst
  2 siblings, 1 reply; 5+ messages in thread
From: Greg Kurz @ 2022-02-08 13:47 UTC (permalink / raw)
  To: Miroslav Rezanina; +Cc: pbonzini, richard.henderson, qemu-devel, f4bug

On Mon, 31 Jan 2022 10:17:14 +0100
Miroslav Rezanina <mrezanin@redhat.com> wrote:

> GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
> equivalent on ppc64 architecture. However, Clang supports only long
> version of the options.
> 
> Use longer form in configure to properly support both GCC and Clang
> compiler. In addition, fix this issue in tcg test configure.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> 
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

> This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
> 
> v2:
>  - handle both -mlittle and -mbig usage
>  - fix tests/tcg/configure.sh
> ---
>  configure              | 4 ++--
>  tests/tcg/configure.sh | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index e6cfc0e4be..066fa29b70 100755
> --- a/configure
> +++ b/configure
> @@ -655,10 +655,10 @@ case "$cpu" in
>    ppc)
>      CPU_CFLAGS="-m32" ;;
>    ppc64)
> -    CPU_CFLAGS="-m64 -mbig" ;;
> +    CPU_CFLAGS="-m64 -mbig-endian" ;;
>    ppc64le)
>      cpu="ppc64"
> -    CPU_CFLAGS="-m64 -mlittle" ;;
> +    CPU_CFLAGS="-m64 -mlittle-endian" ;;
>  
>    s390)
>      CPU_CFLAGS="-m31" ;;
> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> index 309335a2bd..21959e1fde 100755
> --- a/tests/tcg/configure.sh
> +++ b/tests/tcg/configure.sh
> @@ -64,9 +64,9 @@ fi
>  : ${cross_cc_ppc="powerpc-linux-gnu-gcc"}
>  : ${cross_cc_cflags_ppc="-m32"}
>  : ${cross_cc_ppc64="powerpc64-linux-gnu-gcc"}
> -: ${cross_cc_cflags_ppc64="-m64 -mbig"}
> +: ${cross_cc_cflags_ppc64="-m64 -mbig-endian"}
>  : ${cross_cc_ppc64le="$cross_cc_ppc64"}
> -: ${cross_cc_cflags_ppc64le="-m64 -mlittle"}
> +: ${cross_cc_cflags_ppc64le="-m64 -mlittle-endian"}
>  : ${cross_cc_riscv64="riscv64-linux-gnu-gcc"}
>  : ${cross_cc_s390x="s390x-linux-gnu-gcc"}
>  : ${cross_cc_sh4="sh4-linux-gnu-gcc"}



^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] Use long endian options for ppc64
  2022-01-31  9:17 [PATCH v2] Use long endian options for ppc64 Miroslav Rezanina
  2022-02-01  0:00 ` Philippe Mathieu-Daudé via
  2022-02-08 13:47 ` Greg Kurz
@ 2022-02-08 20:57 ` Matheus K. Ferst
  2 siblings, 0 replies; 5+ messages in thread
From: Matheus K. Ferst @ 2022-02-08 20:57 UTC (permalink / raw)
  To: Miroslav Rezanina, qemu-devel; +Cc: pbonzini, richard.henderson, f4bug

On 31/01/2022 06:17, Miroslav Rezanina wrote:
> GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
> equivalent on ppc64 architecture. However, Clang supports only long
> version of the options.
> 
> Use longer form in configure to properly support both GCC and Clang
> compiler. In addition, fix this issue in tcg test configure.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> 
> ---
> This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
> 
> v2:
>   - handle both -mlittle and -mbig usage
>   - fix tests/tcg/configure.sh
> ---
>   configure              | 4 ++--
>   tests/tcg/configure.sh | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index e6cfc0e4be..066fa29b70 100755
> --- a/configure
> +++ b/configure
> @@ -655,10 +655,10 @@ case "$cpu" in
>     ppc)
>       CPU_CFLAGS="-m32" ;;
>     ppc64)
> -    CPU_CFLAGS="-m64 -mbig" ;;
> +    CPU_CFLAGS="-m64 -mbig-endian" ;;
>     ppc64le)
>       cpu="ppc64"
> -    CPU_CFLAGS="-m64 -mlittle" ;;
> +    CPU_CFLAGS="-m64 -mlittle-endian" ;;
> 
>     s390)
>       CPU_CFLAGS="-m31" ;;
> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> index 309335a2bd..21959e1fde 100755
> --- a/tests/tcg/configure.sh
> +++ b/tests/tcg/configure.sh
> @@ -64,9 +64,9 @@ fi
>   : ${cross_cc_ppc="powerpc-linux-gnu-gcc"}
>   : ${cross_cc_cflags_ppc="-m32"}
>   : ${cross_cc_ppc64="powerpc64-linux-gnu-gcc"}
> -: ${cross_cc_cflags_ppc64="-m64 -mbig"}
> +: ${cross_cc_cflags_ppc64="-m64 -mbig-endian"}
>   : ${cross_cc_ppc64le="$cross_cc_ppc64"}
> -: ${cross_cc_cflags_ppc64le="-m64 -mlittle"}
> +: ${cross_cc_cflags_ppc64le="-m64 -mlittle-endian"}
>   : ${cross_cc_riscv64="riscv64-linux-gnu-gcc"}
>   : ${cross_cc_s390x="s390x-linux-gnu-gcc"}
>   : ${cross_cc_sh4="sh4-linux-gnu-gcc"}
> --
> 2.34.1
> 
> 

The patch is fine, but some PPC tests are not compiling with Clang. I've 
sent an RFC about these issues: 
https://lists.gnu.org/archive/html/qemu-ppc/2022-02/msg00116.html

Thanks,
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] Use long endian options for ppc64
  2022-02-08 13:47 ` Greg Kurz
@ 2022-02-09  9:24   ` Greg Kurz
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kurz @ 2022-02-09  9:24 UTC (permalink / raw)
  To: Miroslav Rezanina
  Cc: richard.henderson, qemu-devel, f4bug, qemu-ppc,
	Cédric Le Goater, pbonzini

On Tue, 8 Feb 2022 14:47:19 +0100
Greg Kurz <groug@kaod.org> wrote:

> On Mon, 31 Jan 2022 10:17:14 +0100
> Miroslav Rezanina <mrezanin@redhat.com> wrote:
> 
> > GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
> > equivalent on ppc64 architecture. However, Clang supports only long
> > version of the options.
> > 
> > Use longer form in configure to properly support both GCC and Clang
> > compiler. In addition, fix this issue in tcg test configure.
> > 
> > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> > 
> > ---
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>
> 

Cc'ing QEMU PPC folks since they're likely the primary users
of ppc64 hosts.

> > This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
> > 
> > v2:
> >  - handle both -mlittle and -mbig usage
> >  - fix tests/tcg/configure.sh
> > ---
> >  configure              | 4 ++--
> >  tests/tcg/configure.sh | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/configure b/configure
> > index e6cfc0e4be..066fa29b70 100755
> > --- a/configure
> > +++ b/configure
> > @@ -655,10 +655,10 @@ case "$cpu" in
> >    ppc)
> >      CPU_CFLAGS="-m32" ;;
> >    ppc64)
> > -    CPU_CFLAGS="-m64 -mbig" ;;
> > +    CPU_CFLAGS="-m64 -mbig-endian" ;;
> >    ppc64le)
> >      cpu="ppc64"
> > -    CPU_CFLAGS="-m64 -mlittle" ;;
> > +    CPU_CFLAGS="-m64 -mlittle-endian" ;;
> >  
> >    s390)
> >      CPU_CFLAGS="-m31" ;;
> > diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> > index 309335a2bd..21959e1fde 100755
> > --- a/tests/tcg/configure.sh
> > +++ b/tests/tcg/configure.sh
> > @@ -64,9 +64,9 @@ fi
> >  : ${cross_cc_ppc="powerpc-linux-gnu-gcc"}
> >  : ${cross_cc_cflags_ppc="-m32"}
> >  : ${cross_cc_ppc64="powerpc64-linux-gnu-gcc"}
> > -: ${cross_cc_cflags_ppc64="-m64 -mbig"}
> > +: ${cross_cc_cflags_ppc64="-m64 -mbig-endian"}
> >  : ${cross_cc_ppc64le="$cross_cc_ppc64"}
> > -: ${cross_cc_cflags_ppc64le="-m64 -mlittle"}
> > +: ${cross_cc_cflags_ppc64le="-m64 -mlittle-endian"}
> >  : ${cross_cc_riscv64="riscv64-linux-gnu-gcc"}
> >  : ${cross_cc_s390x="s390x-linux-gnu-gcc"}
> >  : ${cross_cc_sh4="sh4-linux-gnu-gcc"}
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-09  9:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31  9:17 [PATCH v2] Use long endian options for ppc64 Miroslav Rezanina
2022-02-01  0:00 ` Philippe Mathieu-Daudé via
2022-02-08 13:47 ` Greg Kurz
2022-02-09  9:24   ` Greg Kurz
2022-02-08 20:57 ` Matheus K. Ferst

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.