* [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static
@ 2020-03-12 20:24 julien
2020-03-13 10:06 ` Wei Liu
2020-03-13 12:09 ` Paul Durrant
0 siblings, 2 replies; 3+ messages in thread
From: julien @ 2020-03-12 20:24 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, Ian Jackson, Wei Liu, paul
From: Julien Grall <jgrall@amazon.com>
xen-init-dom0 is a standalone binary, so all the functions but the
main() should be static.
Signed-off-by: Julien Grall <jgrall@amazon.com>
Cc: paul@xen.org
---
tools/helpers/xen-init-dom0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index 56f69ab66f..c99224a4b6 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -12,7 +12,7 @@
#define DOMNAME_PATH "/local/domain/0/name"
#define DOMID_PATH "/local/domain/0/domid"
-int clear_domid_history(void)
+static int clear_domid_history(void)
{
int rc = 1;
xentoollog_logger_stdiostream *logger;
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static
2020-03-12 20:24 [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static julien
@ 2020-03-13 10:06 ` Wei Liu
2020-03-13 12:09 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2020-03-13 10:06 UTC (permalink / raw)
To: julien; +Cc: xen-devel, Julien Grall, Ian Jackson, Wei Liu, paul
On Thu, Mar 12, 2020 at 08:24:07PM +0000, julien@xen.org wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> xen-init-dom0 is a standalone binary, so all the functions but the
> main() should be static.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Wei Liu <wl@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static
2020-03-12 20:24 [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static julien
2020-03-13 10:06 ` Wei Liu
@ 2020-03-13 12:09 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2020-03-13 12:09 UTC (permalink / raw)
To: julien, xen-devel
Cc: 'Julien Grall', 'Ian Jackson', 'Wei Liu'
> -----Original Message-----
> From: julien@xen.org <julien@xen.org>
> Sent: 12 March 2020 20:24
> To: xen-devel@lists.xenproject.org
> Cc: Julien Grall <jgrall@amazon.com>; Ian Jackson <ian.jackson@eu.citrix.com>; Wei Liu <wl@xen.org>;
> paul@xen.org
> Subject: [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static
>
> From: Julien Grall <jgrall@amazon.com>
>
> xen-init-dom0 is a standalone binary, so all the functions but the
> main() should be static.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Cc: paul@xen.org
Reviewed-by: Paul Durrant <paul@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-13 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 20:24 [Xen-devel] [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static julien
2020-03-13 10:06 ` Wei Liu
2020-03-13 12:09 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.