* [PATCH] platform/x86: thinkpad_acpi: Fix inconsistent indenting
@ 2021-05-21 9:38 Jiapeng Chong
2021-05-21 9:49 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-21 9:38 UTC (permalink / raw)
To: hmh
Cc: hdegoede, mgross, jdelvare, linux, ibm-acpi-devel,
platform-driver-x86, linux-kernel, linux-hwmon, Jiapeng Chong
Eliminate the follow smatch warning:
drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index dd60c93..d0aa566 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -7939,7 +7939,7 @@ static int volume_write(char *buf)
} else if (sscanf(cmd, "level %u", &l) == 1 &&
l >= 0 && l <= TP_EC_VOLUME_MAX) {
new_level = l;
- continue;
+ continue;
}
}
if (strlencmp(cmd, "mute") == 0)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: thinkpad_acpi: Fix inconsistent indenting
2021-05-21 9:38 [PATCH] platform/x86: thinkpad_acpi: Fix inconsistent indenting Jiapeng Chong
@ 2021-05-21 9:49 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-05-21 9:49 UTC (permalink / raw)
To: Jiapeng Chong, hmh
Cc: mgross, jdelvare, linux, ibm-acpi-devel, platform-driver-x86,
linux-kernel, linux-hwmon
Hi,
On 5/21/21 11:38 AM, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index dd60c93..d0aa566 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -7939,7 +7939,7 @@ static int volume_write(char *buf)
> } else if (sscanf(cmd, "level %u", &l) == 1 &&
> l >= 0 && l <= TP_EC_VOLUME_MAX) {
> new_level = l;
> - continue;
> + continue;
> }
> }
> if (strlencmp(cmd, "mute") == 0)
Thank you for your patch, but actually the indentation of the "new_level = l;"
is wrong, it is indented one level too much.
Please send a new version changing (reducing) the indentation of the
"new_level = l;" statement instead.
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-21 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 9:38 [PATCH] platform/x86: thinkpad_acpi: Fix inconsistent indenting Jiapeng Chong
2021-05-21 9:49 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.