* [RESEND PATCH v1] scsi: ufs: enable link lost interrupt
[not found] <CGME20220801031300epcas2p25866dfc0158ecdd33ef18c44aa23b155@epcas2p2.samsung.com>
@ 2022-08-01 3:09 ` Kiwoong Kim
2022-08-01 17:21 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Kiwoong Kim @ 2022-08-01 3:09 UTC (permalink / raw)
To: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
Cc: Kiwoong Kim
Link lost is treated as fatal error with the following
patch, but its event isn't registered as interrupt source,
so I enable it.
--
scsi: ufs: Treat link loss as fatal error
Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com>
---
drivers/scsi/ufs/ufshci.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index a7ff0e5..0b627f4 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -133,11 +133,7 @@ static inline u32 ufshci_version(u32 major, u32 minor)
#define UFSHCD_UIC_MASK (UIC_COMMAND_COMPL | UFSHCD_UIC_PWR_MASK)
-#define UFSHCD_ERROR_MASK (UIC_ERROR |\
- DEVICE_FATAL_ERROR |\
- CONTROLLER_FATAL_ERROR |\
- SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+#define UFSHCD_ERROR_MASK (UIC_ERROR | INT_FATAL_ERRORS)
#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH v1] scsi: ufs: enable link lost interrupt
2022-08-01 3:09 ` [RESEND PATCH v1] scsi: ufs: enable link lost interrupt Kiwoong Kim
@ 2022-08-01 17:21 ` Bart Van Assche
2022-08-02 1:38 ` Kiwoong Kim
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2022-08-01 17:21 UTC (permalink / raw)
To: Kiwoong Kim, linux-scsi, linux-kernel, alim.akhtar, avri.altman,
jejb, martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
On 7/31/22 20:09, Kiwoong Kim wrote:
> Link lost is treated as fatal error with the following
> patch, but its event isn't registered as interrupt source,
> so I enable it.
> --
> scsi: ufs: Treat link loss as fatal error
Is this patch perhaps intended as a fix for patch "scsi: ufs: Treat link
loss as fatal error"? If so, does it need a Fixes: tag?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [RESEND PATCH v1] scsi: ufs: enable link lost interrupt
2022-08-01 17:21 ` Bart Van Assche
@ 2022-08-02 1:38 ` Kiwoong Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kiwoong Kim @ 2022-08-02 1:38 UTC (permalink / raw)
To: 'Bart Van Assche',
linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, beanhuo, adrian.hunter, sc.suh, hy50.seo,
sh425.lee, bhoon95.kim
> > Link lost is treated as fatal error with the following patch, but its
> > event isn't registered as interrupt source, so I enable it.
> > --
> > scsi: ufs: Treat link loss as fatal error
>
> Is this patch perhaps intended as a fix for patch "scsi: ufs: Treat link
> loss as fatal error"? If so, does it need a Fixes: tag?
>
> Thanks,
>
> Bart.
Right and let me add the tag.
Thanks.
Kiwoong Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-02 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220801031300epcas2p25866dfc0158ecdd33ef18c44aa23b155@epcas2p2.samsung.com>
2022-08-01 3:09 ` [RESEND PATCH v1] scsi: ufs: enable link lost interrupt Kiwoong Kim
2022-08-01 17:21 ` Bart Van Assche
2022-08-02 1:38 ` Kiwoong Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.