From: Paolo Bonzini <pbonzini@redhat.com>
To: Anup Patel <anup@brainfault.org>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Radim K <rkrcmar@redhat.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions
Date: Tue, 30 Jul 2019 13:47:49 +0200 [thread overview]
Message-ID: <00ec47ef-6c03-ec27-3894-7afd4757ee61@redhat.com> (raw)
In-Reply-To: <CAAhSdy0OH9h-R=2NxhhPs6jmFPNgZVSwFtCjtJrf++htu82ifA@mail.gmail.com>
On 30/07/19 13:45, Anup Patel wrote:
>> so:
>>
>> 1) indeed we need SP2V=SPV=1 when entering guest mode
>>
>> 2) sstatus.SPP contains the guest mode
>>
>> 3) SP2P doesn't really matter for KVM since it never goes to VS-mode
>> from an interrupt handler, so if my reasoning is correct I'd leave it
>> clear, but I guess it's up to you whether to set it or not.
> Yes, SP2P does not matter but we set it to 1 here so that from Guest
> perspective it seems we were in S-mode previously.
But the guest never reads sstatus.SPP, it always reads, vsstatus.SPP
doesn't it? In any case it doesn't matter.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Anup Patel <anup@brainfault.org>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Radim K <rkrcmar@redhat.com>, Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions
Date: Tue, 30 Jul 2019 13:47:49 +0200 [thread overview]
Message-ID: <00ec47ef-6c03-ec27-3894-7afd4757ee61@redhat.com> (raw)
In-Reply-To: <CAAhSdy0OH9h-R=2NxhhPs6jmFPNgZVSwFtCjtJrf++htu82ifA@mail.gmail.com>
On 30/07/19 13:45, Anup Patel wrote:
>> so:
>>
>> 1) indeed we need SP2V=SPV=1 when entering guest mode
>>
>> 2) sstatus.SPP contains the guest mode
>>
>> 3) SP2P doesn't really matter for KVM since it never goes to VS-mode
>> from an interrupt handler, so if my reasoning is correct I'd leave it
>> clear, but I guess it's up to you whether to set it or not.
> Yes, SP2P does not matter but we set it to 1 here so that from Guest
> perspective it seems we were in S-mode previously.
But the guest never reads sstatus.SPP, it always reads, vsstatus.SPP
doesn't it? In any case it doesn't matter.
Paolo
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-07-30 11:47 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 11:56 [RFC PATCH 00/16] KVM RISC-V Support Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 01/16] KVM: RISC-V: Add KVM_REG_RISCV for ONE_REG interface Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 02/16] RISC-V: Add hypervisor extension related CSR defines Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-30 9:23 ` Paolo Bonzini
2019-07-30 9:23 ` Paolo Bonzini
2019-07-30 11:04 ` Anup Patel
2019-07-30 11:04 ` Anup Patel
2019-07-30 9:25 ` Paolo Bonzini
2019-07-30 9:25 ` Paolo Bonzini
2019-07-30 11:03 ` Anup Patel
2019-07-30 11:03 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-30 8:48 ` Paolo Bonzini
2019-07-30 8:48 ` Paolo Bonzini
2019-07-30 10:16 ` Paolo Bonzini
2019-07-30 10:16 ` Paolo Bonzini
2019-07-30 11:45 ` Anup Patel
2019-07-30 11:45 ` Anup Patel
2019-07-30 11:47 ` Paolo Bonzini [this message]
2019-07-30 11:47 ` Paolo Bonzini
2019-07-29 11:56 ` [RFC PATCH 05/16] RISC-V: KVM: Implement VCPU interrupts and requests handling Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-30 11:17 ` Paolo Bonzini
2019-07-30 11:17 ` Paolo Bonzini
2019-07-30 12:00 ` Anup Patel
2019-07-30 12:00 ` Anup Patel
2019-07-30 12:12 ` Paolo Bonzini
2019-07-30 12:12 ` Paolo Bonzini
2019-07-30 12:45 ` Anup Patel
2019-07-30 12:45 ` Anup Patel
2019-07-30 13:18 ` Paolo Bonzini
2019-07-30 13:18 ` Paolo Bonzini
2019-07-30 13:35 ` Anup Patel
2019-07-30 13:35 ` Anup Patel
2019-07-30 14:08 ` Paolo Bonzini
2019-07-30 14:08 ` Paolo Bonzini
2019-08-02 3:59 ` Anup Patel
2019-08-02 3:59 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 06/16] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls Anup Patel
2019-07-29 11:56 ` Anup Patel
2019-07-30 8:43 ` Paolo Bonzini
2019-07-30 8:43 ` Paolo Bonzini
2019-07-30 9:35 ` Paolo Bonzini
2019-07-30 9:35 ` Paolo Bonzini
2019-07-30 12:08 ` Anup Patel
2019-07-30 12:08 ` Anup Patel
2019-07-30 12:10 ` Paolo Bonzini
2019-07-30 12:10 ` Paolo Bonzini
2019-07-30 12:16 ` Anup Patel
2019-07-30 12:16 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 07/16] RISC-V: KVM: Implement VCPU world-switch Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-30 9:34 ` Paolo Bonzini
2019-07-30 9:34 ` Paolo Bonzini
2019-07-30 12:51 ` Anup Patel
2019-07-30 12:51 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 08/16] RISC-V: KVM: Handle MMIO exits for VCPU Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-30 11:20 ` Paolo Bonzini
2019-07-30 11:20 ` Paolo Bonzini
2019-07-31 7:23 ` Anup Patel
2019-07-31 7:23 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 09/16] RISC-V: KVM: Handle WFI " Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 10/16] RISC-V: KVM: Implement VMID allocator Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-30 8:59 ` Paolo Bonzini
2019-07-30 8:59 ` Paolo Bonzini
2019-07-29 11:57 ` [RFC PATCH 11/16] RISC-V: KVM: Implement stage2 page table programming Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-30 9:00 ` Paolo Bonzini
2019-07-30 9:00 ` Paolo Bonzini
2019-07-30 12:14 ` Anup Patel
2019-07-30 12:14 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 12/16] RISC-V: KVM: Implement MMU notifiers Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-29 14:40 ` Andreas Schwab
2019-07-29 14:40 ` Andreas Schwab
2019-07-29 18:02 ` Atish Patra
2019-07-29 18:02 ` Atish Patra
2019-07-30 6:51 ` Andreas Schwab
2019-07-30 6:51 ` Andreas Schwab
2019-07-30 7:00 ` Atish Patra
2019-07-30 7:00 ` Atish Patra
2019-07-30 11:26 ` Paolo Bonzini
2019-07-30 11:26 ` Paolo Bonzini
2019-07-31 1:55 ` Atish Patra
2019-07-31 1:55 ` Atish Patra
2019-07-31 6:58 ` Paolo Bonzini
2019-07-31 6:58 ` Paolo Bonzini
2019-07-31 7:18 ` Anup Patel
2019-07-31 7:18 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 14/16] RISC-V: KVM: FP lazy save/restore Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 15/16] RISC-V: KVM: Add SBI v0.1 support Anup Patel
2019-07-29 11:57 ` Anup Patel
2019-07-29 19:40 ` Paolo Bonzini
2019-07-29 19:40 ` Paolo Bonzini
2019-07-29 19:51 ` Atish Patra
2019-07-29 19:51 ` Atish Patra
2019-07-29 20:08 ` Paolo Bonzini
2019-07-29 20:08 ` Paolo Bonzini
2019-07-29 21:08 ` Atish Patra
2019-07-29 21:08 ` Atish Patra
2019-07-30 9:26 ` Paolo Bonzini
2019-07-30 9:26 ` Paolo Bonzini
2019-07-29 11:58 ` [RFC PATCH 16/16] RISC-V: Enable VIRTIO drivers in RV64 and RV32 defconfig Anup Patel
2019-07-29 11:58 ` Anup Patel
2019-07-29 21:47 ` [RFC PATCH 00/16] KVM RISC-V Support Paolo Bonzini
2019-07-29 21:47 ` Paolo Bonzini
2019-07-30 5:26 ` Anup Patel
2019-07-30 5:26 ` Anup Patel
2019-07-30 11:33 ` Paolo Bonzini
2019-07-30 11:33 ` Paolo Bonzini
2019-07-30 13:50 ` Anup Patel
2019-07-30 13:50 ` Anup Patel
2019-07-30 14:02 ` Paolo Bonzini
2019-07-30 14:02 ` Paolo Bonzini
2019-07-30 6:53 ` Andreas Schwab
2019-07-30 6:53 ` Andreas Schwab
2019-07-30 7:25 ` Anup Patel
2019-07-30 7:25 ` Anup Patel
2019-07-30 7:42 ` Andreas Schwab
2019-07-30 7:42 ` Andreas Schwab
2019-07-30 7:36 ` Anup Patel
2019-07-30 7:36 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ec47ef-6c03-ec27-3894-7afd4757ee61@redhat.com \
--to=pbonzini@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=daniel.lezcano@linaro.org \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.