From: Christopher Lameter <cl@linux.com>
To: Dennis Zhou <dennis@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>, "tj@kernel.org" <tj@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: Re: [PATCH 1/2] percpu: km: remove SMP check
Date: Tue, 26 Feb 2019 15:16:44 +0000 [thread overview]
Message-ID: <010001692a612815-46229701-ea3f-4a89-8f88-0c74194ba257-000000@email.amazonses.com> (raw)
In-Reply-To: <20190225151330.GA49611@dennisz-mbp.dhcp.thefacebook.com>
On Mon, 25 Feb 2019, Dennis Zhou wrote:
> > @@ -27,7 +27,7 @@
> > * chunk size is not aligned. percpu-km code will whine about it.
> > */
> >
> > -#if defined(CONFIG_SMP) && defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK)
> > +#if defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK)
> > #error "contiguous percpu allocation is incompatible with paged first chunk"
> > #endif
> >
> > --
> > 2.16.4
> >
>
> Hi,
>
> I think keeping CONFIG_SMP makes this easier to remember dependencies
> rather than having to dig into the config. So this is a NACK from me.
But it simplifies the code and makes it easier to read.
next prev parent reply other threads:[~2019-02-26 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 13:13 [PATCH 1/2] percpu: km: remove SMP check Peng Fan
2019-02-24 13:13 ` [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0] Peng Fan
2019-02-25 15:16 ` dennis
2019-02-26 0:03 ` Peng Fan
2019-02-26 15:15 ` Christopher Lameter
2019-02-26 15:15 ` Christopher Lameter
2019-02-26 16:31 ` Dennis Zhou
2019-02-25 15:13 ` [PATCH 1/2] percpu: km: remove SMP check Dennis Zhou
2019-02-25 23:58 ` Peng Fan
2019-02-26 15:16 ` Christopher Lameter [this message]
2019-02-26 15:16 ` Christopher Lameter
2019-02-26 17:03 ` Dennis Zhou
2019-02-27 13:02 ` Peng Fan
2019-02-27 16:41 ` Dennis Zhou
2019-03-03 8:49 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010001692a612815-46229701-ea3f-4a89-8f88-0c74194ba257-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peng.fan@nxp.com \
--cc=tj@kernel.org \
--cc=van.freenix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.