* [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off
@ 2019-11-18 11:08 John Crispin
2019-11-18 11:08 ` [PATCH 2/2] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
2019-11-29 8:30 ` [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: John Crispin @ 2019-11-18 11:08 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k, John Crispin
Add a WMI call helper to set the powersave mode of a STA interface.
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/wireless/ath/ath11k/wmi.c | 30 +++++++++++++++++++++++++++
drivers/net/wireless/ath/ath11k/wmi.h | 7 +++++++
2 files changed, 37 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 6f1a990c2047..13bf6ff68073 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1178,6 +1178,36 @@ int ath11k_wmi_pdev_set_param(struct ath11k *ar, u32 param_id,
return ret;
}
+int ath11k_wmi_pdev_set_ps_mode(struct ath11k *ar, int vdev_id, u32 enable)
+{
+ struct ath11k_pdev_wmi *wmi = ar->wmi;
+ struct wmi_pdev_set_ps_mode_cmd *cmd;
+ struct sk_buff *skb;
+ int ret;
+
+ skb = ath11k_wmi_alloc_skb(wmi->wmi_sc, sizeof(*cmd));
+ if (!skb)
+ return -ENOMEM;
+
+ cmd = (struct wmi_pdev_set_ps_mode_cmd *)skb->data;
+ cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_STA_POWERSAVE_MODE_CMD) |
+ FIELD_PREP(WMI_TLV_LEN, sizeof(*cmd) - TLV_HDR_SIZE);
+ cmd->vdev_id = vdev_id;
+ cmd->sta_ps_mode = enable;
+
+ ret = ath11k_wmi_cmd_send(wmi, skb, WMI_STA_POWERSAVE_MODE_CMDID);
+ if (ret) {
+ ath11k_warn(ar->ab, "failed to send WMI_PDEV_SET_PARAM cmd\n");
+ dev_kfree_skb(skb);
+ }
+
+ ath11k_dbg(ar->ab, ATH11K_DBG_WMI,
+ "WMI vdev set psmode %d vdev id %d\n",
+ enable, vdev_id);
+
+ return ret;
+}
+
int ath11k_wmi_pdev_suspend(struct ath11k *ar, u32 suspend_opt,
u32 pdev_id)
{
diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4a518d406bc5..9919d8bf297b 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -2827,6 +2827,12 @@ struct wmi_pdev_set_param_cmd {
u32 param_value;
} __packed;
+struct wmi_pdev_set_ps_mode_cmd {
+ u32 tlv_header;
+ u32 vdev_id;
+ u32 sta_ps_mode;
+} __packed;
+
struct wmi_pdev_suspend_cmd {
u32 tlv_header;
u32 pdev_id;
@@ -4682,6 +4688,7 @@ int ath11k_wmi_set_peer_param(struct ath11k *ar, const u8 *peer_addr,
u32 vdev_id, u32 param_id, u32 param_val);
int ath11k_wmi_pdev_set_param(struct ath11k *ar, u32 param_id,
u32 param_value, u8 pdev_id);
+int ath11k_wmi_pdev_set_ps_mode(struct ath11k *ar, int vdev_id, u32 enable);
int ath11k_wmi_wait_for_unified_ready(struct ath11k_base *ab);
int ath11k_wmi_cmd_init(struct ath11k_base *ab);
int ath11k_wmi_wait_for_service_ready(struct ath11k_base *ab);
--
2.20.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] ath11k: disable PS for STA interfaces by default upon bringup
2019-11-18 11:08 [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off John Crispin
@ 2019-11-18 11:08 ` John Crispin
2019-11-29 8:30 ` [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: John Crispin @ 2019-11-18 11:08 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k, John Crispin
After applying this setting the TX performance issue of STA interfaces is
gone and we can see TX performance go up to ~900mbit on HE80.
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 3f4cdfb6f247..79f55e88b7f5 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4074,6 +4074,12 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
goto err_peer_del;
}
+ ret = ath11k_wmi_pdev_set_ps_mode(ar, arvif->vdev_id, false);
+ if (ret) {
+ ath11k_warn(ar->ab, "failed to disable vdev %d ps mode: %d\n",
+ arvif->vdev_id, ret);
+ goto err_peer_del;
+ }
break;
default:
break;
--
2.20.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off
2019-11-18 11:08 [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off John Crispin
2019-11-18 11:08 ` [PATCH 2/2] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
@ 2019-11-29 8:30 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-11-29 8:30 UTC (permalink / raw)
To: John Crispin; +Cc: ath11k
John Crispin <john@phrozen.org> wrote:
> Add a WMI call helper to set the powersave mode of a STA interface.
>
> Signed-off-by: John Crispin <john@phrozen.org>
Failed to apply, please resend.
error: patch failed: drivers/net/wireless/ath/ath11k/mac.c:4074
error: drivers/net/wireless/ath/ath11k/mac.c: patch does not apply
stg import: Diff does not apply cleanly
2 patches set to Changes Requested.
11249515 [1/2] ath11k: add wmi helper for turning STA PS on/off
11249513 [2/2] ath11k: disable PS for STA interfaces by default upon bringup
--
https://patchwork.kernel.org/patch/11249515/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-29 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 11:08 [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off John Crispin
2019-11-18 11:08 ` [PATCH 2/2] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
2019-11-29 8:30 ` [PATCH 1/2] ath11k: add wmi helper for turning STA PS on/off Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.