From: Can Guo <cang@codeaurora.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, ziqichen@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell
Date: Fri, 11 Sep 2020 02:16:54 +0000 [thread overview]
Message-ID: <010101747af387e9-f68ac6fa-1bc6-461d-92ec-dc0ee4486728-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <1599754148.3575.4.camel@HansenPartnership.com>
Hi James and Stanley,
On 2020-09-11 00:09, James Bottomley wrote:
> On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote:
> [...]
>> > + if (!err) {
>> > +cleanup:
>>
>> Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort
>> Task if the task in DB was cleared", "cleanup" label shall be added
>> back here.
>>
>> So your resolution looks good to me.
>>
>> Thanks so much : )
>
> You're welcome ... but just remember I have to explain this to Linus
> when the merge window opens. It would be a lot easier if this hadn't
> happened so please don't make it any worse ...
>
> James
Sorry that my changes got you confused and thank you for help resolve
the
conflicts. My change ("scsi: ufs: Abort tasks before clearing them from
doorbell") is to serve my fixes to ufs error recovery which only got
picked
up on scsi-queue-5.10. So I checked out to scsi-queue-5.10 and made my
changes on the tip of scsi-queue-5.10, below 2 changes were not even
present in scsi-queue-5.10 back that time.
scsi: ufs: Clean up completed request without interrupt notification
scsi: ufs: No need to send Abort Task if the task in DB was cleared
Is there anything wrong with my work flow above? Please let me know the
right process so that I can avoid such conflicts in my next changes,
which
also touch the func ufshcd_abort(). Thanks!
Regards,
Can Guo.
next prev parent reply other threads:[~2020-09-11 2:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 2:24 [PATCH v2 0/2] Add UFS LINERESET handling Can Guo
2020-09-03 2:24 ` [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell Can Guo
2020-09-03 2:24 ` Can Guo
2020-09-03 2:24 ` Can Guo
2020-09-09 5:05 ` James Bottomley
2020-09-09 5:05 ` James Bottomley
2020-09-09 5:05 ` James Bottomley
2020-09-10 2:32 ` Martin K. Petersen
2020-09-10 2:32 ` Martin K. Petersen
2020-09-10 2:32 ` Martin K. Petersen
2020-09-10 2:48 ` Stanley Chu
2020-09-10 2:48 ` Stanley Chu
2020-09-10 2:48 ` Stanley Chu
2020-09-10 6:18 ` James Bottomley
2020-09-10 6:18 ` James Bottomley
2020-09-10 6:18 ` James Bottomley
2020-09-10 8:18 ` Stanley Chu
2020-09-10 8:18 ` Stanley Chu
2020-09-10 8:18 ` Stanley Chu
2020-09-10 16:09 ` James Bottomley
2020-09-10 16:09 ` James Bottomley
2020-09-10 16:09 ` James Bottomley
2020-09-11 2:16 ` Can Guo [this message]
2020-09-11 9:09 ` Bean Huo
2020-09-11 9:09 ` Bean Huo
2020-09-11 9:09 ` Bean Huo
2020-09-14 5:00 ` Can Guo
2020-09-14 5:00 ` Can Guo
2020-09-14 5:00 ` Can Guo
2020-09-15 3:14 ` Can Guo
2020-09-15 3:14 ` Can Guo
2020-09-15 3:14 ` Can Guo
2020-09-15 20:21 ` Martin K. Petersen
2020-09-15 20:21 ` Martin K. Petersen
2020-09-15 20:21 ` Martin K. Petersen
2020-09-16 6:34 ` Can Guo
2020-09-16 6:34 ` Can Guo
2020-09-16 6:34 ` Can Guo
2020-09-11 2:16 ` Can Guo
2020-09-11 2:16 ` Can Guo
2020-09-03 2:24 ` [PATCH v2 2/2] scsi: ufs: Handle LINERESET indication in err handler Can Guo
2020-09-09 2:09 ` [PATCH v2 0/2] Add UFS LINERESET handling Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010101747af387e9-f68ac6fa-1bc6-461d-92ec-dc0ee4486728-000000@us-west-2.amazonses.com \
--to=cang@codeaurora.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=hongwus@codeaurora.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=ziqichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.