All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Can Guo <cang@codeaurora.org>,
	asutoshd@codeaurora.org, nguyenb@codeaurora.org,
	hongwus@codeaurora.org, ziqichen@codeaurora.org,
	rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
	kernel-team@android.com, saravanak@google.com,
	salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bean Huo <beanhuo@micron.com>,
	Bart Van Assche <bvanassche@acm.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell
Date: Thu, 10 Sep 2020 09:09:08 -0700	[thread overview]
Message-ID: <1599754148.3575.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <1599725880.10649.35.camel@mtkswgap22>

On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote:
[...]
> > + 	if (!err) {
> >  +cleanup:
> 
> Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort
> Task if the task in DB was cleared", "cleanup" label shall be added
> back here.
> 
> So your resolution looks good to me.
> 
> Thanks so much : )

You're welcome ... but just remember I have to explain this to Linus
when the merge window opens.  It would be a lot easier if this hadn't
happened so please don't make it any worse ...

James


WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: "moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	open list <linux-kernel@vger.kernel.org>,
	saravanak@google.com, nguyenb@codeaurora.org,
	ziqichen@codeaurora.org, Avri Altman <avri.altman@wdc.com>,
	Can Guo <cang@codeaurora.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bean Huo <beanhuo@micron.com>,
	kernel-team@android.com, Bart Van Assche <bvanassche@acm.org>,
	hongwus@codeaurora.org, asutoshd@codeaurora.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell
Date: Thu, 10 Sep 2020 09:09:08 -0700	[thread overview]
Message-ID: <1599754148.3575.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <1599725880.10649.35.camel@mtkswgap22>

On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote:
[...]
> > + 	if (!err) {
> >  +cleanup:
> 
> Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort
> Task if the task in DB was cleared", "cleanup" label shall be added
> back here.
> 
> So your resolution looks good to me.
> 
> Thanks so much : )

You're welcome ... but just remember I have to explain this to Linus
when the merge window opens.  It would be a lot easier if this hadn't
happened so please don't make it any worse ...

James


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: "moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	open list <linux-kernel@vger.kernel.org>,
	saravanak@google.com, nguyenb@codeaurora.org,
	ziqichen@codeaurora.org, Avri Altman <avri.altman@wdc.com>,
	Can Guo <cang@codeaurora.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Bean Huo <beanhuo@micron.com>,
	kernel-team@android.com, Bart Van Assche <bvanassche@acm.org>,
	hongwus@codeaurora.org, asutoshd@codeaurora.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell
Date: Thu, 10 Sep 2020 09:09:08 -0700	[thread overview]
Message-ID: <1599754148.3575.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <1599725880.10649.35.camel@mtkswgap22>

On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote:
[...]
> > + 	if (!err) {
> >  +cleanup:
> 
> Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort
> Task if the task in DB was cleared", "cleanup" label shall be added
> back here.
> 
> So your resolution looks good to me.
> 
> Thanks so much : )

You're welcome ... but just remember I have to explain this to Linus
when the merge window opens.  It would be a lot easier if this hadn't
happened so please don't make it any worse ...

James


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-10 16:12 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  2:24 [PATCH v2 0/2] Add UFS LINERESET handling Can Guo
2020-09-03  2:24 ` [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell Can Guo
2020-09-03  2:24   ` Can Guo
2020-09-03  2:24   ` Can Guo
2020-09-09  5:05   ` James Bottomley
2020-09-09  5:05     ` James Bottomley
2020-09-09  5:05     ` James Bottomley
2020-09-10  2:32     ` Martin K. Petersen
2020-09-10  2:32       ` Martin K. Petersen
2020-09-10  2:32       ` Martin K. Petersen
2020-09-10  2:48       ` Stanley Chu
2020-09-10  2:48         ` Stanley Chu
2020-09-10  2:48         ` Stanley Chu
2020-09-10  6:18         ` James Bottomley
2020-09-10  6:18           ` James Bottomley
2020-09-10  6:18           ` James Bottomley
2020-09-10  8:18           ` Stanley Chu
2020-09-10  8:18             ` Stanley Chu
2020-09-10  8:18             ` Stanley Chu
2020-09-10 16:09             ` James Bottomley [this message]
2020-09-10 16:09               ` James Bottomley
2020-09-10 16:09               ` James Bottomley
2020-09-11  2:16               ` Can Guo
2020-09-11  9:09                 ` Bean Huo
2020-09-11  9:09                   ` Bean Huo
2020-09-11  9:09                   ` Bean Huo
2020-09-14  5:00                   ` Can Guo
2020-09-14  5:00                     ` Can Guo
2020-09-14  5:00                     ` Can Guo
2020-09-15  3:14                   ` Can Guo
2020-09-15  3:14                     ` Can Guo
2020-09-15  3:14                     ` Can Guo
2020-09-15 20:21                     ` Martin K. Petersen
2020-09-15 20:21                       ` Martin K. Petersen
2020-09-15 20:21                       ` Martin K. Petersen
2020-09-16  6:34                       ` Can Guo
2020-09-16  6:34                         ` Can Guo
2020-09-16  6:34                         ` Can Guo
2020-09-11  2:16               ` Can Guo
2020-09-11  2:16                 ` Can Guo
2020-09-03  2:24 ` [PATCH v2 2/2] scsi: ufs: Handle LINERESET indication in err handler Can Guo
2020-09-09  2:09 ` [PATCH v2 0/2] Add UFS LINERESET handling Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599754148.3575.4.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=hongwus@codeaurora.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nguyenb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=stanley.chu@mediatek.com \
    --cc=ziqichen@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.