* [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled
@ 2020-09-10 7:20 Kalle Valo
2020-09-11 9:58 ` Kalle Valo
2020-09-11 9:58 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-10 7:20 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
If CONFIG_REMOTEPROC was disabled the linking failed with:
ERROR: modpost: "rproc_get_by_phandle" [drivers/net/wireless/ath/ath11k/ath11k.ko] undefined!
Compile tested only.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 1ff8ed786d5d ("ath11k: use remoteproc only with AHB devices")
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 437b1123a34f..413811edd083 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -784,6 +784,9 @@ static int ath11k_core_get_rproc(struct ath11k_base *ab)
struct rproc *prproc;
phandle rproc_phandle;
+ if (!IS_ENABLED(CONFIG_REMOTEPROC))
+ return 0;
+
if (ab->bus_params.mhi_support)
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled
2020-09-10 7:20 [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled Kalle Valo
@ 2020-09-11 9:58 ` Kalle Valo
2020-09-11 9:58 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-11 9:58 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath11k, linux-wireless
Kalle Valo <kvalo@codeaurora.org> wrote:
> If CONFIG_REMOTEPROC was disabled the linking failed with:
>
> ERROR: modpost: "rproc_get_by_phandle" [drivers/net/wireless/ath/ath11k/ath11k.ko] undefined!
>
> Compile tested only.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 1ff8ed786d5d ("ath11k: use remoteproc only with AHB devices")
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
5c0ec012ca7f ath11k: fix link error when CONFIG_REMOTEPROC is disabled
--
https://patchwork.kernel.org/patch/11766849/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled
2020-09-10 7:20 [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled Kalle Valo
2020-09-11 9:58 ` Kalle Valo
@ 2020-09-11 9:58 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-11 9:58 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath11k
Kalle Valo <kvalo@codeaurora.org> wrote:
> If CONFIG_REMOTEPROC was disabled the linking failed with:
>
> ERROR: modpost: "rproc_get_by_phandle" [drivers/net/wireless/ath/ath11k/ath11k.ko] undefined!
>
> Compile tested only.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 1ff8ed786d5d ("ath11k: use remoteproc only with AHB devices")
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
5c0ec012ca7f ath11k: fix link error when CONFIG_REMOTEPROC is disabled
--
https://patchwork.kernel.org/patch/11766849/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled
@ 2020-09-10 7:20 Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-09-10 7:20 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
If CONFIG_REMOTEPROC was disabled the linking failed with:
ERROR: modpost: "rproc_get_by_phandle" [drivers/net/wireless/ath/ath11k/ath11k.ko] undefined!
Compile tested only.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 1ff8ed786d5d ("ath11k: use remoteproc only with AHB devices")
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 437b1123a34f..413811edd083 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -784,6 +784,9 @@ static int ath11k_core_get_rproc(struct ath11k_base *ab)
struct rproc *prproc;
phandle rproc_phandle;
+ if (!IS_ENABLED(CONFIG_REMOTEPROC))
+ return 0;
+
if (ab->bus_params.mhi_support)
return 0;
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-11 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 7:20 [PATCH] ath11k: fix link error when CONFIG_REMOTEPROC is disabled Kalle Valo
2020-09-11 9:58 ` Kalle Valo
2020-09-11 9:58 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-09-10 7:20 Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.