From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Hans Jerry Illikainen'" <hji@dyntopia.com>,
"'SZEDER Gábor'" <szeder.dev@gmail.com>
Cc: <git@vger.kernel.org>
Subject: RE: [PATCH 1/1] gpg-interface: add minTrustLevel as a configuration option
Date: Mon, 23 Dec 2019 09:50:34 -0500 [thread overview]
Message-ID: <011401d5b9a0$58604df0$0920e9d0$@nexbridge.com> (raw)
In-Reply-To: <87y2v54i9v.hji@dyntopia.com>
On December 21, 2019 1:59 PM, Hans Jerry Illikainen wrote:
> On Fri, Dec 20 2019, SZEDER Gábor wrote:
> > On Mon, Dec 16, 2019 at 03:32:04PM +0000, Hans Jerry Illikainen wrote:
> >> This patch introduces a new configuration option: gpg.minTrustLevel.
> >> It consolidates trust-level verification to gpg-interface.c and adds
> >> a new `trust_level` member to the signature_check structure.
> >
> > This patch causes several test failures:
> >
> > https://travis-ci.org/git/git/jobs/627909430#L2259
> >
> > I see you've already posted an updated version, so I tried it locally,
> > and the same test scripts fail with the updated version as well.
>
> Sorry for that! I'm preparing a v2 (tested with both gpg1 and gpg2).
>
> > I noticed that only Linux CI jobs failed, while the OSX jobs
> > succeeded. Our Linux CI jobs (and my box) are based on Ubuntu 16.04,
> > and thus use GnuPG v1.4, while the OSX jobs use v2.something. Not
> > sure that the version difference is connected to the test failures,
> > but I figured it's worth pointing out.
>
> Your observation about the different GPG versions was spot on; thanks!
> That explains why all tests pass on my machine as well as on a personal CI
> setup for my git contributions (both using gpg2).
>
> The issue was that the search for the end of a trust level to parse relied on
> the TRUST_ line being space-separated. But that is not always the case for
> gpg1 (only the lowest-two trust levels contain a space followed by additional
> information in gpg1).
Side question: are there any tests running with alternate GPG packages? I have a platform where the official GPG itself is not available, so am looking for alternatives for that community.
Cheers,
Randall
next prev parent reply other threads:[~2019-12-23 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:32 [PATCH 0/1] gpg-interface: add minTrustLevel as a configuration option Hans Jerry Illikainen
2019-12-16 15:32 ` [PATCH 1/1] " Hans Jerry Illikainen
2019-12-20 22:57 ` SZEDER Gábor
2019-12-21 18:59 ` Hans Jerry Illikainen
2019-12-23 14:50 ` Randall S. Becker [this message]
2019-12-24 11:30 ` Hans Jerry Illikainen
2019-12-24 14:20 ` Randall S. Becker
2019-12-16 20:58 ` [PATCH 0/1] " Junio C Hamano
2019-12-18 23:59 ` Hans Jerry Illikainen
2019-12-19 0:01 ` [PATCH v1 " Hans Jerry Illikainen
2019-12-19 0:01 ` [PATCH v1 1/1] " Hans Jerry Illikainen
2019-12-22 0:31 ` [PATCH v2 0/1] " Hans Jerry Illikainen
2019-12-22 0:31 ` [PATCH v2 1/1] " Hans Jerry Illikainen
2019-12-24 19:02 ` Junio C Hamano
2019-12-27 13:46 ` Hans Jerry Illikainen
2019-12-27 22:21 ` Junio C Hamano
2019-12-22 0:44 ` [PATCH v2 0/1] " Hans Jerry Illikainen
2019-12-27 13:55 ` [PATCH v3 " Hans Jerry Illikainen
2019-12-27 13:55 ` [PATCH v3 1/1] " Hans Jerry Illikainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011401d5b9a0$58604df0$0920e9d0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=hji@dyntopia.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.