From: Hans Jerry Illikainen <hji@dyntopia.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] gpg-interface: add minTrustLevel as a configuration option
Date: Wed, 18 Dec 2019 23:59:10 +0000 [thread overview]
Message-ID: <87pnglyylt.hji@dyntopia.com> (raw)
In-Reply-To: <xmqq4ky0j8ca.fsf@gitster-ct.c.googlers.com>
On Mon, Dec 16 2019, Junio C Hamano wrote:
>> Unfortunately, it breaks backward-compatibility in two ways:
>>
>> 1. The default trust level is TRUST_UNDEFINED. This is compatible with
>> the old behavior of every code path *except* for
>> verify_merge_signature() (since, again, it used to die()s on trust
>> levels below TRUST_MARGINAL).
>
> This might be a bit problematic. If we can keep the default
> behaviour identical to the code before this patch, while allowing
> the configuration to tweak the behaviour, that would have been
> more easily acceptable.
Done in v1.
>> 2. The %G? format specifier no longer includes 'U' for signatures made
>> with a key that is either TRUST_UNDEFINED or TRUST_NEVER.
>
> Hmm, I can sort-of-see why you want to introduce a new placeholder
> "%GT" to disambiguate two sources of 'U', but why would this change
> to "%G?" necessary?
U is re-introduced in v1. %GT is still there (since %G? doesn't print
all trust levels) but I don't mind removing it (I added it for
completeness sake when breaking backward-compatibility in v0).
--
hji
next prev parent reply other threads:[~2019-12-19 0:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:32 [PATCH 0/1] gpg-interface: add minTrustLevel as a configuration option Hans Jerry Illikainen
2019-12-16 15:32 ` [PATCH 1/1] " Hans Jerry Illikainen
2019-12-20 22:57 ` SZEDER Gábor
2019-12-21 18:59 ` Hans Jerry Illikainen
2019-12-23 14:50 ` Randall S. Becker
2019-12-24 11:30 ` Hans Jerry Illikainen
2019-12-24 14:20 ` Randall S. Becker
2019-12-16 20:58 ` [PATCH 0/1] " Junio C Hamano
2019-12-18 23:59 ` Hans Jerry Illikainen [this message]
2019-12-19 0:01 ` [PATCH v1 " Hans Jerry Illikainen
2019-12-19 0:01 ` [PATCH v1 1/1] " Hans Jerry Illikainen
2019-12-22 0:31 ` [PATCH v2 0/1] " Hans Jerry Illikainen
2019-12-22 0:31 ` [PATCH v2 1/1] " Hans Jerry Illikainen
2019-12-24 19:02 ` Junio C Hamano
2019-12-27 13:46 ` Hans Jerry Illikainen
2019-12-27 22:21 ` Junio C Hamano
2019-12-22 0:44 ` [PATCH v2 0/1] " Hans Jerry Illikainen
2019-12-27 13:55 ` [PATCH v3 " Hans Jerry Illikainen
2019-12-27 13:55 ` [PATCH v3 1/1] " Hans Jerry Illikainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnglyylt.hji@dyntopia.com \
--to=hji@dyntopia.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.