[review-request] 9154: fixes for customimage details 'no package found'

[review-request] 9154: fixes for customimage details 'no package found'

[Dave Lerner]

Branch: toaster-next, master
Defect: 9154
Summary: Fixes when search for customimage packages has no results.

jshint: done
html5 validation: done

Test cases and expected results
-------------------------------
Setup
-----
Build a custom image

Static Text
-----------
Select the custom image and enter an unknown package like "xxxxx".
    Verify that the static text matches the spec with caveats below.
    1.  The spec shows a different header for both the no results
        and the results page.  The spec was interpretted as being out-of-date
        with current implemenation, and the well "About package..." was
        assumed to be the current implementation replacment since it shows
        the packages included and other data.
    2:  The spec "search query" was assumed to be a place holder in
        the design doc for a string that was the last unsucessful 'search 
        query'.
    Verify that the text field has the unmatched string xxxxx

All buttons - x, search, search all packages, search recipes
-----------------------------------------------------------------
X button:
click the x icon
    Verify that the text input is cleared.
    Verify that the X icon is cleared.
    Verify "Search Add | Remove packages" placeholder in text field.

Search: 
enter openssl 
click search
    Verify back to customised screen with packages matching 'openssl'

On customise image main page, append abc to openssl and click search
    Verify back to the No packages found screen
On NO packages found page, change text from opensslabc to opensslxyz
click search
    Verify still on No Packages screen

Search all packages:
On the same 'opensslxyz' No packages found page, 
click Search all packages
    Verify back to unfiltered customised image page

Recipes:
Enter helloworld, click search
On 'No packages found' page, click the hyperlink "searching the list of recipes"
    Verify that the software recipes page appears.
 

[PATCH 1/1] toaster: fixes for customimage package not found

[Dave Lerner]

For a custom image, if a search for a package results in no packages
found, then additional information should be presented to the user.
This is different than a 'no results' found for a search in other
contexts, for example, a search for a package in a non-customised build.
For a custom image, a package search failure can happen because the
package was not added to the custom image. This commit presents more
information to the user, suggesting why the package was not found in the
custom image.
The generic table view handling js changes to handle a new div
element no-results-special-... such that, if present, that template
section is shown rather than the default no-results-... section.

[YOCTO #9154]

Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
---
 .../toaster/toastergui/static/js/customrecipe.js   |  9 +++++++++
 bitbake/lib/toaster/toastergui/static/js/table.js  | 11 +++++++++--
 .../toaster/toastergui/templates/customrecipe.html | 22 ++++++++++++----------
 3 files changed, 30 insertions(+), 12 deletions(-)

diff --git a/bitbake/lib/toaster/toastergui/static/js/customrecipe.js b/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
index 3c57899..dbed011 100644
--- a/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
+++ b/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
@@ -205,6 +205,15 @@ function customRecipePageInit(ctx) {
     });
   }
 
+  $("#no-results-show-all-packages").click(function(){
+    $(".no-results-search-input").val("");
+  });
+
+  $("#no-results-remove-search-btn").click(function(){
+      $(".no-results-search-input").val("");
+      $(this).hide();
+  });
+
   /* Trigger a build of your custom image */
   $(".build-custom-image").click(function(){
     libtoaster.startABuild(libtoaster.ctx.projectBuildsUrl,
diff --git a/bitbake/lib/toaster/toastergui/static/js/table.js b/bitbake/lib/toaster/toastergui/static/js/table.js
index a7e4fba..2ae7695 100644
--- a/bitbake/lib/toaster/toastergui/static/js/table.js
+++ b/bitbake/lib/toaster/toastergui/static/js/table.js
@@ -75,8 +75,15 @@ function tableInit(ctx){
 
     if (tableData.total === 0){
       tableContainer.hide();
-      $("#new-search-input-"+ctx.tableName).val(tableParams.search);
-      $("#no-results-"+ctx.tableName).show();
+      if ($("#no-results-special-"+ctx.tableName).length > 0) {
+        /* use this page's special no-results form instead of the default */
+        $("#no-results-search-input-"+ctx.tableName).val(tableParams.search);
+        $("#no-results-special-"+ctx.tableName).show();
+        $("#results-found-"+ctx.tableName).hide();
+      } else {
+        $("#new-search-input-"+ctx.tableName).val(tableParams.search);
+        $("#no-results-"+ctx.tableName).show();
+      }
       table.trigger("table-done", [tableData.total, tableParams]);
 
       return;
diff --git a/bitbake/lib/toaster/toastergui/templates/customrecipe.html b/bitbake/lib/toaster/toastergui/templates/customrecipe.html
index 8cce919..35209bf 100644
--- a/bitbake/lib/toaster/toastergui/templates/customrecipe.html
+++ b/bitbake/lib/toaster/toastergui/templates/customrecipe.html
@@ -102,25 +102,26 @@
         Download recipe file
       </a>
     </div>
-    <div id="no-package-results" class="air" style="display:none;">
+    <div id="no-results-special-{{table_name}}" class="air" style="display:none;">
       <div class="alert">
         <h3>No packages found</h3>
-        <p>You might consider <a href="all-software-recipes.html">searching the list of recipes</a> instead. If you find a recipe that matches the name of the package you want:</p>
+        <p>You might consider <a href={% url 'projectsoftwarerecipes' project.id %}>searching the list of recipes</a> instead. If you find a recipe that matches the name of the package you want:</p>
         <ol>
           <li>Add the layer providing the recipe to your project</li>
           <li>Build the recipe</li>
           <li>Once the build completes, come back to this page and search for the package</li>
         </ol>
         <form class="input-append no-results">
-          <input type="text" class="input-xlarge" value="search query">
-            <a href="#" class="add-on btn">
-              <i class="icon-remove"></i>
-            </a>
-            <button class="btn">Search</button>
-            <button class="btn btn-link" id="show-all">Show all packages</button>
-          </form>
-        </div>
+          <input type="text" class="input-xlarge no-results-search-input" id="no-results-search-input-{{table_name}}" name="search" placeholder="Search {{title|lower}}" />
+          <a href="#" class="add-on btn" id="no-results-remove-search-btn" tabindex="-1">
+            <i class="icon-remove"></i>
+          </a>
+          <button class="btn search-submit-{{table_name}}">Search</button>
+          <button class="btn btn-link" id="no-results-show-all-packages">Show all packages</button>
+        </form>
+      </div>
       </div>
+      <div id="results-found-{{table_name}}">
       <div id="packages-table">
         {% if recipe.get_all_packages.count == 0 and last_build == None %}
         <h2> Add | Remove packages </h2>
@@ -135,6 +136,7 @@
         {% include "toastertable.html" %}
         {% endif %}
       </div>
+      </div>
     </div>
     <div class="span4 well">
       <h2 style="margin-bottom:20px;">About {{recipe.name}}</h2>
-- 
1.9.1

Re: [PATCH 1/1] toaster: fixes for customimage package not found

[Barros Pena, Belen]

On 16/03/2016 17:29, "toaster-bounces@yoctoproject.org on behalf of Dave
Lerner" <toaster-bounces@yoctoproject.org on behalf of
dave.lerner@windriver.com> wrote:

>For a custom image, if a search for a package results in no packages
>found, then additional information should be presented to the user.
>This is different than a 'no results' found for a search in other
>contexts, for example, a search for a package in a non-customised build.
>For a custom image, a package search failure can happen because the
>package was not added to the custom image. This commit presents more
>information to the user, suggesting why the package was not found in the
>custom image.
>The generic table view handling js changes to handle a new div
>element no-results-special-... such that, if present, that template
>section is shown rather than the default no-results-... section.
>
>[YOCTO #9154]

This looks good to me.

Thanks!

Belén

>
>Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
>---
> .../toaster/toastergui/static/js/customrecipe.js   |  9 +++++++++
> bitbake/lib/toaster/toastergui/static/js/table.js  | 11 +++++++++--
> .../toaster/toastergui/templates/customrecipe.html | 22
>++++++++++++----------
> 3 files changed, 30 insertions(+), 12 deletions(-)
>
>diff --git a/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
>b/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
>index 3c57899..dbed011 100644
>--- a/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
>+++ b/bitbake/lib/toaster/toastergui/static/js/customrecipe.js
>@@ -205,6 +205,15 @@ function customRecipePageInit(ctx) {
>     });
>   }
> 
>+  $("#no-results-show-all-packages").click(function(){
>+    $(".no-results-search-input").val("");
>+  });
>+
>+  $("#no-results-remove-search-btn").click(function(){
>+      $(".no-results-search-input").val("");
>+      $(this).hide();
>+  });
>+
>   /* Trigger a build of your custom image */
>   $(".build-custom-image").click(function(){
>     libtoaster.startABuild(libtoaster.ctx.projectBuildsUrl,
>diff --git a/bitbake/lib/toaster/toastergui/static/js/table.js
>b/bitbake/lib/toaster/toastergui/static/js/table.js
>index a7e4fba..2ae7695 100644
>--- a/bitbake/lib/toaster/toastergui/static/js/table.js
>+++ b/bitbake/lib/toaster/toastergui/static/js/table.js
>@@ -75,8 +75,15 @@ function tableInit(ctx){
> 
>     if (tableData.total === 0){
>       tableContainer.hide();
>-      $("#new-search-input-"+ctx.tableName).val(tableParams.search);
>-      $("#no-results-"+ctx.tableName).show();
>+      if ($("#no-results-special-"+ctx.tableName).length > 0) {
>+        /* use this page's special no-results form instead of the
>default */
>+        
>$("#no-results-search-input-"+ctx.tableName).val(tableParams.search);
>+        $("#no-results-special-"+ctx.tableName).show();
>+        $("#results-found-"+ctx.tableName).hide();
>+      } else {
>+        $("#new-search-input-"+ctx.tableName).val(tableParams.search);
>+        $("#no-results-"+ctx.tableName).show();
>+      }
>       table.trigger("table-done", [tableData.total, tableParams]);
> 
>       return;
>diff --git a/bitbake/lib/toaster/toastergui/templates/customrecipe.html
>b/bitbake/lib/toaster/toastergui/templates/customrecipe.html
>index 8cce919..35209bf 100644
>--- a/bitbake/lib/toaster/toastergui/templates/customrecipe.html
>+++ b/bitbake/lib/toaster/toastergui/templates/customrecipe.html
>@@ -102,25 +102,26 @@
>         Download recipe file
>       </a>
>     </div>
>-    <div id="no-package-results" class="air" style="display:none;">
>+    <div id="no-results-special-{{table_name}}" class="air"
>style="display:none;">
>       <div class="alert">
>         <h3>No packages found</h3>
>-        <p>You might consider <a
>href="all-software-recipes.html">searching the list of recipes</a>
>instead. If you find a recipe that matches the name of the package you
>want:</p>
>+        <p>You might consider <a href={% url 'projectsoftwarerecipes'
>project.id %}>searching the list of recipes</a> instead. If you find a
>recipe that matches the name of the package you want:</p>
>         <ol>
>           <li>Add the layer providing the recipe to your project</li>
>           <li>Build the recipe</li>
>           <li>Once the build completes, come back to this page and
>search for the package</li>
>         </ol>
>         <form class="input-append no-results">
>-          <input type="text" class="input-xlarge" value="search query">
>-            <a href="#" class="add-on btn">
>-              <i class="icon-remove"></i>
>-            </a>
>-            <button class="btn">Search</button>
>-            <button class="btn btn-link" id="show-all">Show all
>packages</button>
>-          </form>
>-        </div>
>+          <input type="text" class="input-xlarge
>no-results-search-input" id="no-results-search-input-{{table_name}}"
>name="search" placeholder="Search {{title|lower}}" />
>+          <a href="#" class="add-on btn"
>id="no-results-remove-search-btn" tabindex="-1">
>+            <i class="icon-remove"></i>
>+          </a>
>+          <button class="btn
>search-submit-{{table_name}}">Search</button>
>+          <button class="btn btn-link"
>id="no-results-show-all-packages">Show all packages</button>
>+        </form>
>+      </div>
>       </div>
>+      <div id="results-found-{{table_name}}">
>       <div id="packages-table">
>         {% if recipe.get_all_packages.count == 0 and last_build == None
>%}
>         <h2> Add | Remove packages </h2>
>@@ -135,6 +136,7 @@
>         {% include "toastertable.html" %}
>         {% endif %}
>       </div>
>+      </div>
>     </div>
>     <div class="span4 well">
>       <h2 style="margin-bottom:20px;">About {{recipe.name}}</h2>
>-- 
>1.9.1
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 2775 bytes --]

Sorry I've only just got to this, Dave.

The code generally looks fine.

My only question is why you've added an element with a different id to hold
the alternative no results area. Is there any reason it can't have the same
id="no-package-results" as the standard area?

Similarly, the input element could have the
name "#new-search-input-"+ctx.tableName so that its content is reset by the
existing code in table.js.

This could (I think) remove the need for any changes to table.js.

Elliot

On 16 March 2016 at 17:29, Dave Lerner <dave.lerner@windriver.com> wrote:

>
> Branch: toaster-next, master
> Defect: 9154
> Summary: Fixes when search for customimage packages has no results.
>
> jshint: done
> html5 validation: done
>
> Test cases and expected results
> -------------------------------
> Setup
> -----
> Build a custom image
>
> Static Text
> -----------
> Select the custom image and enter an unknown package like "xxxxx".
>     Verify that the static text matches the spec with caveats below.
>     1.  The spec shows a different header for both the no results
>         and the results page.  The spec was interpretted as being
> out-of-date
>         with current implemenation, and the well "About package..." was
>         assumed to be the current implementation replacment since it shows
>         the packages included and other data.
>     2:  The spec "search query" was assumed to be a place holder in
>         the design doc for a string that was the last unsucessful 'search
>         query'.
>     Verify that the text field has the unmatched string xxxxx
>
> All buttons - x, search, search all packages, search recipes
> -----------------------------------------------------------------
> X button:
> click the x icon
>     Verify that the text input is cleared.
>     Verify that the X icon is cleared.
>     Verify "Search Add | Remove packages" placeholder in text field.
>
> Search:
> enter openssl
> click search
>     Verify back to customised screen with packages matching 'openssl'
>
> On customise image main page, append abc to openssl and click search
>     Verify back to the No packages found screen
> On NO packages found page, change text from opensslabc to opensslxyz
> click search
>     Verify still on No Packages screen
>
> Search all packages:
> On the same 'opensslxyz' No packages found page,
> click Search all packages
>     Verify back to unfiltered customised image page
>
> Recipes:
> Enter helloworld, click search
> On 'No packages found' page, click the hyperlink "searching the list of
> recipes"
>     Verify that the software recipes page appears.
>
>


-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 3566 bytes --]

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Lerner, Dave]

[-- Attachment #1: Type: text/plain, Size: 3392 bytes --]

It's been a while, but as I recall both the HTML5 validator I used and the toaster coding standards mandate that element ids must be unique on a page.  The page loads both sections, with and without data, so reusing the same element id as I did in the first pass failed the validation test (and standards).
Dave

________________________________
From: toaster-bounces@yoctoproject.org [toaster-bounces@yoctoproject.org] on behalf of Smith, Elliot [elliot.smith@intel.com]
Sent: Wednesday, April 06, 2016 9:18 AM
To: Lerner, Dave
Cc: Belen Barros Pena (Intel); toaster@yoctoproject.org
Subject: Re: [Toaster] [toaster] [review-request] 9154: fixes for customimage details 'no package found'

Sorry I've only just got to this, Dave.

The code generally looks fine.

My only question is why you've added an element with a different id to hold the alternative no results area. Is there any reason it can't have the same id="no-package-results" as the standard area?

Similarly, the input element could have the name "#new-search-input-"+ctx.tableName so that its content is reset by the existing code in table.js.

This could (I think) remove the need for any changes to table.js.

Elliot

On 16 March 2016 at 17:29, Dave Lerner <dave.lerner@windriver.com<mailto:dave.lerner@windriver.com>> wrote:

Branch: toaster-next, master
Defect: 9154
Summary: Fixes when search for customimage packages has no results.

jshint: done
html5 validation: done

Test cases and expected results
-------------------------------
Setup
-----
Build a custom image

Static Text
-----------
Select the custom image and enter an unknown package like "xxxxx".
    Verify that the static text matches the spec with caveats below.
    1.  The spec shows a different header for both the no results
        and the results page.  The spec was interpretted as being out-of-date
        with current implemenation, and the well "About package..." was
        assumed to be the current implementation replacment since it shows
        the packages included and other data.
    2:  The spec "search query" was assumed to be a place holder in
        the design doc for a string that was the last unsucessful 'search
        query'.
    Verify that the text field has the unmatched string xxxxx

All buttons - x, search, search all packages, search recipes
-----------------------------------------------------------------
X button:
click the x icon
    Verify that the text input is cleared.
    Verify that the X icon is cleared.
    Verify "Search Add | Remove packages" placeholder in text field.

Search:
enter openssl
click search
    Verify back to customised screen with packages matching 'openssl'

On customise image main page, append abc to openssl and click search
    Verify back to the No packages found screen
On NO packages found page, change text from opensslabc to opensslxyz
click search
    Verify still on No Packages screen

Search all packages:
On the same 'opensslxyz' No packages found page,
click Search all packages
    Verify back to unfiltered customised image page

Recipes:
Enter helloworld, click search
On 'No packages found' page, click the hyperlink "searching the list of recipes"
    Verify that the software recipes page appears.




--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 5136 bytes --]

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 4093 bytes --]

On 6 April 2016 at 15:42, Lerner, Dave <dave.lerner@windriver.com> wrote:

> It's been a while, but as I recall both the HTML5 validator I used and the
> toaster coding standards mandate that element ids must be unique on a
> page.  The page loads both sections, with and without data, so reusing the
> same element id as I did in the first pass failed the validation test (and
> standards).
>

Right, that makes sense. I didn't realise both inputs would be visible at
the same time (I should have paid more attention to Belen's design).

(Though, as an aside, issues like this are exactly why I don't use IDs and
prefer data-* attributes instead.)

I will review it again.

Thanks,
Elliot


> Dave
>
> ------------------------------
> *From:* toaster-bounces@yoctoproject.org [toaster-bounces@yoctoproject.org]
> on behalf of Smith, Elliot [elliot.smith@intel.com]
> *Sent:* Wednesday, April 06, 2016 9:18 AM
> *To:* Lerner, Dave
> *Cc:* Belen Barros Pena (Intel); toaster@yoctoproject.org
> *Subject:* Re: [Toaster] [toaster] [review-request] 9154: fixes for
> customimage details 'no package found'
>
> Sorry I've only just got to this, Dave.
>
> The code generally looks fine.
>
> My only question is why you've added an element with a different id to
> hold the alternative no results area. Is there any reason it can't have the
> same id="no-package-results" as the standard area?
>
> Similarly, the input element could have the
> name "#new-search-input-"+ctx.tableName so that its content is reset by the
> existing code in table.js.
>
> This could (I think) remove the need for any changes to table.js.
>
> Elliot
>
> On 16 March 2016 at 17:29, Dave Lerner <dave.lerner@windriver.com> wrote:
>
>>
>> Branch: toaster-next, master
>> Defect: 9154
>> Summary: Fixes when search for customimage packages has no results.
>>
>> jshint: done
>> html5 validation: done
>>
>> Test cases and expected results
>> -------------------------------
>> Setup
>> -----
>> Build a custom image
>>
>> Static Text
>> -----------
>> Select the custom image and enter an unknown package like "xxxxx".
>>     Verify that the static text matches the spec with caveats below.
>>     1.  The spec shows a different header for both the no results
>>         and the results page.  The spec was interpretted as being
>> out-of-date
>>         with current implemenation, and the well "About package..." was
>>         assumed to be the current implementation replacment since it shows
>>         the packages included and other data.
>>     2:  The spec "search query" was assumed to be a place holder in
>>         the design doc for a string that was the last unsucessful 'search
>>         query'.
>>     Verify that the text field has the unmatched string xxxxx
>>
>> All buttons - x, search, search all packages, search recipes
>> -----------------------------------------------------------------
>> X button:
>> click the x icon
>>     Verify that the text input is cleared.
>>     Verify that the X icon is cleared.
>>     Verify "Search Add | Remove packages" placeholder in text field.
>>
>> Search:
>> enter openssl
>> click search
>>     Verify back to customised screen with packages matching 'openssl'
>>
>> On customise image main page, append abc to openssl and click search
>>     Verify back to the No packages found screen
>> On NO packages found page, change text from opensslabc to opensslxyz
>> click search
>>     Verify still on No Packages screen
>>
>> Search all packages:
>> On the same 'opensslxyz' No packages found page,
>> click Search all packages
>>     Verify back to unfiltered customised image page
>>
>> Recipes:
>> Enter helloworld, click search
>> On 'No packages found' page, click the hyperlink "searching the list of
>> recipes"
>>     Verify that the software recipes page appears.
>>
>>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 6175 bytes --]

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 4674 bytes --]

Hello Dave.

I tried to merge your patch into toaster-next today, but it unfortunately
wouldn't apply cleanly.

Could you please rebase? As it's a single commit, I'm happy to take it from
the tip of a branch rather than you having to re-submit it.

Thanks.
Elliot

On 6 April 2016 at 15:47, Smith, Elliot <elliot.smith@intel.com> wrote:

> On 6 April 2016 at 15:42, Lerner, Dave <dave.lerner@windriver.com> wrote:
>
>> It's been a while, but as I recall both the HTML5 validator I used and
>> the toaster coding standards mandate that element ids must be unique on a
>> page.  The page loads both sections, with and without data, so reusing the
>> same element id as I did in the first pass failed the validation test (and
>> standards).
>>
>
> Right, that makes sense. I didn't realise both inputs would be visible at
> the same time (I should have paid more attention to Belen's design).
>
> (Though, as an aside, issues like this are exactly why I don't use IDs and
> prefer data-* attributes instead.)
>
> I will review it again.
>
> Thanks,
> Elliot
>
>
>> Dave
>>
>> ------------------------------
>> *From:* toaster-bounces@yoctoproject.org [
>> toaster-bounces@yoctoproject.org] on behalf of Smith, Elliot [
>> elliot.smith@intel.com]
>> *Sent:* Wednesday, April 06, 2016 9:18 AM
>> *To:* Lerner, Dave
>> *Cc:* Belen Barros Pena (Intel); toaster@yoctoproject.org
>> *Subject:* Re: [Toaster] [toaster] [review-request] 9154: fixes for
>> customimage details 'no package found'
>>
>> Sorry I've only just got to this, Dave.
>>
>> The code generally looks fine.
>>
>> My only question is why you've added an element with a different id to
>> hold the alternative no results area. Is there any reason it can't have the
>> same id="no-package-results" as the standard area?
>>
>> Similarly, the input element could have the
>> name "#new-search-input-"+ctx.tableName so that its content is reset by the
>> existing code in table.js.
>>
>> This could (I think) remove the need for any changes to table.js.
>>
>> Elliot
>>
>> On 16 March 2016 at 17:29, Dave Lerner <dave.lerner@windriver.com> wrote:
>>
>>>
>>> Branch: toaster-next, master
>>> Defect: 9154
>>> Summary: Fixes when search for customimage packages has no results.
>>>
>>> jshint: done
>>> html5 validation: done
>>>
>>> Test cases and expected results
>>> -------------------------------
>>> Setup
>>> -----
>>> Build a custom image
>>>
>>> Static Text
>>> -----------
>>> Select the custom image and enter an unknown package like "xxxxx".
>>>     Verify that the static text matches the spec with caveats below.
>>>     1.  The spec shows a different header for both the no results
>>>         and the results page.  The spec was interpretted as being
>>> out-of-date
>>>         with current implemenation, and the well "About package..." was
>>>         assumed to be the current implementation replacment since it
>>> shows
>>>         the packages included and other data.
>>>     2:  The spec "search query" was assumed to be a place holder in
>>>         the design doc for a string that was the last unsucessful 'search
>>>         query'.
>>>     Verify that the text field has the unmatched string xxxxx
>>>
>>> All buttons - x, search, search all packages, search recipes
>>> -----------------------------------------------------------------
>>> X button:
>>> click the x icon
>>>     Verify that the text input is cleared.
>>>     Verify that the X icon is cleared.
>>>     Verify "Search Add | Remove packages" placeholder in text field.
>>>
>>> Search:
>>> enter openssl
>>> click search
>>>     Verify back to customised screen with packages matching 'openssl'
>>>
>>> On customise image main page, append abc to openssl and click search
>>>     Verify back to the No packages found screen
>>> On NO packages found page, change text from opensslabc to opensslxyz
>>> click search
>>>     Verify still on No Packages screen
>>>
>>> Search all packages:
>>> On the same 'opensslxyz' No packages found page,
>>> click Search all packages
>>>     Verify back to unfiltered customised image page
>>>
>>> Recipes:
>>> Enter helloworld, click search
>>> On 'No packages found' page, click the hyperlink "searching the list of
>>> recipes"
>>>     Verify that the software recipes page appears.
>>>
>>>
>>
>>
>> --
>> Elliot Smith
>> Software Engineer
>> Intel Open Source Technology Centre
>>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 7136 bytes --]

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Lerner, Dave]

Hi Elliot,
I applied the patch to today's toaster-next, recommitted, and retested per original email tests. The tests passed.

The patch is at the tip of poky-contrib/dlerner/9154-v2 .
Dave 

> -----Original Message-----
> From: Smith, Elliot [mailto:elliot.smith@intel.com]
> Sent: Thursday, April 07, 2016 8:15 AM
> To: Lerner, Dave
> Cc: Belen Barros Pena (Intel); toaster@yoctoproject.org
> Subject: Re: [Toaster] [toaster] [review-request] 9154: fixes for customimage details
> 'no package found'
> 
> Hello Dave.
> 
> I tried to merge your patch into toaster-next today, but it unfortunately wouldn't apply
> cleanly.
> 
> Could you please rebase? As it's a single commit, I'm happy to take it from the tip of a
> branch rather than you having to re-submit it.
> 
> Thanks.
> Elliot
> 
> On 6 April 2016 at 15:47, Smith, Elliot <elliot.smith@intel.com> wrote:
> 
> 
> 	On 6 April 2016 at 15:42, Lerner, Dave <dave.lerner@windriver.com> wrote:
> 
> 
> 		It's been a while, but as I recall both the HTML5 validator I used and the
> toaster coding standards mandate that element ids must be unique on a page.  The page
> loads both sections, with and without data, so reusing the same element id as I did in
> the first pass failed the validation test (and standards).
> 
> 
> 
> 	Right, that makes sense. I didn't realise both inputs would be visible at the same
> time (I should have paid more attention to Belen's design).
> 
> 	(Though, as an aside, issues like this are exactly why I don't use IDs and prefer
> data-* attributes instead.)
> 
> 	I will review it again.
> 
> 	Thanks,
> 	Elliot
> 
> 
> 		Dave
> 
> 
> ________________________________
> 
> 		From: toaster-bounces@yoctoproject.org [toaster-bounces@yoctoproject.org] on
> behalf of Smith, Elliot [elliot.smith@intel.com]
> 		Sent: Wednesday, April 06, 2016 9:18 AM
> 		To: Lerner, Dave
> 		Cc: Belen Barros Pena (Intel); toaster@yoctoproject.org
> 		Subject: Re: [Toaster] [toaster] [review-request] 9154: fixes for customimage
> details 'no package found'
> 
> 
> 		Sorry I've only just got to this, Dave.
> 
> 		The code generally looks fine.
> 
> 		My only question is why you've added an element with a different id to hold
> the alternative no results area. Is there any reason it can't have the same id="no-
> package-results" as the standard area?
> 
> 		Similarly, the input element could have the name "#new-search-input-
> "+ctx.tableName so that its content is reset by the existing code in table.js.
> 
> 		This could (I think) remove the need for any changes to table.js.
> 
> 
> 		Elliot
> 
> 		On 16 March 2016 at 17:29, Dave Lerner <dave.lerner@windriver.com> wrote:
> 
> 
> 
> 			Branch: toaster-next, master
> 			Defect: 9154
> 			Summary: Fixes when search for customimage packages has no results.
> 
> 			jshint: done
> 			html5 validation: done
> 
> 			Test cases and expected results
> 			-------------------------------
> 			Setup
> 			-----
> 			Build a custom image
> 
> 			Static Text
> 			-----------
> 			Select the custom image and enter an unknown package like "xxxxx".
> 			    Verify that the static text matches the spec with caveats below.
> 			    1.  The spec shows a different header for both the no results
> 			        and the results page.  The spec was interpretted as being out-of-
> date
> 			        with current implemenation, and the well "About package..." was
> 			        assumed to be the current implementation replacment since it
> shows
> 			        the packages included and other data.
> 			    2:  The spec "search query" was assumed to be a place holder in
> 			        the design doc for a string that was the last unsucessful 'search
> 			        query'.
> 			    Verify that the text field has the unmatched string xxxxx
> 
> 			All buttons - x, search, search all packages, search recipes
> 			-----------------------------------------------------------------
> 			X button:
> 			click the x icon
> 			    Verify that the text input is cleared.
> 			    Verify that the X icon is cleared.
> 			    Verify "Search Add | Remove packages" placeholder in text field.
> 
> 			Search:
> 			enter openssl
> 			click search
> 			    Verify back to customised screen with packages matching 'openssl'
> 
> 			On customise image main page, append abc to openssl and click search
> 			    Verify back to the No packages found screen
> 			On NO packages found page, change text from opensslabc to opensslxyz
> 			click search
> 			    Verify still on No Packages screen
> 
> 			Search all packages:
> 			On the same 'opensslxyz' No packages found page,
> 			click Search all packages
> 			    Verify back to unfiltered customised image page
> 
> 			Recipes:
> 			Enter helloworld, click search
> 			On 'No packages found' page, click the hyperlink "searching the list of
> recipes"
> 			    Verify that the software recipes page appears.
> 
> 
> 
> 
> 
> 
> 		--
> 
> 		Elliot Smith
> 		Software Engineer
> 		Intel Open Source Technology Centre
> 
> 
> 
> 
> 	--
> 
> 	Elliot Smith
> 	Software Engineer
> 	Intel Open Source Technology Centre
> 
> 
> 
> 
> --
> 
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre

Re: [review-request] 9154: fixes for customimage details 'no package found'

[Smith, Elliot]

[-- Attachment #1: Type: text/plain, Size: 7128 bytes --]

On 7 April 2016 at 17:17, Lerner, David M (Wind River) <
dave.lerner@windriver.com> wrote:

> Hi Elliot,
> I applied the patch to today's toaster-next, recommitted, and retested per
> original email tests. The tests passed.
>

Reviewed again, looks good, sent to bitbake-devel and added to toaster-next.

Elliot


>
> The patch is at the tip of poky-contrib/dlerner/9154-v2 .
> Dave
>
> > -----Original Message-----
> > From: Smith, Elliot [mailto:elliot.smith@intel.com]
> > Sent: Thursday, April 07, 2016 8:15 AM
> > To: Lerner, Dave
> > Cc: Belen Barros Pena (Intel); toaster@yoctoproject.org
> > Subject: Re: [Toaster] [toaster] [review-request] 9154: fixes for
> customimage details
> > 'no package found'
> >
> > Hello Dave.
> >
> > I tried to merge your patch into toaster-next today, but it
> unfortunately wouldn't apply
> > cleanly.
> >
> > Could you please rebase? As it's a single commit, I'm happy to take it
> from the tip of a
> > branch rather than you having to re-submit it.
> >
> > Thanks.
> > Elliot
> >
> > On 6 April 2016 at 15:47, Smith, Elliot <elliot.smith@intel.com> wrote:
> >
> >
> >       On 6 April 2016 at 15:42, Lerner, Dave <dave.lerner@windriver.com>
> wrote:
> >
> >
> >               It's been a while, but as I recall both the HTML5
> validator I used and the
> > toaster coding standards mandate that element ids must be unique on a
> page.  The page
> > loads both sections, with and without data, so reusing the same element
> id as I did in
> > the first pass failed the validation test (and standards).
> >
> >
> >
> >       Right, that makes sense. I didn't realise both inputs would be
> visible at the same
> > time (I should have paid more attention to Belen's design).
> >
> >       (Though, as an aside, issues like this are exactly why I don't use
> IDs and prefer
> > data-* attributes instead.)
> >
> >       I will review it again.
> >
> >       Thanks,
> >       Elliot
> >
> >
> >               Dave
> >
> >
> > ________________________________
> >
> >               From: toaster-bounces@yoctoproject.org [
> toaster-bounces@yoctoproject.org] on
> > behalf of Smith, Elliot [elliot.smith@intel.com]
> >               Sent: Wednesday, April 06, 2016 9:18 AM
> >               To: Lerner, Dave
> >               Cc: Belen Barros Pena (Intel); toaster@yoctoproject.org
> >               Subject: Re: [Toaster] [toaster] [review-request] 9154:
> fixes for customimage
> > details 'no package found'
> >
> >
> >               Sorry I've only just got to this, Dave.
> >
> >               The code generally looks fine.
> >
> >               My only question is why you've added an element with a
> different id to hold
> > the alternative no results area. Is there any reason it can't have the
> same id="no-
> > package-results" as the standard area?
> >
> >               Similarly, the input element could have the name
> "#new-search-input-
> > "+ctx.tableName so that its content is reset by the existing code in
> table.js.
> >
> >               This could (I think) remove the need for any changes to
> table.js.
> >
> >
> >               Elliot
> >
> >               On 16 March 2016 at 17:29, Dave Lerner <
> dave.lerner@windriver.com> wrote:
> >
> >
> >
> >                       Branch: toaster-next, master
> >                       Defect: 9154
> >                       Summary: Fixes when search for customimage
> packages has no results.
> >
> >                       jshint: done
> >                       html5 validation: done
> >
> >                       Test cases and expected results
> >                       -------------------------------
> >                       Setup
> >                       -----
> >                       Build a custom image
> >
> >                       Static Text
> >                       -----------
> >                       Select the custom image and enter an unknown
> package like "xxxxx".
> >                           Verify that the static text matches the spec
> with caveats below.
> >                           1.  The spec shows a different header for both
> the no results
> >                               and the results page.  The spec was
> interpretted as being out-of-
> > date
> >                               with current implemenation, and the well
> "About package..." was
> >                               assumed to be the current implementation
> replacment since it
> > shows
> >                               the packages included and other data.
> >                           2:  The spec "search query" was assumed to be
> a place holder in
> >                               the design doc for a string that was the
> last unsucessful 'search
> >                               query'.
> >                           Verify that the text field has the unmatched
> string xxxxx
> >
> >                       All buttons - x, search, search all packages,
> search recipes
> >
>  -----------------------------------------------------------------
> >                       X button:
> >                       click the x icon
> >                           Verify that the text input is cleared.
> >                           Verify that the X icon is cleared.
> >                           Verify "Search Add | Remove packages"
> placeholder in text field.
> >
> >                       Search:
> >                       enter openssl
> >                       click search
> >                           Verify back to customised screen with packages
> matching 'openssl'
> >
> >                       On customise image main page, append abc to
> openssl and click search
> >                           Verify back to the No packages found screen
> >                       On NO packages found page, change text from
> opensslabc to opensslxyz
> >                       click search
> >                           Verify still on No Packages screen
> >
> >                       Search all packages:
> >                       On the same 'opensslxyz' No packages found page,
> >                       click Search all packages
> >                           Verify back to unfiltered customised image page
> >
> >                       Recipes:
> >                       Enter helloworld, click search
> >                       On 'No packages found' page, click the hyperlink
> "searching the list of
> > recipes"
> >                           Verify that the software recipes page appears.
> >
> >
> >
> >
> >
> >
> >               --
> >
> >               Elliot Smith
> >               Software Engineer
> >               Intel Open Source Technology Centre
> >
> >
> >
> >
> >       --
> >
> >       Elliot Smith
> >       Software Engineer
> >       Intel Open Source Technology Centre
> >
> >
> >
> >
> > --
> >
> > Elliot Smith
> > Software Engineer
> > Intel Open Source Technology Centre
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

[-- Attachment #2: Type: text/html, Size: 9946 bytes --]