From: Andrew Davis <afd@ti.com>
To: Dhruva Gole <d-gole@ti.com>, Mark Brown <broonie@kernel.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, Vibhore Vardhan <vibhore@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62-main: PM fixes in the fss node
Date: Mon, 21 Aug 2023 11:28:12 -0500 [thread overview]
Message-ID: <0137b4f7-799f-14ce-3cd6-0af24cab2d8a@ti.com> (raw)
In-Reply-To: <20230818103750.516309-2-d-gole@ti.com>
On 8/18/23 5:37 AM, Dhruva Gole wrote:
> * Make use of Simple Power-Managed Bus as the fss bus controller is under
> the control of a functional clock, and also is part of a PM domain.
> * Specify the appropriate k3 pd to the fss node as per tisci docs [0].
>
> [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am62x/devices.html
>
This doc makes it look like the number should be 73, but you have 74, what is FSAS?
Andrew
> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
> Co-developed-by: Vibhore Vardhan <vibhore@ti.com>
> Signed-off-by: Vibhore Vardhan <vibhore@ti.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 284b90c94da8..b23c9e3d91cd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -640,10 +640,11 @@ usb1: usb@31100000 {
> };
>
> fss: bus@fc00000 {
> - compatible = "simple-bus";
> + compatible = "simple-pm-bus";
> reg = <0x00 0x0fc00000 0x00 0x70000>;
> #address-cells = <2>;
> #size-cells = <2>;
> + power-domains = <&k3_pds 74 TI_SCI_PD_EXCLUSIVE>;
> ranges;
>
> ospi0: spi@fc40000 {
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com>
To: Dhruva Gole <d-gole@ti.com>, Mark Brown <broonie@kernel.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, Vibhore Vardhan <vibhore@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62-main: PM fixes in the fss node
Date: Mon, 21 Aug 2023 11:28:12 -0500 [thread overview]
Message-ID: <0137b4f7-799f-14ce-3cd6-0af24cab2d8a@ti.com> (raw)
In-Reply-To: <20230818103750.516309-2-d-gole@ti.com>
On 8/18/23 5:37 AM, Dhruva Gole wrote:
> * Make use of Simple Power-Managed Bus as the fss bus controller is under
> the control of a functional clock, and also is part of a PM domain.
> * Specify the appropriate k3 pd to the fss node as per tisci docs [0].
>
> [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am62x/devices.html
>
This doc makes it look like the number should be 73, but you have 74, what is FSAS?
Andrew
> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
> Co-developed-by: Vibhore Vardhan <vibhore@ti.com>
> Signed-off-by: Vibhore Vardhan <vibhore@ti.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 284b90c94da8..b23c9e3d91cd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -640,10 +640,11 @@ usb1: usb@31100000 {
> };
>
> fss: bus@fc00000 {
> - compatible = "simple-bus";
> + compatible = "simple-pm-bus";
> reg = <0x00 0x0fc00000 0x00 0x70000>;
> #address-cells = <2>;
> #size-cells = <2>;
> + power-domains = <&k3_pds 74 TI_SCI_PD_EXCLUSIVE>;
> ranges;
>
> ospi0: spi@fc40000 {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-21 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 10:37 [PATCH 0/2] spi-cadence-quadspi: Introduce runtime_pm support Dhruva Gole
2023-08-18 10:37 ` Dhruva Gole
2023-08-18 10:37 ` [PATCH 1/2] arm64: dts: ti: k3-am62-main: PM fixes in the fss node Dhruva Gole
2023-08-18 10:37 ` Dhruva Gole
2023-08-21 16:28 ` Andrew Davis [this message]
2023-08-21 16:28 ` Andrew Davis
2023-08-18 10:37 ` [RFT/PATCH 2/2] spi: spi-cadence-quadspi: add runtime pm support Dhruva Gole
2023-08-18 10:37 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0137b4f7-799f-14ce-3cd6-0af24cab2d8a@ti.com \
--to=afd@ti.com \
--cc=broonie@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.